Feature Branch Windows Build Broken - lib/canonicalize.c - ELOOP lstat

2005-05-24 Thread Conrad T. Pino
Hi All, The new module lib/canonicalize.c fails to compile because it references the symbolic error ELOOP which Windows does not define. The new module lib/canonicalize.c calls the lstat function and there is no prototype and no implementation on Windows platform we support. We use CVS_LSTAT

RE: Feature Branch Solaris Build Broken - lib/glob.c errors

2005-05-24 Thread Conrad T. Pino
Hi Derek, We have a new lib/glob.c error today which I hope to understand before committing #include sys/stat.h addition to lib/glob_.h you suggested. The 3 new errors (see below) are all a single error occurring in 3 places: storage size of `st' isn't known I'm throwing this out for

Re: Feature Branch Solaris Build Broken - lib/glob.c errors

2005-05-24 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Conrad T. Pino wrote: Hi Derek, We have a new lib/glob.c error today which I hope to understand before committing #include sys/stat.h addition to lib/glob_.h you suggested. Adding #include sys/stat.h to glob_.h doesn't help with this new error? I

Re: [bug-gnulib] New GNULIB glob module?

2005-05-24 Thread Paul Eggert
Derek Price [EMAIL PROTECTED] writes: +#else +/* Is there really a case where the getlogin or getlogin_r proto can come from + somewhere other than unistd.h? */ +# ifdef HAVE_GETLOGIN_R +extern int getlogin_r (char *, size_t); +# else +extern char *getlogin (void); +# endif +#endif

RE: Feature Branch Solaris Build Broken - lib/glob.c errors

2005-05-24 Thread Conrad T. Pino
Hi Derek, From: Derek Price [mailto:[EMAIL PROTECTED] Adding #include sys/stat.h to glob_.h doesn't help with this new error? ... That is correct. Neither of (1) uncondition inclusion nor (2) inclusion conditioned upon __USE_GNU made a difference. ... I wouldn't expect this error in

RE: Feature Branch Solaris Build Broken - lib/glob.c errors

2005-05-24 Thread Conrad T. Pino
Hi Derek, From: Derek Price 1. #include sys/stat.h within glob_.h file. This would be the way to go. You may commit this if you wish. I committed an inclusion immediately before struct stat forward declaration to assure the Solaris stat macro is used but on 2nd reflection the forward

Re: Feature Branch Solaris Build Broken - lib/glob.c errors

2005-05-24 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 It looks like your header is using some sort of #pragma to redefine the function names, which I would hope would make them look less like macros and actually remap the functions, allowing us to use the macros in glob.c as they stand. You are still

RE: Feature Branch Solaris Build Broken - lib/glob.c errors

2005-05-24 Thread Conrad T. Pino
Hi Derek, This platform's sys/stat.h implementation in this case defines macros for stat, fstat and lstat to be the tokens stat64, fstat64 and lstat64 respectively. My analysis of sys/stat.h relevent section is below. These macro definitions are in effect when struct stat definition is

Re: Feature Branch Solaris Build Broken - lib/glob.c errors

2005-05-24 Thread Derek Price
Conrad T. Pino wrote: Hi Derek, From: Derek Price 1. #include sys/stat.h within glob_.h file. This would be the way to go. You may commit this if you wish. I committed an inclusion immediately before struct stat forward declaration to assure the Solaris stat macro is

Re: Feature Branch Solaris Build Broken - lib/glob.c errors

2005-05-24 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Conrad T. Pino wrote: Defining macro __PRAGMA_REDEFINE_EXTNAME on the command line stops all errors and warnings in lib/glob.c compile. (For those new to this thread, this is because the Solaris headers #define stat stat64 when the

RE: Feature Branch Solaris Build Broken - lib/glob.c errors

2005-05-24 Thread Conrad T. Pino
Hi Derek, From: Conrad T. Pino [mailto:[EMAIL PROTECTED] I choose a broken gcc as the likely culprit. I'll run a test and report. Test program and results are below. Conrad /export/home/cvsusr/ccvs/cvs-1.12:$ cat test00.c; gcc -o test00 test00.c; test00 #include stdio.h #ifdef

RE: Feature Branch Solaris Build Broken - lib/glob.c errors

2005-05-24 Thread Conrad T. Pino
Hi Derek, From: Derek Price [mailto:[EMAIL PROTECTED] (For those new to this thread, this is because the Solaris headers #define stat stat64 when the __PRAGMA_REDEFINE_EXTNAME macro is not defined). Why isn't gcc defining this value? According to what I could find on the web, the

RE: Feature Branch Solaris Build Broken - lib/glob.c errors

2005-05-24 Thread Conrad T. Pino
Hi Derek, We have the same behavior with gcc 3.3.5 on Debian Linux 2.6.8-2-686 platform. Conrad [EMAIL PROTECTED]:~$ cat test00.c; uname -a; gcc -v; gcc -o test00 test00.c; ./test00 #include stdio.h #ifdef __PRAGMA_REDEFINE_EXTNAME #define p0value defined #else #define p0value undefined

RE: Feature Branch Solaris Build Broken - lib/glob.c errors

2005-05-24 Thread Conrad T. Pino
Hi Derek, From: Derek Price Solaris Pragmas --- For compatibility with the SunPRO compiler, the following pragma is supported. `redefine_extname OLDNAME NEWNAME' This pragma gives the C function OLDNAME the assembler label NEWNAME. The pragma must appear before