Conrad T. Pino wrote:
Hi Derek,
From: Conrad T. Pino
From: Derek Price
Perhaps the problem is in your GCC installation or usage?
A gcc upgrade sure helps. I installed gcc 3.4.2 binary from SunFreeWare.\
I brought up changes to the GNULIB stat module up on bug-gnulib
Hi Derek,
From: Derek Price
A gcc upgrade sure helps. I installed gcc 3.4.2 binary from SunFreeWare.\
I brought up changes to the GNULIB stat module up on bug-gnulib and
found out that this problem has been encountered before. GNULIB is
going to continue supporting the older gccs
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Conrad T. Pino wrote:
I loaded the gcc 2.95 compiler for the sole purpose of compiling CVS on
this platform since previously CVS Home didn't offer a binary for this
platform. I loaded the gcc 3.4 compiler for the sole purpose of fixing
the CVS
Hi Derek,
We have a new lib/glob.c error today which I hope to
understand before committing #include sys/stat.h
addition to lib/glob_.h you suggested.
The 3 new errors (see below) are all a single error
occurring in 3 places:
storage size of `st' isn't known
I'm throwing this out for
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Conrad T. Pino wrote:
Hi Derek,
We have a new lib/glob.c error today which I hope to
understand before committing #include sys/stat.h
addition to lib/glob_.h you suggested.
Adding #include sys/stat.h to glob_.h doesn't help with this new
error? I
Hi Derek,
From: Derek Price [mailto:[EMAIL PROTECTED]
Adding #include sys/stat.h to glob_.h doesn't help with this new
error? ...
That is correct.
Neither of (1) uncondition inclusion nor (2) inclusion conditioned upon
__USE_GNU made a difference.
... I wouldn't expect this error in
Hi Derek,
From: Derek Price
1. #include sys/stat.h within glob_.h file.
This would be the way to go. You may commit this if you wish.
I committed an inclusion immediately before struct stat forward
declaration to assure the Solaris stat macro is used but on 2nd
reflection the forward
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
It looks like your header is using some sort of #pragma to redefine the
function names, which I would hope would make them look less like macros
and actually remap the functions, allowing us to use the macros in
glob.c as they stand.
You are still
Hi Derek,
This platform's sys/stat.h implementation in this case
defines macros for stat, fstat and lstat to be the
tokens stat64, fstat64 and lstat64 respectively.
My analysis of sys/stat.h relevent section is below.
These macro definitions are in effect when struct stat
definition is
Conrad T. Pino wrote:
Hi Derek,
From: Derek Price
1. #include sys/stat.h within glob_.h file.
This would be the way to go. You may commit this if you wish.
I committed an inclusion immediately before struct stat forward
declaration to assure the Solaris stat macro is
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Conrad T. Pino wrote:
Defining macro __PRAGMA_REDEFINE_EXTNAME on the command line stops all
errors
and warnings in lib/glob.c compile.
(For those new to this thread, this is because the Solaris headers
#define stat stat64 when the
Hi Derek,
From: Conrad T. Pino [mailto:[EMAIL PROTECTED]
I choose a broken gcc as the likely culprit. I'll run a test and report.
Test program and results are below.
Conrad
/export/home/cvsusr/ccvs/cvs-1.12:$ cat test00.c; gcc -o test00 test00.c; test00
#include stdio.h
#ifdef
Hi Derek,
From: Derek Price [mailto:[EMAIL PROTECTED]
(For those new to this thread, this is because the Solaris headers
#define stat stat64 when the __PRAGMA_REDEFINE_EXTNAME macro is not
defined).
Why isn't gcc defining this value? According to what I could find on
the web, the
Hi Derek,
We have the same behavior with gcc 3.3.5 on Debian Linux 2.6.8-2-686 platform.
Conrad
[EMAIL PROTECTED]:~$ cat test00.c; uname -a; gcc -v; gcc -o test00 test00.c;
./test00
#include stdio.h
#ifdef __PRAGMA_REDEFINE_EXTNAME
#define p0value defined
#else
#define p0value undefined
Hi Derek,
From: Derek Price
Solaris Pragmas
---
For compatibility with the SunPRO compiler, the following pragma is
supported.
`redefine_extname OLDNAME NEWNAME'
This pragma gives the C function OLDNAME the assembler label
NEWNAME. The pragma must appear before
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Conrad T. Pino wrote:
Excuse me for perhaps being slow but why is configure choosing to
use lib/glob.h when the platform has /usr/include/glob.h whose
contents follow?
Partly because the GNU glob semantics are more extensive than the POSIX
spec,
Conrad T. Pino wrote:
1. #include sys/stat.h within glob_.h file.
This would be the way to go. You may commit this if you wish.
2. Move #include glob.h below #include sys/stat.h in glob.c file.
This is incorrect. The GNULIB convention is to include a module's
header immediately
Conrad T. Pino wrote:
From: Derek Price [mailto:[EMAIL PROTECTED]
I think I just checked in fixes for both Solaris compile problems, this
one and one with getpwnam_r. Could you let me know if they work? I
have no way to test here.
The compile completes but we have warnings (see below).
Hi Derek,
From: Derek Price
This should be irrelevant, since all reference to struct stat should
be made using the Solaris definition. Our code never attempts to define
it and I am fairly certain that the struct stat; line in glob_.h only
declares the existance of said structure.
[snip]
Excuse me for perhaps being slow but why is configure choosing to
use lib/glob.h when the platform has /usr/include/glob.h whose
contents follow?
/usr/include:$ cat glob.h
/*
* Copyright (c) 1994 by Sun Microsystems, Inc.
* Copyright 1985, 1992 by Mortice Kern Systems Inc. All rights reserved.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Conrad T. Pino wrote:
The Solaris function declaration from
/usr/include/unistd.h:850: previous declaration of `getlogin_r'
looks like:
extern char *getlogin_r(char *, int);
and lib/glob.c line 194 looks like:
extern int getlogin_r (char *,
We have an improvement after a recent commit. An old errors was fixed
but a new errors was uncovered:
gcc -DHAVE_CONFIG_H -I. -I. -I..-Ino/include -g -O2 -c glob.c
glob.c: In function `rpl_glob':
glob.c:579: too many arguments to function `getpwnam_r'
glob.c:660: too many arguments to
From: Derek Price [mailto:[EMAIL PROTECTED]
I think I just checked in fixes for both Solaris compile problems, this
one and one with getpwnam_r. Could you let me know if they work? I
have no way to test here.
The compile completes but we have warnings (see below). Problem may
be struct
23 matches
Mail list logo
