rent
+ program, using the same API found on *BSD systems.
+ * lib/getprogname.c, lib/getprogname.h, m4/getprogname.m4:
+ * modules/getprogname: New files.
+ * MODULES.html.sh (Misc): Add getprogname.
+
2016-09-02 Jim Meyering
manywarnings: add -fno-common
diff --git a/M
On Fri, Sep 2, 2016 at 9:57 AM, Bernhard Voelker
wrote:
> On 09/02/2016 06:22 PM, Jim Meyering wrote:
>> * m4/manywarnings.m4 (gl_MANYWARN_ALL_GCC): Add -fno-common
>> to the list. Quoting the manual, "Compiling with -fno-common is
>> useful on targets for which it p
I want to add -fno-common to manywarnings.m4, so I don't have to add
it manually in the configure.ac of every package that should have it:
From 71fcd3870257a9016437acf8de68cce7b524ddc0 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Fri, 2 Sep 2016 09:16:16 -0700
Subject: [PATCH] manywar
On Mon, Aug 29, 2016 at 3:58 PM, Jim Meyering wrote:
> On Mon, Aug 29, 2016 at 12:05 PM, Paul Eggert wrote:
>> Jim Meyering wrote:
>>
>>> Good catch.
>>> Thanks.
>>
>>
>> In trying it out on GNU Emacs with GCC 6.2 I ran into
On Mon, Aug 29, 2016 at 12:05 PM, Paul Eggert wrote:
> Jim Meyering wrote:
>
>> Good catch.
>> Thanks.
>
>
> In trying it out on GNU Emacs with GCC 6.2 I ran into another problem: it
> complains at compile-time if __builtin_add_overflow's 3rd arg is null. In
&
On Mon, Aug 29, 2016 at 10:17 AM, Paul Eggert wrote:
> Thanks for those fixes from the bleeding edge! One minor point: a strict
> reading of the GCC 7 manual would say that calls to __builtin_add_overflow_p
> etc. should use __typeof__ to avoid overflow in the very expression one is
> trying to ch
From b9c364f02cb7a7485cd063fa2cbcbf82042fa8cc Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Mon, 29 Aug 2016 09:27:50 -0700
Subject: [PATCH 1/2] intprops.h: fix missing-backslash problems
* lib/intprops.h (_GL_ADD_OVERFLOW): Add backslash.
(_GL_SUBTRACT_OVERFLOW,_GL_MULTIPLY_OVERFLOW
On Thu, Aug 18, 2016 at 6:27 AM, Pino Toscano wrote:
> On Wednesday, 17 August 2016 14:14:34 CEST Jim Meyering wrote:
>> On Wed, Aug 17, 2016 at 6:06 AM, Pino Toscano wrote:
>> > Hi,
>> >
>> > On Tuesday, 29 March 2016 14:15:18 CEST Pino Toscano wrote:
>>
On Fri, Aug 19, 2016 at 1:48 PM, Pádraig Brady wrote:
> On 15/08/16 02:36, Assaf Gordon wrote:
>>
>>> On Aug 12, 2016, at 04:37, Pádraig Brady wrote:
>>>
>>> There's precedent for .2() versions of functions, like renameat2() etc.
>>> How about we pass an unsigned int flags, instead of bool, i
On Wed, Aug 17, 2016 at 6:06 AM, Pino Toscano wrote:
> Hi,
>
> On Tuesday, 29 March 2016 14:15:18 CEST Pino Toscano wrote:
>> as discussed in [1], this series adds a new getprogname module.
>> All it does is providing a getprogname function, much like what is
>> found on e.g. *BSD systems, and usi
urs last night, so it's almost
certainly not perfect. Feedback welcome.
From 594011bf91cf1a7fdbf81291ea55ce9f2f6455f3 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Wed, 17 Aug 2016 10:02:31 -0700
Subject: [PATCH] gnulib: update to latest
---
gnulib | 2 +-
1 file changed, 1 insertion(+),
On Mon, Aug 8, 2016 at 4:23 AM, Pádraig Brady wrote:
> On 06/08/16 21:02, Jim Meyering wrote:
>> I was burned by dash's local V=' x' semantics, in spite of having
>> reported and studied this wart, at length, a few years ago. This arose
>> again when Assaf di
d change sooner rather
than later:
http://austingroupbugs.net/view.php?id=351
In the mean time, I feel more than justified in making our tests avoid dash.
If no one objects, I'll push this in a couple of days.
From ac32368bf8a5e0d58c608bc358655ba908add6a7 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: M
On Tue, Aug 2, 2016 at 6:41 AM, Ján Tomko wrote:
> - /\b(then?|[iao]n|i[fst]|but|f?or|at|and|[dt]o)\s+\1\b/gims
> +/\b(?:$(subst $(space),|,$(prohibit_doubled_word_expanded_)))\b/gims
Thank you. I am preparing to push that, but with an important change:
a quick test showed that it matched wa
On Mon, Aug 1, 2016 at 5:11 AM, Ján Tomko wrote:
> 1.44s to 1.02s
Thanks. Mentioned that in the commit log.
Here is the proposed patch:
From 3238fa6a54927c1af81dbd2c512f5e6ead8dcfc2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A1n=20Tomko?=
Date: Mon, 1 Aug 2016 10:54:47 -0700
Subject: [PATCH]
On Fri, Jul 29, 2016 at 2:29 PM, Eric Blake wrote:
> gnulib is still stuck in the old ways of GNU-style changelog entries
> where you call out the file and section touched, as in:
>
> * maint.mk (prohibit_doubled_word): Pre-expand the regex to
> avoid expensive perl regex backrefer
On Tue, Jul 26, 2016 at 7:28 AM, Ján Tomko wrote:
> Instead of spawning three processes per file, rewrite the check
> in perl and run it once for all the files.
> ---
> Alternatively, grep --max-count 1 could help with getting rid of
> the per-file commands and extra sed, but I don't know if it's
On Tue, Jul 26, 2016 at 7:28 AM, Ján Tomko wrote:
> +2016-07-26 Ján Tomko
> +
> + maint.mk: speed up po_check
> +
> + There is some logic in sc_po_check that skips files based on their
> + names, or existence of files with derived names.
> +
> + Rewrite it in perl instea
On Tue, Jul 26, 2016 at 7:28 AM, Ján Tomko wrote:
> Check if there is any if keyword on the currently
> processed line by a simple regex before matching
> against the more expensive capturing regex.
> ---
> ChangeLog| 8
> build-aux/useless-if-before-free | 3 +++
On Sun, Jun 5, 2016 at 7:24 PM, Assaf Gordon wrote:
> Hello,
>
> Thank you for the review.
> Attached an improved patch (also marks the coverage targets as phony).
Thank you. That looks fine, now.
You're welcome to push it.
On Sat, Jun 4, 2016 at 11:26 PM, Jim Meyering wrote:
> On Sat, Jun 4, 2016 at 9:17 PM, Assaf Gordon wrote:
>> Hello,
>>
>> I'd like to suggest the following minor change to the 'coverage' targets in
>> 'maint.mk'.
>>
>> Wit
On Sat, Jun 4, 2016 at 9:17 PM, Assaf Gordon wrote:
> Hello,
>
> I'd like to suggest the following minor change to the 'coverage' targets in
> 'maint.mk'.
>
> With it, when improving coverage of the test suite, a developer can bootstrap
> the coverage build with 'make coverage', then add individ
On Tue, May 17, 2016 at 9:08 AM, Paul Eggert wrote:
> * m4/manywarnings.m4 (gl_MANYWARN_ALL_GCC):
> Add GCC 6.1 options that apply to C.
> * build-aux/gcc-warning.spec: Add GCC 6.1 options that
> do not apply to C, are obsolescent, etc.
Thanks!
Thérèse sent me the following off-list.
>From what I recall, gnulib's web pages are/were all generated
automatically, so the code to do that should be updated accordingly.
However, I don't think I've ever done that. I do see the doc/Makefile
rules to create *.html, but nothing to copy that into pla
On Fri, Mar 25, 2016 at 1:01 PM, Paul Eggert wrote:
> On 03/25/2016 08:16 AM, Jim Meyering wrote:
>>
>> I know that mktemp's -t is not portable, but the code in
>> init.sh was supposed to work around that. Did you see
>> some place where that work-around failed?
On Fri, Mar 25, 2016 at 12:20 AM, Paul Eggert wrote:
> Problem reported by Assaf Gordon in: http://bugs.gnu.org/23107#13
> * tests/init.sh (testdir_prefix_, pfx_, template_length_):
> Remove. All uses removed.
> (test_dir_): Adjust to mktempd_ change.
> (mktempd_): Omit 2nd arg. Stop using -t, a
if (!diag && !T[i].result)
^~
It is a useful warning, but in this case, while the code was
indeed improperly indented, there was no semantic error.
I've pushed this patch:
From fddaabfd235fac7a8dd14d4080d1506a4bec8fde Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Thu, 1
ile, but leaves that file behind
upon failure, I added this little fix-up. I'm sure we
could also fix this by changing automake, but I
don't want to do that just yet.
From cd6a45292cdb7b3c4b628f1cb0f199a02140ea7c Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Tue, 2 Feb 2016 21:39:44 -0800
On Fri, Jan 29, 2016 at 10:33 AM, Paul Eggert wrote:
> My main qualm is Bug#22461. It'd be OK to issue 'grep' with that bug, I
> guess. I wish I had more time to look into it before the release, but on the
> other hand if I put in a bugfix now we'd have to test it. It's not a serious
> bug, just a
-8b6a.tar.xz
Changes in grep since 2.22.30-e07b:
Jim Meyering (1):
gnulib: update to latest
Changes in gnulib since 2.22.30-e07b:
* gnulib 271dfe3...7757cc8 (42):
> get-permissions, strftime: fix grammar in comments
> gettext: mark as obsolete
> gnulib-tool: don't give
t parentheses around '-' inside '<<'
> [-Werror=parentheses]
> #define INT_LEFT_SHIFT_WRAPV(a, b) _GL_INT_OP_WRAPV (a, b, <<)
I have fixed the latter with the attached, just-pushed patch:
From 24fb386f25ce0800577ac64f2d2303822e9e615c Mon Sep 17 00:00:00 2001
Fr
On Sun, Oct 18, 2015 at 10:50 PM, Paul Eggert wrote:
> Jim Meyering wrote:
>
>> Testing on i686 at all was mostly on a whim.
>> This is not a release blocker, by a long shot.
>
> True. Still, it's annoying. I built GCC 4.7.2 and reproduced the bug. We had
>
Hi Paul,
Preparing for the release of grep-2.22, I ran its tests on an
old i686 system with gcc-4.7.2 and other fedora-18-era tools,
that triggered the failure of this static assertion in test-stdalign.c:
CHECK_STATIC (int64_t);
That arises because this "verify" expression is false:
#define
On Sun, Oct 18, 2015 at 2:36 PM, Pádraig Brady wrote:
> On 18/10/15 22:33, Pádraig Brady wrote:
>> On 18/10/15 05:04, Jim Meyering wrote:
>>> I've just pushed the following three patches:
>>
>> Nice. Note this improvement triggered new
>> syntax c
On Sun, Oct 18, 2015 at 10:28 AM, Paul Eggert wrote:
> Jim Meyering wrote:
>>
>> Building coreutils configured with --enable-gcc-warnings and using
>> bleeding-edge gcc evoked a build failure due to the time_rz module.
>> The attached patch removes the warning/error-evo
From 0de3313d86751b8fc4616aad72cc9b6c707f1b3e Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Sun, 18 Oct 2015 09:32:21 -0700
Subject: [PATCH] time_rz: avoid warning from bleeding-edge gcc's -Wnonnull
Compiling with gcc version 6.0.0 20151017 (experimental) (GCC), I
would see this:
I've just pushed the following three patches:
From 30b2a6a9ef73e8929afb0cc1c0fc5295dabf6479 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Thu, 24 Sep 2015 17:03:20 +0100
Subject: [PATCH 1/3] ChangeLog: fix typo: s/cound/count/
---
ChangeLog | 2 +-
1 file changed, 1 insertion(+), 1 del
On Thu, Jul 23, 2015 at 8:29 AM, Pádraig Brady wrote:
> At line 40 we AC_DEFINE(HAVE_SELINUX_SELINUX_H,0)
>
> http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blob;f=m4/selinux-selinux-h.m4;h=fd09b299;hb=HEAD#l40
> However that may already defined to 1 which is the case
> when compiling in -m
On Thu, Jul 16, 2015 at 6:58 AM, Pavel Raiskup wrote:
> On Tuesday 14 of July 2015 06:29:15 Eric Blake wrote:
>> Overall, seems like it is correct, once you fix the typos.
>
> Thanks for your review, fixed patch attached.
Thanks for the patch.
Haven't reviewed thoroughly, but did see this:
+
Patch attached.
2015-07-03 Jim Meyering
set-permissions.c: adjust acl_from_mode's cpp guard
* lib/set-permissions.c (acl_from_mode): Guard with #ifdef
directives identical to those guarding the sole use.
Otherwise, on some systems, we'd get a war
On Tue, Jun 30, 2015 at 9:36 AM, Paul Eggert wrote:
> Jim Meyering wrote:
>
>> same result as before:
>
> OK, let's give up on this approach and try something more direct. I
> installed the attached patch; does it work on OS X?
Perfect.
I made latest coreutils use late
On Mon, Jun 29, 2015 at 7:19 PM, Paul Eggert wrote:
> Jim Meyering wrote:
>>
>> Darn it. I see that I mistakenly pushed one of your patches
>> when I pushed the linkat.m4 fix, Paul. Sorry about that.
>> Happy to revert, if you'd like that. Let me know.
>
>
On Mon, Jun 29, 2015 at 2:01 PM, Jim Meyering wrote:
> On Mon, Jun 29, 2015 at 11:39 AM, Paul Eggert wrote:
>> Jim Meyering wrote:
>>>
>>> the first variant compiled
>>> just fine here (and probably everywhere),
>>> so HAVE_GETGROUPLIST_WITH_INT was
On Mon, Jun 29, 2015 at 11:39 AM, Paul Eggert wrote:
> Jim Meyering wrote:
>>
>> the first variant compiled
>> just fine here (and probably everywhere),
>> so HAVE_GETGROUPLIST_WITH_INT was not defined.
>
>
> Yes, well, it did work on GNU/Linux, which is what
On Sun, Jun 28, 2015 at 11:48 PM, Paul Eggert wrote:
> Jim Meyering wrote:
>>
>> I compiled the just-published snapshot on OS X configured with
>> --enable-gcc-warnings, and saw this:
>>
>> lib/mgetgroups.c: In function 'mgetgroups':
>> lib/mget
This fixes a bug in linkat.m4 I noticed when building the latest
coreutils snapshot.
I'll push this later today.
0001-linkat-fix-invalid-definition-of-LINKAT_SYMLINK_NOTS.patch
Description: Binary data
Building coreutils's latest snapshot on OS X, I saw this:
lib/mountlist.c:1085:2: warning: label 'free_then_fail' defined but
not used [-Wunused-label]
free_then_fail:
^
The attached, just-pushed, patch avoids that warning:
0001-mountlist-avoid-an-unused-label-warning-on-OS-X.patch
De
I've just pushed the attached, to avoid this warning:
lib/error.c:385:40: warning: format '%d' expects argument of type
'int', but argument 4 has type 'unsigned int' [-Wformat=]
fprintf (stderr, file_name != NULL ? "%s:%d: " : " ",
0001-error.c-correct-printf-style-format-d-u.patch
Descri
On Fri, Jun 19, 2015 at 6:50 PM, Daiki Ueno wrote:
> Daiki Ueno writes:
>
>>> The modules are listed by a script that does:
>>> - for each file listed by: git show --oneline --name-only 705f4efc
>>> - deduce the containing modules, based on "Files:"
>>> - deduce
On Wed, Feb 4, 2015 at 9:25 AM, Bruce Korb wrote:
> On 02/02/15 09:27, Pádraig Brady wrote:
>>
>> On 02/02/15 16:41, Chris Lamb wrote:
>>>
>>> We are currently in a funny situation where GNU date can't parse its own
>>> output:
>>>
>>>$ date --date="$(date)"
>>>date: invalid date 'Mon 2 F
On Thu, Jan 15, 2015 at 12:57 PM, Paul Eggert wrote:
> * build-aux/update-copyright: Fix copyright date. How ironic!
> ---
> ChangeLog | 5 +
> build-aux/update-copyright | 4 ++--
> 2 files changed, 7 insertions(+), 2 deletions(-)
...
> -# Copyright (C) 2009-2014 Free Softw
I've just pushed these two changes:
test-strstr.c: avoid a trivial leak
* tests/test-strstr.c (main): Free haystack.
update-copyright: recognize groff's \(co marker
* build-aux/update-copyright (circle_c_re): Also accept
uses of \(co, as found in gzip.1.
On Tue, Dec 30, 2014 at 3:42 PM, Pádraig Brady wrote:
> Since commit 3bf75404, on 26-09-1998, errno may not have been reset.
> Noticed with a spurious coreutils test failure on Darwin 14.0.0.
>
> * lib/xstrtol.c (__xstrtol): Always reset errno before returning.
Cool (well, sort of :-), since it's
On Fri, Dec 5, 2014 at 2:37 AM, Bruno Haible wrote:
> Pádraig Brady wrote on 2014-11-27:
>> + printf: fix configure check on big endian systems
>> + * m4/printf.m4 (gl_PRINTF_INFINITE_LONG_DOUBLE): Add missing bracket.
>
> The same typo occurs in a few other places as well. I'm fixing them
On Thu, Nov 27, 2014 at 3:23 AM, Pádraig Brady wrote:
> * m4/printf.m4 (gl_PRINTF_INFINITE_LONG_DOUBLE): Add missing bracket.
...
> diff --git a/m4/printf.m4 b/m4/printf.m4
...
> - ((unsigned int) (manthi) << 16) | (unsigned int) (mantlo) >> 16),\
> + ((unsigned int) (manthi) << 16
On Thu, Oct 30, 2014 at 8:05 AM, Eric Blake wrote:
> On 10/29/2014 12:29 PM, Jim Meyering wrote:
>> Thanks to many fixes and improvements by Paul Eggert and Norihiro Tanaka,
>> here is a pre-release snapshot:
>>
>> grep snapshot:
>> http://meyering.net/grep/g
On Fri, Oct 3, 2014 at 4:33 PM, Assaf Gordon wrote:
> To ease portability testing of GNU software,
> I've created a collection of virtual-machines of POSIX-compatible,
> Free-Software operating systems.
> These are pre-configured with programs required for building autotools-based
> projects.
...
Without this, updating to the latest from gnulib provokes a new
warning/error in grep:
0001-exclude-declare-exclude_patopts-static.patch
Description: Binary data
On Thu, Sep 4, 2014 at 12:18 PM, Eric Blake wrote:
> Most instances of ;; in C code are mistakes, where the second
> semicolon is a no-op. This rule tries to make it easy to flag
> the typos occuring at the end of a statement. It intentionally
> does not flag for(;;) loops, and misses grammar pr
On Thu, Sep 4, 2014 at 8:11 AM, Ben Pfaff wrote:
> On Thu, Sep 04, 2014 at 06:28:19AM -0600, Eric Blake wrote:
>> Noticed this while writing a syntax check rule to look for bogus
>> doubled semicolons. If there's interest, I could add this rule
>> to maint.mk:
>>
>> # Except for shell files and f
Glad you found the root of the problem, and that it's not in gnulib.
On Fri, Jul 18, 2014 at 3:35 PM, Pádraig Brady wrote:
> On 07/18/2014 10:42 PM, Jim Meyering wrote:
>> From: Jim Meyering
>>
>> * tests/test-userspec.c: I found a system for which getpwnam("0")
>> returned a pointer to a non-root user's entry, and that
From: Jim Meyering
* tests/test-userspec.c: I found a system for which getpwnam("0")
returned a pointer to a non-root user's entry, and that made the
test fail.
(T): Prefix each numeric input with "+", to inhibit lookup.
---
ChangeLog | 8
t
On Wed, Jul 16, 2014 at 3:43 PM, Bernhard Voelker
wrote:
> Does anyone know of a tool using parse_long_options() which
> would rely on printing the --version text right after the usage
> text for the --help option?
No. That would be a bug.
...
> case 'h':
>(*usage_func) (EX
On Sat, Jul 12, 2014 at 4:50 PM, Jim Meyering wrote:
> I was surprised to be able to provoke a segfault in grep.
> Even more surprised to see that the flaw was in regcomp.c.
> Here's the patch I'll push to gnulib.
> I expect the same will go to glibc soon.
FYI, I'
I was surprised to be able to provoke a segfault in grep.
Even more surprised to see that the flaw was in regcomp.c.
Here's the patch I'll push to gnulib.
I expect the same will go to glibc soon.
From 1051177e3c202667889628fd73aee7c3b470f99d Mon Sep 17 00:00:00 2001
From: Jim Meyering
Thanks. That looks fine, but please change "thread safe" to
"thread-safe" everywhere.
sted by running this:
./gnulib-tool --create-testdir --dir=/tmp/x --with-tests --test parse-duration
From afa7c4a28feaac74b7d64b22c61a73377a9c0f2a Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Wed, 11 Jun 2014 15:43:37 -0700
Subject: [PATCH] parse-duration: eliminate 31/31-bit time_t limitation
* lib/parse-duration.c: Incl
On Tue, Jun 10, 2014 at 5:38 PM, Bruce Korb wrote:
> Or maybe:
>
> #ifdef TIME_MAX
> #define TIME_LIMIT TIME_MAX
> #else
> #define TIME_LIMIT (((time_t)~0) >> 1)
> #endif
Why impose such a limit?
I'd go with TYPE_MAXIMUM (time_t).
On Tue, Jun 10, 2014 at 8:47 AM, Phillip Susi wrote:
> I tried making a release candidate by appending -rc1 to the normal version
> number, and it seems that this makes git-version-gen puke and come up with
> UNKNOWN as the version. It looks like it has some code for dealing with old
> versions o
On Wed, Jun 4, 2014 at 12:13 PM, Eric Blake wrote:
> I noticed this while reading through the file to debug a different
> issue. The grace period mentioned in the comment has elapsed.
>
> * top/maint.mk (build_aux): Drop old code, as threatened.
>
> Signed-off-by: Eric Blake
> ---
>
> I'm pushin
On Sat, May 31, 2014 at 2:07 PM, Paul Eggert wrote:
> This fixes some porting problems discovered when testing the latest
> grep snapshot on AIX 7.1. I don't think if fixes any bugs
> in grep but it could be important for other applications.
> * doc/posix-functions/dup2.texi:
> * doc/posix-functi
On Tue, May 27, 2014 at 1:25 PM, Sylvain Beucler wrote:
> This allows the user to see error messages if any (--quiet hides them)
> ---
> gnulib-tool | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnulib-tool b/gnulib-tool
> index b852749..7353920 100755
> --- a/gnulib-to
On Thu, May 22, 2014 at 12:04 AM, Paul Eggert wrote:
> Jim Meyering wrote:
>>
>> What about the conflict with modules/streq?
>> There are over 300 uses of STREQ in gnulib and coreutils.
>> Are you suggesting to change all of those?
>
>
> Yes. But if this is t
API, while we're making
> a module for it. So my suggestion would be to replace STREQ with streq
> uniformly elsewhere, after the stringops module is added.
>
> I think Jim Meyering is the main reason Gnulib uses STREQ so much, so I'd
> like his opinion. Jim, is it OK
On Fri, May 16, 2014 at 1:56 PM, Paul Eggert wrote:
> +*) AC_DEFINE([MBRTOWC_EMPTY_INPUT_BUG], [1],
> + [Define if the mbrtowc function does not return (size_t) 2
Thanks. I've fixed that typo:
s/2/-2/
0001-mbrtowc.m4-fix-a-comment-typo.patch
Description: Binary data
On Thu, May 15, 2014 at 6:30 PM, Paul Eggert wrote:
> * doc/posix-functions/mbrlen.texi (mbrlen):
> * doc/posix-functions/mbrtowc.texi (mbrtowc):
> Document portability problem when the input string is empty. See:
> https://sourceware.org/bugzilla/show_bug.cgi?id=16950
> ChangeLog
On Mon, Mar 24, 2014 at 8:06 AM, Paul Eggert wrote:
> I checked in a dummy file of that name.
Thanks for cleaning up after me, Paul.
ot;git-log-fix" (and it is
> not a "gnulib" module, just a file that needs to be created).
Thanks for the report!
This gnulib patch should fix it:
From caac936ebff9ee6f492b180be6fa6d2aa4a66b01 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Thu, 13 Mar 2014 13:00:00 -0700
Subje
On Sun, Feb 23, 2014 at 10:59 PM, Paul Eggert wrote:
> Thanks for the bug report.
>
> I applied the attached three patches; the first is to gnulib and changes
> gnulib's diffseq module to handle that case better, the second is to
> diffutils and brings diffutils up to the latest gnulib, and the th
On Wed, Jan 1, 2014 at 6:33 PM, Gary V. Vaughan wrote:
> Hi Jim,
>
> On Jan 2, 2014, at 3:22 PM, Jim Meyering wrote:
>> One of our tenets relating to developer-related tools/rules like this
>> is that we do not accommodate inferior tools when it comes to building
>>
On Sat, Jan 4, 2014 at 11:15 AM, Paul Eggert wrote:
> Jim Meyering wrote:
>>
>> How about this?
>
>
> Thanks, but I can't tell from the patch how to exercise just the new check.
"make sc_maint" doesn't do precisely what you want, but is more
focuse
On Fri, Jan 3, 2014 at 8:53 PM, Paul Eggert wrote:
> Jim Meyering wrote:
>>
>> Could you also add a rule so that gnulib's own "sc_maint" will
>> warn us if/when new instances creep in?
>
> Not easily; I wouldn't know where to begin.
>
> It sho
On Fri, Jan 3, 2014 at 3:17 PM, Jim Meyering wrote:
> On Fri, Jan 3, 2014 at 3:13 PM, Bruno Haible wrote:
> ...
>> stream is accessed from different threads. Therefore OK for the change.
>>
>> But all of the functions
>> freadable
>> freadahead
>&g
On Fri, Jan 3, 2014 at 11:20 AM, Paul Eggert wrote:
> * doc/posix-functions/crypt.texi, doc/posix-functions/encrypt.texi:
> * doc/posix-functions/setkey.texi, doc/regex.texi:
> Use ASCII input, not UTF-8.
Nice. Could you also add a rule so that gnulib's own "sc_maint" will
warn us if/when new in
FYI
From a75f17adf4664d5c34366f62fbca38dc5cd8e9dc Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Fri, 3 Jan 2014 16:58:50 -0800
Subject: [PATCH] maint.mk: adapt openat.h-include-without-use test
* top/maint.mk (sc_prohibit_openat_without_use): Also check for
FCHMODAT_INLINE, FCHOWNAT_INLINE
On Fri, Jan 3, 2014 at 3:13 PM, Bruno Haible wrote:
...
> stream is accessed from different threads. Therefore OK for the change.
>
> But all of the functions
> freadable
> freadahead
> freading
> fwritable
> fwriting
> are similar enough that they should be treated the same way. Can you
FYI, without this patch and with very recent gcc, I would see warnings
like this:
lib/freading.c:29:1: error: function might be candidate for attribute 'pure'\
[-Werror=suggest-attribute=pure]
From b076a606c06a7bf7150c9591028052884d48232f Mon Sep 17 00:00:00 2001
From: Jim Meye
Annoyed by warnings-about-unsupported-warning while using
gcc-built-from-git, I've just pushed this change:
From 5088dc55f4209d1ce4763726418834c7366819ec Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Thu, 2 Jan 2014 16:55:04 -0800
Subject: [PATCH] manywarnings: remove -Wmudflap
8.1.4 both work with the fixed quoting.
From 7a0c729aacc3716a665ce3b0c8cb34843bdecc75 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Wed, 1 Jan 2014 20:25:44 -0800
Subject: [PATCH] maint: fix public-submodule-commit to work with newer git
* top/maint.mk (public-submodule-commit): Remove excess qu
On Wed, Jan 1, 2014 at 5:56 PM, Gary V. Vaughan wrote:
> Hi Jim,
>
> Thanks for the quick response.
>
> On Jan 2, 2014, at 2:27 PM, Jim Meyering wrote:
>
>> On Wed, Jan 1, 2014 at 5:08 PM, Gary V. Vaughan wrote:
>> ...
>>> The change (back ticks instea
On Wed, Jan 1, 2014 at 5:08 PM, Gary V. Vaughan wrote:
...
> The change (back ticks instead of $(...) in the no-submodule-changes rule)
> looks like a harmless way to fix the bug to me.
>
> Okay to push?
Hi Gary,
I have been unable to reproduce that failure so far.
E.g., this via grep (which I h
On Fri, Dec 20, 2013 at 11:27 PM, Eric Blake wrote:
> I noticed that recvfd() fails with errno set to EACCES if the other end
> of the socket has closed (such as if it calls _exit()); but "Permission
> denied" as the strerror() message doesn't read very well. Any
> objections to a patch along the
IMHO, it should be gl-* everywhere.
On Mon, Nov 18, 2013 at 5:39 PM, Jim Meyering wrote:
> FYI:
Here's an updated version, semantically identical, but setting a
better example, per Paul's advice:
From c12ca6b35ba2a6ee9dd31e801e2c07f5d8f936df Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Mon, 18 Nov 2013 17:35:01
FYI:
From 694a18993c54415ba7936a236253fee9685ae711 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Mon, 18 Nov 2013 17:35:01 -0800
Subject: [PATCH] quotearg: don't attempt to store 1 << 31 into an "int"
* lib/quotearg.c (quotearg_buffer_restyled): Building coreutils
with
On Wed, Nov 13, 2013 at 10:44 AM, Reuben Thomas wrote:
> On 11 November 2013 14:30, Jim Meyering wrote:
>>
>> Glad you found it.
>> If you can find a good way to document it, I'd appreciate a patch.
>
>
> I can think of nothing better than a note in the s
On Thu, Nov 7, 2013 at 9:52 AM, Reuben Thomas wrote:
> On 7 November 2013 14:55, Jim Meyering wrote:
>>
>> Can you investigate, e.g., instrumenting those rules to see what's
>> happening (then I don't have to ask for instructions on how to
>> reproduce :-), f
On Wed, Nov 6, 2013 at 4:54 PM, Reuben Thomas wrote:
> I turned on tight-scope by pointing it at a directory with a library in.
>
> To start with, it (somewhat confusingly) tells me that all my API functions
> should be static. It doesn't seem to have the option to say they should be
> extern. Thi
't appear to call exit (it does call abort), and so
>> seems to be suitable for a library
>>
>> - hash-pjw which we also use is already licensed as LGPLv2+
>>
>> - it looks like the original author was Jim Meyering (CC'd)
>>
>> - the depend
301 - 400 of 3877 matches
Mail list logo
