Re: Replace use of obsolete Emacs feature "write-file-hooks"

2018-03-07 Thread Paul Eggert
On 03/07/2018 09:32 AM, Glenn Morris wrote: Thanks for replacing the obsolete forms. A few files were already using write-file-functions; I don't know if you want to change those to before-save-hook, for consistency. From today's gnulib: build-aux/config.sub build-aux/config.guess

Re: Replace use of obsolete Emacs feature "write-file-hooks"

2018-03-07 Thread Karl Berry
build-aux/texinfo.tex bug-texi...@gnu.org and doc/maintain.texi. bug-standa...@gnu.org I think Karl Berry can do those so I'll CC: him. Technically I can still commit to the repos, but I think it would be better if I didn't step in. (I can't help but remark that backward

Re: Replace use of obsolete Emacs feature "write-file-hooks"

2018-03-07 Thread Paul Eggert
On 03/07/2018 03:58 PM, Karl Berry wrote: >    doc/maintain.texi. > > bug-standa...@gnu.org Whaddya know, it turns out that I have the bits to do bug-standards after all; I'd forgotten about that. I installed a patch and propagated it into Gnulib. build-aux/texinfo.tex

Re: Replace use of obsolete Emacs feature "write-file-hooks"

2018-03-07 Thread Ben Elliston
On Wed, Mar 07, 2018 at 11:46:56AM -0800, Paul Eggert wrote: > These are all upstream from Gnulib. For the first two, I'm attaching > a proposed patch and CC'ing this to config-patches. For the last > one, I fixed the upstream and propagated it to Gnulib. Applied. Ben signature.asc

Re: Replace use of obsolete Emacs feature "write-file-hooks"

2018-03-07 Thread Glenn Morris
Thanks for replacing the obsolete forms. A few files were already using write-file-functions; I don't know if you want to change those to before-save-hook, for consistency. >From today's gnulib: build-aux/config.sub build-aux/config.guess doc/standards.texi

Re: Replace use of obsolete Emacs feature "write-file-hooks"

2018-03-07 Thread Paul Eggert
Glenn Morris wrote: Please replace "write-file-hooks" with "before-save-hook". I did that in all files maintained in Gnulib, along with files we're copying from Automake (I updated Automake), by installing the attached. Two files remain that I don't believe I have commit privileges on

Re: Replace use of obsolete Emacs feature "write-file-hooks"

2018-03-07 Thread Paul Eggert
Glenn Morris wrote: I assumed any utility to keeping the time stamps update was solely for edits in gnulib itself. I assumed otherwise, in that if a change was made downstream by hand they'd want the timestamps to be updated. By the way, I would rather remove these timestamps as they are

Re: fseeko broken by Fedora rawhide glibc / git master (ie future 2.28)

2018-03-07 Thread Daniel P . Berrangé
On Wed, Mar 07, 2018 at 09:05:59AM -0600, Eric Blake wrote: > On 03/05/2018 01:25 PM, Paul Eggert wrote: > > On 03/05/2018 11:20 AM, Daniel P. Berrangé wrote: > > > Yes, this worked on rawhide when I tested with libvirt. > > > > Thanks, I installed it into Gnulib since it was breaking builds.

Re: fseeko broken by Fedora rawhide glibc / git master (ie future 2.28)

2018-03-07 Thread Eric Blake
On 03/05/2018 01:25 PM, Paul Eggert wrote: On 03/05/2018 11:20 AM, Daniel P. Berrangé wrote: Yes, this worked on rawhide when I tested with libvirt. Thanks, I installed it into Gnulib since it was breaking builds. Bruno's the expert here, and perhaps he can come up with something better.

Re: fseeko broken by Fedora rawhide glibc / git master (ie future 2.28)

2018-03-07 Thread Richard W.M. Jones
On Wed, Mar 07, 2018 at 03:23:10PM +, Daniel P. Berrangé wrote: > On Wed, Mar 07, 2018 at 09:05:59AM -0600, Eric Blake wrote: > > On 03/05/2018 01:25 PM, Paul Eggert wrote: > > > On 03/05/2018 11:20 AM, Daniel P. Berrangé wrote: > > > > Yes, this worked on rawhide when I tested with libvirt. >