Re: [PATCH] maint: Allow gnulib's readutmp module to use systemd.

2024-03-22 Thread Collin Funk
On 3/22/24 2:18 PM, Simon Josefsson wrote: > Upgrading inetutils to use gnulib-tool.py would be nice. As a start, I > bumped the gnulib submodule. Bruno and I are still working on it with a test suite. We want the file output and stdout output to be the same before we recommend using it. Then we

Re: [PATCH] maint: Allow gnulib's readutmp module to use systemd.

2024-03-22 Thread Simon Josefsson via Bug reports for the GNU Internet utilities
Collin Funk writes: > Hi Simon, > > On 3/22/24 12:51 PM, Simon Josefsson wrote: >> Hi. Nice catch, thank you. I have added a CI/CD job to catch -lsystemd >> regressions in the future: > > Nice, looks good to me. > >> Thank you for details -- I think this is somewhat subjective, but I do >>

Re: [PATCH] maint: Allow gnulib's readutmp module to use systemd.

2024-03-22 Thread Collin Funk
Hi Simon, On 3/22/24 12:51 PM, Simon Josefsson wrote: > Hi. Nice catch, thank you. I have added a CI/CD job to catch -lsystemd > regressions in the future: Nice, looks good to me. > Thank you for details -- I think this is somewhat subjective, but I do > prefer to augment as specific LDADD's

Re: [PATCH] maint: Allow gnulib's readutmp module to use systemd.

2024-03-22 Thread Simon Josefsson via Bug reports for the GNU Internet utilities
Collin Funk writes: > When building on GNU/Linux with: > > ./configure --enable-systemd > > there are linker errors due to '-lsystemd' not being passed to the > linker. This is used by Gnulib's readutmp module. Hi. Nice catch, thank you. I have added a CI/CD job to catch -lsystemd regressions