[PATCH] Work with automake-1.10.

2007-02-13 Thread Jim Meyering
' with per-target flags requires `AM_PROG_CC_C_O' in `configure.ac' Here's a patch that fixes those and also removes some trailing blanks. --- From: Jim Meyering [EMAIL PROTECTED] Date: Mon, 12 Feb 2007 23:15:34 +0100 Subject: [PATCH] Work with automake

[PATCH] Compile warning-free with gcc -Wall -Wshadow.

2007-02-13 Thread Jim Meyering
shadowing the string.h function. * libparted/labels/sun.c (sun_partition_enumerate): Rename local variable i to j, to avoid shadowing another local. Signed-off-by: Jim Meyering [EMAIL PROTECTED] --- libparted/exception.c| 14 +++--- libparted/fs/hfs/cache.c |4

[PATCH] * libparted/labels/fdasd.c (GETARG): Remove unused definition.

2007-02-13 Thread Jim Meyering
A tiny change... Signed-off-by: Jim Meyering [EMAIL PROTECTED] --- libparted/labels/fdasd.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/libparted/labels/fdasd.c b/libparted/labels/fdasd.c index df32205..8fd38e1 100644 --- a/libparted/labels/fdasd.c +++ b/libparted

[PATCH] Don't define _GNU_SOURCE manually.

2007-02-13 Thread Jim Meyering
: Remove definition of _GNU_SOURCE. * libparted/arch/linux.c: Likewise. * libparted/device.c: Likewise. * parted/table.c: Likewise. * parted/table.h: Likewise. Signed-off-by: Jim Meyering [EMAIL PROTECTED] --- configure.ac |1 + libparted/arch/gnu.c |4 +--- libparted/arch/linux.c

Re: bug with parted

2007-03-12 Thread Jim Meyering
Frank [EMAIL PROTECTED] wrote: the version is 1.7.1 and the prompt sais: Assertion (disk != NULL) at ../../libparted/disk.c:1319 in function ped_disk_next_partition() failed. bad data in /proc/uptime I tried to access a s1mp3 usb-mp4-player (chinese one). Thanks for the report. This looks

Re: the test suite fails

2007-05-16 Thread Jim Meyering
Benno Schulenberg [EMAIL PROTECTED] wrote: Trying to install parted-.1.8.7 from an overlay produces this: Thanks for the report. What is an overlay? Please give enough information so that someone here can try to reproduce your problem. Also, when a test fails, please rerun it like e.g., cd

Re: the test suite fails

2007-05-16 Thread Jim Meyering
Benno Schulenberg [EMAIL PROTECTED] wrote: Jim Meyering wrote: Benno Schulenberg [EMAIL PROTECTED] wrote: Trying to install parted-.1.8.7 from an overlay produces this: Thanks for the report. What is an overlay? Something Gentoo-specific. Thanks, but that doesn't help me reproduce

Re: unclarities in message

2007-05-16 Thread Jim Meyering
Benno Schulenberg [EMAIL PROTECTED] wrote: diff --git a/partprobe/partprobe.c b/partprobe/partprobe.c index 1659100..e79193a 100644 --- a/partprobe/partprobe.c +++ b/partprobe/partprobe.c @@ -57,7 +57,7 @@ static struct option const long_options[] = { -{no-update, no_argument,

Re: unclarities in message

2007-05-16 Thread Jim Meyering
Benno Schulenberg [EMAIL PROTECTED] wrote: Jim Meyering wrote: Benno Schulenberg [EMAIL PROTECTED] wrote: -{no-update, no_argument, NULL, 'd'}, +{dry-run, no_argument, NULL, 'd'}, Looks good, but do not remove support for --no-update just yet. Instead, mark it as deprecated

Re: the test suite fails

2007-05-16 Thread Jim Meyering
Benno Schulenberg [EMAIL PROTECTED] wrote: Jim Meyering wrote: Benno Schulenberg [EMAIL PROTECTED] wrote: # dd if=/dev/zero of=FILE bs=1M count=1 2/dev/null # parted -s FILE mklabel msdos out 21 # xxd out 000: 1b5b 3f31 3033 3468 .[?1034h That's probably coming

Re: the test suite fails -- because of ncurses-5.6

2007-05-17 Thread Jim Meyering
Benno Schulenberg [EMAIL PROTECTED] wrote: Jim Meyering wrote: Then perhaps it's readline? Do you still get it if you invoke parted like this? # env TERM=dumb parted /dev/hda quit | od -a # env TERM=dumb parted /dev/hda quit | od -a 000 ... It's ncurses. Downgrading from 5.6

Re: Bug?

2007-06-10 Thread Jim Meyering
David Armstrong [EMAIL PROTECTED] wrote: Not sure if this is a bug or not. I've just expanding a hardware raid array to 3000GB and I'm trying to expand the partition table from 2250 to 3000GB. I'm getting an error when trying to expand it. GNU Parted 1.7.1 Using /dev/sda Welcome to GNU

Re: A question.

2007-07-06 Thread Jim Meyering
Vijaya V. Saradhi [EMAIL PROTECTED] wrote: When trying to do make check, I am getting the following output: ... make[1]: Entering directory `/home/saradhi/softwares/parted-1.8.7/tests' ... * ok 11: create expected output file * FAIL 12: check its output -- slightly different here, due to

Re: parted print output formatting

2007-07-11 Thread Jim Meyering
Dax Kelson [EMAIL PROTECTED] wrote: ... Please consider reverting the human friendly print output change, or support a option to print (say, -m) that prints only megabyte values (ala, the historical output style of 'print'). Thinking about this more, changing format and requiring a backwards

Re: Linux swap partitions set to type 0x83

2007-07-27 Thread Jim Meyering
Kenneth MacDonald [EMAIL PROTECTED] wrote: parted 1.8.7 (git trunk seems to be the same) The comparison of fs_type-name to linux-swap no longer catches Linux swap partitions as they're called either linux-swap(new) or linux-swap(old). This means, at least in the DOS label code, creating

Re: Linux swap partitions set to type 0x83

2007-07-31 Thread Jim Meyering
James Jarvis [EMAIL PROTECTED] wrote: Kenny is away on holiday from today so it is probable (but not certain as he has been known to logon and get on with these things) that the patch won't be ready by Friday. Thanks for letting us know. ___

[PATCH] Fix mkpart linux-swap bug: would use 0x83 rather than 0x82

2007-08-14 Thread Jim Meyering
. * tests/t2100-mkswap.sh: New file, test for the above fix. * tests/Makefile.am (TESTS): Add t2100-mkswap.sh. Signed-off-by: Jim Meyering [EMAIL PROTECTED] --- libparted/labels/Makefile.am | 28 +++-- libparted/labels/bsd.c |4 ++- libparted/labels/dasd.c |6

Re: 'partprobe' forgets to set the textdomain [patch]

2007-08-17 Thread Jim Meyering
Jim Meyering [EMAIL PROTECTED] wrote: Benno Schulenberg [EMAIL PROTECTED] wrote: The help message of `partprobe` is not getting localized, because it forgets to set its textdomain. Attached patch fixes this. Thank you! The #if ! ENABLE_NLS lines at the top of partprobe.c can probably

FYI, restore ChangeLog-creation code

2007-12-17 Thread Jim Meyering
I didn't notice my deletion of the ChangeLog-creation code in the merge of bootstrap, so rather than restoring it there, I've put that snippet in bootstrap.conf, where it belongs. bootstrap.conf: Perform ChangeLog-creation here, rather than in bootstrap, so that the next merge will be less

Re: Assertion failed in parted 1.6.19

2007-12-22 Thread Jim Meyering
[EMAIL PROTECTED] wrote: Assertion (cyl_size = 255 * 63) at disk_dos.c:556 in function probe_partition_for_geom() failed. Thanks for the report. However, parted-1.6.x is pretty old, so that bug is most likely already fixed. If you can reproduce such a failure with a newer version (say 1.8.8),

Re: [parted 1.8.8] msdos label and file system corruption issues with 2TB disk

2008-01-11 Thread Jim Meyering
: - From 1bf00ea84e80d9f04aed3c4a15ddb307b1807f5e Mon Sep 17 00:00:00 2001 From: Jim Meyering [EMAIL PROTECTED] Date: Thu, 10 Jan 2008 14:51:56 +0100 Subject: [PATCH] Enforce inherent limitations of the dos partition table format. * libparted/disk.c (_check_partition): Enforce the 32-bit

Re: [parted 1.8.8] msdos label and file system corruption issues with 2TB disk

2008-01-14 Thread Jim Meyering
Michael Reed [EMAIL PROTECTED] wrote: ... I also noticed that this problem also exists on the SGI label type, dvh. Perhaps an examination of the various supported partition types is in order to impose this limitation on more than just msdos labels? A quick glance (from

Re: parted-1.8.x unusable - gives 'unrecognised disk label'. parted 1.7.1 does not.

2008-02-03 Thread Jim Meyering
Graham Keeling [EMAIL PROTECTED] wrote: When I install versions of parted between 1.8.0 and 1.8.8 (I've tested 1.8.0, 1.8.7 and 1.8.8), I get the following and therefore cannot do anything useful with it: GNU Parted 1.8.8 Using /dev/ide/host0/bus1/target0/lun0/disc Welcome

Re: Fould a bug with respect to parted in SLES 10 SP1

2008-02-06 Thread Jim Meyering
Francis, Sapna (STSD) [EMAIL PROTECTED] wrote: We are facing error while using the parted command on SLES10 SP1. The command used is parted -s /dev/mapper/mpath10 p error: Floating point exception Parted utility throws floating point exception when using device mapper path. It works fine

Re: problems with ext3 after resizing

2008-02-13 Thread Jim Meyering
Massimo Bongi [EMAIL PROTECTED] wrote: I have problems with an ext3 partition whose data I would like not to lose, and I hope some one can help me.. I've used parted 1.6.19 to grow an ext3 partition (after adding some disks to a RAID array). It worked without errors, but now when I try to

Re: bug report for parted

2008-02-16 Thread Jim Meyering
[EMAIL PROTECTED] wrote: GNU Parted 1.6.19 ... Assertion ((C * heads + H) * sectors + S == A) at disk_dos.c:582 in function probe_partition_for_geom() failed. Ignore/Cancel? Thanks for reporting that. 1.6.19 is pretty old. I'm pretty sure that particular bug is fixed in newer versions. The

Re: I found bug(s) in GNU parted utility

2008-02-21 Thread Jim Meyering
Hari Sekhon [EMAIL PROTECTED] wrote: Here is the output including what I typed and the result so you can see for yourself: ... End? 99 You found a bug in GNU Parted. Please email a bug report to bug-parted@gnu.org containing the version (1.6.9), and the following Thank you

Re: Bug report for parted 1.6.9

2008-02-21 Thread Jim Meyering
Jesse Becker [EMAIL PROTECTED] wrote: As requested by the parted program, I'm sending this bug report. The device in question is an AoE device, built from 10 400GB hard drives, configured into a RAID10 array. There are *no* existing partition tables or GPT disk labels on the device. I

Re: GPT partition table version 10000 error

2008-02-29 Thread Jim Meyering
jeff [EMAIL PROTECTED] wrote: Yesterday I installed Solaris x86 version 10 2007/08. Today I reinstalled with RHEL 4. During the installation I get: Warning: The format of the GPT partition table is version 1, which is newer than what Parted can recognise. Please tell us!

Re: Formatting a 2Gb MicroSD card

2008-07-25 Thread Jim Meyering
Sebastian Tennant [EMAIL PROTECTED] wrote: I initially used my phone to format a 2Gb MicroSD card and it appeared to have 2Gb of capacity when mounted in my Gnome desktop environment. However, I soon noticed that I was mysteriously losing data and my kern.log was full of messages warning me

Re: [PATCH] Don't fail if unable to reread partition table

2008-08-06 Thread Jim Meyering
Soren Hansen [EMAIL PROTECTED] wrote: I used to use parted 1.7.7 as this was what was shipped by Ubuntu and Debian up until very recently. I used parted to add a partition table to disk images that I'd be using for virtual machines. When parted was updated to 1.8.8, this stopped working, since

Re: [parted-devel] [PATCH] Fall back to not using O_DIRECT

2008-08-06 Thread Jim Meyering
Olaf Hering [EMAIL PROTECTED] wrote: On Tue, Aug 05, Soren Hansen wrote: +#if defined(O_DIRECT) It is safe to drop the entire thing. ifarch like that, in generic code, asks for trouble. Hi Olaf, Thanks for the patch. I agree wholeheartedly that arch-specific #ifdefs are best avoided, but

Re: unrecognised disk label

2008-08-26 Thread Jim Meyering
stonezhang [EMAIL PROTECTED] wrote: If you do follow: dd if=/dev/zero of=/dev/sdb bs=512 count=1 then you create partition by parted ,it will show Error: /dev/sdb: unrecognised disk label, but fdisk have no this error (/dev/sdb is a usb disk). Thanks for the report. However, if you

Re: assertion PED_LE64_TO_CPU (gpt-AlternateLBA) = disk-dev-length failed

2008-08-26 Thread Jim Meyering
Bjorn Helgaas [EMAIL PROTECTED] wrote: [I tried to submit this via Trac, but it said 500 Internal Server Error (Submission rejected as potential spam)]. I also tried to debug this with gdb, but the parted I built complains like this: Sometimes it's easier to debug if you configure like

Re: RAID support for Sun disktype [FIXEDPATCH]

2008-12-21 Thread Jim Meyering
Tom \spot\ Callaway tcall...@redhat.com wrote: Attached is a patch to enable RAID support for Sun disks. Aurora SPARC Linux has been using this successfully for some time now. Thanks for the patch! Can you provide examples that we could massage into a test case or two that would exercise this

Re: RAID support for Sun disktype [FIXEDPATCH]

2008-12-21 Thread Jim Meyering
Tom \spot\ Callaway tcall...@redhat.com wrote: On Sun, 2008-12-21 at 09:33 +0100, Jim Meyering wrote: Tom \spot\ Callaway tcall...@redhat.com wrote: Attached is a patch to enable RAID support for Sun disks. Aurora SPARC Linux has been using this successfully for some time now. Thanks

Re: A bug has been detected in GNU Parted.

2009-05-04 Thread Jim Meyering
Anton Karpov wrote: Linux Debian Lenny 5.01 Kernel: Linux manager 2.6.26-2-686 #1 SMP Thu Mar 26 01:08:11 UTC 2009 i686 GNU/Linux parted 1.8.8 ... manager:~# partprobe -s /dev/sda: msdos partitions 1 2 5 6 /dev/sdb: msdos partitions 1 2 5 6 Backtrace has 7 calls on stack: 7:

Re: parted-1.9.0 released [stable]

2009-07-24 Thread Jim Meyering
Joel Granados wrote: This is to announce parted-1.9.0, a release we're calling stable, because we think it's solid enough for general use. ... gpg --keyserver keys.gnupg.net --recv-keys B9AB9A16 Hi Joel, The announcement notice lists my GPG key ID, yet the tarballs are signed with yours:

Re: growing XFS with GPT partitions

2009-08-18 Thread Jim Meyering
Lasse Kärkkäinen wrote: This is apparently a rather common problem, as I keep receiving messages about this every few weeks. Here's the latest: Michael Monnerie wrote: http://www.mail-archive.com/bug-parted@gnu.org/msg02631.html Did you ever resolve this? How? I solved the problem for

Re: PATCH [libparted]: avoid unnecessary open() / close() on commit()

2009-08-28 Thread Jim Meyering
Hans de Goede wrote: ... This is rather inefficient, and causes 2 udev change events to be fired for /dev/sda (+ the change events from the BLKRRPART), causing all kind of scanning (blkid friends) twice. The attached patch fixes things to only open the device once. Hi Hans, Thanks for the

Re: [parted] ped_partition_busy should not call the libparted exception handler

2009-10-06 Thread Jim Meyering
Hans de Goede wrote: Modify libparted/arch/linux.c _partition_get_part_dev() to not call _device_stat() but instead use stat directly, as _device_stat() calls the libparted exception handler and we don't want this here, the only caller of _partition_get_part_dev() is _partition_is_mounted(),

Re: [parted] ped_partition_busy should not call the libparted exception handler

2009-10-06 Thread Jim Meyering
Hans de Goede wrote: On 10/06/2009 11:54 AM, Jim Meyering wrote: Hans de Goede wrote: Modify libparted/arch/linux.c _partition_get_part_dev() to not call _device_stat() but instead use stat directly, as _device_stat() calls the libparted exception handler and we don't want this here, the only

Re: moving partitions with 240 heads geometry converts them to 255 heads geometry

2009-10-07 Thread Jim Meyering
Kim Mik wrote: At the Parted Magic forum, we have a report that Gparted messes up the disk when partitions which have 240 heads geometry on disk get moved. Those moved partitions get a 255 heads geometry See for the post of the bug reporter at:

Re: [PATCH parted] Handle swap flag in msdos type labels

2009-10-10 Thread Jim Meyering
Hans de Goede wrote: From: David Cantrell dcantr...@redhat.com Original patch by David Cantrell dcantr...@redhat.com, I (Hans de Goede hdego...@redhat.com) made the following changes: -msdos_partition_is_flag_available() should return 1 for swap flag -Only change the partition type to 82

Re: [PATCH parted] Handle swap flag in msdos type labels

2009-10-13 Thread Jim Meyering
Hans de Goede wrote: From: David Cantrell dcantr...@redhat.com Original patch by David Cantrell dcantr...@redhat.com, I (Hans de Goede hdego...@redhat.com) made the following changes: -msdos_partition_is_flag_available() should return 1 for swap flag -Only change the partition type to 82

Re: [PATCH parted 2/5] linux.c: save blkid topology in arch_specific data for later use

2009-10-28 Thread Jim Meyering
Hans de Goede wrote: This is a preparation patch for adding get_minimal_alignment and get_optimal_alignment functions to linux's _PedDeviceArchOps. --- libparted/arch/linux.c | 75 ++-- libparted/arch/linux.h |8 + 2 files changed, 36

Re: [PATCH parted 1/7] libparted: add ped_device_get_xxx_alignment() functions

2009-10-29 Thread Jim Meyering
Hans de Goede wrote: Add ped_device_get_minimum_alignment() and ped_device_get_optimum_alignment() functions to libparted. Note this is a resent of my previous patchset with a number of typos corrected: aligment - alignment minimal_alignment - minimum_aligment optimal_alignment -

Re: [PATCH parted 1/5] dasd: Cleanup anchor handling

2009-11-04 Thread Jim Meyering
Hans de Goede wrote: The current dasd label code keeps an fdasd anchor struct in the DasdDiskSpecific struct, and fills this during dasd_read. However this anchor does not get updated with any future mods, until dasd_write, at which points it gets completely re-initialized. Thanks for these

Re: [PATCH parted 1/5] dasd: Cleanup anchor handling

2009-11-04 Thread Jim Meyering
Hans de Goede wrote: On 11/04/2009 10:32 AM, Jim Meyering wrote: Hans de Goede wrote: The current dasd label code keeps an fdasd anchor struct in the DasdDiskSpecific struct, and fills this during dasd_read. However this anchor does not get updated with any future mods, until dasd_write

Re: [PATCH parted] dasd: Fix ped_disk_new_fresh() to not read old data from disk (rh533808)

2009-11-09 Thread Jim Meyering
Hans de Goede wrote: dasd_write(), was reading the volume label from the disk (trough fdasd_check_volume()) and later writing it back again, this is fine for existing dasd labels, but when creating a fresh label, this would also cause the old volume label to be re-used, and if the old label

Re: [PATCH parted] dasd: Fix ped_disk_new_fresh() to not read old data from disk (rh533808)

2009-11-12 Thread Jim Meyering
Jim Meyering wrote: Hans de Goede wrote: dasd_write(), was reading the volume label from the disk (trough fdasd_check_volume()) and later writing it back again, this is fine for existing dasd labels, but when creating a fresh label, this would also cause the old volume label to be re-used

Re: [PATCH parted] dasd: Fix ped_disk_new_fresh() to not read old data from disk (rh533808)

2009-11-12 Thread Jim Meyering
Jim Meyering wrote: Jim Meyering wrote: Hans de Goede wrote: dasd_write(), was reading the volume label from the disk (trough fdasd_check_volume()) and later writing it back again, this is fine for existing dasd labels, but when creating a fresh label, this would also cause the old volume

Re: assertion failed in 1.6.22

2009-11-20 Thread Jim Meyering
Chris Carbaugh wrote: Version 1.6.22 Assertion (last_usable = disk-dev-length) at disk_gpt.c:482 in function _parse_header() failed. Thanks for the report. Parted has improved a lot since 1.6.x. If you can reproduce a failure with 1.9.x or 2.x, please report it here again.

[PATCH 2/2] pc98: avoid segfault with simulated large sectors

2009-12-07 Thread Jim Meyering
While exercising a new interface, a known problem (the pc98 partition table type not 512-byte-sector ready) caused a new test to fail, so I've fixed one of the failing parts of pc98 support: From 1e8c1c6cf8b4b2616405b7ee42d036a30126387a Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer

Re: [PATCH parted 3/3] dasd: fix memleak in dasd_free

2009-12-09 Thread Jim Meyering
Hans de Goede wrote: * libparted/labels/dasd.c(dasd_free): free disk_specific data. --- libparted/labels/dasd.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/libparted/labels/dasd.c b/libparted/labels/dasd.c index dd492f2..57612a3 100644 ---

Re: [PATCH parted 2/5] parted: add --align commandline option to specify mkpart alignment

2009-12-10 Thread Jim Meyering
Hans de Goede wrote: The new --align commandline option can have the following values: none: Use the minimum alignment allowed by the disk type cyl: Align partitions to cylinders (the default) min: Use minimum alignment as given by the disk topology information opt: Use optimum

Re: [PATCH parted 2/5] parted: add --align commandline option to specify mkpart alignment

2009-12-10 Thread Jim Meyering
Hans de Goede wrote: The new --align commandline option can have the following values: none: Use the minimum alignment allowed by the disk type cyl: Align partitions to cylinders (the default) min: Use minimum alignment as given by the disk topology information opt: Use optimum

Re: [PATCH parted 1/6] parted.texi: Document --align option

2009-12-10 Thread Jim Meyering
Hans de Goede wrote: doc/parted.texi: Document --align option. Thanks for all of these! I've just confirmed that they pass all tests and pushed them. ___ bug-parted mailing list bug-parted@gnu.org http://lists.gnu.org/mailman/listinfo/bug-parted

Re: [PATCH parted] linux: Treat loopback devices as files

2009-12-11 Thread Jim Meyering
= PED_DEVICE_FILE; } else { dev-type = PED_DEVICE_UNKNOWN; } -- 1.6.6.rc1.319.g9b57d From 6792f263d47f9550869fde3a751aaf7349b91c0a Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Fri, 11 Dec 2009 16:56:45 +0100 Subject: [PATCH 2/2] tests: ensure

parted-2.1 release imminent

2009-12-11 Thread Jim Meyering
I hope to make a release in the next few days, probably on Monday. If any of you know of existing problems or fixes that have not been applied, please let us know here on the list. ___ bug-parted mailing list bug-parted@gnu.org

Re: Error initialising SCSI device /dev/sda - Invalid argument and parted: double free or corruption (out)

2009-12-18 Thread Jim Meyering
Rudy Gevaert wrote: ... If I then quiet parted I get *** glibc detected *** parted: double free or corruption (out): 0x7efff7afcab0 *** That is then only with parted 1.8.8.git.2008.03.24-11.1. So to conclude: 1) In my case, doing things with -s enabled doesn't work (either versions)

Re: [PATCH parted 2/2] linux: Fix use after free in devicemapper code

2009-12-18 Thread Jim Meyering
Hans de Goede wrote: * libparted/arch/linux.c (_dm_add_partition): Fix use of dm_task information after freeing it. --- libparted/arch/linux.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libparted/arch/linux.c b/libparted/arch/linux.c index

parted-2.1 released [stable]

2009-12-20 Thread Jim Meyering
While this release adds some features, they are new interfaces or changes enabled only via a new option, or via the presence of a new on-disk bit. As such, they should be safe enough that I can still call this a stable release. Special thanks to Hans De Goede for numerous fixes and additions.

Re: issues

2009-12-24 Thread Jim Meyering
Jim Thomas wrote: Jim == Jim Thomas tho...@cfht.hawaii.edu writes: Jim Except that it does not : Jim [r...@test:~/] # parted --script /dev/sdb mklabel gpt Jim [r...@test:~/] # parted --script -- /dev/sdb mkpart gpt 0 -1s Jim Error: You requested a partition from 0.00B to

Re: [PATCH parted 2/3] linux: Remove unused blkpg.h header file

2010-01-29 Thread Jim Meyering
Hans de Goede wrote: * libparted/arch/linux.c: Don't include blkpg.h. * libparted/arch/blkpg.h: Deleted. ... Thanks. Applied, with this addition, so that make dist does not fail: * libparted/Makefile.am (libparted_la_SOURCES): Remove arch/blkpg.h. diff --git a/libparted/Makefile.am

Re: [PATCH parted 1/3] linux: use blkid_topology_get_physical_sector_size

2010-01-29 Thread Jim Meyering
Hans de Goede wrote: The official 2.17 release of util-linux-ng, has added a function to get the physical sector size, use that instead of getting the minimum io size. * libparted/arch/linux.c(_device_set_sector_size): use blkid_topology_get_physical_sector_size. --- libparted/arch/linux.c

Re: [PATCH parted 3/3] linux: Remove PED_DEVICE_FILE check from _device_set_sector_size

2010-01-29 Thread Jim Meyering
Hans de Goede wrote: _device_set_sector_size never get called for devices with a type of PED_DEVICE_FILE, and having a PED_DEVICE_FILE check inside an ifdef __390__ block does not make sense. * libparted/arch/linux.c(_device_set_sector_size): Remove PED_DEVICE_FILE check. ... Thanks! That

Re: [PATCH parted 6/7] Makefiles: Fix check-other-sector_sizes

2010-01-31 Thread Jim Meyering
-recursive Thanks! Obviously a bug. (introduced by me, btw). And in fact, it hid a test failure. I've fixed the failing test, two -Wshadow warnings, and pushed this change: From 2f1828c6e01968db108084e19f3edea0190e83bd Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Sun

Re: [PATCH parted 6/7] Makefiles: Fix check-other-sector_sizes

2010-01-31 Thread Jim Meyering
Hans de Goede wrote: Thanks for the heads up, note that I've finished a couple of test installs this morning and the rest of the patch set is good to go too from my pov. Actually I've already build Fedora and RHEL-6 packages with it in. Speaking of testing, ... Are any parts of the code

Re: Bug with rewriting partition table - need help

2010-02-07 Thread Jim Meyering
27/249 wrote: Seems that attached patch fixed this bug. I tested some cases, and everything works fine for me, but I'm not sure if it can break something hidden, so, developers, please review this fix. On Sun, Feb 7, 2010 at 6:50 PM, 27/249 i27...@gmail.com wrote: Yes, I forgot to add that

Re: Bug with rewriting partition table - need help

2010-02-09 Thread Jim Meyering
Jim Meyering wrote: 27/249 wrote: Seems that attached patch fixed this bug. I tested some cases, and everything works fine for me, but I'm not sure if it can break something hidden, so, developers, please review this fix. On Sun, Feb 7, 2010 at 6:50 PM, 27/249 i27...@gmail.com wrote: Yes, I

Re: [PATCH parted 1/7] linux: Fixup phys_sector_size setting

2010-02-10 Thread Jim Meyering
Thanks for rebasing. I've just pushed that series with minor wording changes to commit logs and NEWS. ___ bug-parted mailing list bug-parted@gnu.org http://lists.gnu.org/mailman/listinfo/bug-parted

parted-2.2 coming soon

2010-02-10 Thread Jim Meyering
Given the recently-fixed GPT bugs and Hans' alignment related changes, I'd like to make a new release soon. If anyone has pending patches, or known problems they haven't yet reported, please speak up soon. Here's NEWS so far: ** Changes in behavior The default alignment (--align option)

Re: Differences in Primary GPT Header

2010-02-18 Thread Jim Meyering
Tobias Arp wrote: i am using parted 2.1 aand i have some questions about gpt partitions. I have created a gpt partion on a harddisk. After creating a ntfs file system on this partition i got full access to this drive. I could read and write successfully on it. I viewed the primary gpt

Re: Differences in Primary GPT Header

2010-02-18 Thread Jim Meyering
Tobias Arp wrote: -Ursprüngliche Nachricht- Von: Jim Meyering j...@meyering.net Gesendet: 18.02.2010 09:31:54 An: Tobias Arp tobias...@web.de Betreff: Re: Differences in Primary GPT Header Tobias Arp wrote: i am using parted 2.1 aand i have some questions about gpt partitions. I

Re: [PATCH parted] libparted: copy needs_clobber value in ped_disk_duplicate()

2010-02-20 Thread Jim Meyering
Hans de Goede wrote: Most duplicate disk_ops use ped_disk_new_fresh, which sets needs_clobber to 1. This would lead to clobbering the disk when committing a duplicate disk even when the original disk was not made with ped_disk_new_fresh. * libparted/disk.c (ped_disk_duplicate): copy

Re: Wrong partition identifier for HFS

2010-02-26 Thread Jim Meyering
the first patch: From 15b05d910328f4120f5ded3b81f5f29e861f8b31 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Fri, 26 Feb 2010 14:47:52 +0100 Subject: [PATCH 1/3] tests: gpt-pmbr: don't ignore stdout comparison result * tests/t0202-gpt-pmbr.sh: Fail if we get unexpected output

parted-2.2 released [stable]

2010-02-26 Thread Jim Meyering
This is to announce parted-2.2, a stable release. Here's its soon-to-be-updated home page: http://www.gnu.org/software/parted/ Thanks to everyone else who has been contributing, helping to manage the mailing list and reporting bugs. For a summary of changes and contributors, see:

Re: Wrong partition identifier for HFS

2010-02-26 Thread Jim Meyering
Curtis Gedak wrote: (BTW, your mail client mangled the patch, so I couldn't apply it) I had cut and pasted the patch into Thunderbird and it was probably wrapped at 70 characters. That would be a problem, but I can usually work around it. Whatever you did also caused the first space to be

Re: [PATCH parted] msdos_partition_is_flag_available: fix hidden on extended

2010-03-02 Thread Jim Meyering
Thanks! I've added NEWS, and for once may refrain from adding a test. From 737ff191283d660401edb0422df707a9412e79af Mon Sep 17 00:00:00 2001 From: David Cantrell dcantr...@redhat.com Date: Tue, 2 Mar 2010 09:58:18 +0100 Subject: [PATCH] libparted: msdos_partition_is_flag_available: fix hidden on

[PATCH] tests: reenable a bsd partition table test

2010-03-11 Thread Jim Meyering
FYI, just pushed: From a4b18ded3b8cdfa1a50d4fb6f7a70111c7b473e6 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Thu, 11 Mar 2010 19:48:08 +0100 Subject: [PATCH] tests: reenable a bsd partition table test * libparted/tests/common.c (_implemented_disk_label): Remove bsd from

Re: [PATCH parted 2/2] libparted: Don't canonicalize /dev/mapper paths

2010-04-06 Thread Jim Meyering
Hans de Goede wrote: Besides fixing the issue displayed by libparted/tests/symlink.c, this has the added advantage that the output of parted p on one of these devices now says: Disk /dev/mapper/BigVol2-lv_iscsi_disk2: 34.4GB Which is a lot more user friendly then the output before this

Re: [RFC/PATCH 0/2] support for CMS-formatted disks on the s/390 architecture

2010-04-17 Thread Jim Meyering
Jonathan Nieder wrote: The inimitable Stephen Powell sent something like the two patches below to http://bugs.debian.org/578097. It seems that they teach the dasd driver in parted to handle CMS-labeled partitions, which are a little more flexible and probably more common than the LDL format

Re: [RFC/PATCH 0/2] support for CMS-formatted disks on the s/390 architecture

2010-04-17 Thread Jim Meyering
Stephen Powell wrote: On Sat, 17 Apr 2010 11:10:04 -0400 (EDT), Jim Meyering wrote: Thanks for preparing those. Can either of you outline a test for each that would fail before application of a patch and succeed after it? For the first problem, the invalid starting block for an LDL disk

Re: [PATCH parted 2/2] dos: Fix prep / palo flag handling

2010-04-20 Thread Jim Meyering
; dos_data-raid = 0; dos_data-lvm = 0; + dos_data-palo = 0; Thanks for the bug fix. Here's a test to exercise it, along with a typo fix. From 5ee31fb42876c7a36f499908dcc36f701efa0b56 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Tue, 20

Re: [PATCH parted 1/2] dos: Add a partition flag for diagnostics / recovery partitions

2010-04-20 Thread Jim Meyering
Hans de Goede wrote: msdos partition tables can contain diagnostics partitions (often used now a days as system recovery partitions). For some users of libparted (ie anaconda) it is usefull to know if a dos partition is a regular partition or a diagnostic partition (see rh bug 534066). *

Re: [RFC/PATCH 0/2] support for CMS-formatted disks on the s/390 architecture

2010-04-21 Thread Jim Meyering
Stephen Powell wrote: ... My goal is to write a portable shell script that triggers the flaw, and use that to show your fix solves the problem. I'm working on that, and I will have something for you shortly, but in the mean time I've been doing some regression testing, and I have discovered

Re: [RFC/PATCH 0/2] support for CMS-formatted disks on the s/390 architecture

2010-04-21 Thread Jim Meyering
Stephen Powell wrote: ... Yes, that is absolutely correct. An LDL- or CMS-format disk, by definition, has one and only one partition, and it is non-modifiable. By that I mean that the size and location of the partition can only be changed by reformatting the disk with a different block

Re: [PATCH parted] linux: dm_task_run returns 0 on error

2010-04-23 Thread Jim Meyering
Hans de Goede wrote: We were checking for a return value of 0 for dm_task_run errors, but dm_task_run returns 0 on error (and 1 on success). Thanks to Joe Jin for spotting this, see Red Hat bug 582907. * libparted/arch/linux.c(_dm_remove_map_name, _dm_is_part, _dm_remove_parts,

Re: parted bug, don't read the partition table

2010-04-23 Thread Jim Meyering
jdd wrote: This is a report from a bug found in openSUSE 11.2 and reported in openSUSE bugzilla here: https://bugzilla.novell.com/show_bug.cgi?id=598464 In short, in some obscure circomstances (obscure because I don't know how I happen to have such a drive), parted refuses to read the

BLKPG changes pushed

2010-04-23 Thread Jim Meyering
I'm not happy with these changes yet, mainly because of the lack of tests, but also because I just tried to add a couple partitions (in free space), and each time, I got this: $ sudo ./parted -s $dev u B mkpart F13-root $s2 $e2 Warning: WARNING: the kernel failed to re-read the partition

Re: BLKPG changes pushed

2010-04-24 Thread Jim Meyering
Phillip Susi wrote: On Fri, 2010-04-23 at 20:49 +0200, Jim Meyering wrote: I'm not happy with these changes yet, mainly because of the lack of tests, but also because I just tried to add a couple partitions (in free space), and each time, I got this: $ sudo ./parted -s $dev u B mkpart

Re: BLKPG changes pushed

2010-04-24 Thread Jim Meyering
Curtis Gedak wrote: Jim Meyering wrote: ... I just tried to add a couple partitions (in free space), and each time, I got this: $ sudo ./parted -s $dev u B mkpart F13-root $s2 $e2 Warning: WARNING: the kernel failed to re-read the partition table on /dev/sda (Device or resource

Re: BLKPG changes pushed

2010-04-24 Thread Jim Meyering
Curtis Gedak wrote: Jim Meyering wrote: Curtis Gedak wrote: Jim Meyering wrote: ... I just tried to add a couple partitions (in free space), and each time, I got this: $ sudo ./parted -s $dev u B mkpart F13-root $s2 $e2 Warning: WARNING: the kernel failed to re-read the partition

[PATCH 1/2] ui: get version number from a separately-compiled file

2010-04-27 Thread Jim Meyering
The first change helps keep --version output in sync with reality. The second corrects the URL printed by --version. From a206a36b53ae3d6e0454cd6c3f99618b147b941f Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Mon, 26 Apr 2010 18:44:40 +0200 Subject: [PATCH 1/2] ui: get

Re: BLKPG changes pushed

2010-04-27 Thread Jim Meyering
Curtis Gedak wrote: Curtis Gedak wrote: Jim Meyering wrote: $ sudo ./parted -s $dev u B mkpart F13-root $s2 $e2 Warning: WARNING: the kernel failed to re-read the partition table on /dev/sda (Device or resource busy). As a result, it may not reflect all of your changes

[PATCH] tests: test all boolean flags

2010-04-28 Thread Jim Meyering
Here's a more thorough test of the MSDOS flags. Hans, note that currently this would not test your new DIAG flag, since there was no sentence for it in the texinfo documentation. Would you care to add one? From 97961ee49e8461458a0667137550608c993904c6 Mon Sep 17 00:00:00 2001 From: Jim Meyering

[PATCH 1/8] maint: pass newer make syntax-check tests from gnulib

2010-04-28 Thread Jim Meyering
Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Wed, 28 Apr 2010 19:14:17 +0200 Subject: [PATCH 1/8] maint: pass newer make syntax-check tests from gnulib * cfg.mk (local-checks-to-skip): Add these, to pass make syntax-check sc_error_message_uppercase, sc_error_message_period

one more

2010-04-28 Thread Jim Meyering
I neglected to add the new file, init.sh to EXTRA_DIST, so make distcheck would fail. Here's the fix: From a27fb4c02f7312aa957df69afe548d062f48d9b3 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Wed, 28 Apr 2010 22:50:35 +0200 Subject: [PATCH] tests: distribute new file

Re: [PATCH] tests: test all boolean flags

2010-04-29 Thread Jim Meyering
Hans de Goede wrote: Hi, Great, thanks! I've resend my DIAG flag patch with a new chunk adding a blurb about the flag to the texinfo documentation. On 04/28/2010 06:28 PM, Jim Meyering wrote: Here's a more thorough test of the MSDOS flags. Hans, note that currently this would not test your

  1   2   3   4   >