On 6/19/12 10:36 PM, David Holmes wrote:
On 20/06/2012 2:32 PM, Daniel D. Daugherty wrote:
That all said, it still seems to me that the logic for GENERATED is
not correct if you have done a cd into the 64 subdirectory.
Exactly the opposite is true. Without the TOPDIR/GENERATED combo,
when you
On 20/06/2012 2:32 PM, Daniel D. Daugherty wrote:
That all said, it still seems to me that the logic for GENERATED is
not correct if you have done a cd into the 64 subdirectory.
Exactly the opposite is true. Without the TOPDIR/GENERATED combo,
when you "cd 64", the "../generated" that the GENER
On 6/19/12 9:37 PM, David Holmes wrote:
On 20/06/2012 1:23 PM, Daniel D. Daugherty wrote:
Thanks for the quick review!
You said it was urgent ;-)
Yes, but sometimes that still doesn't get me timely reviews. :-)
However, you have to be crazy to change HotSpot Makefiles so...
can you really bl
On 20/06/2012 1:23 PM, Daniel D. Daugherty wrote:
Thanks for the quick review!
You said it was urgent ;-)
On 6/19/12 8:06 PM, David Holmes wrote:
It would be nice if the cd into the 64 directory could be handled
internally to the link logic rather than occurring at the top-level (I
say this
TOPDIR is also used in other HotSpot Makefiles so my usage here
is consistent.
Dan
On 6/19/12 8:51 PM, Kelly O'Hair wrote:
And TOPDIR might be a variable used in the top level JDK Makefiles, referring
to the top of the forest. :^(
So the TOPDIR name needs to be more unique I think.
-kto
On
Thanks for the quick review!
On 6/19/12 8:06 PM, David Holmes wrote:
Hi Dan,
It would be nice if the cd into the 64 directory could be handled
internally to the link logic rather than occurring at the top-level (I
say this as someone who will need to hand merge this into another
workspace ;
Thanks for the quick review!
On 6/19/12 7:58 PM, Kelly O'Hair wrote:
130 ( set -e ; \
131 cd 64 ; \
132 $(QUIETLY) $(ADD_GNU_DEBUGLINK) \
133 $(LIBJVM_DB_DEBUGINFO) $(LIBJVM_DB) ; \
134 )
Would be better as:
130 ( cd 64&& $(AD
And TOPDIR might be a variable used in the top level JDK Makefiles, referring
to the top of the forest. :^(
So the TOPDIR name needs to be more unique I think.
-kto
On Jun 19, 2012, at 7:06 PM, David Holmes wrote:
> Hi Dan,
>
> It would be nice if the cd into the 64 directory could be handled
Hi Dan,
It would be nice if the cd into the 64 directory could be handled
internally to the link logic rather than occurring at the top-level (I
say this as someone who will need to hand merge this into another
workspace ;-) ).
Also in make/solaris/makefiles/add_gnu_debuglink.make I don't un
I see a tiny issue with the script:
200 if [ -s ${tmpfile} ] ; then
201 diff -c ${tmpfile} ${template_dir}/${header} 1>&2
202 if [ "$?" = "0" ] ; then
203 echo "SUCCESS: The license header for "`pwd`"/"$1" has been
verified."
204 echo "###"
205
130 ( set -e ; \
131 cd 64 ; \
132 $(QUIETLY) $(ADD_GNU_DEBUGLINK) \
133 $(LIBJVM_DB_DEBUGINFO) $(LIBJVM_DB) ; \
134 )
Would be better as:
130 ( cd 64 && $(ADD_GNU_DEBUGLINK) $(LIBJVM_DB_DEBUGINFO)
$(LIBJVM_DB) )
And making GENERATED
Changeset: 8fb4cd2f05a1
Author:mbykov
Date: 2012-06-19 14:24 -0700
URL: http://hg.openjdk.java.net/jdk8/build/rev/8fb4cd2f05a1
7178241: Basic script for JDK source code legal headers conformance verification
Summary: A new script lic_check.sh to check license headers in JDK source c
Greetings,
This is an URGENT code review request for a Solaris specific Full Debug
Symbols (FDS) fix. Due to a Makefile logic error, the full debug symbol
files and related '_g' symlinks are created in the wrong sub-directory
for a couple of the dtrace libraries. The incorrect paths have a double
Hi, guys,
unfortunately, not many of the current AWT engineers can provide
valuable information on the wrapper generator. Many thanks to Yuri (in
CC), he digged up the following bug:
6185483: AMD64: xawt 32-bit build should not require running a 64-bit
executable
It's hidden on bugs.sun.co
On 19/06/12 12:18, David Holmes wrote:
On 19/06/2012 7:48 PM, Maurizio Cimadamore wrote:
On 14/06/12 13:14, David Holmes wrote:
On 14/06/2012 10:10 PM, Magnus Ihse Bursie wrote:
On 2012-06-14 13:52, David Holmes wrote:
As I understand this, sizers is to X11 Java code what the
UnixConstants pr
On 19/06/2012 7:48 PM, Maurizio Cimadamore wrote:
On 14/06/12 13:14, David Holmes wrote:
On 14/06/2012 10:10 PM, Magnus Ihse Bursie wrote:
On 2012-06-14 13:52, David Holmes wrote:
As I understand this, sizers is to X11 Java code what the
UnixConstants program is to the filesystem code. It has
On 14/06/12 13:14, David Holmes wrote:
On 14/06/2012 10:10 PM, Magnus Ihse Bursie wrote:
On 2012-06-14 13:52, David Holmes wrote:
As I understand this, sizers is to X11 Java code what the
UnixConstants program is to the filesystem code. It has to determine
various sizes of native data structure
17 matches
Mail list logo
