Re: Client VM for 64 bit linux

2012-12-27 Thread Helbrass
On Fri, 28 Dec 2012 01:04:05 +0200, David Holmes wrote: On 28/12/2012 6:26 AM, Helbrass wrote: Hi Phil, First of all, you're always building both server and client for 32 bit, what's the big deal with always building it for 64 bit? Time and space. But the main point here is that 64-bit c

Re: Client VM for 64 bit linux

2012-12-27 Thread David Holmes
On 28/12/2012 6:26 AM, Helbrass wrote: Hi Phil, First of all, you're always building both server and client for 32 bit, what's the big deal with always building it for 64 bit? Time and space. But the main point here is that 64-bit client VM is not a supported VM configuration. As discussed i

Re: Review Request: 8005549: build-infra: Merge NewMakefile.gmk and common/makefiles/Makefile

2012-12-27 Thread Tim Bell
Looks good. Tim On 12/27/12 12:50, Erik Joelsson wrote: Merged NewMakefile.gmk and common/makefiles/Makefile and removed redundant functionality. * The bridgebuild and jprt specific stuff was moved to a separate file common/makefiles/Jprt.gmk. * Default targets changed a bit. Default is basi

Re: Review Request: 8005549: build-infra: Merge NewMakefile.gmk and common/makefiles/Makefile

2012-12-27 Thread Kelly O'Hair
Looks good to me. -kto On Dec 27, 2012, at 12:50 PM, Erik Joelsson wrote: > Merged NewMakefile.gmk and common/makefiles/Makefile and removed redundant > functionality. > > * The bridgebuild and jprt specific stuff was moved to a separate file > common/makefiles/Jprt.gmk. > * Default target

hg: jdk8/build/jdk: 8005540: build-infra: Improve incremental build speed on windows by caching find results

2012-12-27 Thread erik . joelsson
Changeset: e91caf05f441 Author:erikj Date: 2012-12-27 20:18 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e91caf05f441 8005540: build-infra: Improve incremental build speed on windows by caching find results Reviewed-by: ohair ! makefiles/BuildJdk.gmk ! makefiles/Compil

hg: jdk8/build: 2 new changesets

2012-12-27 Thread erik . joelsson
Changeset: 77f062a41850 Author:erikj Date: 2012-12-27 20:15 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/77f062a41850 8001942: build-infra: General permission problems on Windows/cygwin Summary: Added sanity check for file permissions in configure Reviewed-by: tbell, ohair

Re: Client VM for 64 bit linux

2012-12-27 Thread Phil Race
On 12/27/2012 12:26 PM, Helbrass wrote: Hi Phil, First of all, you're always building both server and client for 32 bit, what's the big deal with always building it for 64 bit? Its a huge deal. You are not just flipping an unimportant build switch. You are adding a significant new feature to

Review Request: 8005549: build-infra: Merge NewMakefile.gmk and common/makefiles/Makefile

2012-12-27 Thread Erik Joelsson
Merged NewMakefile.gmk and common/makefiles/Makefile and removed redundant functionality. * The bridgebuild and jprt specific stuff was moved to a separate file common/makefiles/Jprt.gmk. * Default targets changed a bit. Default is basically what it was "jdk". There is a new "all" target which

Re: Client VM for 64 bit linux

2012-12-27 Thread Kelly O'Hair
Sorry, I have to agree with Phil here. It has been my experience that using a server VM might add a few seconds to startup and will use more memory, but I found that the NetBeans GUI interactions were zippier once the VM warmed up. Since NetBeans startups are fairly rare, it's not a good determi

Re: Review Request: 8005548: build-infra: Fix docs target on windows

2012-12-27 Thread Kelly O'Hair
Looks fine. Just for the historical record As far as I know, the Release Engineering team has only built javadocs on select platforms I think by using NO_DOCS=true to turn it off in most cases. And Windows wasn't one of the ones that did javadocs because for the longest time, the javadoc Mak

Re: Client VM for 64 bit linux

2012-12-27 Thread Helbrass
Hi Phil, First of all, you're always building both server and client for 32 bit, what's the big deal with always building it for 64 bit? Second, I'm agree that in most cases server VM may be better, but in my case I'm programmer, not server administrator, and all day long I'm using NetBea

Re: Review Request: 8005548: build-infra: Fix docs target on windows

2012-12-27 Thread Tim Bell
Erik: Small fix for making docs target work on windows. Corrects path separator. http://cr.openjdk.java.net/~erikj/8005548/webrev.01/ Looks good! Tim

Review Request: 8005548: build-infra: Fix docs target on windows

2012-12-27 Thread Erik Joelsson
Small fix for making docs target work on windows. Corrects path separator. http://cr.openjdk.java.net/~erikj/8005548/webrev.01/

Re: Client VM for 64 bit linux

2012-12-27 Thread Phil Race
I am fairly sure we do not want the build system to spit out a 64 bit client VM by default. My recollection from many years ago is that the VM team and performance team determined that the 64 bit server VM was as good as, or better than the 64 bit client VM on all the metrics that mattered and t

Re: Review Request: 8005540: build-infra: Improve incremental build speed on windows by caching find results

2012-12-27 Thread Kelly O'Hair
A little hard to review, but in general I really like the idea. I had experimented with files containing the 'find' output in the past, but never thought about using make variables. Very clever. The variables and values are in the make process itself, easier to keep up-to-date and trust, faster

Re: JDK7 build on mac os fails: JavaNativeFoundation.h: No such file

2012-12-27 Thread mikhail cherkasov
David, I use OSX 10.7.5. I installedX11 package. But the build failed with the same error again: http://dl.dropbox.com/u/23235695/build2.log - this log for jdk8 without closed part, but I also tried to build jdk7 and received the same error too. 27.12.

Re: Review Request: 8001942: build-infra: General permission problems on Windows/cygwin

2012-12-27 Thread Kelly O'Hair
Looks fine. But my m4 eyes are not great. :^( -kto On Dec 27, 2012, at 6:03 AM, Erik Joelsson wrote: > Small change, adding a configure check making sure the source has read > permission. If not, an error message explaining the likely cause in cygwin is > printed. > > http://cr.openjdk.java.

Review Request: 8005540: build-infra: Improve incremental build speed on windows by caching find results

2012-12-27 Thread Erik Joelsson
A few weeks back, I did some experiments with find on windows/cygwin. File caching is not nearly as efficient as on linux, combined with slow forks this makes repeated runs of find over the same set of files very inefficient. This pattern is used a lot in the new makefiles for finding sources.

Re: Review Request: 8001942: build-infra: General permission problems on Windows/cygwin

2012-12-27 Thread Tim Bell
Erik: Small change, adding a configure check making sure the source has read permission. If not, an error message explaining the likely cause in cygwin is printed. http://cr.openjdk.java.net/~erikj/8001942/webrev.01/ /Erik Looks good. Thank you for this - a number of users on this list ha

Re: JDK7 build on mac os fails: JavaNativeFoundation.h: No such file

2012-12-27 Thread David Chase
On 2012-12-27, at 7:41 AM, mikhail cherkasov wrote: > I have installed all software from the following list: > http://wiki.se.oracle.com/display/JPG/Build+JDK+on+Mac+OS+X#BuildJDKonMacOSX-System > I not sure about X11 -does it require separate installation? Yes, X11 requires separate installat

Review Request: 8001942: build-infra: General permission problems on Windows/cygwin

2012-12-27 Thread Erik Joelsson
Small change, adding a configure check making sure the source has read permission. If not, an error message explaining the likely cause in cygwin is printed. http://cr.openjdk.java.net/~erikj/8001942/webrev.01/ /Erik

Re: JDK7 build on mac os fails: JavaNativeFoundation.h: No such file

2012-12-27 Thread mikhail cherkasov
I have installed all software from the following list: http://wiki.se.oracle.com/display/JPG/Build+JDK+on+Mac+OS+X#BuildJDKonMacOSX-System I not sure about X11 -does it require separate installation? link to log: http://dl.dropbox.com/u/23235695/build_all.log 27.12.2012 16:27, David Holmes пишет

Re: JDK7 build on mac os fails: JavaNativeFoundation.h: No such file

2012-12-27 Thread David Holmes
The mailing lists strip most attachments. Your log file never made it. Are you missing some OSX developer software? David On 27/12/2012 10:02 PM, mikhail cherkasov wrote: Sending mail again, because I wasn't subscriber and email was holden for moderation. I attached builds log file. 27.12.201

Re: Fwd: PPC Linux 64 needs -fsigned-char option for gcc

2012-12-27 Thread David Holmes
On 27/12/2012 8:49 PM, Erik Joelsson wrote: This does indeed seem to be missing in build-infra. The correct place to add it would be in common/autoconf/toolchain.m4. If you search for arm or ppc you will find a big case statement where compiler and arch specific flags are setup. Erik: I don't c

Re: Client VM for 64 bit linux

2012-12-27 Thread David Holmes
On 27/12/2012 7:14 PM, Aekold Helbrass wrote: Hi David, Thanx for your answer. Yes, patches are really small, I hope they will not be crippled by email renderer. See patches below. And about new build system, can you please link me where can I read more about it? It is the build-infra project

Re: JDK7 build on mac os fails: JavaNativeFoundation.h: No such file

2012-12-27 Thread mikhail cherkasov
Resent builds log file again for hotspot-dev list. 27.12.2012 15:08, Erik Joelsson пишет: Adding hotspot-dev to cc since it's failing in hotspot. On 2012-12-27 12:00, mikhail cherkasov wrote: I attached builds log file. 27.12.2012 14:24, Erik Joelsson пишет: Hello, Which set of repositories

Re: JDK7 build on mac os fails: JavaNativeFoundation.h: No such file

2012-12-27 Thread mikhail cherkasov
I attached the builds log file. 27.12.2012 14:24, Erik Joelsson пишет: Hello, Which set of repositories did you clone? /Erik On 2012-12-26 14:16, mikhail cherkasov wrote: Hi All, I have the following error during build: Linking vm... /Users/mcherkasov/jdk/7ws/sources/openjdk7/hotspot/agent

Re: JDK7 build on mac os fails: JavaNativeFoundation.h: No such file

2012-12-27 Thread Erik Joelsson
Adding hotspot-dev to cc since it's failing in hotspot. On 2012-12-27 12:00, mikhail cherkasov wrote: I attached builds log file. 27.12.2012 14:24, Erik Joelsson пишет: Hello, Which set of repositories did you clone? /Erik On 2012-12-26 14:16, mikhail cherkasov wrote: Hi All, I have the f

Re: Fwd: PPC Linux 64 needs -fsigned-char option for gcc

2012-12-27 Thread Erik Joelsson
This does indeed seem to be missing in build-infra. The correct place to add it would be in common/autoconf/toolchain.m4. If you search for arm or ppc you will find a big case statement where compiler and arch specific flags are setup. /Erik On 2012-12-24 04:59, Sean Chou wrote: Hello, Move

Re: JDK7 build on mac os fails: JavaNativeFoundation.h: No such file

2012-12-27 Thread mikhail cherkasov
I tried the following repos: http://hg.openjdk.java.net/jdk7u/jdk7u and http://hg.openjdk.java.net/jdk7u/jdk7u-dev I used this instruction:http://wiki.se.oracle.com/display/JPGSE/JDK7+Mac+OS+X+build 27.12.2012 14:24, Erik Joelsson

Re: Debug Info in class files

2012-12-27 Thread Ben Evans
Hi Miten, You may also want to think about joining the Adopt OpenJDK project - a number of our members may well be interested in use cases like this. Thanks, Ben On 26 Dec 2012 12:13, "miten mehta" wrote: > Hi, > > I was using eclipse ide to remote debug tomcat web app which used oracle > jdk

Re: JDK7 build on mac os fails: JavaNativeFoundation.h: No such file

2012-12-27 Thread Erik Joelsson
Hello, Which set of repositories did you clone? /Erik On 2012-12-26 14:16, mikhail cherkasov wrote: Hi All, I have the following error during build: Linking vm... /Users/mcherkasov/jdk/7ws/sources/openjdk7/hotspot/agent/src/os/bsd/MacosxDebuggerLocal.m:27:54: error: JavaNativeFoundation/Jav

Re: Debug Info in class files

2012-12-27 Thread Erik Joelsson
Most of the classes in the jdk will not be compiled with -g option by default. If you build openjdk yourself, you can force debug info in classes by setting DEBUG_CLASSFILES=true when running make. /Erik On 2012-12-26 13:12, miten mehta wrote: Hi, I was using eclipse ide to remote debug tomc

Re: Client VM for 64 bit linux

2012-12-27 Thread Aekold Helbrass
Hi David, Thanx for your answer. Yes, patches are really small, I hope they will not be crippled by email renderer. See patches below. And about new build system, can you please link me where can I read more about it? ##