Re: RFR: 8010465: Can't enable sjavac when building in jprt.

2013-04-08 Thread Anthony Petrov
Good to know this is unrelated to this fix. Thanks. -- best regards, Anthony On 4/8/2013 17:21, Erik Joelsson wrote: On 2013-04-08 15:17, Anthony Petrov wrote: Thanks for clarifying that. Makes sense to me. The fix looks good to me, btw, although I'm not a build expert. Also, could you cla

Re: No compiler1 product1 for ARCH_DATA_MODEL=64?

2013-04-08 Thread Isml
OK, I got it. Thanks everyone! -- Original -- From: "David Holmes"; Date: Tue, Apr 9, 2013 11:07 AM To: "Isml"; Cc: "build-dev"; Subject: Re: No compiler1 product1 for ARCH_DATA_MODEL=64? 64-bit client VM is not supported. You can probably make it work

Re: PING: [PATCH] Enable debug info on all libraries for OpenJDK builds

2013-04-08 Thread David Holmes
On 9/04/2013 11:06 AM, Martin Buchholz wrote: On Mon, Apr 8, 2013 at 5:51 PM, David Holmes mailto:david.hol...@oracle.com>> wrote: On 9/04/2013 2:59 AM, Andrew Hughes wrote: Well, if I push it, it will be, no? Testing comes before pushing - thank you. This issue keeps coming

Re: No compiler1 product1 for ARCH_DATA_MODEL=64?

2013-04-08 Thread Tim Bell
On 04/08/13 19:50, Isml wrote: Hi everyone,I am trying to compile a x64 version openjdk on Ubuntu 12.10 x64. I use the following commands: export LP64=1 make product1(I want to compile the client jvm) but receive the following errors: No compiler1 product1 for AR

Re: No compiler1 product1 for ARCH_DATA_MODEL=64?

2013-04-08 Thread David Holmes
64-bit client VM is not supported. You can probably make it work with a bit of makefile hackery, but it is not supported. Search the hotspot mailing list archives for some discussion on this. David On 9/04/2013 12:50 PM, Isml wrote: Hi everyone,I am trying to compile a x64 version openj

No compiler1 product1 for ARCH_DATA_MODEL=64?

2013-04-08 Thread Isml
Hi everyone,I am trying to compile a x64 version openjdk on Ubuntu 12.10 x64. I use the following commands: export LP64=1 make product1(I want to compile the client jvm) but receive the following errors: No compiler1 product1 for ARCH_DATA_MODEL=64 But I can succe

Re: RFR (XXS): 8011678: test/Makefile should pick up JT_HOME environment variable

2013-04-08 Thread Christian Thalinger
After checking the OpenJDK census it seems that only Vladimir is an official reviewer. But that's just the official part. Thanks for the reviews! -- Chris On Apr 6, 2013, at 11:58 PM, Mike Duigou wrote: > This looks good to me. I will make the same change in the jdk/test/makefile > for when

Re: PING: [PATCH] Enable debug info on all libraries for OpenJDK builds

2013-04-08 Thread Martin Buchholz
On Mon, Apr 8, 2013 at 5:51 PM, David Holmes wrote: > On 9/04/2013 2:59 AM, Andrew Hughes wrote: > >> >> Well, if I push it, it will be, no? >> > > Testing comes before pushing - thank you. > This issue keeps coming up. Non-Oracle committers have no access to the Oracle automated testing submiss

Re: PING: [PATCH] Enable debug info on all libraries for OpenJDK builds

2013-04-08 Thread David Holmes
On 9/04/2013 2:59 AM, Andrew Hughes wrote: - Original Message - Hi Andrew, On 5/04/2013 8:39 PM, Andrew Hughes wrote: Still need a reviewer for this. This looks okay as a first step. Second step would be to connect DEBUG_ALL_BINARIES to a configure option. Agreed. Something that u

Re: Support building zero with the new build

2013-04-08 Thread Andrew Hughes
- Original Message - > On 04/08/2013 03:26 PM, Andrew Hughes wrote: > >> I have pushed the changes: > >> http://hg.openjdk.java.net/jdk8/build/rev/653ff6bcf0b1 > >> http://hg.openjdk.java.net/jdk8/build/jdk/rev/fddd158b872a > >> > >> Thank you everyone for all (very patient) reviews and sug

Re: Support building zero with the new build

2013-04-08 Thread Omair Majid
On 04/08/2013 03:26 PM, Andrew Hughes wrote: >> I have pushed the changes: >> http://hg.openjdk.java.net/jdk8/build/rev/653ff6bcf0b1 >> http://hg.openjdk.java.net/jdk8/build/jdk/rev/fddd158b872a >> >> Thank you everyone for all (very patient) reviews and suggestions! >> > > I'm quite surprised to

Re: Support building zero with the new build

2013-04-08 Thread Andrew Hughes
- Original Message - > On 04/03/2013 11:17 AM, Erik Joelsson wrote: > > On 2013-04-03 16:54, Andrew Hughes wrote: > >> Do we have a bug ID? Assuming I don't find any issues, we should be > >> good to go. > > JDK-8011388: Support building zero and zeroshark with the new build > > > > /Er

Re: Support building zero with the new build

2013-04-08 Thread Omair Majid
On 04/03/2013 11:17 AM, Erik Joelsson wrote: > On 2013-04-03 16:54, Andrew Hughes wrote: >> Do we have a bug ID? Assuming I don't find any issues, we should be >> good to go. > JDK-8011388: Support building zero and zeroshark with the new build > > /Erik I have pushed the changes: http://hg.open

hg: jdk8/build: 8011388: Support building zero and zeroshark with the new build

2013-04-08 Thread omajid
Changeset: 653ff6bcf0b1 Author:omajid Date: 2013-04-08 14:07 -0400 URL: http://hg.openjdk.java.net/jdk8/build/rev/653ff6bcf0b1 8011388: Support building zero and zeroshark with the new build Reviewed-by: andrew, dholmes, erikj Contributed-by: Omair Majid , Roman Kennke ! common/a

hg: jdk8/build/jdk: 8011388: Support building zero and zeroshark with the new build

2013-04-08 Thread omajid
Changeset: fddd158b872a Author:omajid Date: 2013-04-08 14:09 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/fddd158b872a 8011388: Support building zero and zeroshark with the new build Reviewed-by: andrew, dholmes, erikj Contributed-by: Omair Majid , Roman Kennke ! make

Re: A couple of questions about the new build system

2013-04-08 Thread Phil Race
FWIW, I was on Solaris 10 SPARC. I sent you a separate email off-list since what I saw is that the case you described does actually work but one that is different - in closed sources - didn't work. -phil. On 4/8/2013 9:00 AM, Kelly O'Hair wrote: I think it's /showIncludes ??? http://msdn.mic

Re: [OpenJDK 2D-Dev] Fwd: requesting bug id for removing redundant fontconfig files

2013-04-08 Thread Andrew Hughes
- Original Message - > On 04/08/2013 11:09 AM, Erik Joelsson wrote: > > From a build point of view I think the patch looks ok. I can't comment on > > if it's safe to remove > > the fontconfig files though. I've created a bug: > > > > 8011693: Remove redundant fontconfig files > > > > Tha

Re: PING: [PATCH] Enable debug info on all libraries for OpenJDK builds

2013-04-08 Thread Andrew Hughes
- Original Message - > Hi Andrew, > > On 5/04/2013 8:39 PM, Andrew Hughes wrote: > > Still need a reviewer for this. > > This looks okay as a first step. Second step would be to connect > DEBUG_ALL_BINARIES to a configure option. Agreed. Something that unifies both the JDK and HotSpot a

Re: RFR: 8006288: build-infra: Use solaris nm and not gnm on solaris

2013-04-08 Thread Tim Bell
Hi Erik: Looks good... approved! Tim Small patch changing configure to only look for nm and never gnm on Solaris. Gnm is still needed in the compare script and is assigned to a new variable GNM. http://cr.openjdk.java.net/~erikj/8006288/webrev.01/ /Erik

Re: RFR: 8010465: Can't enable sjavac when building in jprt.

2013-04-08 Thread Tim Bell
Hi Erik: This looks good - approved. Sorry for the delay. Tim Reminder that I would like this reviewed. /Erik On 2013-03-21 12:49, Erik Joelsson wrote: This patch makes it possible to enable sjavac in jprt runs. This is achieved by adding -buildenv ENABLE_SJAVAC=true to the jprt command

Re: RFR: 8010465: Can't enable sjavac when building in jprt.

2013-04-08 Thread Kelly O'Hair
Looks ok with me. ;^) -kto On 4/8/13 2:44 AM, "Erik Joelsson" wrote: >Reminder that I would like this reviewed. > >/Erik > >On 2013-03-21 12:49, Erik Joelsson wrote: >> This patch makes it possible to enable sjavac in jprt runs. This is >> achieved by adding -buildenv ENABLE_SJAVAC=true to t

Re: A couple of questions about the new build system

2013-04-08 Thread Kelly O'Hair
I think it's /showIncludes ??? http://msdn.microsoft.com/en-us/library/hdkef6tk%28v=vs.100%29.aspx -kto On 4/8/13 1:16 AM, "Erik Joelsson" wrote: >I just realized you are probably running on windows and unfortunately >this currently doesn't work there. We use the -M flag for gcc which >outputs

Re: RFR: 8010465: Can't enable sjavac when building in jprt.

2013-04-08 Thread Alexander Scherbatiy
On 4/8/2013 5:21 PM, Erik Joelsson wrote: On 2013-04-08 15:17, Anthony Petrov wrote: Thanks for clarifying that. Makes sense to me. The fix looks good to me, btw, although I'm not a build expert. Also, could you clarify why do Windows builds fail with sjavac? Is this a known bug in sjavac o

Re: RFR: 8010465: Can't enable sjavac when building in jprt.

2013-04-08 Thread Erik Joelsson
On 2013-04-08 15:17, Anthony Petrov wrote: Thanks for clarifying that. Makes sense to me. The fix looks good to me, btw, although I'm not a build expert. Also, could you clarify why do Windows builds fail with sjavac? Is this a known bug in sjavac or the build system? It looks to me like

Re: RFR: 8010465: Can't enable sjavac when building in jprt.

2013-04-08 Thread Anthony Petrov
Thanks for clarifying that. Makes sense to me. The fix looks good to me, btw, although I'm not a build expert. Also, could you clarify why do Windows builds fail with sjavac? Is this a known bug in sjavac or the build system? -- best regards, Anthony On 04/08/13 17:03, Erik Joelsson wrote:

Re: RFR: 8010465: Can't enable sjavac when building in jprt.

2013-04-08 Thread Erik Joelsson
Sjavac also enables parallel execution of java compilation, speeding up full builds as well. But even if it didn't, being able to verify that sjavac builds work in jprt will be a must if we are to enable it by default. /Erik On 2013-04-08 14:56, Anthony Petrov wrote: Just curious: sjavac is su

Re: RFR: 8010465: Can't enable sjavac when building in jprt.

2013-04-08 Thread Anthony Petrov
Just curious: sjavac is supposed to address the issue with slow incremental builds. JPRT builds are full builds usually. What is the benefit of using sjavac for full builds? -- best regards, Anthony On 04/08/13 13:44, Erik Joelsson wrote: Reminder that I would like this reviewed. /Erik On 2

RFR: 8006288: build-infra: Use solaris nm and not gnm on solaris

2013-04-08 Thread Erik Joelsson
Small patch changing configure to only look for nm and never gnm on Solaris. Gnm is still needed in the compare script and is assigned to a new variable GNM. http://cr.openjdk.java.net/~erikj/8006288/webrev.01/ /Erik

Re: [OpenJDK 2D-Dev] Fwd: requesting bug id for removing redundant fontconfig files

2013-04-08 Thread Jiri Vanek
On 04/08/2013 11:09 AM, Erik Joelsson wrote: From a build point of view I think the patch looks ok. I can't comment on if it's safe to remove the fontconfig files though. I've created a bug: 8011693: Remove redundant fontconfig files Thank you very much. I will continue review on 2d-dev. J

Re: PING: [PATCH] Enable debug info on all libraries for OpenJDK builds

2013-04-08 Thread Erik Joelsson
On 2013-04-05 15:50, Erik Joelsson wrote: On 2013-04-05 14:54, David Holmes wrote: Hi Andrew, On 5/04/2013 8:39 PM, Andrew Hughes wrote: Still need a reviewer for this. This looks okay as a first step. Second step would be to connect DEBUG_ALL_BINARIES to a configure option. This need

Re: RFR: 8010465: Can't enable sjavac when building in jprt.

2013-04-08 Thread Erik Joelsson
Reminder that I would like this reviewed. /Erik On 2013-03-21 12:49, Erik Joelsson wrote: This patch makes it possible to enable sjavac in jprt runs. This is achieved by adding -buildenv ENABLE_SJAVAC=true to the jprt command line. http://cr.openjdk.java.net/~erikj/8010465/webrev.root.01/ Do

Re: [OpenJDK 2D-Dev] Fwd: requesting bug id for removing redundant fontconfig files

2013-04-08 Thread Erik Joelsson
From a build point of view I think the patch looks ok. I can't comment on if it's safe to remove the fontconfig files though. I've created a bug: 8011693: Remove redundant fontconfig files /Erik On 2013-04-08 10:00, Jiri Vanek wrote: On 04/03/2013 04:42 PM, Andrew Hughes wrote: [Forwarding t

Re: A couple of questions about the new build system

2013-04-08 Thread Erik Joelsson
I just realized you are probably running on windows and unfortunately this currently doesn't work there. We use the -M flag for gcc which outputs make dependency files. The visual studio compiler doesn't have this feature. There are ways this can be worked around. I've created 8011687 to track

Re: [OpenJDK 2D-Dev] Fwd: requesting bug id for removing redundant fontconfig files

2013-04-08 Thread Jiri Vanek
On 04/03/2013 04:42 PM, Andrew Hughes wrote: [Forwarding to 2d-dev] - Forwarded Message - Hi! FontConfig files are no longer necessary for jdk7 and 8. I have patch for their removal (http://jvanek.fedorapeople.org/oracle/jdk8/webrevs/removedFontConfigFiles/) and I have built and teste

Re: RFR (XXS): 8011678: test/Makefile should pick up JT_HOME environment variable

2013-04-08 Thread Mikael Gerdin
Christian, On 04/07/2013 06:39 AM, Christian Thalinger wrote: http://cr.openjdk.java.net/~twisti/8011678 Looks good to me. /Mikael 8011678: test/Makefile should pick up JT_HOME environment variable Reviewed-by: The JT_HOME can only be overridden by a make argument or JPRT_JTREG_HOME. Pi