----- Original Message ----- > On 04/03/2013 11:17 AM, Erik Joelsson wrote: > > On 2013-04-03 16:54, Andrew Hughes wrote: > >> Do we have a bug ID? Assuming I don't find any issues, we should be > >> good to go. > > JDK-8011388: Support building zero and zeroshark with the new build > > > > /Erik > > I have pushed the changes: > http://hg.openjdk.java.net/jdk8/build/rev/653ff6bcf0b1 > http://hg.openjdk.java.net/jdk8/build/jdk/rev/fddd158b872a > > Thank you everyone for all (very patient) reviews and suggestions! >
I'm quite surprised to see this. I was about to give feedback on my attempt to build with this patch (fortunately, it passed) and yet it's already been committed. Also, according to http://openjdk.java.net/census#erikj, Erik isn't a reviewer and I'm not sure there's a final ok from David either (feel free to drop me a link if there is). > Thanks, > Omair > > -- > PGP Key: 66484681 (http://pgp.mit.edu/) > Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
