----- Original Message ----- > On 04/08/2013 03:26 PM, Andrew Hughes wrote: > >> I have pushed the changes: > >> http://hg.openjdk.java.net/jdk8/build/rev/653ff6bcf0b1 > >> http://hg.openjdk.java.net/jdk8/build/jdk/rev/fddd158b872a > >> > >> Thank you everyone for all (very patient) reviews and suggestions! > >> > > > > I'm quite surprised to see this. I was about to give feedback on my > > attempt > > to build with this patch (fortunately, it passed) and yet it's already been > > committed. > > I thought I heard you mention on IRC that this built without problems. I > am sorry if I misunderstood that or mis-remember. Is there anything I > can do to address this (now or in the future)? >
I did, but that's not on record. In future, it'd be worth pinging me to double-check. > > Also, according to http://openjdk.java.net/census#erikj, Erik > > isn't a reviewer and I'm not sure there's a final ok from David either > > (feel free to drop me a link if there is). > > The result of the vote was announced, though I am also surprised that > the census has not been updated: > > http://mail.openjdk.java.net/pipermail/jdk8-dev/2013-April/002266.html > I wasn't even aware there was a vote. If I was, I'd have voted in favour. > Thanks, > Omair > > -- > PGP Key: 66484681 (http://pgp.mit.edu/) > Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
