Re: RFR (S): JDK-8142909 Integration of minor fixes from the build-infra project

2015-11-16 Thread David Holmes
On 16/11/2015 10:14 PM, Erik Joelsson wrote: On 2015-11-16 12:11, David Holmes wrote: On 16/11/2015 6:22 PM, Erik Joelsson wrote: On 2015-11-16 03:10, David Holmes wrote: Hi Magnus, On 13/11/2015 9:33 PM, Magnus Ihse Bursie wrote: On 2015-11-13 09:13, Erik Joelsson wrote: Hello, make/bsd/m

Re: RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

2015-11-16 Thread Yasumasa Suenaga
Thank you for your comment! I've uploaded new webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8036003/webrev.01/ Could you review it again? Thanks, Yasumasa On 2015/11/17 0:51, Andrew Hughes wrote: - Original Message - Hello, I think this looks mostly OK, but I'm pretty sure

Re: RFR (S): JDK-8142909 Integration of minor fixes from the build-infra project

2015-11-16 Thread Erik Joelsson
On 2015-11-16 12:11, David Holmes wrote: On 16/11/2015 6:22 PM, Erik Joelsson wrote: On 2015-11-16 03:10, David Holmes wrote: Hi Magnus, On 13/11/2015 9:33 PM, Magnus Ihse Bursie wrote: On 2015-11-13 09:13, Erik Joelsson wrote: Hello, make/bsd/makefiles/amd64.make: make/bsd/makefiles/gc

Re: RFR (S): JDK-8142909 Integration of minor fixes from the build-infra project

2015-11-16 Thread David Holmes
On 16/11/2015 6:22 PM, Erik Joelsson wrote: On 2015-11-16 03:10, David Holmes wrote: Hi Magnus, On 13/11/2015 9:33 PM, Magnus Ihse Bursie wrote: On 2015-11-13 09:13, Erik Joelsson wrote: Hello, make/bsd/makefiles/amd64.make: make/bsd/makefiles/gcc.make: Perhaps the order of "$(OPT_CFLAGS/N

Re: RFR: JDK-8143036: Make install target does not depend on images

2015-11-16 Thread Alan Bateman
On 16/11/2015 09:17, Erik Joelsson wrote: Make install target should depend on images. Somehow this dependency got lost in JDK-8054834. Bug: https://bugs.openjdk.java.net/browse/JDK-8143036 Patch: diff -r 106c06398f7a make/Main.gmk --- a/make/Main.gmk +++ b/make/Main.gmk @@ -462,6 +462,8 @@

Re: RFR (S): JDK-8142909 Integration of minor fixes from the build-infra project

2015-11-16 Thread Erik Joelsson
On 2015-11-16 03:10, David Holmes wrote: Hi Magnus, On 13/11/2015 9:33 PM, Magnus Ihse Bursie wrote: On 2015-11-13 09:13, Erik Joelsson wrote: Hello, make/bsd/makefiles/amd64.make: make/bsd/makefiles/gcc.make: Perhaps the order of "$(OPT_CFLAGS/NOOPT) $(OPT_CFLAGS/$(BUILDARCH))" should be r

Re: RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

2015-11-16 Thread Yasumasa Suenaga
Hi Erik, > One thing, could you name the variable DEBUG_SYMBOLS, with the S at the > end so that it matches the configure option? Currently, ENABLE_DEBUG_SYMBOLS (--enable-debug-symbols) is available. So I add DEBUG_SYMBOL to avoided confuse. I think that it is very trivial change... Thanks,

Re: RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

2015-11-16 Thread Erik Joelsson
Hello, I think this looks mostly OK, but I'm pretty sure Magnus will want to comment. I'm afraid he likely won't be able to until next week however. One thing, could you name the variable DEBUG_SYMBOLS, with the S at the end so that it matches the configure option? /Erik On 2015-11-16 10:38, Ya

RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

2015-11-16 Thread Yasumasa Suenaga
Hi all, I would like to propose JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped] . I had posted this enhancement which provides new make variable [1]. But it does not fit current jdk 9. So I propose it again as new configure option. I'm sure that this enhancement helps Lin

RFR: JDK-8143036: Make install target does not depend on images

2015-11-16 Thread Erik Joelsson
Make install target should depend on images. Somehow this dependency got lost in JDK-8054834. Bug: https://bugs.openjdk.java.net/browse/JDK-8143036 Patch: diff -r 106c06398f7a make/Main.gmk --- a/make/Main.gmk +++ b/make/Main.gmk @@ -462,6 +462,8 @@ test-image-jdk-jtreg-native: build-test-jd

Re: RFR: JDK-8142907 Integration of minor fixes from the build-infra project

2015-11-16 Thread Erik Joelsson
On 2015-11-16 05:33, David Holmes wrote: Hi Magnus, I had a flick through most of the files. Overall seems okay but I have a few queries below. On 13/11/2015 12:43 PM, Magnus Ihse Bursie wrote: The build-infra project has collected a number of minor fixes and changes during the new hotspot