Build changes look good.
/Erik
On 2018-05-25 14:26, Mikhailo Seledtsov wrote:
Please review this change that will open source VM Testbase Runtime
tests. This group includes tests covering a variety of runtime
functional areas: arraycopy, barrier, jni, threads, vtable and contented.
These te
Please review this change that will open source VM Testbase Runtime
tests. This group includes tests covering a variety of runtime
functional areas: arraycopy, barrier, jni, threads, vtable and contented.
These tests have been used internally for a while, and are now being
open sourced. Since
Looks good to me.
-phil.
On 05/25/2018 10:59 AM, Erik Joelsson wrote:
Hello,
Valid point. Reordered the versions search order.
I also noticed that there is a new build failure caused by a warning
in a test. This patch disables the warning. There is a bug filed for
fixing it already:
http
Hello,
Valid point. Reordered the versions search order.
I also noticed that there is a new build failure caused by a warning in
a test. This patch disables the warning. There is a bug filed for fixing
it already:
https://bugs.openjdk.java.net/browse/JDK-8203802
New webrev: http://cr.openjd
On 2018-05-25 06:52, Tim Bell wrote:
Magnus-
On 05/25/18 04:23, Claes Redestad wrote:
On 2018-05-25 12:06, Magnus Ihse Bursie wrote:
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8200867-remove-jdk9-references/webrev.01
Looks good to me!
/Claes
Looks good!
doc/building.md
doc/buildi
Looks good.
/Erik
On 2018-05-25 01:30, Magnus Ihse Bursie wrote:
For some reason, the AIX version of jsig.c was not removed in
JDK-8200298, as was intended and reviewed in the webrev. (hg hiccup
perhaps, or PEBKAC from Yours truly).
Bug: https://bugs.openjdk.java.net/browse/JDK-8203822
Pat
On 2018-05-25 01:21, Magnus Ihse Bursie wrote:
On 2018-05-16 16:18, Magnus Ihse Bursie wrote:
16 maj 2018 kl. 01:39 skrev Erik Joelsson:
Hello,
In GensrcJfr, JFR_TOOLS_OUTPUTDIR is defined twice.
Oops, will fix.
Other build tools are in make/{jdk,hotspot}/src/classes. Do you think we shoul
Magnus-
On 05/25/18 04:23, Claes Redestad wrote:
On 2018-05-25 12:06, Magnus Ihse Bursie wrote:
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8200867-remove-jdk9-references/webrev.01
Looks good to me!
/Claes
doc/building.md
doc/building.html
These files also have changes to minimum gcc ve
On 2018-05-25 12:06, Magnus Ihse Bursie wrote:
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8200867-remove-jdk9-references/webrev.01
Looks good to me!
/Claes
There were some lingering references to jdk 9 in the build
documentation. Remove this (and do not replace with new version numbers,
due to our accelerated versioning scheme).
From the bug report:
$ bash ./configure --help | head -1
`configure' configures OpenJDK jdk9 to adapt to many kinds of
Thank you Magnus and Kevin for your quick reviews.
Regards,
Alexey
On 25/05/2018 09:49, Kevin Walls wrote:
Thanks Alexey - my build with this change completed OK too and the
MSVCP dependency in awt.dll has gone, great!
Thanks
Kevin
On 25/05/2018 09:27, Alexey Ivanov wrote:
Hi,
Could you
Thanks Alexey - my build with this change completed OK too and the MSVCP
dependency in awt.dll has gone, great!
Thanks
Kevin
On 25/05/2018 09:27, Alexey Ivanov wrote:
Hi,
Could you please review the following fix for 8u-dev?
jbs: https://bugs.openjdk.java.net/browse/JDK-8203790
webrev: ht
On 2018-05-25 10:27, Alexey Ivanov wrote:
Hi,
Could you please review the following fix for 8u-dev?
jbs: https://bugs.openjdk.java.net/browse/JDK-8203790
webrev: http://cr.openjdk.java.net/~aivanov/8203790/jdk8/webrev.0/
There's a missing ‘C‘ in the name, and the compiler flags were not
added
For some reason, the AIX version of jsig.c was not removed in
JDK-8200298, as was intended and reviewed in the webrev. (hg hiccup
perhaps, or PEBKAC from Yours truly).
Bug: https://bugs.openjdk.java.net/browse/JDK-8203822
Patch inline:
diff --git a/src/java.base/aix/native/libjsig/jsig.c
b/sr
Hi,
Could you please review the following fix for 8u-dev?
jbs: https://bugs.openjdk.java.net/browse/JDK-8203790
webrev: http://cr.openjdk.java.net/~aivanov/8203790/jdk8/webrev.0/
There's a missing ‘C‘ in the name, and the compiler flags were not added
which led to the dependency.
Thank you,
On 2018-05-16 16:18, Magnus Ihse Bursie wrote:
16 maj 2018 kl. 01:39 skrev Erik Joelsson :
Hello,
In GensrcJfr, JFR_TOOLS_OUTPUTDIR is defined twice.
Oops, will fix.
Other build tools are in make/{jdk,hotspot}/src/classes. Do you think we should
be moving them to one place? Regardless, I th
On Fri 25. May 2018 at 09:39, Magnus Ihse Bursie <
[email protected]> wrote:
> On 2018-05-25 07:56, Thomas Stüfe wrote:
>
> Hi Erik,
>
> will Oracle change the jdk-submit builds to VS2017? Most of our guys
> still work with VS2013, so we may miss build errors on our machines.
>
> This
On 2018-05-24 03:08, Ao Qi wrote:
Hi Erik,
Thanks for your comments. I made a new patch:
$ hg diff
diff -r 31361382634b make/autoconf/build-aux/config.guess
--- a/make/autoconf/build-aux/config.guess Tue May 22 10:08:04 2018 -0700
+++ b/make/autoconf/build-aux/config.guess Thu May 24 09:07:17 2
On 2018-05-23 02:05, Erik Joelsson wrote:
Looks like the line "# } nsk/jvmti" is a left over. Otherwise this
looks ok, even if it's an enormous amount of duplication. Hopefully we
can figure out a better way to express common parameters for tests soon.
Argee, the current solution is not scaling
On 2018-05-25 07:56, Thomas Stüfe wrote:
Hi Erik,
will Oracle change the jdk-submit builds to VS2017? Most of our guys
still work with VS2013, so we may miss build errors on our machines.
This change will affect all our build systems, including jdk-submit, yes.
Fix looks good to me.
/Magnus
20 matches
Mail list logo
