Re: RFR: JDK-8211130: Change to Oracle Developer Studio 12.6 for building on Solaris at Oracle

2018-09-25 Thread Tim Bell
Erik: It's time for Oracle to change the official compiler used for building OpenJDK on Solaris. The new version will be Oracle Developer Studio 12.6 and the build will happen on Solaris 11.3. This patch changes the jib dependency to use the new devkit and updates the devkit generator script wit

RFR: JDK-8211130: Change to Oracle Developer Studio 12.6 for building on Solaris at Oracle

2018-09-25 Thread Erik Joelsson
It's time for Oracle to change the official compiler used for building OpenJDK on Solaris. The new version will be Oracle Developer Studio 12.6 and the build will happen on Solaris 11.3. This patch changes the jib dependency to use the new devkit and updates the devkit generator script with the

Re: src.zip is not being updated when running make images

2018-09-25 Thread Erik Joelsson
This has been observed recently and logged here https://bugs.openjdk.java.net/browse/JDK-8211016. The workaround is to manually remove support/src.zip before rebuild. /Erik On 2018-09-25 11:50, Jorn Vernee wrote: Hello, I'm running into a problem where running `make images` does not update

src.zip is not being updated when running make images

2018-09-25 Thread Jorn Vernee
Hello, I'm running into a problem where running `make images` does not update the `images/jdk/lib/src.zip` file. I have tried deleting the file and then running the command, which creates the src.zip, but it still has the old source files in it. I'm debugging using my IDE (Netbeans), but wit

Re: Fwd: Java 11 / JDK 11: General Availability

2018-09-25 Thread Erik Joelsson
The plan is that we do, given the recently adopted policy. /Erik On 2018-09-25 10:31, Jonathan Gibbons wrote: Now that JDK 11 is available, what are the plans to bump up the boot JDK version? -- Jon Forwarded Message Subject: Java 11 / JDK 11: General Availability Dat

Fwd: Java 11 / JDK 11: General Availability

2018-09-25 Thread Jonathan Gibbons
Now that JDK 11 is available, what are the plans to bump up the boot JDK version? -- Jon Forwarded Message Subject:Java 11 / JDK 11: General Availability Date: Tue, 25 Sep 2018 10:23:51 -0700 (PDT) From: [email protected] Reply-To: [email protected]

Re: [8u] Include all classes in sources (src.zip)?

2018-09-25 Thread Severin Gehwolf
On Tue, 2018-09-25 at 08:52 -0700, Erik Joelsson wrote: > Yes, it is indeed. I recognize that now. > > /Erik > > > On 2018-09-25 08:49, Alan Bateman wrote: > > > > > > On 25/09/2018 16:43, Erik Joelsson wrote: > > > At Oracle, I'm pretty sure we need to maintain the current behavior > > > so

Re: [8u] Include all classes in sources (src.zip)?

2018-09-25 Thread Erik Joelsson
Yes, it is indeed. I recognize that now. /Erik On 2018-09-25 08:49, Alan Bateman wrote: On 25/09/2018 16:43, Erik Joelsson wrote: At Oracle, I'm pretty sure we need to maintain the current behavior so that patch needs to be accompanied by a corresponding patch in Oracle closed. Is this th

Re: [8u] Include all classes in sources (src.zip)?

2018-09-25 Thread Alan Bateman
On 25/09/2018 16:43, Erik Joelsson wrote: At Oracle, I'm pretty sure we need to maintain the current behavior so that patch needs to be accompanied by a corresponding patch in Oracle closed. Is this the same issue as JDK-8044235 that Omair fixed in JDK 9: http://hg.openjdk.java.net/jdk9/jdk

Re: [8u] Include all classes in sources (src.zip)?

2018-09-25 Thread Erik Joelsson
At Oracle, I'm pretty sure we need to maintain the current behavior so that patch needs to be accompanied by a corresponding patch in Oracle closed. /Erik On 2018-09-25 05:15, Severin Gehwolf wrote: Hi, We have a local spec file patch so that we include all sources in src.zip shipped with t

RE: build issues after 8211029 on gcc4.8 and our porting Linux platforms (ppc64(le)/ s390x)

2018-09-25 Thread Baesken, Matthias
Thanks for the heads-up, we've seen this one too but noticed that you had already a bug opened . Best regards, Matthias > -Original Message- > From: Roman Kennke > Sent: Dienstag, 25. September 2018 17:05 > To: Baesken, Matthias ; 'build- > [email protected]' ; net-dev d...@open

Re: build issues after 8211029 on gcc4.8 and our porting Linux platforms (ppc64(le)/ s390x)

2018-09-25 Thread Roman Kennke
Related, I've also filed: https://bugs.openjdk.java.net/browse/JDK-8211071 and waiting for review here: http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-September/055666.html Thanks, Roman > Hello, one additonal info , my colleague looking into the compile issues > after 8211029 f

RE: build issues after 8211029 on gcc4.8 and our porting Linux platforms (ppc64(le)/ s390x)

2018-09-25 Thread Baesken, Matthias
Hello, one additonal info , my colleague looking into the compile issues after 8211029 found this error , when compiling on linuxx86_64 : === Output from failing command(s) repeated here === * For target support_native_java.base_libnet_DatagramPacket.o: In file included from /OpenJDK/82103

build issues after 8211029 on gcc4.8 and our porting Linux platforms (ppc64(le)/ s390x)

2018-09-25 Thread Baesken, Matthias
Hello, it looks like 8211029: Have a common set of enabled warnings for all native libraries breaks a lot of our Linux based builds. Our gcc 4.8 misses some of the introduced command line options : cc1plus: error: unrecognized command line option "-Wno-misleading-indentation" [-Werror] cc1p

[8u] Include all classes in sources (src.zip)?

2018-09-25 Thread Severin Gehwolf
Hi, We have a local spec file patch so that we include all sources in src.zip shipped with the JDK. Would this be acceptable for upstream? If not, are there any particular reasons? If yes, I prepare a patch for this (if desired in a backwards compat way). http://cr.openjdk.java.net/~sgehwolf/webr

Re: RFR: JDK-8211071: unpack.cpp fails to compile with statement has no effect [-Werror=unused-value]

2018-09-25 Thread Magnus Ihse Bursie
> 25 sep. 2018 kl. 10:21 skrev Roman Kennke : > > Not sure this is the correct list. Please redirect as appropriate. I believe core-libs is the appropriate place. Cc:d. > > Please review the following proposed change: > > > There are 3 asserts in unpack.cpp which check only constants, and

RFR: JDK-8211071: unpack.cpp fails to compile with statement has no effect [-Werror=unused-value]

2018-09-25 Thread Roman Kennke
Not sure this is the correct list. Please redirect as appropriate. Please review the following proposed change: There are 3 asserts in unpack.cpp which check only constants, and which the compiler rejects as 'has no effect' (in fastdebug builds). This seems to be caused by: https://bugs.openjdk