Re: JDK14 cross-compile to arm64 fails to locate c++ header new

2020-08-25 Thread Choe, Jiwon
Hi Adrian, Thanks for the quick reply. Yes, I do have build-essential installed on the host system. I have cross-compiled jdk14 from a 32-bit x86 system to target aarch32-linux-gnueabihf before, with the same version gcc and g++. Could this still be the issue though? Thanks again, Jiwon On Tue,

Re: RFR: JDK-8252145: Unify Info.plist files with correct version strings

2020-08-25 Thread Sergey Bylokhov
Looks fine. On 25.08.2020 07:27, Erik Joelsson wrote: On 2020-08-24 19:18, Sergey Bylokhov wrote: Hi, Erik. I would like to highlight one thing affected by this fix. The text in the default about dialog in the Swing application will be changed. For my local build:  - Current text: "Java

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Sergey Bylokhov
On 25.08.2020 16:25, Philip Race wrote: On 8/25/20, 4:01 PM, Sergey Bylokhov wrote: It is applied if the "automatic graphics switching" is enabled, if the user disables this feature for the "power adapter" mode, then the discrete graphics will be always used. That's a bit misleading If

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Philip Race
On 8/25/20, 4:01 PM, Sergey Bylokhov wrote: It is applied if the "automatic graphics switching" is enabled, if the user disables this feature for the "power adapter" mode, then the discrete graphics will be always used. That's a bit misleading If I disable automatic graphics switching it

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Kevin Rushforth
On 8/25/2020 4:17 PM, Sergey Bylokhov wrote: On 25.08.2020 16:08, Kevin Rushforth wrote: I haven't tested an FX app yet, but since this changes the plist properties, I want to see whether or not FX apps are impacted. It should be affected because the first variation of the fix was pushed

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Sergey Bylokhov
On 25.08.2020 16:08, Kevin Rushforth wrote: I haven't tested an FX app yet, but since this changes the plist properties, I want to see whether or not FX apps are impacted. It should be affected because the first variation of the fix was pushed to the FX(if nothing changed since then):

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Kevin Rushforth
This is how other applications work...  Also results are similar to other macbooks without discrete graphics. That's sort of what I was getting at with my earlier question: why have a discrete graphics card that never / seldom gets used? This may be more of a question for Apple, but it

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Sergey Bylokhov
On 25.08.2020 15:40, Philip Race wrote: On 8/25/20, 12:27 PM, Sergey Bylokhov wrote: On 25.08.2020 05:43, Kevin Rushforth wrote: Does this only apply when the MacBook is running on battery, or will this affect performance even when the laptop is plugged in? If the latter, I wonder what

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Philip Race
On 8/25/20, 12:27 PM, Sergey Bylokhov wrote: On 25.08.2020 05:43, Kevin Rushforth wrote: Does this only apply when the MacBook is running on battery, or will this affect performance even when the laptop is plugged in? If the latter, I wonder what Apple's rationale is for including a

Re: RFR [16/java.xml] 8251561: Fix doclint warnings in the java.xml package

2020-08-25 Thread Erik Joelsson
Ah, I was looking for that kind of information in the bug report, but couldn't find any. /Erik On 2020-08-25 13:20, Joe Wang wrote: Hi Erik, We're acting on a report Jon generated separately. The warnings checks are currently disabled (see line 106 JAVADOC_DISABLED_DOCLINT := accessibility

Re: JDK14 cross-compile to arm64 fails to locate c++ header new

2020-08-25 Thread John Paul Adrian Glaubitz
Hi Jiwon! On 8/25/20 10:06 PM, Choe, Jiwon wrote: > === Output from failing command(s) repeated here === > * For target > hotspot_variant-server_libjvm_gtest_objs_precompiled_precompiled.hpp.gch: > In file included from >

Re: RFR [16/java.xml] 8251561: Fix doclint warnings in the java.xml package

2020-08-25 Thread Joe Wang
Hi Erik, We're acting on a report Jon generated separately. The warnings checks are currently disabled (see line 106 JAVADOC_DISABLED_DOCLINT := accessibility html missing syntax reference). -Joe On 8/25/20 12:39 PM, Erik Joelsson wrote: On 2020-08-25 12:21, Roger Riggs wrote: Hi Erik,

Re: RFR [16/java.xml] 8251561: Fix doclint warnings in the java.xml package

2020-08-25 Thread Roger Riggs
Hi Erik, We're in a cleanup phase of the source before re-enabling disabled warnings. The warnings for "missing" comments are disabled: Docs.gmk: 106: JAVADOC_DISABLED_DOCLINT := accessibility html missing syntax reference Roger On 8/25/20 3:39 PM, Erik Joelsson wrote: On 2020-08-25

JDK14 cross-compile to arm64 fails to locate c++ header new

2020-08-25 Thread Choe, Jiwon
Hello all, I'm trying to cross-compile JDK 14 to target aarch64-linux-gnu, from a 64-bit x86 Linux machine. I followed the steps described in the documentation ( https://hg.openjdk.java.net/jdk/jdk14/raw-file/tip/doc/building.html#creating-and-using-sysroots-with-qemu-deboostrap), but when I try

Re: RFR [16/java.xml] 8251561: Fix doclint warnings in the java.xml package

2020-08-25 Thread naoto . sato
+1 Naoto On 8/25/20 11:47 AM, Joe Wang wrote: Cc-ing build-dev@openjdk.java.net (makefile change: make/Docs.gmk) Updated webrev: http://cr.openjdk.java.net/~joehw/jdk16/8251561/webrev_04/ Thanks Roger! Please see inline comments. On 8/25/20 8:09 AM, Roger Riggs wrote: Hi Joe, Eliminating

Re: RFR [16/java.xml] 8251561: Fix doclint warnings in the java.xml package

2020-08-25 Thread Erik Joelsson
On 2020-08-25 12:21, Roger Riggs wrote: Hi Erik, org.w3c is in third party code that is not being updated. There is a balance between ignoring the warnings and doing a bunch of editing that would overwritten by a future update. Yes, I get that part, but why are those warnings not

Re: RFR [16/java.xml] 8251561: Fix doclint warnings in the java.xml package

2020-08-25 Thread Roger Riggs
Hi Joe, The updates to those files are fine, I mixed up the two packages. Roger On 8/25/20 2:47 PM, Joe Wang wrote: org/xml/...: If we're suppressing the warnings for org/xml/... then the files changes are unnecessary? Did you mean org/w3c? We're only suppressing the warnings for org/w3c

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Sergey Bylokhov
On 25.08.2020 05:43, Kevin Rushforth wrote: Does this only apply when the MacBook is running on battery, or will this affect performance even when the laptop is plugged in? If the latter, I wonder what Apple's rationale is for including a discrete graphics card that isn't used most of the

Re: RFR [16/java.xml] 8251561: Fix doclint warnings in the java.xml package

2020-08-25 Thread Roger Riggs
Hi Erik, org.w3c is in third party code that is not being updated. There is a balance between ignoring the warnings and doing a bunch of editing that would overwritten by a future update. $.02, Roger On 8/25/20 2:58 PM, Erik Joelsson wrote: Build change looks ok, but why is it needed? You

Re: RFR [16/java.xml] 8251561: Fix doclint warnings in the java.xml package

2020-08-25 Thread Erik Joelsson
Build change looks ok, but why is it needed? You are fixing a bunch of warnings in one part of the source and disabling them in another part. Is there some other change incoming that will enable more warning categories by default? /Erik On 2020-08-25 11:47, Joe Wang wrote: Cc-ing

Re: RFR [16/java.xml] 8251561: Fix doclint warnings in the java.xml package

2020-08-25 Thread Joe Wang
Cc-ing build-dev@openjdk.java.net (makefile change: make/Docs.gmk) Updated webrev: http://cr.openjdk.java.net/~joehw/jdk16/8251561/webrev_04/ Thanks Roger! Please see inline comments. On 8/25/20 8:09 AM, Roger Riggs wrote: Hi Joe, Eliminating the checking for warnings in org.w3c is fine.

Re: RFR: JDK-8252145: Unify Info.plist files with correct version strings

2020-08-25 Thread Erik Joelsson
On 2020-08-24 19:18, Sergey Bylokhov wrote: Hi, Erik. I would like to highlight one thing affected by this fix. The text in the default about dialog in the Swing application will be changed. For my local build:  - Current text: "Java Version 1.0 (16)"  - After the fix: "Java Version 16

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Kevin Rushforth
Does this only apply when the MacBook is running on battery, or will this affect performance even when the laptop is plugged in? If the latter, I wonder what Apple's rationale is for including a discrete graphics card that isn't used most of the time. -- Kevin On 8/24/2020 11:27 PM, Sergey

Re: [aarch64-port-dev ] RFR(L): 8231441: AArch64: Initial SVE backend support

2020-08-25 Thread Ningsheng Jian
Hi Erik, On 8/24/20 11:26 PM, Erik Österlund wrote: Hi Ningsheng, On 2020-08-24 11:59, Ningsheng Jian wrote: Hi Erik, Thanks for the review! On 8/22/20 12:21 AM, Erik Österlund wrote: Hi, Have you tried this with ZGC on AArch64? It has custom code for saving live registers in the load

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Sergey Bylokhov
On 24.08.2020 13:35, Philip Race wrote: Is there any performance cost to doing this ? I'd expect so. Any estimate ? Yes, performance is affected for sure: - SwingMark: OGL_Base: 14000 OGL_Fix: 24000 Metal: 18000 - Here is a j2dbench for the common draw operations(new/old/metal):