On Fri, 11 Sep 2020 06:21:46 GMT, Aleksey Shipilev wrote:
>> Monica Beckwith has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> x$OPENJDK_TARGET_CPU" = "xaarch64"
>>
>> Incorporating Aleksey's comments to incorporate 'x'
>
> The check
On Thu, 10 Sep 2020 15:30:04 GMT, Monica Beckwith wrote:
>> ZGC and ShenandoahGC are two low latency GCs in OpenJDK HotSpot. We will
>> enable and run microbenchmarks and scaling
>> tests for both. After enabling, I ran JTRegs, a few micros, and SPECJBB2015
>> (heap and multi-JVM) scaling tests
On Thu, 10 Sep 2020 17:09:00 GMT, Monica Beckwith wrote:
>> This looks good to me with Alexsey's changes applied.
>
> Ref: https://github.com/openjdk/jdk/pull/97#issuecomment-690077743
> Hi David,
> Thanks. I wanted to start a conversation here as it does modify common code
> (the aarch64-linux
Hi Monica,
On 11/09/2020 3:11 am, Monica Beckwith wrote:
Ref: https://github.com/openjdk/jdk/pull/97#issuecomment-690077743
Hi David,
Thanks. I wanted to start a conversation here as it does modify common code
(the aarch64-linux combo check) and also
wanted to highlight the difference between S
On Sun, 6 Sep 2020 13:57:19 GMT, Dmitriy Dumanskiy
wrote:
> **isEmpty** is faster + has less byte code + easier to read. Benchmarks could
> be found
>
> [here](https://medium.com/javarevisited/micro-optimizations-in-java-string-equals-22be19fd8416).
1) This is un-necessary churn.
2) I can't
On Thu, 10 Sep 2020 12:04:48 GMT, Dmitriy Dumanskiy
wrote:
> I have in mind dozens of improvements all over the code like this one.
That sounds scary. Broad updates like these cause unnecessary churn in the
codebase, and can make merging and back
porting harder. Changes should be discussed ah
On Wed, 9 Sep 2020 09:49:44 GMT, Philippe Marschall
wrote:
>> Hello, newbie here
>>
>> I picked JDK-8138732 to work on because it has a "starter" label and I
>> believe I understand what to do.
>>
>> - I tried to update the copyright year to 2020 in every file.
>> - I decided to change `@sinc
On Thu, 10 Sep 2020 16:28:34 GMT, Stuart Monteith wrote:
>>> Ah, Shenandoah does not filter for OS, so it is enabled for AArch64
>>> already, right?
>>
>> +1
>
> This looks good to me with Alexsey's changes applied.
Ref: https://github.com/openjdk/jdk/pull/97#issuecomment-690077743
Hi David,
T
On Thu, 10 Sep 2020 15:50:39 GMT, Alan Bateman wrote:
>> 14 cc'd mailing lists is unworkable. You need to be subscribed to lists to
>> post, but even if you are a reply-all will
>> be delayed due to all of the mails being held up for moderator approval due
>> to:
>> " Too many recipients to the
On Thu, 10 Sep 2020 05:16:00 GMT, Monica Beckwith wrote:
>> Ah, Shenandoah does not filter for OS, so it is enabled for AArch64 already,
>> right?
>
>> Ah, Shenandoah does not filter for OS, so it is enabled for AArch64 already,
>> right?
>
> +1
This looks good to me with Alexsey's changes ap
On Thu, 10 Sep 2020 13:53:10 GMT, David Holmes wrote:
>> @dholmes-ora raises a good point. Hopefully there is a balance point between
>> a dozen different bugs / pull requests
>> each targeting one area and one bug / PR targeting a dozen separate areas. I
>> don't have a good general rule to su
On Thu, 10 Sep 2020 05:09:25 GMT, Aleksey Shipilev wrote:
>> Monica Beckwith has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> x$OPENJDK_TARGET_CPU" = "xaarch64"
>>
>> Incorporating Aleksey's comments to incorporate 'x'
>
> make/autoc
> ZGC and ShenandoahGC are two low latency GCs in OpenJDK HotSpot. We will
> enable and run microbenchmarks and scaling
> tests for both. After enabling, I ran JTRegs, a few micros, and SPECJBB2015
> (heap and multi-JVM) scaling tests for both
> the GCs.
Monica Beckwith has updated the pull requ
On 10/09/2020 10:07 pm, Dmitriy Dumanskiy wrote:
On Thu, 10 Sep 2020 11:21:28 GMT, David Holmes wrote:
The code in java.base was updated to use String::isEmpty in JDK 12
(JDK-8215281). There was follow-up in JDK 13 to do
the same in the java.desktop module (JDK-8223237). Changing the remainin
On Thu, 10 Sep 2020 12:18:51 GMT, Kevin Rushforth wrote:
>> This should be broken up to deal with the files in different functional
>> areas under different bugids and PRs. Otherwise
>> the cross-posting to so many lists is prohibitive. Files in different areas
>> need to be reviewed by differe
Hello Adam,
I agree with this change. However, since we moved to github and Skara
last weekend, you need to post this as a PR. See instructions for
setting up an OpenJDK workflow in the new Skara world here:
https://wiki.openjdk.java.net/display/SKARA/Skara
/Erik
On 2020-09-10 02:36, Adam F
Hello Adam,
This is a nice cleanup, but please repost as a PR.
/Erik
On 2020-09-10 02:42, Adam Farley8 wrote:
Hi All,
Reviews and sponsor requested for the removal of the now-redundant
MAKE_SUBDIR argument in DeclareRecipesForPhase's comment, along with its
removal from anything that calls th
On Thu, 10 Sep 2020 11:21:28 GMT, David Holmes wrote:
>> The code in java.base was updated to use String::isEmpty in JDK 12
>> (JDK-8215281). There was follow-up in JDK 13 to do
>> the same in the java.desktop module (JDK-8223237). Changing the remaining
>> usages make sense although I see that
On Thu, 10 Sep 2020 11:21:28 GMT, David Holmes wrote:
>> The code in java.base was updated to use String::isEmpty in JDK 12
>> (JDK-8215281). There was follow-up in JDK 13 to do
>> the same in the java.desktop module (JDK-8223237). Changing the remaining
>> usages make sense although I see that
On Thu, 10 Sep 2020 10:40:15 GMT, Alan Bateman wrote:
>> @kevinrushforth thanks. Done.
>>
>> Similar issues:
>> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8215014
>> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8251246
>> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=822
On 10/09/2020 10:44, Archana Nogriya wrote:
Hi,
I am requesting a proposal for the contribution to OpenJDK.
I have created webrev with my changes.
Moving to build-dev as that is normally where the linker options are
discussed.
I don't know if there is a significant need for Windows 32-bit bu
On Thu, 10 Sep 2020 08:47:35 GMT, Dmitriy Dumanskiy
wrote:
>> Before this Enhancement can be formally reviewed, you will need a JBS bug
>> ID. If you are already working with a
>> Committer or Reviewer in the `jdk` project who has agreed to sponsor your
>> change, they can file the Enhancement
Hi All,
Reviews and sponsor requested for the removal of the now-redundant
MAKE_SUBDIR argument in DeclareRecipesForPhase's comment, along with its
removal from anything that calls that macro.
Bug: https://bugs.openjdk.java.net/browse/JDK-8253000
Webrev: http://cr.openjdk.java.net/~afarley/825
Hi All,
Requesting reviews and sponsor for the following change.
A previous change (JDK-8244044) appears to prevent make from checking the
include dirs for an included gmk file.
This means that you can't override the included file using the include
dirs, as was previously the case.
This sound
On Wed, 9 Sep 2020 07:57:48 GMT, Dmitriy Dumanskiy
wrote:
>> @doom369 jcheck requires an associated issue
>
> @mrserb hello. Thanks for the review. Any further actions required from me?
Before this Enhancement can be formally reviewed, you will need a JBS bug ID.
If you are already working wit
On Wed, 9 Sep 2020 20:21:44 GMT, Kevin Rushforth wrote:
>> @mrserb hello. Thanks for the review. Any further actions required from me?
>
> Before this Enhancement can be formally reviewed, you will need a JBS bug ID.
> If you are already working with a
> Committer or Reviewer in the `jdk` projec
On Sun, 6 Sep 2020 13:57:19 GMT, Dmitriy Dumanskiy
wrote:
> **isEmpty** is faster + has less byte code + easier to read. Benchmarks could
> be found
>
> [here](https://medium.com/javarevisited/micro-optimizations-in-java-string-equals-22be19fd8416).
@doom369 jcheck requires an associated is
On Sun, 6 Sep 2020 13:57:19 GMT, Dmitriy Dumanskiy
wrote:
> **isEmpty** is faster + has less byte code + easier to read. Benchmarks could
> be found
>
> [here](https://medium.com/javarevisited/micro-optimizations-in-java-string-equals-22be19fd8416).
src/demo/share/java2d/J2DBench/src/j2dben
On Sun, 6 Sep 2020 18:08:15 GMT, thatsIch
wrote:
>> **isEmpty** is faster + has less byte code + easier to read. Benchmarks
>> could be found
>>
>> [here](https://medium.com/javarevisited/micro-optimizations-in-java-string-equals-22be19fd8416).
>
> @doom369 jcheck requires an associated issu
**isEmpty** is faster + has less byte code + easier to read. Benchmarks could
be found
[here](https://medium.com/javarevisited/micro-optimizations-in-java-string-equals-22be19fd8416).
-
Commit messages:
- Merge branch 'master' of https://github.com/doom369/jdk into
reaplce_equal
Hi Monica,
On 10/09/2020 5:26 pm, Monica Beckwith wrote:
ZGC and ShenandoahGC are two low latency GCs in OpenJDK HotSpot. We will enable
and run microbenchmarks and scaling
tests for both. After enabling, I ran JTRegs, a few micros, and SPECJBB2015
(heap and multi-JVM) scaling tests for both
t
On Wed, 2020-09-09 at 14:26 -0400, Zhengyu Gu wrote:
> Verified, it fixed build. Looks good to me.
>
> Thanks for the quick fix.
Thanks for the review!
Cheers,
Severin
> -Zhengyu
>
> On 9/9/20 2:16 PM, Severin Gehwolf wrote:
> > Hi,
> >
> > Please review this 8u (jdk8u/jdk8u-dev tree) fix for
ZGC and ShenandoahGC are two low latency GCs in OpenJDK HotSpot. We will enable
and run microbenchmarks and scaling
tests for both. After enabling, I ran JTRegs, a few micros, and SPECJBB2015
(heap and multi-JVM) scaling tests for both
the GCs.
-
Commit messages:
- JDK-8252114: Win
On Thu, 10 Sep 2020 05:06:41 GMT, Aleksey Shipilev wrote:
> I see the block that enables ZGC, where is the block that enables Shenandoah?
I had a block for Shenandoah, but then I saw that someone had already
modified/combined the Shenandoah to part to be
enabled for all combos of aarch64: "# Ch
On Wed, 9 Sep 2020 20:24:37 GMT, Monica Beckwith wrote:
> ZGC and ShenandoahGC are two low latency GCs in OpenJDK HotSpot. We will
> enable and run microbenchmarks and scaling
> tests for both. After enabling, I ran JTRegs, a few micros, and SPECJBB2015
> (heap and multi-JVM) scaling tests for
On Wed, 9 Sep 2020 09:49:44 GMT, Philippe Marschall
wrote:
>> Hello, newbie here
>>
>> I picked JDK-8138732 to work on because it has a "starter" label and I
>> believe I understand what to do.
>>
>> - I tried to update the copyright year to 2020 in every file.
>> - I decided to change `@sinc
36 matches
Mail list logo
