On Tue, 19 Oct 2021 13:51:45 GMT, Weijun Wang wrote:
> As a follow up of JEP 411, we will soon disallow security manager by default.
> jtreg 6.1 does not set its own security manager if JDK version is >= 18.
LGTM
-
Marked as reviewed by iignatyev (Reviewer).
PR:
On Tue, 3 Aug 2021 20:18:11 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this small patch that enables
> `runtime/jsig/Testjsig.java` test and compilation of its native library on
> all platforms but windows?
> from JBS:
>> `runtime/jsig/Testj
On Tue, 3 Aug 2021 20:18:11 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this small patch that enables
> `runtime/jsig/Testjsig.java` test and compilation of its native library on
> all platforms but windows?
> from JBS:
>> `runtime/jsig/Testj
Hi all,
could you please review this small patch that enables
`runtime/jsig/Testjsig.java` test and compilation of its native library on all
platforms but windows?
from JBS:
> `runtime/jsig/Testjsig.java` test currently `@requires (os.family ==
> "linux")` and
On Sun, 20 Jun 2021 11:08:21 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this small patch that enables
> `runtime/jsig/Testjsig.java` test and compilation of its native library on
> all platforms but windows?
> from JBS:
>> `runtime/jsig/Testj
On Sun, 20 Jun 2021 11:08:21 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this small patch that enables
> `runtime/jsig/Testjsig.java` test and compilation of its native library on
> all platforms but windows?
> from JBS:
>> `runtime/jsig/Testj
Hi all,
could you please review this small patch that enables
`runtime/jsig/Testjsig.java` test and compilation of its native library on all
platforms but windows?
from JBS:
> `runtime/jsig/Testjsig.java` test currently `@requires (os.family ==
> "linux")` and
On Tue, 13 Apr 2021 09:30:23 GMT, Doug Simon wrote:
> I guess this should really be named `isJVMCICompilerEnabled` now and the
> `vm.graal.enabled` predicate renamed to `vm.jvmcicompiler.enabled` but maybe
> that's too big a change (or can be done later).
@dougxc, I don't think that we should
On Thu, 22 Apr 2021 18:15:58 GMT, Mikael Vidstedt wrote:
> The bootjdk used for macosx-aarch64 at Oracle is a custom build of JDK 16
> from early December, so does not include all the JDK 16 GA functionality.
> This leads to build issues after JDK-8263621 which uses a method not included
> in
On Fri, 9 Apr 2021 22:26:40 GMT, Vladimir Kozlov wrote:
>> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related
>> to Java-based JIT compiler (Graal) from JDK:
>>
>> - `jdk.internal.vm.compiler` — the Graal compiler
>> - `jdk.internal.vm.compiler.management` — Graal's
On Sat, 10 Apr 2021 16:36:54 GMT, Vladimir Kozlov wrote:
>> should we remove `sun.hotspot.code.Compiler::isGraalEnabled` method and
>> update a few of its users accordingly?
>> what about `vm.graal.enabled` `@requires` property?
>
> @iignatev If you think that I should clean tests anyway I
On Fri, 9 Apr 2021 22:26:40 GMT, Vladimir Kozlov wrote:
>> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related
>> to Java-based JIT compiler (Graal) from JDK:
>>
>> - `jdk.internal.vm.compiler` — the Graal compiler
>> - `jdk.internal.vm.compiler.management` — Graal's
On Fri, 9 Apr 2021 22:30:32 GMT, Vladimir Kozlov wrote:
>> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related
>> to Java-based JIT compiler (Graal) from JDK:
>>
>> - `jdk.internal.vm.compiler` — the Graal compiler
>> - `jdk.internal.vm.compiler.management` — Graal's
On Thu, 8 Apr 2021 17:24:38 GMT, Vladimir Kozlov wrote:
>> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related
>> to Ahead-of-Time Compiler from JDK:
>>
>> - `jdk.aot` module — the `jaotc` tool
>> - `src/hotspot/share/aot` — loads AoT compiled code into VM for
On Tue, 2 Feb 2021 18:17:55 GMT, Jesper Wilhelmsson
wrote:
> We have our (first) RC candidate build for JDK 16 on Feb 04, 2021. We need to
> remove the EA from version string for this build (b35) and going forward.
>
> Pushing this for @pashh
Marked as reviewed by iignatyev (Reviewer).
On Tue, 17 Nov 2020 00:31:24 GMT, Igor Ignatyev wrote:
> Hi all,
>
>
> [8256414](https://bugs.openjdk.java.net/browse/JDK-8256414) / #1233 added
> similar profile to submit workflow, this patch defines `linux-x64-optimized`
> profile in jib-profile so it can be used
On Tue, 17 Nov 2020 19:52:49 GMT, Erik Joelsson wrote:
>> Igor Ignatyev has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> build only hotspot for optimized
>
> Marked as reviewed by erikj (Reviewer).
or
>
> cc-ing @dcubed-ojdk
Igor Ignatyev has updated the pull request incrementally with one additional
commit since the last revision:
build only hotspot for optimized
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1244/files
- new: https://git.openjdk.java
Hi all,
[8256414](https://bugs.openjdk.java.net/browse/JDK-8256414) / #1233 added
similar profile to submit workflow, this patch defines `linux-x64-optimized`
profile in jib-profile so it can be used by mach5 and added to tier1?
Thanks
-- Igor
cc-ing @dcubed-ojdk
-
Commit
emember reading discussions about this.
>
> Thanks, Thomas
>
> On Mon, Nov 16, 2020 at 9:35 PM Daniel D.Daugherty <mailto:dcu...@openjdk.java.net>> wrote:
> On Mon, 16 Nov 2020 19:29:59 GMT, Igor Ignatyev <mailto:iignat...@openjdk.org>> wrote:
>
> >>
On Mon, 16 Nov 2020 19:29:59 GMT, Igor Ignatyev wrote:
>> Marked as reviewed by shade (Reviewer).
>
> Thanks for the reviews, folks. the build looks green, integrating.
> @iignatev - did you also change Mach5? I don't have workflow builds enabled
> by default since I typical
On Mon, 16 Nov 2020 18:58:37 GMT, Aleksey Shipilev wrote:
>> Igor Ignatyev has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added --disable-precompiled-headers
>
> Marked as reviewed by shade (Reviewer).
On Mon, 16 Nov 2020 18:26:18 GMT, Igor Ignatyev wrote:
> Hi all,
>
> Could you please review this small and trivial patch which adds
> `linux-x64-optimized` build to submit workflow so breakages of this build
> flavor would be easier to spot?
>
> Thanks,
> -- Igor
T
On Mon, 16 Nov 2020 18:40:27 GMT, Aleksey Shipilev wrote:
> Looks fine, but wouldn't you like to add `--disable-precompiled-headers` as
> well?
sure, make sense.
-
PR: https://git.openjdk.java.net/jdk/pull/1233
> Hi all,
>
> Could you please review this small and trivial patch which adds
> `linux-x64-optimized` build to submit workflow so breakages of this build
> flavor would be easier to spot?
>
> Thanks,
> -- Igor
Igor Ignatyev has updated the pull request increment
Hi all,
Could you please review this small and trivial patch which adds
`linux-x64-optimized` build to submit workflow so breakages of this build
flavor would be easier to spot?
Thanks,
-- Igor
-
Commit messages:
- add linux-x64-optimized build
Changes:
On Fri, 30 Oct 2020 17:40:51 GMT, Vladimir Kozlov wrote:
> We shipped Ahead-of-Time compilation (the jaotc tool) in JDK 9, as an
> experimental feature. We shipped Graal as an experimental JIT compiler in JDK
> 10. We haven't seen much use of these features, and the effort required to
>
On Thu, 8 Oct 2020 11:00:41 GMT, Aleksei Voitylov wrote:
> @iignatev I resolved the conflict in whitebox.cpp and fixed a minor style nit
> on the way. Could you take a look?
LGTM
-
PR: https://git.openjdk.java.net/jdk/pull/49
On Tue, 6 Oct 2020 23:08:40 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this small cleanup which replaces
> `ManagementFactory.getRuntimeMXBean().getName().split("@")[0]` w/
> `ProcessHandle.current().pid()` to get current
> process pid?
On Wed, 7 Oct 2020 18:38:07 GMT, Roger Riggs wrote:
>> Igor Ignatyev has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - use Long.toString instead of String.valueOf
>> - remove explicit coversion to Str
On Wed, 7 Oct 2020 06:30:43 GMT, Aleksey Shipilev wrote:
>> test/failure_handler/test/sanity/Suicide.java line 36:
>>
>>> 34: String osName = System.getProperty("os.name");
>>> 35: if (osName.contains("Windows")) {
>>> 36: cmd = "taskkill.exe /F /PID " +
> Hi all,
>
> could you please review this small cleanup which replaces
> `ManagementFactory.getRuntimeMXBean().getName().split("@")[0]` w/
> `ProcessHandle.current().pid()` to get current
> process pid? Thanks,
> -- Igor
Igor Ignatyev has updated the pull
Hi all,
could you please review this small cleanup which replaces
`ManagementFactory.getRuntimeMXBean().getName().split("@")[0]` w/
`ProcessHandle.current().pid()` to get current
process pid?
Thanks,
-- Igor
-
Commit messages:
- update copyright
- use ProcessHandle::pid instead
On Wed, 16 Sep 2020 00:15:54 GMT, Igor Ignatyev wrote:
> problemlists[[1]] check verifies that there are no problem-list entries w/
> the bug-id used in the commit message.
>
> [1]: https://github.com/openjdk/skara/pull/518
This pull request has now been integrated.
Changes
On Wed, 16 Sep 2020 13:08:17 GMT, Erik Joelsson wrote:
>> problemlists[[1]] check verifies that there are no problem-list entries w/
>> the bug-id used in the commit message.
>>
>> [1]: https://github.com/openjdk/skara/pull/518
>
> Marked as reviewed by erikj (Reviewer).
thanks for your
problemlists[[1]] check verifies that there are no problem-list entries w/ the
bug-id used in the commit message.
[1]: https://github.com/openjdk/skara/pull/518
-
Commit messages:
- 8253207: enable problemlists jcheck's check
Changes:
thanks Erik, pushed to jdk15.
-- Igor
> On Jul 28, 2020, at 8:15 AM, Erik Joelsson wrote:
>
> Looks good.
>
> /Erik
>
> On 2020-07-28 07:51, Igor Ignatyev wrote:
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>> Hi all,
>>
>> could you
> 1 files changed, 1 insertions(+), 1 deletions(-)
Hi all,
could you please review the one-liner which fixes the typo introduced by
8245610?
patch:
> diff -r 31a8f79a7dfe make/Main.gmk
> --- a/make/Main.gmk Tue Jul 28 10:32:57 2020 -0400
> +++ b/make/Main.gmk Tue Jul 28 07:50:42 2020 -0700
LGTM
— Igor
> On Jun 23, 2020, at 11:13 AM, Erik Joelsson wrote:
>
> That looks much better! :)
>
> /Erik
>
>> On 2020-06-23 09:53, Magnus Ihse Bursie wrote:
>>> On 2020-06-23 17:05, Erik Joelsson wrote:
>>> Looks good, but that was the worst way of posting a patch I've seen to date.
>> The
Magnus, Erik,
thanks for your reviews, pushed w/ a newline being added at L#654 of
make/Main.gmk.
Cheers,
-- Igor
> On Jun 16, 2020, at 7:03 AM, Magnus Ihse Bursie
> wrote:
>
> On 2020-06-16 15:06, Erik Joelsson wrote:
>>
>> On 2020-06-15 17:39, Igor Ignatyev
ve/discuss the fate of the test.
Thanks,
-- Igor
> On Jun 16, 2020, at 12:14 AM, David Holmes wrote:
>
> Hi Igor,
>
> On 16/06/2020 10:39 am, Igor Ignatyev wrote:
>> @David, Erik, Magnus,
>> please find the answers to your comments at the bottom of this email.
>> @
@David, Erik, Magnus,
please find the answers to your comments at the bottom of this email.
@all,
David's and Erik's comments made me realize that some parts of the original
patch were stashed away and didn't make it to webrev.00. I'm truly sorry for
the confusion and inconvenience. I also
testing revealed that LingeredAppTest.java required some love, incremental
webrev w/ the fixes for LingeredAppTest --
http://cr.openjdk.java.net/~iignatyev//8211977/webrev.0-1
-- Igor
> On Jun 12, 2020, at 8:38 PM, Igor Ignatyev wrote:
>
> adding build-dev
>
>> On Jun 12
adding build-dev
> On Jun 12, 2020, at 8:36 PM, Igor Ignatyev wrote:
>
> http://cr.openjdk.java.net/~iignatyev//8211977/webrev.00/
>> 796 lines changed: 200 ins; 588 del; 8 mod;
>
> Hi all,
>
> could you please review this small patch which puts all tests for test
to me.
>
> /Erik
>
> On 10/06/2020 1:56 am, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev/8246387/webrev.00/
>>> 110 lines changed: 6 ins; 89 del; 15 mod;
>> Hi all,
>> could you please review the patch which switches jtreg used in
http://cr.openjdk.java.net/~iignatyev/8246387/webrev.00/
> 110 lines changed: 6 ins; 89 del; 15 mod;
Hi all,
could you please review the patch which switches jtreg used in jdk/jdk to the
newly promoted jtreg5.1? as before, the patch changes 'requiredVersion'
property in all jtreg test suites
paths to
> libraries to build OpenJDK. This is now different, I always have to manually
> download gtests and specify gtest location. This is regrettable.
>
> Thanks, Thomas
>
>
> On Tue, May 26, 2020 at 2:27 PM Magnus Ihse Bursie
> mailto:magnus.ihse.bur...@oracle.com>>
thanks Erik, pushed.
-- Igor
> On May 26, 2020, at 2:52 PM, Erik Joelsson wrote:
>
> Looks good.
>
> /Erik
>
> On 2020-05-26 14:48, Igor Ignatyev wrote:
>> Hi all,
>>
>> could you please review this trivial one-liner?
>>
>> JBS: https:/
Hi all,
could you please review this trivial one-liner?
JBS: https://bugs.openjdk.java.net/browse/JDK-8245870
webrev: http://cr.openjdk.java.net/~iignatyev//8245870/webrev.00
testing: build on linux-x64,windows-x64 (in progress)
Thanks,
-- Igor
iases
know which changes might be required to enable/disable hotspot gtest tests
compilation.
Thanks.
-- Igor
>
> /Magnus
>
> On 2020-05-22 20:12, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev/8245610/webrev.00/
>>> 132 lines changed: 80 ins; 36 del; 16 m
Magnus a chance to
> look at this too.
>
> /Erik
>
> On 2020-05-22 11:12, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev/8245610/webrev.00/
>>> 132 lines changed: 80 ins; 36 del; 16 mod
>> http://cr.openjdk.java.net/~iignatyev/8245610/webrev.00%2b
google/googletest
<https://github.com/google/googletest>
git checkout release-1.8.1
-- Igor
> On May 22, 2020, at 11:12 AM, Igor Ignatyev wrote:
>
> http://cr.openjdk.java.net/~iignatyev/8245610/webrev.00/
>> 132 lines changed: 80 ins; 36 del; 16 mod
> http://cr.openjdk.java.ne
http://cr.openjdk.java.net/~iignatyev/8245610/webrev.00/
> 132 lines changed: 80 ins; 36 del; 16 mod
http://cr.openjdk.java.net/~iignatyev/8245610/webrev.00%2bremoval/
> 57482 lines changed: 80 ins; 57385 del; 17 mod;
Hi all,
could you please review this small (if you ignore removal part) patch
3/20 4:05 PM, Magnus Ihse Bursie wrote:
>>
>>> 23 apr. 2020 kl. 15:50 skrev Igor Ignatyev :
>>>
>>>
>>>
>>>> On Apr 23, 2020, at 6:12 AM, Erik Joelsson
>>>> wrote:
>>>>
>>>> Hell
> On Apr 23, 2020, at 6:12 AM, Erik Joelsson wrote:
>
> Hello Matthias,
>
> On 2020-04-23 05:51, Matthias Klose wrote:
>> jdk-15+20 fails to build with
>>
>> * For target
>> support_test_failure_handler_classes__the.BUILD_FAILURE_HANDLER_batch:
>>
Thanks for your review, Sergey.
-- Igor
> On Apr 16, 2020, at 1:43 AM, Sergey Bylokhov
> wrote:
>
> Looks fine.
>
> On 4/15/20 10:22 pm, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8240904/webrev.00
>>> 35 lines changed: 26 ins; 0 del; 10 m
t 6:17 AM, Erik Joelsson wrote:
>
> Looks ok to me. Would it be possible to break up the long lines a bit to
> improve readability? Backslash escape for newlines should work in properties
> files.
>
> /Erik
>
> On 2020-04-15 22:22, Igor Ignatyev wrote:
>> http://
http://cr.openjdk.java.net/~iignatyev//8240904/webrev.00
> 35 lines changed: 26 ins; 0 del; 10 mod
Hi all,
8233827[1] which added screenshots to so-called failure handler had an
unexpected side-effect on linux, where users might observer flashes each time a
screenshot is taken, which, to put
Hi Roger,
removal of applications/ctw/modules/jdk_rmic.java and changes in doc (assuming
.html was generated from .md) look good to me.
adding hotspot-runtime alias to bring attention of runtime team. I'm not sure
who are the right people to review bin/unshuffle_list.txt though,.. build team
Hi Erik,
looks good to me.
-- Igor
> On Apr 9, 2020, at 8:15 AM, Erik Joelsson wrote:
>
> The test
> open/test/hotspot/jtreg/testlibrary_tests/process/TestNativeProcessBuilder.java
> fails when building the JDK with VS2019. More specifically, it fails if the
> JDK under test is built with
http://cr.openjdk.java.net/~iignatyev//8238943/webrev.00
> 10 lines changed: 1 ins; 0 del; 9 mod;
Hi all,
could you please review the patch which changes jtreg version used in jdk/jdk
to the latest and greatest -- jtreg 5.0? and as (recently became) usually, this
patch also bumps
David, Misha,
thanks for your review, pushed.
-- Igor
> On Jul 18, 2019, at 10:14 AM, mikhailo.seledt...@oracle.com wrote:
>
> +1
>
> On 7/17/19 9:43 PM, David Holmes wrote:
>> Hi Igor,
>>
>> This seems fine to me.
>>
>> Thanks,
>> Davi
can I get a review for this patch?
http://cr.openjdk.java.net/~iignatyev//8226910/webrev.01/index.html
<http://cr.openjdk.java.net/~iignatyev//8226910/webrev.01/index.html>
Thanks,
-- Igor
> On Jul 6, 2019, at 11:50 AM, Igor Ignatyev wrote:
>
> Hi David,
>
>> On
Hi David,
> On Jul 6, 2019, at 1:58 AM, David Holmes wrote:
>
> Hi Igor,
>
> On 6/07/2019 1:09 pm, Igor Ignatyev wrote:
>> ping?
>> -- Igor
>>> On Jun 27, 2019, at 3:25 PM, Igor Ignatyev wrote:
>>>
>>> http://cr.openjdk.java.net/~iignaty
ping?
-- Igor
> On Jun 27, 2019, at 3:25 PM, Igor Ignatyev wrote:
>
> http://cr.openjdk.java.net/~iignatyev//8226910/webrev.00/index.html
>> 25 lines changed: 18 ins; 3 del; 4 mod;
>
> Hi all,
>
> could you please review this small patch which adds JTREG_RUN_PROB
http://cr.openjdk.java.net/~iignatyev//8226910/webrev.00/index.html
> 25 lines changed: 18 ins; 3 del; 4 mod;
Hi all,
could you please review this small patch which adds JTREG_RUN_PROBLEM_LISTS
options to run-test framework? when JTREG_RUN_PROBLEM_LISTS is set to true,
jtreg will use problem
gt; Robin
>
>> On 24 May 2019, at 23:33, Igor Ignatyev wrote:
>>
>> @Erik, Thanks!
>>
>> @hotspot (looking at Robin), can I get another review?
>>
>> -- Igor
>>
>>> On May 24, 2019, at 8:28 AM, Erik Joelsson wrote:
>>>
>
@Erik, Thanks!
@hotspot (looking at Robin), can I get another review?
-- Igor
> On May 24, 2019, at 8:28 AM, Erik Joelsson wrote:
>
> Thanks, looks good!
>
> /Erik
>
> On 2019-05-23 19:07, Igor Ignatyev wrote:
>> Hi Erik,
>>
>> thanks for your revie
http://cr.openjdk.java.net/~iignatyev//8222414/webrev.01
> 21638 lines changed: 21628 ins; 0 del; 10 mod;
Hi all,
could you please review this patch which makes mocking framework from google
test available for hotspot tests?
JBS: https://bugs.openjdk.java.net/browse/JDK-8222414
testing: tier1
> done unnecessarily. I would recommend explicitly setting the
> default_make_targets (which would be product-bundles and test-bundles) for
> the new *-gcov profiles.
>
> On lines 795, 804 and 812 you seem to have left commented out code that
> should probably be removed.
&g
all
hotspot tests.
[1] https://bugs.openjdk.java.net/browse/JDK-8219408
<https://bugs.openjdk.java.net/browse/JDK-8219408>
[2] https://bugs.openjdk.java.net/browse/JDK-8219140
<https://bugs.openjdk.java.net/browse/JDK-8219140>
Thanks,
-- Igor
> On Feb 19, 2019, at 5:06 PM, Ig
ionArgs=true in 8219254.
Thanks,
-- Igor
> On Feb 19, 2019, at 5:49 PM, Joseph D. Darcy wrote:
>
> Hello,
>
> On 2/19/2019 5:06 PM, Igor Ignatyev wrote:
>> Hi Erik,
>>
>> thanks for your review.
>>
>> we can't just bump the required version as it can
http://cr.openjdk.java.net/~iignatyev//8219395/webrev.00/index.html
> 65 lines changed: 59 ins; 0 del; 6 mod;
Hi all,
could you please review the patch which makes it easy to run tests on the
builds w/ native-code-coverage enabled? to do so the patch
- sets GCOV_PREFIX env. variable, so .gcda
e:
>
> Looks good.
>
> Do we need to also bump the required version in the TEST.ROOT files?
>
> /Erik
>
> On 2019-02-19 16:34, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8219132/webrev.00/index.html
>>> 1 line changed: 0 ins; 0 del; 1 mod;
http://cr.openjdk.java.net/~iignatyev//8219132/webrev.00/index.html
> 1 line changed: 0 ins; 0 del; 1 mod;
Hi all,
could you please review this one-liner which switch jtreg version to
jtreg4.2-b14?
webrev: http://cr.openjdk.java.net/~iignatyev//8219132/webrev.00/index.html
JBS:
thanks Erik, pushed.
y, this means exactly that.
-- Igor
> On Feb 19, 2019, at 12:35 PM, Erik Joelsson wrote:
>
> Looks good.
>
> Does this mean it works on Macos?
>
> /Erik
>
> On 2019-02-19 11:46, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~ii
http://cr.openjdk.java.net/~iignatyev//8219391/webrev.00
> 21 lines changed: 3 ins; 0 del; 18 mod;
Hi all,
could you please review this small and trivial patch which allows usage of
--enable-native-coverage configure option w/ clang devkit?
> llvm/clang supports gcov in the same way gcc does,
~erikj/8217613/webrev.02/index.html
>
> Verified with local test using TEST_OPTS=AOT_MODULES=java.base on Macosx,
> Linux and Windows, as well as mach5 run of the same.
>
> /Erik
>
> On 2019-01-23 15:55, Igor Ignatyev wrote:
>> so far it has affected only my local runs, so
so far it has affected only my local runs, so we are in no hurry to get this
fixed ;) you can work on a better fix, I, meanwhile, will apply your patch to
my local ws as a workaround.
-- Igor
> On Jan 23, 2019, at 3:10 PM, Erik Joelsson wrote:
>
> On 2019-01-23 13:38, Igor Ignat
Hi Erik,
I don't like that it's based on the assumption that ld and clang/gcc are in the
same directory, but this assumption seems to be always true for now. so unless
there is an easy way to get ld path, I'm fine w/ this fix.
-- Igor
> On Jan 23, 2019, at 1:18 PM, Vladimir Kozlov
> wrote:
Hi Vladimir,
overall your fix looks reasonable, but w/ it we can get unintentionally
disabled features (b/c grep doesn't do full word match). although this problem
wasn't really introduced by your fix, I think it's be better to fix it as a
part of your patch. I see two possible solutions:
-
_TESTS += failure-handler make
>
>
>
> On Nov 2, 2018, at 1:27 AM, Magnus Ihse Bursie
> wrote:
>
>
> On 2018-11-02 00:37, Igor Ignatyev wrote:
>> on a second though, removing these macros isn't that big, here is an
>> incremental web
ed due to
rebasing.
Erik, could you please re-review build changes?
http://cr.openjdk.java.net/~iignatyev//8213058/webrev.01/
<http://cr.openjdk.java.net/~iignatyev//8213058/webrev.01/> is the whole webrev.
Thanks,
-- Igor
> On Nov 1, 2018, at 4:23 PM, Igor Ignatyev wrote
t; all uses should just be deleted ... unless you plan on adding some other form
> of logging for this?
>
> Thanks,
> David
>
> On 2/11/2018 7:15 AM, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8213058/webrev.00/index.html
>>> 174 lines changed: 0 in
http://cr.openjdk.java.net/~iignatyev//8213058/webrev.00/index.html
> 174 lines changed: 0 ins; 170 del; 4 mod;
Hi all,
could you please review this small clean up which removes
ExecuteInternalVMTests and VerboseInternalVMTests flags and related make
targets and tests?
8177708[1-3] is to
Hi Magnus,
herein I will be talking only about 1st two warnings.
although your analyze is correct, it doesn't take into account the fact that
the warnings report situations that can't happen in current codebase, and gcc
doesn't report them in our "regular" builds b/c it can proof that
- in
Hi,
my claim was based on the warnings which we were getting when we just
introduced code coverage builds in JDK 9, e.g. 8130790[1] (clobbered warning in
libt2k). these warnings haven't been seen w/o code coverage enabled, and
enabling coverage changes code path, so I don't think we should
Hi Erik,
thanks for your review!
-- Igor
> On Aug 28, 2018, at 9:01 AM, Erik Joelsson wrote:
>
> Hello,
>
> I have nothing to add in addition to Magnus' comments. If that is fixed, this
> looks good from a build point of view.
>
> /Erik
>
>
> On 2018
st leads to big
> reshufflings whenever a command line changes, with little gain in
> readability. Instead, just indent the line following the \ with four more
> spaces (and no tabs!). (See
> http://openjdk.java.net/groups/build/doc/code-conventions.html)
sure thing, I'll remove all
gt; now looks like we have a new pattern of source files/directories that turns
>> into native libraries, and we could of course create a new macro that
>> automatically generates compilation setups for them as well (given that file
>> or directory names makes it possible to autom
happens, so I'd be happy to see us tackle it in a second/third step.
>
> So looks good to me and thanks for doing it!
> Jc
>
> On Tue, Aug 21, 2018 at 9:58 PM Igor Ignatyev <mailto:igor.ignat...@oracle.com>> wrote:
> Hi David,
>
> thanks for looking at the webre
Hi David,
thanks for looking at the webrev and all your comments. my answers are inlined.
enjoy your vacation!
-- Igor
> On Aug 21, 2018, at 9:28 PM, David Holmes wrote:
>
> Hi Igor,
>
> On 22/08/2018 9:04 AM, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignaty
http://cr.openjdk.java.net/~iignatyev//8209611/webrev.02/index.html
<http://cr.openjdk.java.net/~iignatyev//8209611/webrev.02/index.html> is a new
version of patch, which moves only vmTestbase tests.
Thanks,
-- Igor
> On Aug 20, 2018, at 11:07 PM, Igor Ignatyev wrote:
>
>
mk.
Cheers,
-- Igor
>
> Thanks,
> David
>
>> Thanks,
>> — Igor
>> On Aug 20, 2018, at 6:43 PM, David Holmes > <mailto:david.hol...@oracle.com>> wrote:
>>> Hi Igor,
>>>
>>> On 21/08/2018 8:59 AM, Igor Ignatyev wrote:
>>>
http://cr.openjdk.java.net/~iignatyev//8209611/webrev.01/index.html
> 11160 lines changed: 879 ins; 61 del; 10220 mod;
Hi all,
could you please review the patch which moves all hotspot native test code to
C++? this will guarantee that we always use C++ compilers for them (as an
opposite to
> On Aug 1, 2018, at 10:33 PM, David Holmes wrote:
>
> Hi Igor,
>
> On 2/08/2018 5:42 AM, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev/8208647/webrev.00/index.html
>>> 5 lines changed: 0 ins; 0 del; 5 mod;
>> Hi all,
>> could you p
http://cr.openjdk.java.net/~iignatyev/8208647/webrev.00/index.html
> 5 lines changed: 0 ins; 0 del; 5 mod;
Hi all,
could you please review this small fix which switches jtreg to the latest
available build? due to changes in javatest API, failure_handler had to be
slightly updated.
webrev:
looks good to me.
-- Igor
> On Jul 24, 2018, at 3:48 PM, Alexandre (Shura) Iline
> wrote:
>
> Hi,
>
> Could you please tale a quick look on this simple fix?
>
> diff --git a/test/jtreg-ext/requires/VMProps.java
> b/test/jtreg-ext/requires/VMProps.java
> ---
ou were able re-test it to verify that it actually
> works. Not like last time.
>
> Thanks,
> Vladimir
>
> On 7/5/18 1:02 PM, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8206429/webrev.00/index.html
>>> 243 lines changed: 0 ins; 124 del; 1
http://cr.openjdk.java.net/~iignatyev//8206429/webrev.00/index.html
> 243 lines changed: 0 ins; 124 del; 119 mod;
Hi all,
could you please review this redo of 8202561? 8202561 was backed out b/c our CI
infra didn't support multiple test group files. now such configurations are
supported, so
1 - 100 of 134 matches
Mail list logo
