Re: RFR: 8286744: failure_handler: dmesg command on macos fails to collect data due to permission issues [v2]

On Fri, 13 May 2022 14:39:44 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to fix the failure >> handler command `dmesg` on macOS? >> >> As noted in the JBS issue, the command currently fails with permission >> error. The commit in this PR uses `sudo` as

Integrated: 8268626: Remove native pre-jdk9 support for jtreg failure handler

On Fri, 11 Jun 2021 18:44:38 GMT, Leonid Mesnik wrote: > jtreg failure handler uses native lib to implement getPid for preJDK9. > Currently. it is not needed and might be removed. This pull request has now been integrated. Changeset: 2e70bc35 Author:Leonid Mesnik URL:

RFR: 8268626: Remove native pre-jdk9 support for jtreg failure handler

jtreg failure handler uses native lib to implement getPid for preJDK9. Currently. it is not needed and might be removed. - Commit messages: - native lib support removed. Changes: https://git.openjdk.java.net/jdk/pull/4476/files Webrev:

Re: RFR: 8254862: lldb in devkit doesn't work

On Fri, 16 Oct 2020 20:34:15 GMT, Erik Joelsson wrote: > This patch adds the lldb framework to the macosx devkit to make it possible > to run the lldb debugger. Marked as reviewed by lmesnik (Committer). - PR: https://git.openjdk.java.net/jdk/pull/711

Re: RFR: 8239026: Support non-maven artifacts by JibArtifactManager

Thank you for review. Leonid On 2/18/20 8:42 AM, Erik Joelsson wrote: Looks good. /Erik On 2020-02-13 17:44, Leonid Mesnik wrote: Hi Could you please review following fix which extend JibArtifactManager to support download and installation of artifacts with layout different from maven

RFR: 8239026: Support non-maven artifacts by JibArtifactManager

Hi Could you please review following fix which extend JibArtifactManager to support download and installation of artifacts with layout different from maven style. It is planned that user provide name and properties to resolve layout using default or jib manager. There are no tests which use

Re: RFR: 8230781: Add JTREG_FAILURE_HANDLER_TIMEOUT to control timeout handler timeout

Thank you > On Sep 10, 2019, at 6:17 AM, Erik Joelsson wrote: > > Looks good. > > /Erik > > On 2019-09-09 17:03, Leonid Mesnik wrote: >> Hi >> >> Could you please review following fix which add >> JTREG_FAILURE_HANDLER_TIMEOUT option to customize

Re: RFR: 8230781: Add JTREG_FAILURE_HANDLER_TIMEOUT to control timeout handler timeout

> On Sep 9, 2019, at 5:55 PM, David Holmes wrote: > > On 10/09/2019 10:43 am, Leonid Mesnik wrote: >> Hi >> On 9/9/19 5:12 PM, David Holmes wrote: >>> Hi Leonid, >>> >>> On 10/09/2019 10:03 am, Leonid Mesnik wrote: >>>> H

Re: RFR: 8230781: Add JTREG_FAILURE_HANDLER_TIMEOUT to control timeout handler timeout

Hi On 9/9/19 5:12 PM, David Holmes wrote: Hi Leonid, On 10/09/2019 10:03 am, Leonid Mesnik wrote: Hi Could you please review following fix which add JTREG_FAILURE_HANDLER_TIMEOUT option to customize timeout handler timeout. webrev: http://cr.openjdk.java.net/~lmesnik/8230781/webrev.00

RFR: 8230781: Add JTREG_FAILURE_HANDLER_TIMEOUT to control timeout handler timeout

Hi Could you please review following fix which add JTREG_FAILURE_HANDLER_TIMEOUT option to customize timeout handler timeout. webrev: http://cr.openjdk.java.net/~lmesnik/8230781/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8230781 I verified fix locally and with mach5. Leonid

Re: RFR (round 5), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

Hi The shared tests changes looks good for me. Thank you for fixing and testing different combinations. Leonid > On Dec 3, 2018, at 11:10 PM, Roman Kennke wrote: > > Round 5 of Shenandoah review includes: > - A fix for the @requires tag in TestFullGCCountTest.java. It should be > correct

Re: RFR (round 1), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

Hi Thank you for your fixes and additional testing. I'll check new version  in the round-2. Leonid On 11/28/18 10:36 AM, Roman Kennke wrote: Hi Leonid, I looked at the tests changes only. It seems that  a some tests might start failing if JDK built without Shenandoah GC. Also some test

Re: RFR (round 1), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

Hi I looked at the tests changes only. It seems that  a some tests might start failing if JDK built without Shenandoah GC. Also some test are not going to be selected as expected. Unfortunately logic of '@requires' and @run in jtreg tests doesn't always work well for specific cases of

Re: 8209520: Build fails when native code coverage is enabled

;>> >>> If this is deemed unacceptable, it's better to disable those few warnings >>> specifically, for the files/libraries they occur in. >>> >> If the claim on the warnings produced by GCC while generating code coverage >> is false, then I certainly agree that the wa

Re: 8209520: Build fails when native code coverage is enabled

;> >> macroassembler changes are good. >> >> Thanks, >> Vladimir >> >>> On 8/23/18 1:51 PM, Leonid Mesnik wrote: >>> Hi >>> Could you please review following fix which fix code so gcc doesn't >>> complain when JDK is build with enabl

Re: 8199271: [TESTBUG] open source VM testbase stress tests

Thank you for review. Leonid > On May 16, 2018, at 8:48 PM, serguei.spit...@oracle.com wrote: > > Hi Leonid, > > Looks good to me too. > > Thanks, > Serguei > > > On 5/14/18 14:04, Leonid Mesnik wrote: >> Misha >> >> Thank you for r

Re: 8199271: [TESTBUG] open source VM testbase stress tests

Thank you for review. Leonid > On May 8, 2018, at 2:41 PM, Erik Joelsson <erik.joels...@oracle.com> wrote: > > Build changes look good. > > /Erik > > > On 2018-05-08 14:23, Leonid Mesnik wrote: >> Hi >> >> Please review this change open so

8199271: [TESTBUG] open source VM testbase stress tests

Hi Please review this change open sourcing vm testbase stress tests. These tests have been developed a long time ago for internal test harness and don't looks very nice now. They are open sourced with minimal changes only. The long term plan is to review and improve them moving out of

Re: RFR: 8166790: Add stress test GCBasher

Very nice. Thank you for implementing this. Leonid On 04.10.2016 12:42, Erik Helin wrote: On 2016-09-30, Leonid Mesnik wrote: Hi I think that it would be better to split this test into 4 tests. Currently this test is going to be skipped if any specific GCare set. Or it could even fail

Re: RFR(S): 8154209: Remove client VM from default JIB profile on windows-x86 and linux-x86

Thank you for review. Leonid On 07.06.2016 12:32, David Holmes wrote: On 7/06/2016 7:03 PM, Leonid Mesnik wrote: Hi The testset hotspot is not affected by this change. It run c2 only on windows/linux-x86. Right -sorry - I forgot we already ripped out client testing in 8153071. All good

Re: RFR(S): 8154209: Remove client VM from default JIB profile on windows-x86 and linux-x86

Hi The testset hotspot is not affected by this change. It run c2 only on windows/linux-x86. I verified that default target and pit has same results and similar time as before my fix. Leonid On 27.05.2016 01:09, David Holmes wrote: Hi Leonid, On 27/05/2016 5:00 AM, Leonid Mesnik wrote

Re: RFR(S): 8154209: Remove client VM from default JIB profile on windows-x86 and linux-x86

ux-x86 and windows-x86 profiles. The linux-x86 currently includes minimal and server VM. The server VM is used by default. The test targets has been updated to test server for this profiles. Leonid On 21.04.2016 09:23, Leonid Mesnik wrote: Mikael On 21.04.2016 00:41, Mikael Vidstedt wrote: Good

Re: RFR(S): 8155950: Add minimal VM in JIB profile on linux-x86

Thank you for review. Leonid On 05.05.2016 00:42, David Holmes wrote: On 5/05/2016 12:10 AM, Leonid Mesnik wrote: The hotspot changes are fixed separately and the final fix is only changes in the root. It remains the same. http://cr.openjdk.java.net/~lmesnik/8155950/webrev.00/root/ <h

Re: RFR(S): 8155950: Add minimal VM in JIB profile on linux-x86

n 4/05/2016 7:01 PM, Leonid Mesnik wrote: David On 04.05.2016 11:40, David Holmes wrote: On 4/05/2016 4:43 PM, Leonid Mesnik wrote: Please review this small change which adds minimal VM as a part of default JIB profile on linux-x86. The fix also include quick workaround for bug JDK-8155946

Re: RFR(S): 8155950: Add minimal VM in JIB profile on linux-x86

Hi On 04.05.2016 13:23, David Holmes wrote: On 4/05/2016 7:01 PM, Leonid Mesnik wrote: David On 04.05.2016 11:40, David Holmes wrote: On 4/05/2016 4:43 PM, Leonid Mesnik wrote: Please review this small change which adds minimal VM as a part of default JIB profile on linux-x86. The fix also

Re: RFR(S): 8155950: Add minimal VM in JIB profile on linux-x86

Thank you for review. I will separate gc fix from this commit and push only build changes here . Leonid On 04.05.2016 11:15, Erik Joelsson wrote: Jib change looks good to me. /Erik On 2016-05-04 08:43, Leonid Mesnik wrote: Please review this small change which adds minimal VM as a part

Re: RFR(S): 8155950: Add minimal VM in JIB profile on linux-x86

David On 04.05.2016 11:40, David Holmes wrote: On 4/05/2016 4:43 PM, Leonid Mesnik wrote: Please review this small change which adds minimal VM as a part of default JIB profile on linux-x86. The fix also include quick workaround for bug JDK-8155946 <https://bugs.openjdk.java.net/browse/

RFR(S): 8155950: Add minimal VM in JIB profile on linux-x86

Please review this small change which adds minimal VM as a part of default JIB profile on linux-x86. The fix also include quick workaround for bug JDK-8155946 . Bug: https://bugs.openjdk.java.net/browse/JDK-8155950 Webrev (top):

Re: RFR(S): 8154209: Remove client VM from default JIB profile on windows-x86 and linux-x86

://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02/hotspot/webrev/ Incremental webrevs (from webrev.01): top: http://cr.openjdk.java.net/~mikael/webrevs/8154209/webrev.02.incr/webrev/ hotspot: N/A (same as webrev.01) Cheers, Mikael On 4/18/2016 12:52 AM, Leonid Mesnik wrote: Hi Sho

Re: RFR(S): 8154209: Remove client VM from default JIB profile on windows-x86 and linux-x86

Hi Shouldn't be jprt targets in jprt.properties updates to stop using client also? http://hg.openjdk.java.net/jdk9/hs/file/645c48292130/make/jprt.properties line 206 - 214 # Test target list (no fastdebug & limited c2 testing) my.test.target.set= \