Re: RFR [9] Modular Source Code

2014-08-28 Thread Phil Race
* All of the awt-related directories (libawt_* and common) include an unnecessary extra layer, the "sun" directory. It is not needed anymore, Let's *not* do that. It also affects the destination package. Remember sun.* is the protected top-level package .. and people won't always be running in j

Re: incremental builds in the new JDK9 modular build

2014-08-20 Thread Phil Race
-x86_64-normal-server-release/jdk/modules/jdk.jconsole/_the.jdk.jconsole_batch] Error 3 make[2]: *** [jdk.jconsole-java] Error 2 make[1]: *** [main-wrapper] Error 2 make: *** [default] Error 2 -phil. On 08/20/2014 02:37 PM, Mandy Chung wrote: On 8/20/2014 1:26 PM, Phil Race wrote: I understoo

incremental builds in the new JDK9 modular build

2014-08-20 Thread Phil Race
I understood we now build individual modules so when I touched one java source file in the desktop module I expected to see only that one module rebuilt but I see this :- Compiling 2787 files for java.desktop Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:dep

Re: RFR [9] Modular Source Code

2014-08-19 Thread Phil Race
On a related note I am scratching my head about why some files destined to be compiled into libawt or libawt_xawt go into a directory called 'common'. Eg OpenGL sources are in common but aren't common to all libs or even to all awt libs, since they would go into libawt on windows and libawt_xawt o

Re: [8u20] RFR: 8038027: DTDBuilder should be run in headless mode

2014-07-17 Thread Phil Race
Looks Ok to me. -phil. On 7/17/2014 12:43 PM, David DeHaven wrote: Ping? Can a build-dev Reviewer approve this? -DrD- Please review my trivial backport of JDK-8038027. The actual change is identical to 9, the difference is the surrounding $(JAVA) is $(JAVA_SMALL) in JDK 9. JBS Issue: http

Re: RFR: JDK-8043160: JDK 9 Build failure in accessbridge

2014-06-02 Thread Phil Race
Looks good to me. This has been a constant pain so I am very happy to see it fixed -phil. On 6/2/2014 4:58 AM, Erik Joelsson wrote: A friendly reminder that this still needs to be reviewed. /Erik On 2014-05-23 12:31, Erik Joelsson wrote: Hello, This patch attempts to fix a build problem in

Re: [OpenJDK 2D-Dev] RFR: Allow using the system libjpeg

2014-05-22 Thread Phil Race
BTW .. I just realised I haven't seen a bug ID in this thread. Does one already exist ? -phil. On 5/21/14 5:49 PM, Omair Majid wrote: * Andrew Hughes [2014-05-21 20:23]: - Original Message - * Andrew Hughes [2014-05-21 12:22]: I'm not keen on the hardcoding of '-ljpeg' + LIBJPEG_

Re: [OpenJDK 2D-Dev] RFR: Allow using the system libjpeg

2014-05-21 Thread Phil Race
On 05/21/2014 08:06 AM, Omair Majid wrote: I will need to push that closed generated-configure.sh afterwards however so that closed builds don't break. Anything I need to do to ensure the pushes are co-ordinated correctly? Just make sure I notice the push and I'll fix ASAP .. -phil.

Re: [OpenJDK 2D-Dev] RFR: Allow using the system libjpeg

2014-05-20 Thread Phil Race
enerated-configure.sh afterwards however so that closed builds don't break. -phil. On 05/20/2014 10:18 AM, Phil Race wrote: I'm going to apply the patch and run it through open + closed builds cross-platforms .. -phil.. On 5/20/2014 10:15 AM, Anthony Petrov wrote: Thanks for the update, Om

Re: [OpenJDK 2D-Dev] RFR: Allow using the system libjpeg

2014-05-20 Thread Phil Race
I'm going to apply the patch and run it through open + closed builds cross-platforms .. -phil.. On 5/20/2014 10:15 AM, Anthony Petrov wrote: Thanks for the update, Omair. The fix looks good to me now. -- best regards, Anthony On 5/20/2014 9:11 PM, Omair Majid wrote: Hi, Updated webrevs: ht

Re: JDK9 build failure on Windows : javac OutOfMemoryError

2014-05-08 Thread Phil Race
As for how much head is actually needed, I haven't dug into it, but just doing a simple javac -XmxXXXM Foo.java, I could only get up to about 1500M. I wasn't able to build on my laptop, but my lab machine worked just fine, so it's probably close to the border. Brad On 3/12

Re: [OpenJDK 2D-Dev] RFR: Allow using a system-installed lcms2

2014-04-29 Thread Phil Race
I've run the patch through jprt and it builds fine (in default mode) on closed builds on all OS versions we build on .. so looks good. -phil. On 4/28/2014 8:27 AM, Omair Majid wrote: Hi Phil, * Phil Race [2014-03-19 12:41]: On 3/17/2014 4:27 AM, Magnus Ihse Bursie wrote: I don't

Re: CFV: Nomination of Tim Bell as the new Build Group Lead

2014-04-10 Thread Phil Race
Vote: yes -phil.

Re: [OpenJDK 2D-Dev] RFR: Allow using a system-installed lcms2

2014-03-19 Thread Phil Race
On 3/17/2014 4:27 AM, Magnus Ihse Bursie wrote: While we generally support moving files to a proper location, if this move is causing trouble for Phil and the 2d team, we think it can be an acceptable exception this time to just single out the LCMS.c file. (This can be achieved by setting INC

Re: JDK9 build failure on Windows : javac OutOfMemoryError

2014-03-12 Thread Phil Race
tmore had similar issues last week. The problem in his case was that the 32 bit VM couldn't get a large enough heap. Switching to a 64 bit boot jdk resolved the issue for him. Mike On Mar 12 2014, at 14:45 , Phil Race wrote: I'm on Windows 7 64 bit and I've quit every app e

JDK9 build failure on Windows : javac OutOfMemoryError

2014-03-12 Thread Phil Race
I'm on Windows 7 64 bit and I've quit every app except for my console windows yet I still get this error below. How can I get past this ? -phil. -- ## Starting jdk Compiling 9635 files for BUILD_JDK The system is out of resources. Consult the following stack trace for details. java.

Re: jdk9 dev builds broken on all Solaris configs after fix "8036611: Cleanup of handling of properties..."

2014-03-07 Thread Phil Race
I filed https://bugs.openjdk.java.net/browse/JDK-8036948 -phil. On 3/7/2014 12:41 PM, Phil Race wrote: After the change below all my Solaris builds are failing. http://mail.openjdk.java.net/pipermail/jdk9-dev-changes/2014-March/000524.html Its failing at least on the JPRT sfbay server

jdk9 dev builds broken on all Solaris configs after fix "8036611: Cleanup of handling of properties..."

2014-03-07 Thread Phil Race
After the change below all my Solaris builds are failing. http://mail.openjdk.java.net/pipermail/jdk9-dev-changes/2014-March/000524.html Its failing at least on the JPRT sfbay server .. Eg :- ...build/solaris-x86_64-normal-server-release/jdk/classes/com/sun/rowset/RowSetResourceBundle_zh_HK.prope

Re: [OpenJDK 2D-Dev] RFR: Allow using a system-installed lcms2

2014-02-28 Thread Phil Race
The moving of most of these files will cause me some significant pain. I am not convinced why its necessary. And if done wrong we lose the history. Even if done *right* the history is harder to get at. Plus the jigsaw people are very likely to move this code *again*. I need to look at this more, b

Re: [OpenJDK 2D-Dev] RFR: JDK-8035821: Move psfont properties files from src/share/classes to src/share/lib

2014-02-27 Thread Phil Race
ages/cursors/motif_MoveDrop32x32.gif lib/images/cursors/motif_MoveNoDrop32x32.gif lib/psfont.properties.ja lib/psfontj2d.properties lib/sound.properties Mandy [1] http://hg.openjdk.java.net/jdk9/dev/jdk/file/tip/src/share/classes/sun/print/PSPrinterJob.java On 2/27/14 12:32 PM, Phil Race wrote: Magnus, I

Re: [OpenJDK 2D-Dev] RFR: JDK-8035821: Move psfont properties files from src/share/classes to src/share/lib

2014-02-27 Thread Phil Race
has turned into a blocker to handle all those misplaced files when we need to reshuffle all source code. So, to summarize: * The code using those files will not be affected. * This is needed for the jigsaw project. With that information, I hope you can reconsider your position. /Magnus 26

Re: RFR: JDK-8035821: Move psfont properties files from src/share/classes to src/share/lib

2014-02-26 Thread Phil Race
/2014 10:46 AM, Phil Race wrote: Adding 2d-dev as 2d owns this file and might like to know where it went. My 2p : the files are however interpreted solely by the code with which it is co-located. So unless the build will come crashing down around us, I'd very much prefer that these files st

Re: RFR: JDK-8035821: Move psfont properties files from src/share/classes to src/share/lib

2014-02-26 Thread Phil Race
Adding 2d-dev as 2d owns this file and might like to know where it went. My 2p : the files are however interpreted solely by the code with which it is co-located. So unless the build will come crashing down around us, I'd very much prefer that these files stay exactly where I put them ... -ph

Re: Open JDK8 fast-debug : crashes on Solaris Sparc T4 machines

2014-02-12 Thread Phil Race
The README-builds.html file specifies SS12 Update 1 + a bunch of patches There's probably a good reason for all of that and new architectures often need compiler fixes, so does the same occur if you upgrade and patch ? -phil. On 2/12/2014 7:48 AM, Baesken, Matthias wrote: I noticed when buildi

Re: [OpenJDK 2D-Dev] Unexpected Mac X11 dependency

2014-01-13 Thread Phil Race
This is OK for your own build but no more than that. Users won't have X11 installed and even if they did I am not sure it'll work. So you need to be able to build with a freetype that can be relocated and bundled as part of your distribution. The one from the OS X X11 doesn't work for that. A

Re: CFV: New Build Group Member: Magnus Ihse Bursie

2013-12-03 Thread Phil Race
Vote: yes -phil. On 12/3/2013 2:53 AM, Erik Joelsson wrote: I hereby nominate Magnus Ihse Bursie to Membership in the OpenJDK Build Group.

Re: J2SE est mort, vive Java SE!

2013-12-02 Thread Phil Race
On 12/2/2013 1:28 PM, Sean Mullan wrote: 'j' sounds reasonable to me. However, I'm not really sure if the 'j2' here is from 'j2se', 'j2re', or 'j2sdk', I would have to ask some developers who did the original implementation. It could have been simply to help avoid naming clashes with other

Re: Removal of the old build system, partial and preliminary review (part 3)

2013-11-04 Thread Phil Race
I had this problem recently and I don't think you need restore the files - just the directory. I used hg mv to relocate the files but because *all* files were moved out of the directory so hg deleted the directory. It was sufficient to mkdir again for webrev to properly recognise the files as

Re: [OpenJDK 2D-Dev] RFR: 8008022: Upgrade Direct X SDK used to build JDK

2013-09-09 Thread Phil Race
Seems fine to me given that the versions are identical across all SDKs we might use. Also since this simply removes a required build component, there should be no 'flag day' where people need to be given notice to install a new build component. I think you said that you didn't have the standalon

Re: win7 jdk 8 build : fork: retry: Resource temporarily unavailable

2013-08-22 Thread Phil Race
en it made sense because I had done some updates and I had trouble running cygwin (the shell I think). Here I've not done anything like that and I cured it by quitting a few apps. I think I need to wait for the next time it occurs to try this to see if it really will help. -phil. /Erik On 20

win7 jdk 8 build : fork: retry: Resource temporarily unavailable

2013-08-21 Thread Phil Race
My Win 7 x 64 showed it had approx 2GB (out of 6GB) memory free when I got this message doing an incremental build :- ## Starting langtools /cygdrive/c/jdks/jdk8_2d/common/bin/logger.sh: fork: retry: Resource temporarily unavailable /cygdrive/c/jdks/jdk8_2d/common/bin/logger.sh: fork: retry: Re

Re: jdk8 first build attempt - failed

2013-07-29 Thread Phil Race
On 7/29/2013 10:25 AM, Pete Brunet wrote: Thanks Phil, I found build\windows-x86-normal-server-fastdebug\corba\gensrc and in that dir is one file _the_idls.d with one line IDLS_ARE_CREATED=yes Pete Hmm .. in my case that is there but there are also com & org directories with in all about 3Mb

Re: jdk8 first build attempt - failed

2013-07-29 Thread Phil Race
Its generated from the IDL file by the idl compiler. Should be under build/macosx.../corba/gensrc/ -phil. On 7/29/2013 8:01 AM, Pete Brunet wrote: I don't see BindingListHolder.java in the repo at hg.openjdk.java.net/jdk8/awt/corba/file/a013024b0747/src/share/classes/org/omg/CosNaming Is it su

Re: jdk 8 building just jdk

2013-07-26 Thread Phil Race
Flogging a dead horse here .. > it shouldn't really be necessary to do partial builds any more (it was way too fragile in the past with the old build) I whole heartedly disagree. I've said it before and I say it again. I do not want to build hotspot or anything else besides JDK I do not want t

Re: RFR: 8010385: build with LOG=trace broken on mac

2013-06-27 Thread Phil Race
Looks fine to me too ... I wish I'd seen this 30 seconds ago. I literally just hit this bug on mac and filed a dup (which I'll close) and then saw this RFR. BTW What I'm trying to do is see the gcc compiler options that are actually used on Mac. debug and info options didn't reveal anything. What

Why does the Windows build look for Solaris source files ?

2013-06-06 Thread Phil Race
I created a stripped down platform-specific set of sources for the Windows build and although it doesn't look like it was fatal I see the following :- ## Starting jdk /usr/bin/find: `/cygdrive/c/jdks/jdk8_2d/jdk/src/solaris/classes': No such file or directory /usr/bin/find: `/cygdrive/c/jdks/jdk

Re: Add optional support for using the system libicu

2013-06-05 Thread Phil Race
3 1:40 PM, Alan Bateman wrote: On 05/06/2013 19:02, Phil Race wrote: Yes, please support the old build system. Is this really necessary? The old build is a tax and we really need it to die. In this case, it's a new feature and I don't see any point in anyone spending time adding this

Re: Add optional support for using the system libicu

2013-06-05 Thread Phil Race
Omair, Since this entirely affects a 2D component, please include 2d-dev in this discussion. I would have been 'surprised' to see this change if I hadn't just spotted this thread. And I believe this change should be integrated via the 2D forest. Yes, please support the old build system. I am no

Re: Compiling 10459 java files when 1 is all that is needed.

2013-05-20 Thread Phil Race
That helps a *lot* ! Only 84 files being compiled for my case. -phil. On 5/20/2013 2:44 PM, Sergey Bylokhov wrote: Hi, Phil. You can try to use filter option: For example: make JDK_FILTER=sun/java2d/loops On 21.05.2013 0:04, Phil Race wrote: I am getting very frustrated trying to do some

Re: Compiling 10459 java files when 1 is all that is needed.

2013-05-20 Thread Phil Race
Jon, That should make it faster but does it fix what seems like non-existent dependency analysis in the build ? -phil. On 5/20/2013 1:07 PM, Jonathan Gibbons wrote: On 05/20/2013 01:04 PM, Phil Race wrote: I am getting very frustrated trying to do some simple work on my Mac using JDK 8. I

Compiling 10459 java files when 1 is all that is needed.

2013-05-20 Thread Phil Race
I am getting very frustrated trying to do some simple work on my Mac using JDK 8. I touch *one* .java source file and I have to wait > 4 minutes for the build system which goes off and compiles everything. I have an SSD and i7 chip so I don't want to imagine what it would be like on a slower syste

Re: Why is CUPS required?

2013-05-20 Thread Phil Race
CUPS is used by the Java 2D printing APIs on Solaris & Linux and similar. If you want to build an implementation of "Java SE" on a platform where printing is supported and you do not enable printing, then you will fail the JCK. The suggestion that servers don't print is odd. They sometimes do,

Re: Preserving changeset authorship (was Re: PING: [PATCH] Enable debug info on all libraries for OpenJDK builds)

2013-05-09 Thread Phil Race
> (Yes, this is one of those rare cases in which a sponsor should use the -u option.) I'd hazard a guess that there are number of people who overlook this option in part because they don't realise you can do hg commit -u ... I was kind of surprised myself when I first learned to do this as

Re: A couple of questions about the new build system

2013-04-08 Thread Phil Race
dency files. The visual studio compiler doesn't have this feature. There are ways this can be worked around. I've created 8011687 to track this issue. /Erik On 2013-04-02 10:16, Erik Joelsson wrote: On 2013-03-29 00:00, Phil Race wrote: If you touch a header fie, the build is supposed to n

Re: A couple of questions about the new build system

2013-03-28 Thread Phil Race
2013 02:29 PM, Phil Race wrote: 1. Why do we have both --with-cups and --with-cups-include ? All we use is the header files so the latter is what matters and I'm not sure which one the build system prefers if both are set. 2. In the old build I could do cd make/sun/font make clean

A couple of questions about the new build system

2013-03-28 Thread Phil Race
1. Why do we have both --with-cups and --with-cups-include ? All we use is the header files so the latter is what matters and I'm not sure which one the build system prefers if both are set. 2. In the old build I could do cd make/sun/font make clean make all Is there anything analagous

Re: Solaris jdk8 build failed due missed dependency: freetype2

2013-03-12 Thread Phil Race
Do you have the SUNWfreetype2 package installed ? -phil. On 3/12/2013 3:29 AM, mikhail cherkasov wrote: Hello all, Could you please advise where I can get freetype2 for Solaris? I'm looking for binaries for amd64/i386, I've tried to build it, but faced with the following error: gmake: ***

Re: Allow using a system-installed giflib

2013-03-08 Thread Phil Race
If I understand correctly, this removes the directory containing the JDK's copy of giflib sources from the set of locations to be compiled etc, and replaces it with just a link line pointer to use "libgif" which is then expected to be on the default linker path, ie in /usr/lib. I think this is fi

Re: current clone of jfx is crashing

2013-02-25 Thread Phil Race
> Using the jfxrt.jar from 7u15 works OK, but not the one built from the cloned repo. I don't know what Pete cloned .. but JavaFX is a mixture of native and Java, just like JDK and you can't mix and match the jar and the native any more than you could mix rt.jar from 7u13 and native libs from

Re: build JDK 7 Windows 7: make jdk fails building sounds

2013-02-12 Thread Phil Race
2d-dev *and* sound-dev I should say .. -phil. On 2/12/2013 5:09 PM, Phil Race wrote: I am not sure if you mean will it be "fixing" this. The JDK 8 new build system should not be making any changes to the choice of library or tools being used here or anywhere else without discussi

Re: build JDK 7 Windows 7: make jdk fails building sounds

2013-02-12 Thread Phil Race
ive on how stable-complete the JDK 8 build is or will be, especially for Windows? Randy -Original Message----- From: Phil Race [mailto:philip.r...@oracle.com] Sent: Tuesday, February 12, 2013 4:45 PM To: Randy Nielsen Cc: Kelly O'Hair; build-dev@openjdk.java.net Subject: Re: build JDK 7 Wind

Re: build JDK 7 Windows 7: make jdk fails building sounds

2013-02-12 Thread Phil Race
unately I can't redistribute this file, but it is available through MSDN. Regards, Randy -Original Message- From: Phil Race [mailto:philip.r...@oracle.com] Sent: Tuesday, February 12, 2013 11:42 AM To: Randy Nielsen Cc: Kelly O'Hair; build-dev@openjdk.java.net Subject: Re: build

Re: build JDK 7 Windows 7: make jdk fails building sounds

2013-02-12 Thread Phil Race
I think Microsoft may have recently removed this. Typing "summer 2004 direct x sdk" into google, the top hit is a link to the download location but it is no longer is a valid link. Obviously lots of people already have a copy but I'm not sure if they can redistribute it to you. We specified that

Re: building JDK6 - latest usable compiler

2013-02-07 Thread Phil Race
Yes you need VS2003. At this point your best bet to get it may be ebay :-) -phil. On 2/7/2013 12:18 PM, Pete Brunet wrote: Hi I have VS 2010 and need to build JDK6. Using my typical JDK7 set up with VS 2010 make sanity reports ../make/common/shared/Compiler-msvc.gmk:129 *** COMPILER_PATH cann

Re: Client VM for 64 bit linux

2012-12-27 Thread Phil Race
I am not sure why you need a chrooted install. You can run 32 bit JDK on 64 bit Linux. Its just that the distros make it a bit of a pain as you need to go and get the 32 bit X11 and other libs. -phil. On Thu, 27 Dec 2012 20:13:46 +0200, Phil Race wrote: I am fairly sure we do not want the bu

Re: Client VM for 64 bit linux

2012-12-27 Thread Phil Race
I am fairly sure we do not want the build system to spit out a 64 bit client VM by default. My recollection from many years ago is that the VM team and performance team determined that the 64 bit server VM was as good as, or better than the 64 bit client VM on all the metrics that mattered and t

Re: [OpenJDK 2D-Dev] Request for review : FreeType embedded in OSX packages

2012-10-17 Thread Phil Race
e java code available ? Le 17 oct. 2012 à 18:27, Phil Race a écrit : PS .. I could be misremembering or misunderstanding but the other obstacle I ran into when I looked at this (ages ago) was that the freetype I built was expecting to be installed in a specific location. I didn't think it

Re: [OpenJDK 2D-Dev] Request for review : FreeType embedded in OSX packages

2012-10-17 Thread Phil Race
eemed that the freetype.dylib was fussy about where it was placed. Could you also check that your build works and really loads *your* version of the lib - try using a Postscript Type 1 font via Font.createFont(), that should trigger it. -phil. On 10/17/12 9:18 AM, Phil Race wrote: On 10/17/12 1:

Re: Request for review : FreeType embedded in OSX packages

2012-10-17 Thread Phil Race
the Java2D team owns this part of the code. (I cc'd Phil Race). Ticket created : #2361569 Link to patches provided inside What number is that ? I think its just an incident. I will file a JIRA bug on this shortly .. but I had tried the patch yesterday and FWIW it doesn't seem to remo

Re: The future of partial builds

2012-09-10 Thread Phil Race
A huge step backwards. I don't want to have to clone or keep hotspot up to date and I prefer using the 'RE' builds of hotspot to any I would create. I have never found this fragile. Its worked well for over 10 years ... -phil. On 9/10/2012 8:36 AM, Jonathan Gibbons wrote: Having to compile hotsp

Re: Fwd: JDK build on Mountain Lion

2012-07-27 Thread Phil Race
I don't know why we build xawt on OS X - at least by default. We don't use X11 for UI in our JDK on Mac and I'm 99% sure its not getting tested. Building the XAWT toolkit on OS X perhaps should be an optional selection -phil. On 7/27/2012 10:48 AM, Kelly O'Hair wrote: Some interesting inform

Re: [OpenJDK 2D-Dev] Review: Removing GenerateNativeHeader where not needed

2012-07-09 Thread Phil Race
Fine by me. -phil. On 7/4/2012 5:32 AM, Anthony Petrov wrote: Looks good to me. Although most of the changes are in Java2D code, so I'm also CC'ing 2d-dev@ to take a look. -- best regards, Anthony On 7/3/2012 10:23 PM, Erik Joelsson wrote: The build infra project added the use of the annotat

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing

2012-05-29 Thread Phil Race
I have one concern It sounds like the option is new in gcc 4.4 : http://gcc.gnu.org/gcc-4.4/porting_to.html I am not sure you can assume that since .. http://hg.openjdk.java.net/jdk8/jdk8/raw-file/tip/README-builds.html#gcc " The GNU gcc compiler version should be 4.3 or newer." And I sugges

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing

2012-05-23 Thread Phil Race
On 5/23/2012 9:32 AM, Andrew Hughes wrote: - Original Message - I suppose the problem that some new version of GCC enables this option by default and we could run into a problem at run time if we don't disable it ? Yes, 4.4 to be precise. It's not particularly new; it came out on Apr

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing

2012-05-23 Thread Phil Race
at 17:01, Phil Race wrote: I suppose the problem that some new version of GCC enables this option by default and we could run into a problem at run time if we don't disable it ? But this patch would appear to disable it for the whole ICU library .. and any other C++ code in the .so whi

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing

2012-05-23 Thread Phil Race
I suppose the problem that some new version of GCC enables this option by default and we could run into a problem at run time if we don't disable it ? But this patch would appear to disable it for the whole ICU library .. and any other C++ code in the .so which I would have to suppose impacts t

Re: [OpenJDK 2D-Dev] Request for Review: Remove import of empty JNI header files

2012-04-25 Thread Phil Race
Looks fine. If its not a pain, 2d forest would probably be the most appropriate as 3/4 are 2D .. -phil. On 4/25/2012 8:27 AM, Chris Hegarty wrote: [ cc'ing awt-dev & 2d-dev ] The change looks fine Magnus, though it may be best to push through the awt or 2d forest. Members of these groups, cc

Re: Need reviewer, 7150324: Stop using drop bundles in jaxp

2012-03-02 Thread Phil Race
It looks OK to me but I'm not an ant expert. -phil. On 3/2/2012 12:57 PM, Kelly O'Hair wrote: 7150324: Stop using drop bundles in jaxp http://cr.openjdk.java.net/~ohair/openjdk8/infra-jaxp/webrev/ I'm working on helping to get the jdk8 build-infra changes integrated, this is for jaxp. This i

Re: Question about BUILD_HEADLESS and HEADLESS

2012-02-14 Thread Phil Race
On windows headless is simply a state. But Solaris/Linux have "true" headless builds where there are headless (stub) versions of UI libraries. And I think that headless is a valid JCK mode .. you can pass JCK in headless on platforms that don't support UI. But I'd check the JCK guys on that one

Re: Adding asm to JDK 8

2012-02-03 Thread Phil Race
we can make it into a module. Why does it need to be a module before that can happen ? So far as I can tell initially binary goes into rt.jar either way (source in shared or separate repo). -phil. On 2/3/2012 12:11 PM, Phil Race wrote: Oh, its for lambda! Thank you for mentioning that. I

Re: Adding asm to JDK 8

2012-02-03 Thread Phil Race
Oh, its for lambda! Thank you for mentioning that. I had no clue what we needed this thing for :-), may be it was obvious to the rest of the world but not to me and I was surprised it wasn't mentioned in Jim's email. But does it really need its own new repo ? I think there needs to be a discuss

Re: Is anyone able to build on Win 7

2012-02-01 Thread Phil Race
Volker, Will you be able to debug this ? FWIW my cygwin is 1.7.8 and I use win7 x64, for JDK builds and have done so for about as long as its been available, and probably the main issue I've had is accidentally using the wrong version of gnu make, and I don't know offhand any more if the cygw

Re: jdk/src/solaris - time to re-visit it?

2011-11-30 Thread Phil Race
On 11/30/2011 5:15 AM, Ulf Zibis wrote: Am 30.11.2011 13:10, schrieb Dmitry Samersoff: On 2011-11-30 16:05, Steve Poole wrote: I suggested maintaining the name as src/solaris partly because I don't believe in churn and am not sure what would make a better name other than src/unix .. would that

Re: jdk/src/solaris - time to re-visit it?

2011-11-29 Thread Phil Race
other than src/unix .. would that be OK ? You could create src/sunos for the really sunos parts .. Keeping the name the same also makes applying backport patches much easier. Well, that and of course my fingers know it very well. -phil. On 11/29/2011 2:00 PM, Alan Bateman wrote: On 29/11/2011 1

Re: jdk/src/solaris - time to re-visit it?

2011-11-29 Thread Phil Race
--src |--share |--posix |--winapi |--SYSV |--GNU |--BSD |--solaris |--aix |--gnu |--linux |--darwin |--freebsd |--windows |--wince * 95%+ of the code will be the same across solaris/linux/etc An

Re: jdk/src/solaris - time to re-visit it?

2011-11-23 Thread Phil Race
Its tricky. I would not gratuitously change any of the directory names, especially the win32 one. There'd have to be a compelling reason. The Linux and Solaris ports share X11 for their windowing system, but the OS X port doesn't. So some mac things would go in src/solaris, as they are shar

Re: Successfully building 32- and 64-bit OpenJDK 8 on WinXP/64bit with free tools only

2011-11-07 Thread Phil Race
Sean, I am not sure what you mean by "installed" - installed into \windows\system32 or installed in the JRE bin directory? But the latter is the only way its supposed to work, and the build should take the copy of freetype.dll you provide to it, and copy it to that location. At runtime, freet

Re: Confused about Windows build

2011-10-26 Thread Phil Race
Fredrik, Ulf started this by asking about openjdk 6 which does need VS2003. It doesn't support VS2010 .. and JDK 7 and 8 already build with VS2010 Express and have done so for well over a year. No need to use that forest, just standard 7. -phil. On 10/26/2011 9:34 AM, Fredrik Öhrström wrote:

Re: Review Request: openjdk make changes for "CR 7099017: jdk7u2-dev does not build"

2011-10-17 Thread Phil Race
On 10/17/2011 2:13 PM, Phil Race wrote: Looks fine to me .. I assume that building these moved to be in tandem with their existence. A better word than "assume" is"interpret" .. -phil. -phil. On 10/17/2011 1:54 PM, chris.grus...@oracle.com wrote: I am still lo

Re: Review Request: openjdk make changes for "CR 7099017: jdk7u2-dev does not build"

2011-10-17 Thread Phil Race
Looks fine to me .. I assume that building these moved to be in tandem with their existence. -phil. On 10/17/2011 1:54 PM, chris.grus...@oracle.com wrote: I am still looking for a reviewer. Please, -ChrisG On 10/13/2011 5:03 PM, chris.grus...@oracle.com wrote: openjdk make changes to skip de

Re: Confused about Windows build

2011-10-16 Thread Phil Race
I concur. Out of the box, 32 bit builds with even the closest extant free SDK may be something that has never even been tried and my guess is it won't work without changes. -phil. On 10/16/11 7:09 PM, Kelly O'Hair wrote: Windows 2000 and Visual Studio 2003 is for 32bit. Windows 2003 and Micros

Re: Should the Build Group sponsor the "JDK 7 Update" project?

2011-06-15 Thread Phil Race
Vote: yes

Re: Boot JDK used with jdk7 builds

2011-06-03 Thread Phil Race
Well .. we do not distribute binaries of 6-open so that's a bit of a stumbling block. Plus 6-open is relatively new in the great scheme of things and is more of a 6/7 hybrid. -phil. On 6/3/2011 9:02 AM, Dr Andrew John Hughes wrote: On 08:57 Fri 03 Jun , Kelly O'Hair wrote: The documented

Re: Should the Build Group sponsor the JDK 8 Project?

2011-05-23 Thread Phil Race
your decision, if you wish, on subsequent lines. This is optional and not required. Only Members of the Build Group are eligible to vote on this decision [2]. The current Members are: Kelly O'Hair Mark Reinhold Xiomara Jayasena Tim Bell Phil Race David Katleman

Re: Need reviewer: Exceptions to mapfile rule on shared libraries

2011-04-15 Thread Phil Race
For jpeg its something we could consider for JDK 8 although I think its been called libjpeg since JDK 1.0 without apparent problems. But this JDK libxinerama is only for Solaris (SPARC, specifically), and on Solaris Xinerama functionality has always lived in libXext.so, so there's no clash. Sola

Re: where is rebase.exe used?

2011-03-15 Thread Phil Race
I suspect you are interested in the fix for 7020815: REBASE should not be required for windows jdk repo builds - can't build with VS 2010 Express It was pushed a few days ago ... -phil. On 3/15/2011 11:09 PM, Weijun Wang wrote: Visual C++ 2010 Express has no rebase.exe in the SDK/bin director

Re: Need reviewer: Disable use of VS2003

2011-03-15 Thread Phil Race
Looks good. -phil. On 3/15/2011 4:25 PM, Kelly O'Hair wrote: Need reviewer: Disable use of VS2003 Prior to completely removing the VS2003 through VS2008 makefile logic in the jdk7 makefiles, Phil recommended that I just disable it to start out. Seems like a grand idea. ;^) This does not app

Re: Need reviewer: demo fixes from a long time ago ...

2011-03-15 Thread Phil Race
Looks good. -phil. On 3/15/2011 2:25 PM, Kelly O'Hair wrote: Need reviewer for these 2 demo fixes: 6685150: make/mkdemo/jpda/Makefile creates jpda.jar and src.zip instead of examples.jar 6710813: SwingSet2 source display tabs do not work since JDK 7 b20 http://cr.openjdk.java.net/~ohair/openj

Re: JDK8 Preliminary Repository Layout

2011-03-09 Thread Phil Race
Andrew, Whilst almost everything you wrote is something I agree with (like getting jcheck out there, not adding additional build tools/complexity), the one thing I quite like right now comes up here I'd like to keep is the separate repos. Its not just hotspot, but I've been working on JDK for

Re: Need reviewer: jdk/make/common/shared/Defs-windows.gmk

2011-01-10 Thread Phil Race
Approved. -phil. On 1/10/11 4:28 PM, Kelly O'Hair wrote: Need reviewer: jdk/make/common/shared/Defs-windows.gmk Minor correction that impacts anyone that installs VS2010 in a non-space location or sets VS100COMNTOOLS to a directory with no spaces. 7011382: Fix use of VS100COMNTOOLS when in

Re: Need Reviewer: OpenJDK7 Windows VS2010 warning silencing

2010-12-28 Thread Phil Race
Looks ok to me. -phil. On 12/28/2010 3:19 PM, Kelly O'Hair wrote: Need Reviewer: Windows VS2010 warning silencing With Windows VS2010 compilers, we started seeing many warnings about supposedly insecure function usage. These are not actually detecting errors as much as indicating that certai

Re: Help to build OpenJDK, Windows 7, VS2008 (VS2010)

2010-12-14 Thread Phil Race
On 12/14/2010 10:50 AM, Kelly O'Hair wrote: You said Windows 7, but the makefile seemed to have gotten 6.1 from the systeminfo, is that right? Is 6.1 Windows 7? If so that sure is confusing. :^( Yes, Windows 7 is "6.1". Windows 7 is a marketing name. -phil.

Re: Can't delete an old OpenJDK directory because of NUL files

2010-10-27 Thread Phil Race
Not addressing the how to delete part, but hopefully this is a VERY old directory. I was getting these files back in the spring and fixed it in May in jdk/make/common/shared/Platform.gmk as thus :- --- a/make/common/shared/Platform.gmk +++ b/make/common/shared/Platform.gmk @@ -275,7 +275,12 @@ i

Re: FYI: FreeType hinting is now enable by default

2010-08-07 Thread Phil Race
Raffaello Giulietti wrote: On 2010-08-06 18:29, Phil Race wrote: Well .. that is the very newest freetype but the doc is correct in that its referring to 2.3 More precisely, it's referring to "2.3 or newer". which was all that existed when it was written. Its

Re: FYI: FreeType hinting is now enable by default

2010-08-06 Thread Phil Race
Well .. that is the very newest freetype but the doc is correct in that its referring to 2.3 However if you are on Linux then jdk will use the system freetype and some distros are disabling the hinting for technical reasons. I think the reason is that a lot of free fonts are not hinted so turni

Re: How to run java.exe in Visual Studio

2010-06-16 Thread Phil Race
You may be better off posting to the awt-dev list as this doesn't sound like a build issue, and AWT developers spend more time being cosy with the VS debugger. -phil. On 6/16/2010 12:39 PM, Pete Brunet wrote: My prior post is what I did when VS was activated due to a crash. Now that I'm not cr

Re: OpenJDK Windows build with Visual Studio 2010 Express Edition

2010-06-16 Thread Phil Race
_MSDEVTOOLS_PATH for these VS2010 based builds, whereas with VS2003 it may not have been necessary. Basically you need to set this to point at the SDK's bin directory. -phil. On 6/13/2010 12:41 AM, Phil Race wrote: At this time we've not tried openjdk builds with VS2010 I know freetype

Re: OpenJDK Windows build with Visual Studio 2010 Express Edition

2010-06-13 Thread Phil Race
At this time we've not tried openjdk builds with VS2010 I know freetype check has issues but not hard ones. It appears that's the only issue, but fixing it is TBD. Your various path issues are likely not unique to VS2010 The failure to find "rc" and "mt" is probably most easily rectified by set

hg: jdk7/build/hotspot: 6953588: hotspot\src\share\vm\interpreter\bytecodes.cpp doesn't compile with VS2010 on AMD64

2010-05-19 Thread phil . race
Changeset: daf617c34be6 Author:prr Date: 2010-05-19 10:21 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/daf617c34be6 6953588: hotspot\src\share\vm\interpreter\bytecodes.cpp doesn't compile with VS2010 on AMD64 Reviewed-by: dcubed ! src/share/vm/interpreter/bytecodes

hg: jdk7/build/jdk: 2 new changesets

2010-05-19 Thread phil . race
Changeset: 416cfd5c6ca9 Author:prr Date: 2010-05-19 09:45 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/416cfd5c6ca9 6903970: VS2008/VS2010 build fails in make/sun/jkernel because of "afxres.h" missing Reviewed-by: ohair, art ! make/common/shared/Defs-windows.gmk ! make

<    1   2   3   4   5   >