Re: RFR: 8282828: CDS uncompressed oops archive is not deterministic

2022-05-02 Thread Calvin Cheung
On Fri, 29 Apr 2022 22:50:45 GMT, Ioi Lam wrote: > During `java -Xshare:dump -XX:-UseCompressedOops`, the location of the Java > heap is chosen by the OS. Due to Address Space Layout Randomization, the heap > will always start at a different location. This causes the archive for > uncompressed

Re: RFR: 8253495: CDS generates non-deterministic output [v8]

2022-03-15 Thread Calvin Cheung
On Tue, 15 Mar 2022 17:08:27 GMT, Ioi Lam wrote: >> This patch makes the result of "java -Xshare:dump" deterministic: >> - Disabled new Java threads from launching. This is harmless. See comments >> in jvm.cpp >> - Fixed a problem in hashtable ordering in heapShared.cpp >> - BasicHashtableEntry

Re: RFR: 8253495: CDS generates non-deterministic output [v6]

2022-03-14 Thread Calvin Cheung
On Fri, 11 Mar 2022 06:55:23 GMT, Ioi Lam wrote: >> This patch makes the result of "java -Xshare:dump" deterministic: >> - Disabled new Java threads from launching. This is harmless. See comments >> in jvm.cpp >> - Fixed a problem in hashtable ordering in heapShared.cpp >> - BasicHashtableEntry

Re: RFR: 8268821: Split systemDictionaryShared.cpp [v4]

2021-06-25 Thread Calvin Cheung
On Fri, 25 Jun 2021 22:28:50 GMT, Yumin Qi wrote: >> src/hotspot/share/cds/lambdaProxyClassDictionary.hpp line 28: >> >>> 26: #define SHARED_CDS_LAMBDAPROXYCLASSINFO_HPP >>> 27: #include "cds/metaspaceShared.hpp" >>> 28: #include "classfile/javaClasses.hpp" >> >> Is this include necessary? > >

Re: RFR: 8268821: Split systemDictionaryShared.cpp [v4]

2021-06-25 Thread Calvin Cheung
On Fri, 25 Jun 2021 01:15:29 GMT, Yumin Qi wrote: >> Hi, Please review >> systemDictionaryShared becomes fatter and fatter so it is time to split it >> into functional files. Moved security and jar operation related code into >> CDSProtectionDomain, and moved shared class info (DumpTime/RunTime

Re: RFR: 8268821: Split systemDictionaryShared.cpp [v3]

2021-06-23 Thread Calvin Cheung
On Thu, 24 Jun 2021 03:11:35 GMT, Yumin Qi wrote: >> Hi, Please review >> systemDictionaryShared becomes fatter and fatter so it is time to split it >> into functional files. Moved security and jar operation related code into >> CDSProtectionDomain, and moved shared class info (DumpTime/RunTime

Re: RFR: 8268821: Split systemDictionaryShared.cpp [v2]

2021-06-23 Thread Calvin Cheung
On Wed, 23 Jun 2021 20:45:49 GMT, Yumin Qi wrote: >> Hi, Please review >> systemDictionaryShared becomes fatter and fatter so it is time to split it >> into functional files. Moved security and jar operation related code into >> CDSProtectionDomain, and moved shared class info (DumpTime/RunTime

Re: RFR(L): 8202035: Archive the set of ModuleDescriptor and ModuleReference objects for system modules

2018-07-06 Thread Calvin Cheung
Hi Jiangli, Thanks for this start-up improvement. The changes look good overall. I've the following minor comments. 1) make/hotspot/symbols/symbols-unix 134 JVM_InitializeFromArchive If you want the symbols to be in alphabetical order, the above should be moved after JVM_InitStackTr

Re: RFR(L): 8199255: [TESTBUG] Open source VM testbase default methods tests

2018-05-23 Thread Calvin Cheung
Hi Misha, I've compared the file.list from your closed webrev with the one from this open webrev and didn't see any missing files. Also spot checked a few copyright headers and they look good. Regarding TEST.groups, why was the following removed? 1160 vmTestbase_nsk_stress = \ 1161 vmTestbas

Re: RFR: 8193213 & 8182731: Make the UseAppCDS option obsolete

2018-04-26 Thread Calvin Cheung
On 4/26/18, 12:00 PM, Jiangli Zhou wrote: Hi Calvin, On Apr 26, 2018, at 10:10 AM, Calvin Cheung wrote: On 4/25/18, 9:34 PM, Jiangli Zhou wrote: Here is the incremental webrev with updates that incorporate all feedbacks: http://cr.openjdk.java.net/~jiangli/8193213_8182731/webrev_inc.02

Re: RFR: 8193213 & 8182731: Make the UseAppCDS option obsolete

2018-04-26 Thread Calvin Cheung
On 4/25/18, 9:34 PM, Jiangli Zhou wrote: Here is the incremental webrev with updates that incorporate all feedbacks: http://cr.openjdk.java.net/~jiangli/8193213_8182731/webrev_inc.02/ Looks good. - Filed JDK-8202282 (https://bugs.openjdk.java.net/browse/JDK-8202282) for TestCommon.makeComma

Re: RFR (XS) 8022740 - Visual 2008 IDE build is broken

2013-08-21 Thread Calvin Cheung
Hi Ioi, I've tried your patch on vs2010 and it seems working fine. I was able to generate a project file and used vs2010 to open the project file. So I think your fix is good. (I'm not a Reviewer) Calvin On 8/9/2013 5:39 PM, Ioi Lam wrote: |Please review a very small fix:|| || ||http://cr.op

hg: jdk7/deploy/jdk: 6992226: Missing windows COMPANY file property settings

2010-11-15 Thread calvin . cheung
Changeset: 06aacd794fca Author:ccheung Date: 2010-11-09 23:05 -0800 URL: http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/06aacd794fca 6992226: Missing windows COMPANY file property settings Reviewed-by: ohair ! make/common/Defs.gmk