Re: RFR: JDK-8159544: Remove deprecated classes in com.sun.security.auth.**

2017-08-18 Thread Vincent Ryan
Your changes look fine to me. Thanks. > On 17 Aug 2017, at 20:08, Sean Mullan wrote: > > Please review this JDK 10 change to remove the deprecated classes in > com.sun.security.auth.** that have been previously marked with > forRemoval=true in JDK 9. > > webrev: http://cr.openjdk.java.net/~m

Re: RFR 8162739: Create new keytool option to access cacerts file

2016-08-08 Thread Vincent Ryan
Your changes look good to me. Thanks. > On 8 Aug 2016, at 14:46, Weijun Wang wrote: > > Please review the code changes at > > http://cr.openjdk.java.net/~weijun/8162739/webrev.00/ > > A new -cacerts option is added to keytool so there is no need to provide the > full cacerts path on the co

Re: [8] RfR 8027567: JDK8 build failure: the correct version of GNU make is being rejected

2013-10-30 Thread Vincent Ryan
igure.sh, I just assume is ok once > common/autoconf/autogen.sh is run ). > > -Chris. > > On 30/10/2013 16:24, Vincent Ryan wrote: >> Sure. I’ll re-run autogen.sh and submit an updated webrev. >> Thanks. >> >> >> On 30 Oct 2013, at 16:15, Erik Joelsson

Re: [8] RfR 8027567: JDK8 build failure: the correct version of GNU make is being rejected

2013-10-30 Thread Vincent Ryan
to also submit > the closed generated-configure. > > /Erik > > On 2013-10-30 17:07, Vincent Ryan wrote: >> Thanks Erik. We’re seeing the issue in TL so it’d be great to get this fixed >> today. >> Would you like to take ownership of this issue or shall I push yo

Re: [8] RfR 8027567: JDK8 build failure: the correct version of GNU make is being rejected

2013-10-30 Thread Vincent Ryan
; It seems the problem is with the grep tool used to parse the version string. >> /usr/xpg4/bin/grep doesn't handle '\(3\.8[12]\)\|\(4\.\)' the same as gnu >> grep. In jprt it finds /usr/sfw/bin/ggrep which works better. I will see if >> I can figure out something

Re: [8] RfR 8027567: JDK8 build failure: the correct version of GNU make is being rejected

2013-10-30 Thread Vincent Ryan
ter. > > I guess we can still resolve the problem in tl, and sync back into master, > but Erik should ensure that the original issue is still fixed, "8026528: > [build] configure does not recognize newer make in cygwin" > > -Chris. > > [1] http://hg.openjdk.java.

[8] RfR 8027567: JDK8 build failure: the correct version of GNU make is being rejected

2013-10-30 Thread Vincent Ryan
Please review this fix to correct the JDK8 build Configure script. It reverts a recent change to common/autoconf/basics.m4 that was causing a build failure on Solaris. Bug: https://bugs.openjdk.java.net/browse/JDK-8027567 Webrev: http://cr.openjdk.java.net/~vinnie/8027567/

Re: Allow configure to detect if EC implementation is present

2013-03-15 Thread Vincent Ryan
You're correct Omar. That target directory is not always present as I had indicated below. The new and old builds are indeed consistent in the way they handle that. Thanks. On 14 Mar 2013, at 19:50, Omair Majid wrote: > On 03/14/2013 03:14 PM, Vincent Ryan wrote: >> The DISABLE_

Re: Allow configure to detect if EC implementation is present

2013-03-14 Thread Vincent Ryan
The DISABLE_INTREE_EC flag is designed to control whether the Elliptic Curve support in the JDK source tree is skipped during a build. It is used to avoid the duplication of EC libraries on platforms where an EC library is already present. In the old build it was a build option. In the new build

Re: Code Review 7103549: Remove dependencies on libjava and libjvm from security libraries

2011-10-21 Thread Vincent Ryan
Those changes look fine. On 10/21/11 04:43 PM, Chris Hegarty wrote: > All of the security native libraries have runtime dependencies on libjava and > libjvm, most of which are completely unnecessary. This CR proposes to remove > these dependencies and provide localized versions of the trivial uti

hg: jdk7/build/jdk: 6891632: Remove duplicate ECC source files

2009-10-14 Thread vincent . ryan
Changeset: eacb36e30327 Author:vinnie Date: 2009-10-14 23:41 +0100 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/eacb36e30327 6891632: Remove duplicate ECC source files Reviewed-by: wetmore - src/share/native/sun/security/ec/ec.h - src/share/native/sun/security/ec/ec2.h - src/