Re: [OpenJDK 2D-Dev] [11] RFR for JDK-8202476: ImageLib is broken in 32 bit Windows

2018-05-04 Thread Alexey Ivanov
Thank you! -- Alexey On 04/05/2018 18:53, Phil Race wrote: Yes, your confirmation on the testing was all that was needed. -phil. On 5/4/2018 10:45 AM, Alexey Ivanov wrote: Hi Phil, Just to confirm: do you approve the change? Thank you, Alexey On 02/05/2018 19:24, Alexey Ivanov wrote: Hi

Re: [OpenJDK 2D-Dev] [11] RFR for JDK-8202476: ImageLib is broken in 32 bit Windows

2018-05-04 Thread Phil Race
Yes, your confirmation on the testing was all that was needed. -phil. On 5/4/2018 10:45 AM, Alexey Ivanov wrote: Hi Phil, Just to confirm: do you approve the change? Thank you, Alexey On 02/05/2018 19:24, Alexey Ivanov wrote: Hi Phil, Thank you for your review. On 02/05/2018 17:28, Phil R

Re: [OpenJDK 2D-Dev] [11] RFR for JDK-8202476: ImageLib is broken in 32 bit Windows

2018-05-04 Thread Alexey Ivanov
Hi Phil, Just to confirm: do you approve the change? Thank you, Alexey On 02/05/2018 19:24, Alexey Ivanov wrote: Hi Phil, Thank you for your review. On 02/05/2018 17:28, Phil Race wrote: So ... the original change that removed the mapfiles broke the 32 bit build because of inconsistency bet

Re: [OpenJDK 2D-Dev] [11] RFR for JDK-8202476: ImageLib is broken in 32 bit Windows

2018-05-02 Thread Alexey Ivanov
Hi Phil, Thank you for your review. On 02/05/2018 17:28, Phil Race wrote: So ... the original change that removed the mapfiles broke the 32 bit build because of inconsistency between declarations + definitions of some functions. It did not affect 64 bit build because JNICALL is a no-op there.

Re: [OpenJDK 2D-Dev] [11] RFR for JDK-8202476: ImageLib is broken in 32 bit Windows

2018-05-02 Thread Phil Race
So ... the original change that removed the mapfiles broke the 32 bit build because of inconsistency between declarations + definitions of some functions. It did not affect 64 bit build because JNICALL is a no-op there. The next change (8201226) added JNICALL to make it consistent, but was not

Re: [11] RFR for JDK-8202476: ImageLib is broken in 32 bit Windows

2018-05-02 Thread Magnus Ihse Bursie
Looks good to me, but you should have a reviewer from the client team as well. /Magnus > 2 maj 2018 kl. 11:52 skrev Alexey Ivanov : > > Hi, > > Could you please review the following fix for jdk11? > > bug: https://bugs.openjdk.java.net/browse/JDK-8202476 > webrev: http://cr.openjdk.java.net/~

RE: [11] RFR for JDK-8202476: ImageLib is broken in 32 bit Windows

2018-05-02 Thread Baesken, Matthias
> Subject: [11] RFR for JDK-8202476: ImageLib is broken in 32 bit Windows > > Hi, > > Could you please review the following fix for jdk11? > > bug: https://bugs.openjdk.java.net/browse/JDK-8202476 > webrev: http://cr.openjdk.java.net/~aivanov/8202476/jdk11/webrev.0/ &g

[11] RFR for JDK-8202476: ImageLib is broken in 32 bit Windows

2018-05-02 Thread Alexey Ivanov
Hi, Could you please review the following fix for jdk11? bug: https://bugs.openjdk.java.net/browse/JDK-8202476 webrev: http://cr.openjdk.java.net/~aivanov/8202476/jdk11/webrev.0/ This is a follow-up fix for JDK-8201226 which enabled building JDK for 32 bit Windows, its code review: http://mai