Re: [PATCH] Fix Shark build in JDK9

2015-01-14 Thread Erik Joelsson
On 2015-01-14 08:22, David Holmes wrote: Hi Roman, On 14/01/2015 7:41 AM, Roman Kennke wrote: Ok I think I found a way to avoid copying the whole #define block just for one line. I define that line before (and empty in case of SHARK) and use that inside the big #define. http://cr.openjdk.java

Re: [PATCH] Fix Shark build in JDK9

2015-01-13 Thread David Holmes
Hi Roman, On 14/01/2015 7:41 AM, Roman Kennke wrote: Ok I think I found a way to avoid copying the whole #define block just for one line. I define that line before (and empty in case of SHARK) and use that inside the big #define. http://cr.openjdk.java.net/~rkennke/shark-build-hotspot/webrev.02

Re: [PATCH] Fix Shark build in JDK9

2015-01-13 Thread Roman Kennke
Ok I think I found a way to avoid copying the whole #define block just for one line. I define that line before (and empty in case of SHARK) and use that inside the big #define. http://cr.openjdk.java.net/~rkennke/shark-build-hotspot/webrev.02/ Please review and push if ok. Roman Am Freitag, den

Re: [PATCH] Fix Shark build in JDK9

2015-01-13 Thread Roman Kennke
Hi David, > > - In ciTypeFlow.cpp only include some files and code only when building > > C2. I don't think that code makes sense outside of C2. (That's the issue > > that you've seen). > > Looks okay but someone from compiler team needs to comment. There may be > other code that need adjusting

Re: [PATCH] Fix Shark build in JDK9

2015-01-08 Thread David Holmes
Hi Roman, Commenting on the hotspot changes ... On 8/01/2015 9:01 PM, Roman Kennke wrote: Hi Erik, I'm CC-ing hotspot-dev for review of Hotspot code related changes. Yes, some additional changes to Hotspot are required. This is the full set of changes needed to build and run Shark: http://cr

Re: [PATCH] Fix Shark build in JDK9

2015-01-08 Thread Erik Joelsson
On 2015-01-08 12:54, Andrew Haley wrote: On 01/08/2015 11:38 AM, Erik Joelsson wrote: I tried building locally (Ubuntu 14.04 with llvm 3.4) but it failed with undefined references at link time: /usr/lib/llvm-3.4/lib/libLLVMSupport.a(Process.o): In function `llvm::sys::Process::FileDescriptorHas

Re: [PATCH] Fix Shark build in JDK9

2015-01-08 Thread Andrew Haley
On 01/08/2015 11:38 AM, Erik Joelsson wrote: > Hello Roman, > > Thanks for the full patch! > > I discovered a problem with the top repo patch. When autoconf (using m4) > evaluates your change, the brackets disappear. To fix this, more > brackets need to be added. Here is a version that works fo

Re: [PATCH] Fix Shark build in JDK9

2015-01-08 Thread Erik Joelsson
Hello Roman, Thanks for the full patch! I discovered a problem with the top repo patch. When autoconf (using m4) evaluates your change, the brackets disappear. To fix this, more brackets need to be added. Here is a version that works for me that will make the correct sed expression appear in

Re: [PATCH] Fix Shark build in JDK9

2015-01-08 Thread Andrew Haley
On 01/08/2015 11:31 AM, Roman Kennke wrote: > I guess for my purposes it's good enough to pass some GCC flag to turn > on C++11 support, so that the new LLVM headers can be used. That's all > that I need. But does that work without further changes? Andrew.

Re: [PATCH] Fix Shark build in JDK9

2015-01-08 Thread Roman Kennke
Am Donnerstag, den 08.01.2015 um 21:20 +1000 schrieb David Holmes: > On 8/01/2015 9:05 PM, Roman Kennke wrote: > > Oh and notice that if you try to build it yourself, use a version of > > LLVM < 3.5. In 3.5, C++11 is used/required, and OpenJDK doesn't support > > C++11 yet. (are there any plans abo

Re: [PATCH] Fix Shark build in JDK9

2015-01-08 Thread David Holmes
On 8/01/2015 9:05 PM, Roman Kennke wrote: Oh and notice that if you try to build it yourself, use a version of LLVM < 3.5. In 3.5, C++11 is used/required, and OpenJDK doesn't support C++11 yet. (are there any plans about this?) I'd recommend LLVM 3.4.2. C++11? We still have workarounds for comp

Re: [PATCH] Fix Shark build in JDK9

2015-01-08 Thread Roman Kennke
Oh and notice that if you try to build it yourself, use a version of LLVM < 3.5. In 3.5, C++11 is used/required, and OpenJDK doesn't support C++11 yet. (are there any plans about this?) I'd recommend LLVM 3.4.2. Roman Am Donnerstag, den 08.01.2015 um 11:03 +0100 schrieb Erik Joelsson: > Hello Rom

Re: [PATCH] Fix Shark build in JDK9

2015-01-08 Thread Roman Kennke
Hi Erik, I'm CC-ing hotspot-dev for review of Hotspot code related changes. Yes, some additional changes to Hotspot are required. This is the full set of changes needed to build and run Shark: http://cr.openjdk.java.net/~rkennke/shark-build-hotspot/webrev.01/ In detail: - In the Makefile fix a

Re: [PATCH] Fix Shark build in JDK9

2015-01-08 Thread Erik Joelsson
Hello Roman, This addition looks good to me. Thinking about what the others said, it might be inconvenient to have all this be pushed to different forests. I tried applying all the changes to jdk9/hs-rt, but I can't seem to build zeroshark.. Did you have more hotspot changes to be able to fin

Re: [PATCH] Fix Shark build in JDK9

2015-01-07 Thread David Holmes
On 8/01/2015 1:10 AM, Erik Joelsson wrote: Hello, On 2015-01-07 15:45, Roman Kennke wrote: Hello there, I made some fixes to the build machinery to be able to build Shark: http://cr.openjdk.java.net/~rkennke/shark-build-top/ Looks fine, but the generated configure script needs to be generate

Re: [PATCH] Fix Shark build in JDK9

2015-01-07 Thread Roman Kennke
Hi Erik, When I built Zero and Shark on my Raspberry Pi, I noticed another problem when copying jvm.cfg into the right places. I fixed it in a similar way as I did for the SA stuff: http://cr.openjdk.java.net/~rkennke/shark-build-jdk/webrev.02/ I think that should be all for now. Please push th

Re: [PATCH] Fix Shark build in JDK9

2015-01-07 Thread Roman Kennke
Am Mittwoch, den 07.01.2015 um 17:49 +0100 schrieb Erik Joelsson: > On 2015-01-07 17:29, Roman Kennke wrote: > > Am Mittwoch, den 07.01.2015 um 17:16 +0100 schrieb Erik Joelsson: > >> On 2015-01-07 17:11, Roman Kennke wrote: > >>> Hi Erik, > >>> > >>> Do you have a bug for this? > >>> No. > >>> > >

Re: [PATCH] Fix Shark build in JDK9

2015-01-07 Thread Volker Simonis
On Wed, Jan 7, 2015 at 5:29 PM, Roman Kennke wrote: > Am Mittwoch, den 07.01.2015 um 17:16 +0100 schrieb Erik Joelsson: >> On 2015-01-07 17:11, Roman Kennke wrote: >> > Hi Erik, >> > >> > Do you have a bug for this? >> > No. >> > >> > I haven't pushed any changes to JDK in a while. Is it possible

Re: [PATCH] Fix Shark build in JDK9

2015-01-07 Thread Erik Joelsson
On 2015-01-07 17:29, Roman Kennke wrote: Am Mittwoch, den 07.01.2015 um 17:16 +0100 schrieb Erik Joelsson: On 2015-01-07 17:11, Roman Kennke wrote: Hi Erik, Do you have a bug for this? No. I haven't pushed any changes to JDK in a while. Is it possible in the meantime for me to create my own

Re: [PATCH] Fix Shark build in JDK9

2015-01-07 Thread Roman Kennke
Am Mittwoch, den 07.01.2015 um 17:16 +0100 schrieb Erik Joelsson: > On 2015-01-07 17:11, Roman Kennke wrote: > > Hi Erik, > > > > Do you have a bug for this? > > No. > > > > I haven't pushed any changes to JDK in a while. Is it possible in the > > meantime for me to create my own bugs? Otherwise, p

Re: [PATCH] Fix Shark build in JDK9

2015-01-07 Thread Erik Joelsson
On 2015-01-07 17:11, Roman Kennke wrote: Hi Erik, Do you have a bug for this? No. I haven't pushed any changes to JDK in a while. Is it possible in the meantime for me to create my own bugs? Otherwise, please file one for me :-) You should be able to log in to https://bugs.openjdk.java.net and

Re: [PATCH] Fix Shark build in JDK9

2015-01-07 Thread Roman Kennke
Hi Erik, > >>> I made some fixes to the build machinery to be able to build Shark: > >>> > >>> http://cr.openjdk.java.net/~rkennke/shark-build-top/ > >> Looks fine, but the generated configure script needs to be generated by > >> the script as it also updates a timestamp inside the file. We will s

Re: [PATCH] Fix Shark build in JDK9

2015-01-07 Thread Erik Joelsson
On 2015-01-07 16:41, Roman Kennke wrote: Hi Erik, I made some fixes to the build machinery to be able to build Shark: http://cr.openjdk.java.net/~rkennke/shark-build-top/ Looks fine, but the generated configure script needs to be generated by the script as it also updates a timestamp inside

Re: [PATCH] Fix Shark build in JDK9

2015-01-07 Thread Roman Kennke
Hi Erik, > > I made some fixes to the build machinery to be able to build Shark: > > > > http://cr.openjdk.java.net/~rkennke/shark-build-top/ > Looks fine, but the generated configure script needs to be generated by > the script as it also updates a timestamp inside the file. We will still > nee

Re: [PATCH] Fix Shark build in JDK9

2015-01-07 Thread Erik Joelsson
Hello, On 2015-01-07 15:45, Roman Kennke wrote: Hello there, I made some fixes to the build machinery to be able to build Shark: http://cr.openjdk.java.net/~rkennke/shark-build-top/ Looks fine, but the generated configure script needs to be generated by the script as it also updates a timesta

Re: [PATCH] Fix Shark build in JDK9

2015-01-07 Thread Roman Kennke
I just realized that I posted some unneeded stuff, and that the check for ZERO *or* ZEROSHARK can be made simpler: http://cr.openjdk.java.net/~rkennke/shark-build-jdk/webrev.01/ Roman Am Mittwoch, den 07.01.2015 um 15:45 +0100 schrieb Roman Kennke: > Hello there, > > I made some fixes to the bu

[PATCH] Fix Shark build in JDK9

2015-01-07 Thread Roman Kennke
Hello there, I made some fixes to the build machinery to be able to build Shark: http://cr.openjdk.java.net/~rkennke/shark-build-top/ http://cr.openjdk.java.net/~rkennke/shark-build-hotspot/ http://cr.openjdk.java.net/~rkennke/shark-build-jdk/ In particular, it does: - Improve the sed command to