Re: RFR: 8258407: Split up CompileJavaModules.gmk into make/modules/$M/Java.gmk [v4]

2021-01-11 Thread Magnus Ihse Bursie
> Right now `CompileJavaModules.gmk` contains two different part: one part with > the functionality needed to compile a java module, and one part were all > special requirements for all modules are listed. > > The second part should be removed from `CompileJavaModules.gmk`, and instead > listed

Re: RFR: 8258407: Split up CompileJavaModules.gmk into make/modules/$M/Java.gmk [v3]

2021-01-11 Thread Magnus Ihse Bursie
On Mon, 4 Jan 2021 15:16:35 GMT, Erik Joelsson wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Final bug fixes... > > Marked as reviewed by erikj (Reviewer). @erikj79 Actually, I had not done that. But it wa

Re: RFR: 8258407: Split up CompileJavaModules.gmk into make/modules/$M/Java.gmk

2021-01-04 Thread Erik Joelsson
On Tue, 15 Dec 2020 13:11:30 GMT, Magnus Ihse Bursie wrote: > Right now `CompileJavaModules.gmk` contains two different part: one part with > the functionality needed to compile a java module, and one part were all > special requirements for all modules are listed. > > The second part should b

Re: RFR: 8258407: Split up CompileJavaModules.gmk into make/modules/$M/Java.gmk [v3]

2021-01-04 Thread Erik Joelsson
On Tue, 15 Dec 2020 14:40:34 GMT, Magnus Ihse Bursie wrote: >> Right now `CompileJavaModules.gmk` contains two different part: one part >> with the functionality needed to compile a java module, and one part were >> all special requirements for all modules are listed. >> >> The second part sho

Re: RFR: 8258407: Split up CompileJavaModules.gmk into make/modules/$M/Java.gmk [v3]

2020-12-15 Thread Magnus Ihse Bursie
> Right now `CompileJavaModules.gmk` contains two different part: one part with > the functionality needed to compile a java module, and one part were all > special requirements for all modules are listed. > > The second part should be removed from `CompileJavaModules.gmk`, and instead > listed

Re: RFR: 8258407: Split up CompileJavaModules.gmk into make/modules/$M/Java.gmk [v2]

2020-12-15 Thread Magnus Ihse Bursie
> Right now `CompileJavaModules.gmk` contains two different part: one part with > the functionality needed to compile a java module, and one part were all > special requirements for all modules are listed. > > The second part should be removed from `CompileJavaModules.gmk`, and instead > listed

RFR: 8258407: Split up CompileJavaModules.gmk into make/modules/$M/Java.gmk

2020-12-15 Thread Magnus Ihse Bursie
Right now `CompileJavaModules.gmk` contains two different part: one part with the functionality needed to compile a java module, and one part were all special requirements for all modules are listed. The second part should be removed from `CompileJavaModules.gmk`, and instead listed directly fo