Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v4]

2021-12-22 Thread Andrew Leonard
On Wed, 22 Dec 2021 17:30:36 GMT, Erik Joelsson wrote: >> Andrew Leonard has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - 8278766: Enable OpenJDK build support for reproducible jars and jmods >> using --date >> >>

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v4]

2021-12-22 Thread Erik Joelsson
On Wed, 22 Dec 2021 15:44:39 GMT, Andrew Leonard wrote: >> If "reproducible build" is enabled, then utilize the new --date option in >> the building of jar's and jmods. >> Validating the boot jdk supports --date for the building of the jars. >> >> Signed-off-by: Andrew Leonard > > Andrew

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v4]

2021-12-22 Thread Andrew Leonard
On Fri, 17 Dec 2021 20:04:20 GMT, Andrew Leonard wrote: >> make/common/MakeBase.gmk line 148: >> >>> 146: ifeq ($(SOURCE_DATE_ISO_8601), ) >>> 147: # GNU date format did not work, try BSD date options >>> 148: SOURCE_DATE_ISO_8601 := $(shell $(DATE) -u -j -f "%s" >>>

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v4]

2021-12-22 Thread Andrew Leonard
On Fri, 17 Dec 2021 17:47:02 GMT, Erik Joelsson wrote: >> Andrew Leonard has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - 8278766: Enable OpenJDK build support for reproducible jars and jmods >> using --date >> >>

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v4]

2021-12-22 Thread Andrew Leonard
> If "reproducible build" is enabled, then utilize the new --date option in the > building of jar's and jmods. > Validating the boot jdk supports --date for the building of the jars. > > Signed-off-by: Andrew Leonard Andrew Leonard has updated the pull request incrementally with three

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v4]

2021-12-22 Thread Andrew Leonard
On Fri, 17 Dec 2021 20:08:43 GMT, Andrew Leonard wrote: >> But I think the code in InitSupport will be executed always; Init.gmk is our >> "bootstrapper" / "trampoline" which wraps all calls to make (and >> InitSupport.gmk contains gory implementation details of Init.gmk). > > @magicus don't