RFR 8003161: Cannot build jdk8/build using the new build system after latest merge.

It seems that some changes (like introduction of cmshalf.c) did not update the new makefiles and caused the OpenJDK only build to fail. http://cr.openjdk.java.net/~ohrstrom/webrev-8003161-root/ http://cr.openjdk.java.net/~ohrstrom/webrev-8003161-jdk/ //Fredrik

Re: Working with common/autoconf/configure

Thanks for the feedback! I have also run into those Xt and Xrender libs missing and having to figure them out myself. We should add checks for them in configure and correct the naming of the freetype lib (or maybe the name varies and both should be suggested). I've filed bug JDK-8003162 for th

Re: RFR 8003161: Cannot build jdk8/build using the new build system after latest merge.

That and an unfortunate merge in CreateJars.gmk. The missing mkdir in JavaCompilation.gmk hasn't been a problem for a long time, but it was bound to happen at some point. These fixes need to go in ASAP as they all cause build breaks in build-infra. /Erik On 2012-11-08 10:59, Fredrik Öhrstr

Re: Review Request: 8002028: build-infra: need no-hotspot partial build

On 2012-11-08 04:19, David Holmes wrote: Hi Erik, Two queries: 1. In Main.gmk wouldn't it be better to move the hotspot targets inside the conditional - that way if you ask to build hotspot when you are not configured to build it you will get an error. I figured there would be errors when

Re: Review request: 8002365: build-infra: Build-infra fails on solaris 11.1 on sparc

On 2012-11-08 08:33, David Holmes wrote: On 8/11/2012 4:56 PM, David Holmes wrote: On 8/11/2012 12:38 AM, Erik Joelsson wrote: This is essentially the patch from Vincent to make build-infra work on Solaris 11.1 with some minor adjustments to keep the new and old build equal. http://cr.openjd

Re: RFR 8003161: Cannot build jdk8/build using the new build system after latest merge.

On 8/11/2012 7:59 PM, Fredrik Öhrström wrote: It seems that some changes (like introduction of cmshalf.c) did not update the new makefiles and caused the OpenJDK only build to fail. http://cr.openjdk.java.net/~ohrstrom/webrev-8003161-root/ I don't understand this: $$(shell $(MKDIR) -p $$(

Re: RFR 8003161: Cannot build jdk8/build using the new build system after latest merge.

On 08/11/2012 09:59, Fredrik Öhrström wrote: It seems that some changes (like introduction of cmshalf.c) did not update the new makefiles and caused the OpenJDK only build to fail. http://cr.openjdk.java.net/~ohrstrom/webrev-8003161-root/ http://cr.openjdk.java.net/~ohrstrom/webrev-8003161-jdk/

Re: RFR 8003161: Cannot build jdk8/build using the new build system after latest merge.

On 2012-11-08 11:52, David Holmes wrote: On 8/11/2012 7:59 PM, Fredrik Öhrström wrote: It seems that some changes (like introduction of cmshalf.c) did not update the new makefiles and caused the OpenJDK only build to fail. http://cr.openjdk.java.net/~ohrstrom/webrev-8003161-root/ I don't un

Re: RFR 8003161: Cannot build jdk8/build using the new build system after latest merge.

2012-11-08 11:52, David Holmes skrev: I don't understand this: $$(shell $(MKDIR) -p $$($1_BIN) && $(RM) $$($1_BIN)/_the.$$($1_JARNAME)_include) If you have to create the directory there can't possibly be anything to rm. ??? Two things need to be established before ListPathsSafely is ex

hg: jdk8/build/jdk: 8003161: small fixes to re-enable new build system

Changeset: 1e79fec4a01f Author:ohrstrom Date: 2012-11-08 12:25 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1e79fec4a01f 8003161: small fixes to re-enable new build system Reviewed-by: dholmes, alanb, erikj ! makefiles/CompileNativeLibraries.gmk ! makefiles/CreateJars.g

hg: jdk8/build: 8003161: small fixes to re-enable new build system

Changeset: 8bbc72864a41 Author:ohrstrom Date: 2012-11-08 12:24 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/8bbc72864a41 8003161: small fixes to re-enable new build system Reviewed-by: dholmes, alanb, erikj ! common/makefiles/JavaCompilation.gmk

Re: Review Request: 8002028: build-infra: need no-hotspot partial build

New webrev for root: http://cr.openjdk.java.net/~erikj/8002028/webrev.root.02/ Changed to conditional as David suggested. Improved the description and fail message in configure. /Erik On 2012-11-08 11:41, Erik Joelsson wrote:

Re: Review Request: 8002028: build-infra: need no-hotspot partial build

Looks good to me. Tim On 11/08/12 06:27, Erik Joelsson wrote: New webrev for root: http://cr.openjdk.java.net/~erikj/8002028/webrev.root.02/ Changed to conditional as David suggested. Improved the description and fail message i

Review Request: 8003177: build-infra: Compare reports diff in LocaleDataMetaInfo.class

Small fix for class file diff that was introduced with the changes to locales. http://cr.openjdk.java.net/~erikj/8003177/webrev.01/ Before this change, LocaleDataMetaInfo.java was generated with an extra space in the list of locales fo

Re: Review Request: 8002028: build-infra: need no-hotspot partial build

And a new for jdk too. This fixes solaris. http://cr.openjdk.java.net/~erikj/8002028/webrev.jdk.02/ /Erik On 2012-11-08 15:27, Erik Joelsson wrote: New webrev for root: http://cr.openjdk.java.net/~erikj/8002028/webrev.root.02/

Re: Review Request: 8003177: build-infra: Compare reports diff in LocaleDataMetaInfo.class

My bad. This should have been fixed with 8001231. Looks good to me. Naoto On 11/8/12 8:40 AM, Erik Joelsson wrote: Small fix for class file diff that was introduced with the changes to locales. http://cr.openjdk.java.net/~erikj/8003177/webrev.01/

Re: CFV: Nomination of Erik Joelsson to OpenJDK Build Group

Vote: yes -kto On Nov 7, 2012, at 9:52 AM, Kelly O'Hair wrote: > > I hereby nominate Erik Joelsson to Membership in the OpenJDK Build Group. > > Erik Joelsson (http://openjdk.java.net/census#erikj) is a Committer to the > Build Infrastructure Project > and author in the HotSpot Express and

Re: CFV: Nomination of Erik Joelsson to OpenJDK Build Group

Vote: yes On 11/07/12 09:52, Kelly O'Hair wrote: Please cast your vote or veto by replying to this message

Re: Build changes for 7176225: Remove JDBC-ODBC Bridge

On Oct 30, 2012, at 7:55 AM, Alan Bateman wrote: > On 29/10/2012 12:41, John Yeary wrote: >> Thanks Ulf, that was my exact point Ulf. Although, you were much more >> eloquent. >> >> One of the most consistent things that Java has done is ensuring backwards >> compatibility. The removal of someth

Re: RFR: JDK-8001191: use -source 8 -target 8 when compiling the JDK

Looks good to me. Thanks, Jim On 10/31/2012 01:43 PM, Kumar Srinivasan wrote: Hello, Please review changes to rev up the default -source and -target for jdk compilation, thus producing v52.0 class files. Bug is here: https://jbs.oracle.com/bugs/browse/JDK-8001191 Webrev is here: http://c

Re: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

Looks good to me Gary On Oct 31, 2012, at 8:41 PM, David Holmes wrote: > No takers so far - don't be shy, it's not a difficult one I promise :) > > Updated webrev: http://cr.openjdk.java.net/~dholmes/8002034/webrev.01/ > > Because of the multiple sub-make invocations that occur during a build t

Fwd: RFR: 8000780: make Zero build and run with JDK8

This patch contains a Makefile change: http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.03/make/Makefile.udiff.html -- Chris Begin forwarded message: > From: Roman Kennke > Subject: Re: RFR: Make Zero build and run with JDK8 > Date: October 17, 2012 4:09:13 PM PDT > To: Christian Thalinger

Re: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

Looks even better now! Gary On Nov 1, 2012, at 3:41 PM, David Holmes wrote: > On 2/11/2012 2:20 AM, Daniel D. Daugherty wrote: >> On 10/31/12 11:41 PM, David Holmes wrote: >>> No takers so far - don't be shy, it's not a difficult one I promise :) >>> >>> Updated webrev: http://cr.openjdk.java.

Re: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

On 11/1/2012 7:47 PM, David Holmes wrote: On 2/11/2012 8:49 AM, Dmitry Samersoff wrote: David, Sorry, (my eyes) I misread if As far as I understand, cross compilation require explicit ALT_OBJCOPY. Yes. Is there any defaults? No. The makefiles know nothing about the toolsets for cross-c

Re: Build changes for 7176225: Remove JDBC-ODBC Bridge

On Oct 26, 2012, at 5:39 PM, Alan Bateman wrote: > On 26/10/2012 21:14, John Yeary wrote: >> Hello All, >> >> Out of curiosity what will replace it? I looked at the transitional >> notification[1], but it leaves me feeling a little uneasy about it. At one >> point, I worked on a number of "simpl

Fwd: RFR: 8000780: make Zero build and run with JDK8

This patch contains a Makefile change: http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.03/make/Makefile.udiff.html -- Chris Begin forwarded message: > From: Roman Kennke > Subject: Re: RFR: Make Zero build and run with JDK8 > Date: October 17, 2012 4:09:13 PM PDT > To: Christian Thalinger

Re: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling

OBJCOPY changes look good. bill On 11/4/2012 5:32 PM, David Holmes wrote: Okay here's the final update :) http://cr.openjdk.java.net/~dholmes/8002034/webrev.03/ We now have a default objcopy when cross-compiling and I augmented the error message if no objcopy is found. These changes only a

Make File Changes For CR4239752

Hi, I have a bug fix which needs make file changes, which can be reviewed at http://cr.openjdk.java.net/~dxu/4239752/webrev/. With the above make file changes, I am able to build jdk successfully in old build system. But if I built it using new build system, the build process failed and comp

Re: RFR: 8000780: make Zero build and run with JDK8

Looks fine. Thanks for the heads up. -kto On Oct 25, 2012, at 3:41 PM, Christian Thalinger wrote: > This patch contains a Makefile change: > > http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.03/make/Makefile.udiff.html > > -- Chris > > Begin forwarded message: > >> From: Roman Kennke >>

Re: RFR 8003161: Cannot build jdk8/build using the new build system after latest merge.

On 8/11/2012 9:11 PM, Fredrik Öhrström wrote: 2012-11-08 11:52, David Holmes skrev: I don't understand this: $$(shell $(MKDIR) -p $$($1_BIN) && $(RM) $$($1_BIN)/_the.$$($1_JARNAME)_include) If you have to create the directory there can't possibly be anything to rm. ??? Two things need to be

Re: Review Request: 8002028: build-infra: need no-hotspot partial build

On 9/11/2012 12:27 AM, Erik Joelsson wrote: New webrev for root: http://cr.openjdk.java.net/~erikj/8002028/webrev.root.02/ Changed to conditional as David suggested. It seems that because hotspot is added to .PHONY then make doesn'

Re: Review Request: 8002028: build-infra: need no-hotspot partial build

On 9/11/2012 2:51 AM, Erik Joelsson wrote: And a new for jdk too. This fixes solaris. http://cr.openjdk.java.net/~erikj/8002028/webrev.jdk.02/ Here: ! $1_SRC_FILES := $(shell $(FIND) $2 -type f -a \( -name DUMMY $(addprefix