Looks good to me too.
/Erik
On 2014-02-05 11:39, Magnus Ihse Bursie wrote:
Hi Jessica,
The patch looks fine. Thank you for finding this issue and posting a
patch!
I believe such trivial changes can be accepted without the hassle of
you signing the OCA, but I need to verify that.
/Magnus
Just wondering is there a plan to deal with build warnings on Linux?
I was experimenting with macros that could be used to deal with the
-Wunused-parameter
warning, but there are over 3700 occurrences and frankly it's not a very
useful
warning in the context of JNI formal function parameters at
Michael,
I'm totally agree with you (and had sent to build-dev approx the same
letter about two weeks ago).
On my opinion we should turn off unused parameter warning, at least for
product build.
-Dmitry
On 2014-02-07 14:02, Michael McMahon wrote:
> Just wondering is there a plan to deal with b
It seems, the warning is emitted by the combination of:
-W -Wall
and could be disabled by adding -Wno-unused-parameter
Michael
On 07/02/14 10:06, Dmitry Samersoff wrote:
Michael,
I'm totally agree with you (and had sent to build-dev approx the same
letter about two weeks ago).
On my opinion
On 07/02/14 10:43, Michael McMahon wrote:
It seems, the warning is emitted by the combination of:
-W -Wall
and could be disabled by adding -Wno-unused-parameter
Given the definition of JNI method signatures, then I agree with this.
It would be really helpful to be able to see "real" warnings
Jessica,
Your patch is now committed to jdk9. Once again, thank you!
/Magnus
On 2014-02-05 11:44, Man, Jessica wrote:
Great, thank you Magnus.
I have signed the OCA,
http://www.oracle.com/technetwork/community/oca-486395.html#g under Goldman
Sachs.
-Original Message-
From: Magnus
On 2014-02-05 16:15, Omair Majid wrote:
* Andrew Hughes [2014-02-04 19:26]:
On 2014-02-03 18:43, Omair Majid wrote:
The following webrevs modify the build system to allow building against
the system-installed copy of libpng as well as using the bundled copy of
libpng
ROOT: http://cr.openjdk.j
On 07/02/2014 01:06, Magnus Ihse Bursie wrote:
It looks basically good. Some comments:
In spec.gmk.in:
+RMICONNECTOR_IIOP=@RMICONNECTOR_IIOP@
Please use := as = has a special meaning in make (late evaluation). Simple
assignment is :=.
In jdk-options.m4:
Please add a set of AC_MSG_CHECKING/RESU
Hi,
could you please review the following tiny change which fixes an issue
in the nashorn build:
https://bugs.openjdk.java.net/browse/JDK-8033951
http://cr.openjdk.java.net/~simonis/webrevs/8033951/
This fix is for jdk9 but I shink it should be down-ported into 8udev as well.
Here some backgrou
Hello Volker,
The patch looks good to me. Have you tried it on windows? I think the
quoting is correct, but would like to be sure.
/Erik
On 2014-02-07 17:44, Volker Simonis wrote:
Hi,
could you please review the following tiny change which fixes an issue
in the nashorn build:
https://bugs.
Hi Erik,
thanks for the review.
The Windows build is still running and I won't submit until it doesn't
finish successfully.
Regards,
Volker
On Fri, Feb 7, 2014 at 6:09 PM, Erik Joelsson wrote:
> Hello Volker,
>
> The patch looks good to me. Have you tried it on windows? I think the
> quoting
Part of the issue seems to be that the meaning of -Wno-unused seems to have
changed and/or become ineffective. It's reported that it previously hid all
unused parameter warnings though it doesn't seem to on any compiler I'm
currently using.
I've included -Wno-unused-parameter with the changes g
12 matches
Mail list logo
