RFR: JDK-8141261 Clean up building of demos

2015-11-03 Thread Magnus Ihse Bursie
The handling of demos has not been up to the same quality as the rest of the build. Worst of all is the use of non-named argument macros, which makes the macro calls very hard to decipher. The driver behind this fix is that I need to understand properly this code to be able to clean up flag ha

RFR: JDK-6512052 remove java-rmi.exe and java-rmi.cgi

2015-11-03 Thread Magnus Ihse Bursie
Here's an old bug from the Good Riddance Dept. The TLDR; version: The java-rmi launcher is broken and irrelevant, at the same time. And has been since JDK6 or so. Bug: https://bugs.openjdk.java.net/browse/JDK-6512052 WebRev: http://cr.openjdk.java.net/~ihse/JDK-6512052-remove-java-rmi-launche

Re: RFR: JDK-6512052 remove java-rmi.exe and java-rmi.cgi

2015-11-03 Thread Alan Bateman
On 03/11/2015 10:29, Magnus Ihse Bursie wrote: Here's an old bug from the Good Riddance Dept. The TLDR; version: The java-rmi launcher is broken and irrelevant, at the same time. And has been since JDK6 or so. Bug: https://bugs.openjdk.java.net/browse/JDK-6512052 WebRev: http://cr.openjdk.ja

RFR: JDK-8141333 Rename SetupArchive to SetupJarArchive

2015-11-03 Thread Magnus Ihse Bursie
It is not very clear that SetupArchive is actually creating a jar file. Analogous with SetupZipArchive, it should be renamed to SetupJarArchive. Also, the implementation should be moved to a separate file, out of JavaCompilation.gmk. Bug: https://bugs.openjdk.java.net/browse/JDK-8141333 WebRev

Re: RFR: JDK-8141332: Switch macosx devkit in JPRT

2015-11-03 Thread Magnus Ihse Bursie
On 2015-11-03 16:36, Erik Joelsson wrote: It's time to switch the devkit used for building for macosx in JPRT. This change also includes the changes to the devkit generation script. Bug: https://bugs.openjdk.java.net/browse/JDK-8141332 Webrev: http://cr.openjdk.java.net/~erikj/8141332/webrev.01

Re: RFR: JDK-8141261 Clean up building of demos

2015-11-03 Thread Erik Joelsson
Looks good, nice work! /Erik On 2015-11-03 10:25, Magnus Ihse Bursie wrote: The handling of demos has not been up to the same quality as the rest of the build. Worst of all is the use of non-named argument macros, which makes the macro calls very hard to decipher. The driver behind this fix

Re: RFR: JDK-8141261 Clean up building of demos

2015-11-03 Thread Tim Bell
Magnus- Looks good to me as well. /Tim On 11/03/15 08:14, Erik Joelsson wrote: Looks good, nice work! /Erik On 2015-11-03 10:25, Magnus Ihse Bursie wrote: The handling of demos has not been up to the same quality as the rest of the build. Worst of all is the use of non-named argument macro

Re: RFR: JDK-8141333 Rename SetupArchive to SetupJarArchive

2015-11-03 Thread Tim Bell
On 11/03/15 07:36, Magnus Ihse Bursie wrote: It is not very clear that SetupArchive is actually creating a jar file. Analogous with SetupZipArchive, it should be renamed to SetupJarArchive. Also, the implementation should be moved to a separate file, out of JavaCompilation.gmk. Bug: https://b

RFR: JDK-8141332: Switch macosx devkit in JPRT

2015-11-03 Thread Erik Joelsson
It's time to switch the devkit used for building for macosx in JPRT. This change also includes the changes to the devkit generation script. Bug: https://bugs.openjdk.java.net/browse/JDK-8141332 Webrev: http://cr.openjdk.java.net/~erikj/8141332/webrev.01/ /Erik

Re: RFR: JDK-8141333 Rename SetupArchive to SetupJarArchive

2015-11-03 Thread Erik Joelsson
jdk/make/gendata/GendataPolicyJars.gmk: You add "include JarArchive.gmk" but didn't remove "include JavaCompilation.gmk". Otherwise nice. /Erik On 2015-11-03 16:36, Magnus Ihse Bursie wrote: It is not very clear that SetupArchive is actually creating a jar file. Analogous with SetupZipArchiv

Re: RFR: JDK-8141332: Switch macosx devkit in JPRT

2015-11-03 Thread Tim Bell
Hi Erik On 11/03/15 07:48, Magnus Ihse Bursie wrote: On 2015-11-03 16:36, Erik Joelsson wrote: It's time to switch the devkit used for building for macosx in JPRT. This change also includes the changes to the devkit generation script. Bug: https://bugs.openjdk.java.net/browse/JDK-8141332 Webr

RFR(S): 8141290: AIX: fix build after '8140661: Rename LDFLAGS_SUFFIX to LIBS'

2015-11-03 Thread Volker Simonis
Hi, unfortunately, change '8140661: Rename LDFLAGS_SUFFIX to LIBS' broke the AIX build. Can somebody please review this small change which fixes the build? http://cr.openjdk.java.net/~simonis/webrevs/2015/8141290/ https://bugs.openjdk.java.net/browse/JDK-8141290 Besides this immediate build fi

Re: RFR: JDK-8141333 Rename SetupArchive to SetupJarArchive

2015-11-03 Thread Magnus Ihse Bursie
On 2015-11-03 17:21, Erik Joelsson wrote: jdk/make/gendata/GendataPolicyJars.gmk: You add "include JarArchive.gmk" but didn't remove "include JavaCompilation.gmk". Oops. :) Thanks. /Magnus

Re: RFR(S): 8141290: AIX: fix build after '8140661: Rename LDFLAGS_SUFFIX to LIBS'

2015-11-03 Thread Magnus Ihse Bursie
On 2015-11-03 17:20, Volker Simonis wrote: Hi, unfortunately, change '8140661: Rename LDFLAGS_SUFFIX to LIBS' broke the AIX build. I'm sorry for that. :-( Can somebody please review this small change which fixes the build? http://cr.openjdk.java.net/~simonis/webrevs/2015/8141290/ https://bu

Re: Problems with --with-override and gensrc targets

2015-11-03 Thread Magnus Ihse Bursie
On 2015-11-02 15:41, Mikael Gerdin wrote: Hi build-devs, I was trying to do a fancy setup with multiple different hotspot directories in a single source tree to create some builds for performance measurements. I used the configure flag --with-override-hotspot=hotspot-foo and when I attempted

Fwd: [verona.stage] RFR 8139986: Store debug level in java.vm.debug and conditionally print in "java -version"

2015-11-03 Thread Alejandro E Murillo
There are building changes in this RFR and I meant to include this alias but didn't. So here you go Thanks Alejandro Forwarded Message Subject: [verona.stage] RFR 8139986: Store debug level in java.vm.debug and conditionally print in "java -version" Date: Tue, 03 Nov 201

"expr: syntax error" on jdk9/dev build

2015-11-03 Thread Jonathan Gibbons
I'm seeing a bunch of "syntax error"s on an otherwise successful build of jdk9/dev. This is on Ubuntu Linux, 14.04. Is this a known problem; should I be worried? -- Jon Creating support/jce/policy/unlimited/US_export_policy.jar Creating support/jce/policy/limited/local_policy.jar Creating sup