Re: RFR: JDK-8180651: Make target to run tests on exploded image

2017-05-22 Thread Erik Joelsson
Hello, That works for me. The drawback is that run-test already has a big set of automatic suffixes for different tests to run. By using a prefix, those are more easily separated during tab completion. On the other hand, this suggestion makes it very clear what is being asked for, which is go

Re: RFR: JDK-8180480 Use "requires transitive" relationship when determining modules for javadoc

2017-05-22 Thread Magnus Ihse Bursie
On 2017-05-19 16:47, Mandy Chung wrote: On May 19, 2017, at 1:08 AM, Magnus Ihse Bursie wrote: "Indirect exports" was a good term. I dropped the "Deps" part of the name and it all became much clearer. Here's an updated webrev: http://cr.openjdk.java.net/~ihse/JDK-8180480-docs-should-use-req

Re: RFR: JDK-8180651: Make target to run tests on exploded image

2017-05-22 Thread Magnus Ihse Bursie
On 2017-05-22 09:33, Erik Joelsson wrote: Hello, That works for me. The drawback is that run-test already has a big set of automatic suffixes for different tests to run. By using a prefix, those are more easily separated during tab completion. I agree, prefix is better. Go with your origin

Re: Review Request: JDK-8180717: Upgrade the docs bundle index page

2017-05-22 Thread Magnus Ihse Bursie
On 2017-05-19 22:48, Mandy Chung wrote: This patch updates the build tool to generate an improved presentation of the module groupings. A sample page: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8180717/docs/index.html Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8180717/

Re: RFR: JDK-8175824 Adapt javadoc generation to different requirements for JDK and JavaSE

2017-05-22 Thread Magnus Ihse Bursie
On 2017-05-19 13:10, Erik Joelsson wrote: Looks good. Minor nit. There are variables named JavaSE_MODULES as well as JAVASE_MODULES which can be a bit confusing. Perhaps the latter can be inlined at this point? Or the first should perhaps be called JavaSE_GROUP_MODULES? I agree, that was con

Re: RFR: JDK-8175824 Adapt javadoc generation to different requirements for JDK and JavaSE

2017-05-22 Thread Magnus Ihse Bursie
On 2017-05-19 17:09, Mandy Chung wrote: Magnus, Iris and Kevin provides the description for each group. The overview page can look like this: This document is the Java™ Platform, Standard Edition Development Kit (JDK™) 9 API Specification. Java SE The Java Platform, Standard Editi

Re: RFR: JDK-8175824 Adapt javadoc generation to different requirements for JDK and JavaSE

2017-05-22 Thread Erik Joelsson
Looks good to me. /Erik On 2017-05-22 10:31, Magnus Ihse Bursie wrote: On 2017-05-19 17:09, Mandy Chung wrote: Magnus, Iris and Kevin provides the description for each group. The overview page can look like this: This document is the Java™ Platform, Standard Edition Development Kit (JD

Re: RFR: JDK-8175824 Adapt javadoc generation to different requirements for JDK and JavaSE

2017-05-22 Thread Mandy Chung
> On May 22, 2017, at 1:31 AM, Magnus Ihse Bursie > wrote: > > Updated version: > > http://cr.openjdk.java.net/~ihse/JDK-8175824-javadoc-dynamic-overview-and-groups/webrev.02 207 This is a list of all modules included in the $$($1_FULL_NAME) API Specification. \ I suggest to keep th

Re: Review Request: JDK-8180717: Upgrade the docs bundle index page

2017-05-22 Thread Mandy Chung
> On May 22, 2017, at 1:02 AM, Magnus Ihse Bursie > wrote: > > On 2017-05-19 22:48, Mandy Chung wrote: >> This patch updates the build tool to generate an improved presentation of >> the module groupings. A sample page: >>http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8180717/docs/index.