Re: (11) RFR (S) JDK-8198640: VS2017 (LNK4281) Link Warning Against Missed ASLR Optimization

Thank you for the review Christian!  I have gone forward and created the RFE at https://bugs.openjdk.java.net/browse/JDK-8198652. Lois On 2/23/2018 3:54 PM, Christian Tornqvist wrote: Forgot to say that the webrev looks good! On Feb 23, 2018, at 3:53 PM, Christian Tornqvist

Re: (11) RFR (S) JDK-8198640: VS2017 (LNK4281) Link Warning Against Missed ASLR Optimization

Looks good. /Erik On 2018-02-23 12:11, Lois Foltan wrote: Please review this fix to ignore linker warning (LNK4281).  This is a new linker warning generated by VS2017 v15.5 to "to point out any 64-bit image specified to link with a lower than 4GB base address doesn't get best ASLR

Re: (11) RFR (S) JDK-8198640: VS2017 (LNK4281) Link Warning Against Missed ASLR Optimization

Thanks Erik! Lois On 2/23/2018 4:08 PM, Erik Joelsson wrote: Looks good. /Erik On 2018-02-23 12:11, Lois Foltan wrote: Please review this fix to ignore linker warning (LNK4281).  This is a new linker warning generated by VS2017 v15.5 to "to point out any 64-bit image specified to link with

Re: RFR: JDK-8198627 JDK-8198318 broke readlink testing

+1 . This fixed it for me when I tried it yesterday. -phil. On 02/23/2018 06:52 AM, Erik Joelsson wrote: Looks good and thanks for picking this up! I never got around to it yesterday. /Erik On 2018-02-23 05:24, Magnus Ihse Bursie wrote: The if line introduced in JDK-8198318 is missing a

(11) RFR (S) JDK-8198312: VS2017: Upgrade HOTSPOT_BUILD_COMPILER in vm_version.cpp

Please review this small fix to set HOTSPOT_BUILD_COMPILER correctly for VS2017. open webrev at http://cr.openjdk.java.net/~lfoltan/bug_jdk8198312/webrev/ bug link https://bugs.openjdk.java.net/browse/JDK-8198312 Testing: hs-tier(1-3), jdk-tier(1-3) complete Thanks, Lois

Re: (11) RFR (S) JDK-8198312: VS2017: Upgrade HOTSPOT_BUILD_COMPILER in vm_version.cpp

Hello Lois, This looks good, but I would suggest to also add 1900 for VS2015, for completeness. /Erik On 2018-02-23 09:54, Lois Foltan wrote: Please review this small fix to set HOTSPOT_BUILD_COMPILER correctly for VS2017. open webrev at

RE: RFR(S): 8196992: Resolve disabled warnings for libdt_socket

Looks good, Chris. > -Original Message- > From: build-dev [mailto:build-dev-boun...@openjdk.java.net] On Behalf Of > Chris Plummer > Sent: Freitag, 23. Februar 2018 02:04 > To: build-dev@openjdk.java.net build-dev ; > serviceability-dev

Re: RFR: JDK-8198627 JDK-8198318 broke readlink testing

Magnus- Looks good to me as well. Thanks- /Tim On 02/23/18 06:52, Erik Joelsson wrote: Looks good and thanks for picking this up! I never got around to it yesterday. /Erik On 2018-02-23 05:24, Magnus Ihse Bursie wrote: The if line introduced in JDK-8198318 is missing a "test". Thanks to

Re: RFR: JDK-8198627 JDK-8198318 broke readlink testing

Good patch, Magnus! We've been affected by this as well but instead of digging deeper into the problem we've installed "readlink" on our AIX build machines, where it wasn't available until now. Good to know that "readlink" is still not a mandatory requirement for the build :) On Fri, Feb 23,

Re: (11) RFR (S) JDK-8198312: VS2017: Upgrade HOTSPOT_BUILD_COMPILER in vm_version.cpp

On 2/23/2018 1:05 PM, Erik Joelsson wrote: Hello Lois, This looks good, but I would suggest to also add 1900 for VS2015, for completeness. Thanks for the review Erik!  I have updated the webrev to add 1900, however, I couldn't find a release # for VS2015, since all documentation I could

Re: (11) RFR (S) JDK-8198312: VS2017: Upgrade HOTSPOT_BUILD_COMPILER in vm_version.cpp

On 2018-02-23 11:16, Lois Foltan wrote: On 2/23/2018 1:05 PM, Erik Joelsson wrote: Hello Lois, This looks good, but I would suggest to also add 1900 for VS2015, for completeness. Thanks for the review Erik!  I have updated the webrev to add 1900, however, I couldn't find a release # for

Re: (11) RFR (S) JDK-8198312: VS2017: Upgrade HOTSPOT_BUILD_COMPILER in vm_version.cpp

Thanks again for the review Erik! Lois On 2/23/2018 2:44 PM, Erik Joelsson wrote: Looks good! /Erik On 2018-02-23 11:39, Lois Foltan wrote: On 2/23/2018 2:31 PM, Erik Joelsson wrote: On 2018-02-23 11:16, Lois Foltan wrote: On 2/23/2018 1:05 PM, Erik Joelsson wrote: Hello Lois, This

Re: (11) RFR (S) JDK-8198312: VS2017: Upgrade HOTSPOT_BUILD_COMPILER in vm_version.cpp

On 2/23/2018 2:31 PM, Erik Joelsson wrote: On 2018-02-23 11:16, Lois Foltan wrote: On 2/23/2018 1:05 PM, Erik Joelsson wrote: Hello Lois, This looks good, but I would suggest to also add 1900 for VS2015, for completeness. Thanks for the review Erik!  I have updated the webrev to add 1900,

Re: (11) RFR (S) JDK-8198312: VS2017: Upgrade HOTSPOT_BUILD_COMPILER in vm_version.cpp

Looks good! /Erik On 2018-02-23 11:39, Lois Foltan wrote: On 2/23/2018 2:31 PM, Erik Joelsson wrote: On 2018-02-23 11:16, Lois Foltan wrote: On 2/23/2018 1:05 PM, Erik Joelsson wrote: Hello Lois, This looks good, but I would suggest to also add 1900 for VS2015, for completeness. Thanks

(11) RFR (S) JDK-8198640: VS2017 (LNK4281) Link Warning Against Missed ASLR Optimization

Please review this fix to ignore linker warning (LNK4281).  This is a new linker warning generated by VS2017 v15.5 to "to point out any 64-bit image specified to link with a lower than 4GB base address doesn't get best ASLR optimization". The Hotspot jvm.dll is specifically linked with

Re: (11) RFR (S) JDK-8198640: VS2017 (LNK4281) Link Warning Against Missed ASLR Optimization

Hi Lois, Why do we link jvm.dll with -base? Thanks, Christian > On Feb 23, 2018, at 3:11 PM, Lois Foltan wrote: > > Please review this fix to ignore linker warning (LNK4281). This is a new > linker warning generated by VS2017 v15.5 to "to point out any 64-bit image

Re: (11) RFR (S) JDK-8198640: VS2017 (LNK4281) Link Warning Against Missed ASLR Optimization

On 2/23/2018 3:18 PM, Christian Tornqvist wrote: Hi Lois, Why do we link jvm.dll with -base? Hi Christian, It is not clear to me why we do, so I was going to follow up with an RFE to investigate & suggest the removal of -base if unnecessary. Lois Thanks, Christian On Feb 23, 2018, at

Re: (11) RFR (S) JDK-8198640: VS2017 (LNK4281) Link Warning Against Missed ASLR Optimization

Sounds like a good plan :) Thanks, Christian > On Feb 23, 2018, at 3:22 PM, Lois Foltan wrote: > >> On 2/23/2018 3:18 PM, Christian Tornqvist wrote: >> >> Hi Lois, >> >> Why do we link jvm.dll with -base? > Hi Christian, > It is not clear to me why we do, so I was

Re: (11) RFR (S) JDK-8198640: VS2017 (LNK4281) Link Warning Against Missed ASLR Optimization

Forgot to say that the webrev looks good! > On Feb 23, 2018, at 3:53 PM, Christian Tornqvist > wrote: > > Sounds like a good plan :) > > Thanks, > Christian > >>> On Feb 23, 2018, at 3:22 PM, Lois Foltan wrote: >>> >>> On 2/23/2018

Re: RFR(S): 8196992: Resolve disabled warnings for libdt_socket

Chris, This looks good to me too. Thanks, Serguei On 2/23/18 00:48, Langer, Christoph wrote: Looks good, Chris. -Original Message- From: build-dev [mailto:build-dev-boun...@openjdk.java.net] On Behalf Of Chris Plummer Sent: Freitag, 23. Februar 2018 02:04 To:

Re: RFR(S): 8196992: Resolve disabled warnings for libdt_socket

On 2018-02-23 02:03, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8196992 diff --git a/make/lib/Lib-jdk.jdwp.agent.gmk b/make/lib/Lib-jdk.jdwp.agent.gmk --- a/make/lib/Lib-jdk.jdwp.agent.gmk +++ b/make/lib/Lib-jdk.jdwp.agent.gmk @@ -43,7

Re: RFR: JDK-8198569: SetupTextFileProcessing should use sed with 'g'

On 2018-02-22 23:26, Erik Joelsson wrote: I'm currently trying to use SetupTextFileProcessing with a file where the same replacement string appears twice on the same row. This doesn't work. To fix it, I would like to add /g on the sed replacement expressions. Oops :) Webrev:

RFR: JDK-8198627 JDK-8198318 broke readlink testing

The if line introduced in JDK-8198318 is missing a "test". Thanks to Jon and Erik for discovering the problem and the solution. Bug: https://bugs.openjdk.java.net/browse/JDK-8198627 Patch inline: diff --git a/make/autoconf/basics.m4 b/make/autoconf/basics.m4 --- a/make/autoconf/basics.m4 +++

Re: RFR: JDK-8198243: Add build time check for global operator new/delete in object files

On 2018-02-22 20:41, Erik Joelsson wrote: On 2018-02-21 21:06, David Holmes wrote: On 22/02/2018 4:07 AM, Erik Joelsson wrote: Hello, On 2018-02-20 21:33, David Holmes wrote: a) how much time it adds to the build? I have not done extensive testing, but on my Linux workstation with 32

Re: RFR: JDK-8198627 JDK-8198318 broke readlink testing

Looks good and thanks for picking this up! I never got around to it yesterday. /Erik On 2018-02-23 05:24, Magnus Ihse Bursie wrote: The if line introduced in JDK-8198318 is missing a "test". Thanks to Jon and Erik for discovering the problem and the solution. Bug: