Hi Jakub,
Please see comments inline.
And one more point: please remove links to mail threads from sources
(http://mail.openjdk.java.net/pipermail/aarch32-port-dev/2016-November/000611.html).
Boris
12.12.2018 17:36, Jakub Vaněk пишет:
Hi Erik,
On 2018-12-12 at 15:41 +0300, Boris Ulasevich
Hi Magnus , thanks for working on this ! The patch looks good to me (not a
Reviewer however).
I put your patch into our internal build/test patch queue , will come
back in case I notice any issues .
Best regards, Matthias
> Date: Wed, 12 Dec 2018 19:28:39 -0500
> From: Kim Barrett
On 2018-12-12 23:17, David Holmes wrote:
Hi Magnus,
What did -Xa do?
I believe Kim has answered this satisfactory.
Do AWT folk need to check this.
I'm adding awt and 2d lists to this review.
I find it hard to understand the connection between:
I'm not sure there is a connection..? It's
On 2018-12-12 13:17, David Holmes wrote:
Okay I went away and did some homework ...
Let me back up a bit and see if I have the evolution of this correctly.
The native implementation of Java methods should be declared and
defined with JNIEXPORT and JNICALL.
JNIEXPORT controls the export
On 2018-12-13 08:48, Andrew Luo wrote:
Hi,
I attached the latest patch, which now can use Windows paths.
Great!
I looked at the code, and it looks really good. Just one request. I
understand why you want to unify the similar code between msys and wsl,
but unless you have actually verified
Hi,
I have made a mistake when editing the patch (I forgot to change the
added line count in one header).
https://raw.githubusercontent.com/ev3dev-lang-java/openjdk-ev3/52d38ea739fda826759f171313991717e477c31d/upstream/softfloat.patch
Thanks,
Jakub
čt 13. 12. 2018 v 14:10 odesílatel Jakub
Hmm, the patch still fails. I will have to redo the changes
in the source tree and then reexport the patch. Editing
the patch file manually wasn't a good idea.
Thanks,
Jakub
čt 13. 12. 2018 v 14:21 odesílatel Jakub Vaněk napsal:
>
> Hi,
>
> I have made a mistake when editing the patch (I
Bug;
https://bugs.openjdk.java.net/browse/JDK-8215356
There are lots of hotspot/tier1 tests on x86_32 caused by Shenandoah. This mode
is experimental, and
we can disable it without prejudice to make tests clean. Once x86_32 support is
fixed, we can
re-enable it back.
Fix:
diff -r
ok by me. Thanks!
Roman
Am 13.12.18 um 14:58 schrieb Aleksey Shipilev:
> Bug;
> https://bugs.openjdk.java.net/browse/JDK-8215356
>
> There are lots of hotspot/tier1 tests on x86_32 caused by Shenandoah. This
> mode is experimental, and
> we can disable it without prejudice to make tests
Hi Boris,
I have updated the patch:
https://raw.githubusercontent.com/ev3dev-lang-java/openjdk-ev3/0887015e0dfcc45ffed03872a8ad42a609496459/upstream/softfloat.patch
Now reinterpret_cast is used and the URL is present
only in the documentation for enabling flags.
I didn't expect a performance
Thanks!
I would like to consider it trivial. Build system devs, are you good with this?
-Aleksey
On 12/13/18 3:30 PM, Roman Kennke wrote:
> ok by me. Thanks!
> Roman
>
> Am 13.12.18 um 14:58 schrieb Aleksey Shipilev:
>> Bug;
>> https://bugs.openjdk.java.net/browse/JDK-8215356
>>
>> There are
Yes.
/Magnus
> 13 dec. 2018 kl. 16:02 skrev Aleksey Shipilev :
>
> Thanks!
>
> I would like to consider it trivial. Build system devs, are you good with
> this?
>
> -Aleksey
>
>> On 12/13/18 3:30 PM, Roman Kennke wrote:
>> ok by me. Thanks!
>> Roman
>>
>>> Am 13.12.18 um 14:58 schrieb
(Also, for build changes there are no hard and fast rules about reviews like in
Hotspot. A single review is typically okay.)
/Magnus
> 13 dec. 2018 kl. 16:34 skrev Magnus Ihse Bursie
> :
>
> Yes.
>
> /Magnus
>
>> 13 dec. 2018 kl. 16:02 skrev Aleksey Shipilev :
>>
>> Thanks!
>>
>> I would
Noted.
Pushed.
Thanks!
-Aleksey
On 12/13/18 4:36 PM, Magnus Ihse Bursie wrote:
> (Also, for build changes there are no hard and fast rules about reviews like
> in Hotspot. A single review is typically okay.)
>
> /Magnus
>
>> 13 dec. 2018 kl. 16:34 skrev Magnus Ihse Bursie
>> :
>>
>> Yes.
On 2018-12-13 11:44, Andrew Luo wrote:
Oh, also, using WSLPATH to set PATH/l causes a LOT of extra output, namely,
every time a Win32 executable is run this gets printed:
<3>init: (21845) ERROR: UtilTranslatePathList:2021: Failed to translate
/usr/local/sbin
<3>init: (21845) ERROR:
Oh, also, using WSLPATH to set PATH/l causes a LOT of extra output, namely,
every time a Win32 executable is run this gets printed:
<3>init: (21845) ERROR: UtilTranslatePathList:2021: Failed to translate
/usr/local/sbin
<3>init: (21845) ERROR: UtilTranslatePathList:2021: Failed to translate
Didn't see this message before I sent mine out. How about an environment
variable instead? I don't want to make too much changes to the argument
parsing logic, etc. of fixpath, instead in -w mode it could read an environment
variable, perhaps FIXPATH_PATH and set PATH to that?
Thanks,
Maybe we can get fixpath to help here? It could take an extra argument with -w,
the additional directories to add to PATH before executing the target command?
/Magnus
> 13 dec. 2018 kl. 21:36 skrev Erik Joelsson :
>
>> On 2018-12-13 11:44, Andrew Luo wrote:
>> Oh, also, using WSLPATH to set
On 2018-12-13 02:11, Magnus Ihse Bursie wrote:
-D_XPG6
??
To be honest, I'm not completely sure about this. Without this define,
the build failed with the following error message:
Compiler or options invalid for pre-UNIX 03 X/Open applications and
pre-2001 POSIX applications
This was
I just tried your suggestion. $CC is passed as a parameter to fixpath
sometimes, so it will require a decent bit of work to get working. Also, when
executing commands on bash in the format "$CC ..." $CC has to be an actual
command - it can't have extra environment variables set at the
Hello,
It's nice to see this progressing!
I just wanted to let you know I took your patch from yesterday and
started experimenting too. I managed to get configure to automatically
find the Visual Studio installation as Magnus described, when running in
a pure WSL shell without VS env. I
21 matches
Mail list logo
