On 2019-10-16 14:55, Erik Joelsson wrote:
Build change looks good now.
I agree.
/Magnus
/Erik
On 2019-10-16 05:50, Jan Lahoda wrote:
Hi,
An updated patch is here:
http://cr.openjdk.java.net/~jlahoda/8226585/webrev.02/
Changes in the update:
-added the dependency into the makefiles
On 2019-10-22 09:36, David Holmes wrote:
Hi Magnus,
On 22/10/2019 5:17 pm, Magnus Ihse Bursie wrote:
The -Wextra option to gcc enables a bunch of useful warnings. Some of
them, but not all, can be individually enabled or disabled. All other
libraries in OpenJDK are compiled with -Wextra, but
On 2019-10-22 05:22, mark.reinh...@oracle.com wrote:
RFE: https://bugs.openjdk.java.net/browse/JDK-8232080
CSR: https://bugs.openjdk.java.net/browse/JDK-8232753
Webrev: https://cr.openjdk.java.net/~mr/rev/8232080/
Build changes look good.
/Magnus
This change implements jlink plugins, and
The -Wextra option to gcc enables a bunch of useful warnings. Some of
them, but not all, can be individually enabled or disabled. All other
libraries in OpenJDK are compiled with -Wextra, but not Hotspot.
Enabling -Wextra triggers a couple of warnings that can be individually
disabled. (The
Hi all,
May I get reviews for this one-line change?
JBS: https://bugs.openjdk.java.net/browse/JDK-8232768
Webrev: http://cr.openjdk.java.net/~jiefu/8232768/webrev.00/
This kind of configuration, with both --disable-cds and
--enable-generate-classlist, will fail.
The failure is caused by
On 2019-10-22 09:44, Jie Fu wrote:
Hi all,
May I get reviews for this one-line change?
JBS: https://bugs.openjdk.java.net/browse/JDK-8232768
Webrev: http://cr.openjdk.java.net/~jiefu/8232768/webrev.00/
This kind of configuration, with both --disable-cds and
--enable-generate-classlist,
On 2019-10-21 17:45, Erik Joelsson wrote:
On 2019-10-21 02:46, Magnus Ihse Bursie wrote:
On 2019-10-21 09:43, Per Liden wrote:
Hi Erik,
On 10/18/19 2:54 PM, Erik Joelsson wrote:
Hello Leo,
When removing a JVM feature from the VALID_JVM_FEATURES list, it
needs to be added to the
As a part of the ongoing process of cleaning up and improving our
handling of warnings, the time has now come to the solstudio compiler.
(I know this is not the most relevant of compilers, but I actually
started out with the warning cleanup project on solstudio, since it's a
simple, but
Hi Magnus,
Thanks for your review and valuable comments.
It is the second case since the VM will report an error for
DumpLoadedClassList when CDS is disabled.
So generate-classlist *never* will work with CDS disabled.
Updated: http://cr.openjdk.java.net/~jiefu/8232768/webrev.01/
Please
On 22/10/2019 04:22, mark.reinh...@oracle.com wrote:
RFE: https://bugs.openjdk.java.net/browse/JDK-8232080
CSR: https://bugs.openjdk.java.net/browse/JDK-8232753
Webrev: https://cr.openjdk.java.net/~mr/rev/8232080/
I've read through the code for the new jlink plugins and the changes to
Hi Magnus,
On 22/10/2019 5:17 pm, Magnus Ihse Bursie wrote:
The -Wextra option to gcc enables a bunch of useful warnings. Some of
them, but not all, can be individually enabled or disabled. All other
libraries in OpenJDK are compiled with -Wextra, but not Hotspot.
Enabling -Wextra triggers a
On 2019-10-22 14:52, Jie Fu wrote:
Hi Magnus,
Thanks for your review and valuable comments.
It is the second case since the VM will report an error for
DumpLoadedClassList when CDS is disabled.
So generate-classlist *never* will work with CDS disabled.
Updated:
> On Oct 22, 2019, at 3:17 AM, Magnus Ihse Bursie
> wrote:
>
> I have tested that this compiles without warnings on gcc 4.8, 5.5, 6.5, 7.4
> and 8.3 on x64. I have also tried building zero on x64, aarch64 and arm32
> with gcc 8.3.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8211073
>
When RunTest.gmk runs jtreg tests, it prints the exitcode of jtreg into
a file named exitcode.txt. Soemtimes, this fails and the exitcode.txt
file is left empty. This is causing trouble in automated testing where
the surrounding framework is expecting to check the result in that file.
I
On 10/21/19 8:22 PM, mark.reinh...@oracle.com wrote:
RFE: https://bugs.openjdk.java.net/browse/JDK-8232080
CSR: https://bugs.openjdk.java.net/browse/JDK-8232753
Webrev: https://cr.openjdk.java.net/~mr/rev/8232080/
Looks good to me. One minor comment:
AddResourcePlugin isn't really a
In arguments.cpp, could you use a new JVMFlag to declare options that came from
this resource as RESOURCE?
- jint result = parse_each_vm_init_arg(vm_options_args, _mod_javabase,
JVMFlag::INTERNAL);
+ jint result = parse_each_vm_init_arg(vm_options_args, _mod_javabase,
JVMFlag::RESOURCE);
This
Looks good.
/Erik
On 2019-10-22 02:35, Magnus Ihse Bursie wrote:
As a part of the ongoing process of cleaning up and improving our
handling of warnings, the time has now come to the solstudio compiler.
(I know this is not the most relevant of compilers, but I actually
started out with the
Hi!
I will add "cmsgc" like so: DEPRECATED_JVM_FEATURES="trace cmsgc"
Should I file a reminder bug for later removal of that feature (I guess
not)? If I should, at what version should it be removed?
Thanks for finding this!
/Leo
On 21/10/2019 17:45, Erik Joelsson wrote:
On 2019-10-21
Looks good.
/Erik
On 2019-10-22 00:17, Magnus Ihse Bursie wrote:
The -Wextra option to gcc enables a bunch of useful warnings. Some of
them, but not all, can be individually enabled or disabled. All other
libraries in OpenJDK are compiled with -Wextra, but not Hotspot.
Enabling -Wextra
HotSpot changes seem fine to me.
Thanks,
Vladimir
On 10/21/19 8:22 PM, mark.reinh...@oracle.com wrote:
RFE: https://bugs.openjdk.java.net/browse/JDK-8232080
CSR: https://bugs.openjdk.java.net/browse/JDK-8232753
Webrev: https://cr.openjdk.java.net/~mr/rev/8232080/
This change implements jlink
On 2019-10-22 09:30, Leo Korinth wrote:
Hi!
I will add "cmsgc" like so: DEPRECATED_JVM_FEATURES="trace cmsgc"
Yes, exactly. Thanks!
Should I file a reminder bug for later removal of that feature (I
guess not)? If I should, at what version should it be removed?
Thanks for finding this!
2019/10/22 10:31:55 -0700, bob.vande...@oracle.com:
> In arguments.cpp, could you use a new JVMFlag to declare options that came
> from this resource as RESOURCE?
>
> - jint result = parse_each_vm_init_arg(vm_options_args, _mod_javabase,
> JVMFlag::INTERNAL);
> + jint result =
2019/10/22 7:15:10 -0700, alan.bate...@oracle.com:
> On 22/10/2019 04:22, mark.reinh...@oracle.com wrote:
>> RFE: https://bugs.openjdk.java.net/browse/JDK-8232080
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8232753
>> Webrev: https://cr.openjdk.java.net/~mr/rev/8232080/
>
> I've read through
> On Oct 22, 2019, at 3:22 PM, mark.reinh...@oracle.com wrote:
>
> 2019/10/22 10:31:55 -0700, bob.vande...@oracle.com:
>> In arguments.cpp, could you use a new JVMFlag to declare options that came
>> from this resource as RESOURCE?
>>
>> - jint result =
2019/10/22 14:12:18 -0700, mandy.ch...@oracle.com:
> On 10/21/19 8:22 PM, mark.reinh...@oracle.com wrote:
>> RFE: https://bugs.openjdk.java.net/browse/JDK-8232080
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8232753
>> Webrev: https://cr.openjdk.java.net/~mr/rev/8232080/
>
> Looks good to me.
Hotspot changes look good to me.
Bob.
> On Oct 22, 2019, at 6:36 PM, mark.reinh...@oracle.com wrote:
>
> 2019/10/22 12:43:42 -0700, bob.vande...@oracle.com:
>>> On Oct 22, 2019, at 3:22 PM, mark.reinh...@oracle.com wrote:
>>> 2019/10/22 10:31:55 -0700, bob.vande...@oracle.com:
In
Hi Magnus,
Thank you very much.
Yes, I need a sponsor.
Thanks a lot.
Best regards,
Jie
On 2019/10/23 上午5:14, Magnus Ihse Bursie wrote:
On 2019-10-22 14:52, Jie Fu wrote:
Hi Magnus,
Thanks for your review and valuable comments.
It is the second case since the VM will report an error for
On 10/22/19 3:37 PM, mark.reinh...@oracle.com wrote:
2019/10/22 14:12:18 -0700, mandy.ch...@oracle.com:
On 10/21/19 8:22 PM, mark.reinh...@oracle.com wrote:
RFE: https://bugs.openjdk.java.net/browse/JDK-8232080
CSR: https://bugs.openjdk.java.net/browse/JDK-8232753
Webrev:
+1
Thanks
Vladimir
> On Oct 22, 2019, at 3:42 PM, Bob Vandette wrote:
>
> Hotspot changes look good to me.
>
> Bob.
>
>
>> On Oct 22, 2019, at 6:36 PM, mark.reinh...@oracle.com wrote:
>>
>> 2019/10/22 12:43:42 -0700, bob.vande...@oracle.com:
> On Oct 22, 2019, at 3:22 PM,
2019/10/22 12:43:42 -0700, bob.vande...@oracle.com:
>> On Oct 22, 2019, at 3:22 PM, mark.reinh...@oracle.com wrote:
>> 2019/10/22 10:31:55 -0700, bob.vande...@oracle.com:
>>> In arguments.cpp, could you use a new JVMFlag to declare options
>>> that came from this resource as RESOURCE?
>>>
>>> -
30 matches
Mail list logo
