On 2020-06-30 12:32, Kim Barrett wrote:
On Jun 30, 2020, at 6:08 AM, Magnus Ihse Bursie
wrote:
Currently hotspot/share/utilities/globalDefinitions_visCPP.hpp contains a lot
of #pragma warning( disable : ...).
All these globally disabled warnings should move to the make files instead.
I
On 2020-06-30 01:20, Ludovic Henry wrote:
Hi Magnus,
I have now looked a bit more closely at the code. This is what I have
found so far that attracted my eye. Please note that this is not a
complete review. When you have a JEP and a test plan for how to verify
these changes and make sure
Hi all,
Please review this change.
This change is happen on discussion for WSL 2 support [1], but I tested this
change on WSL 1 (Ubuntu 20.04).
JBS: https://bugs.openjdk.java.net/browse/JDK-8248526
webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8248526/webrev.00/
I saw two configure
On 2020-06-30 09:47, Yasumasa Suenaga wrote:
Hi all,
Please review this change.
This change is happen on discussion for WSL 2 support [1], but I
tested this change on WSL 1 (Ubuntu 20.04).
JBS: https://bugs.openjdk.java.net/browse/JDK-8248526
webrev:
We should use SetupJdkLibrary instead of SetupNativeCompilation for
hotspot libraries. This does not make any difference right now, but will
facilitate upcoming changes.
I have tested with COMPARE_BUILD on linux to verify that libjvm.so is
bit-by-bit identical after this change. Other
Currently hotspot/share/utilities/globalDefinitions_visCPP.hpp contains
a lot of #pragma warning( disable : ...).
All these globally disabled warnings should move to the make files instead.
I also cleaned out some versions checks that are no longer relevant for
the range of supported versions
> On Jun 30, 2020, at 6:48 AM, Magnus Ihse Bursie
> wrote:
>
> On 2020-06-30 12:32, Kim Barrett wrote:
>>> On Jun 30, 2020, at 6:08 AM, Magnus Ihse Bursie
>>> wrote:
>>>
>>> Currently hotspot/share/utilities/globalDefinitions_visCPP.hpp contains a
>>> lot of #pragma warning( disable : ...).
Hi Jorn,
On 2020-06-30 14:52, Jorn Vernee wrote:
Hi Claes,
I see what you mean.
I've created a patch that instead greps through all the benchmark source
files, and finds files with `--enable-preview` in them. Then, only those
files are compiled with --enable-preview, by using a separate
Hi Claes,
I see what you mean.
I've created a patch that instead greps through all the benchmark source
files, and finds files with `--enable-preview` in them. Then, only those
files are compiled with --enable-preview, by using a separate call to
SetupJavaCompilation.
This relies on the
Looks good.
/Erik
On 2020-06-30 02:55, Magnus Ihse Bursie wrote:
We should use SetupJdkLibrary instead of SetupNativeCompilation for
hotspot libraries. This does not make any difference right now, but
will facilitate upcoming changes.
I have tested with COMPARE_BUILD on linux to verify that
On 2020-06-30 15:13, Claes Redestad wrote:
Hi Jorn,
On 2020-06-30 14:52, Jorn Vernee wrote:
Hi Claes,
I see what you mean.
I've created a patch that instead greps through all the benchmark
source files, and finds files with `--enable-preview` in them. Then,
only those files are compiled
Looks good.
/Erik
On 2020-06-30 03:08, Magnus Ihse Bursie wrote:
Currently hotspot/share/utilities/globalDefinitions_visCPP.hpp
contains a lot of #pragma warning( disable : ...).
All these globally disabled warnings should move to the make files
instead.
I also cleaned out some versions
On 2020-06-30 07:15, Magnus Ihse Bursie wrote:
On 2020-06-30 15:13, Claes Redestad wrote:
Hi Jorn,
On 2020-06-30 14:52, Jorn Vernee wrote:
Hi Claes,
I see what you mean.
I've created a patch that instead greps through all the benchmark
source files, and finds files with
Hello
Please review this fix for zero vm building on macos.
The issue comes from the libffi, it’s headers are located inside
usr/include/ffi/ folder in Macos.sdk, so it can’t be found by configure script.
If one wants to use system’s libffi and pass path to libffi via configure
argument as
The gtest build code contains some errors (e.g. sending -w to all
compilers, which cause a warning for cl.exe), and some non-standard
handling of warnings.
Bug: https://bugs.openjdk.java.net/browse/JDK-8248563
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8248563-fix-gtest-cflags/webrev.01
On 2020/06/30 22:50, Magnus Ihse Bursie wrote:
On 2020-06-30 14:11, Yasumasa Suenaga wrote:
Thanks Magnus!
We cannot build OpenJDK on Windows 10 May 2020 update even if we use WSL 1.
So I will push this change when I got second reviewer.
The two-reviewer rule is only for hotspot code. Build
On 2020-06-30 16:48, Erik Joelsson wrote:
On 2020-06-30 07:15, Magnus Ihse Bursie wrote:
On 2020-06-30 15:13, Claes Redestad wrote:
Hi Jorn,
On 2020-06-30 14:52, Jorn Vernee wrote:
Hi Claes,
I see what you mean.
I've created a patch that instead greps through all the benchmark
> On Jun 30, 2020, at 6:08 AM, Magnus Ihse Bursie
> wrote:
>
> Currently hotspot/share/utilities/globalDefinitions_visCPP.hpp contains a lot
> of #pragma warning( disable : ...).
>
> All these globally disabled warnings should move to the make files instead.
>
> I also cleaned out some
On 2020-06-30 18:19, Claes Redestad wrote:
On 2020-06-30 17:16, Magnus Ihse Bursie wrote:
On 2020-06-30 16:48, Erik Joelsson wrote:
On 2020-06-30 07:15, Magnus Ihse Bursie wrote:
On 2020-06-30 15:13, Claes Redestad wrote:
Hi Jorn,
On 2020-06-30 14:52, Jorn Vernee wrote:
Hi Claes,
Hello
I agree modding hpp files is a bad idea
Thanks for idea with setting LIBFFI_CFLAGS
here is updated webrev: http://cr.openjdk.java.net/~vkempik/8248495/webrev.01/
AC_CHECK_HEADERS ignored CFLAGS for some reason, so modding header_name for it
was still needed.
This special case only
Thanks Magnus!
We cannot build OpenJDK on Windows 10 May 2020 update even if we use WSL 1.
So I will push this change when I got second reviewer.
I hope we can build OpenJDK on WSL 2, and I will help you if I can :)
Yasumasa
On 2020/06/30 18:24, Magnus Ihse Bursie wrote:
On 2020-06-30
On 2020-06-30 14:11, Yasumasa Suenaga wrote:
Thanks Magnus!
We cannot build OpenJDK on Windows 10 May 2020 update even if we use
WSL 1.
So I will push this change when I got second reviewer.
The two-reviewer rule is only for hotspot code. Build changes only
requires one review, so you are
On 2020-06-30 18:40, Magnus Ihse Bursie wrote:
An alternative workaround would be to add
@Fork(jvmArgsAppend = "--enable-preview") to all micros, whether
they use preview features or not. Perhaps that wouldn't be so bad,
actually.
That sounds like a reasonable compromise, yes.
Well, it
On 2020-06-30 17:16, Magnus Ihse Bursie wrote:
On 2020-06-30 16:48, Erik Joelsson wrote:
On 2020-06-30 07:15, Magnus Ihse Bursie wrote:
On 2020-06-30 15:13, Claes Redestad wrote:
Hi Jorn,
On 2020-06-30 14:52, Jorn Vernee wrote:
Hi Claes,
I see what you mean.
I've created a patch
Vladimir,
This looks like it can break in other situation than your specific case.
It sounds like you should set LIBFFI_CFLAGS= to -Iinstallation>, such that "/ffi.h" exists.
In particular, the change of include path in globalDefinitions_zero.hpp
looks bad.
/Magnus
On 2020-06-30 15:33,
On 2020-06-30 19:32, Claes Redestad wrote:
On 2020-06-30 18:40, Magnus Ihse Bursie wrote:
An alternative workaround would be to add
@Fork(jvmArgsAppend = "--enable-preview") to all micros, whether
they use preview features or not. Perhaps that wouldn't be so bad,
actually.
That sounds like a
On 2020-06-30 13:15, Claes Redestad wrote:
On 2020-06-30 22:12, Magnus Ihse Bursie wrote:
Second to that a solution in the build would be preferable - if we can
come up with something that has infinitesimal impact to build times.
Are we talking about many files? Could you consider listing
Hello,
Please review a small change to bring JDK 16's --release information for
JDK 15 up to date with JDK 15 b29:
JDK-8247534: Update --release 15 symbol information for JDK 15 build 29
http://cr.openjdk.java.net/~darcy/8247534.0/
Patch below.
Thanks,
-Joe
---
On 2020-06-30 21:08, Vladimir Kempik wrote:
Hello
I agree modding hpp files is a bad idea
Thanks for idea with setting LIBFFI_CFLAGS
here is updated webrev: http://cr.openjdk.java.net/~vkempik/8248495/webrev.01/
I still think you are doing this too complicated, and the wrong way around.
On 2020-06-30 22:12, Magnus Ihse Bursie wrote:
Second to that a solution in the build would be preferable - if we can
come up with something that has infinitesimal impact to build times.
Are we talking about many files? Could you consider listing those files
explicitly in the makefile? That
On 2020-07-01 01:50, jiefu(傅杰) wrote:
Hi Vladimir and Magnus,
How about configuring with --with-libffi=... like this:
--with-libffi=/usr/local/Cellar/libffi/3.2.1/lib/libffi-3.2.1
--disable-warnings-as-errors
I can compile zero vm on our macos platforms with that configuration.
Looks good.
/Erik
On 2020-06-30 08:19, Magnus Ihse Bursie wrote:
The gtest build code contains some errors (e.g. sending -w to all
compilers, which cause a warning for cl.exe), and some non-standard
handling of warnings.
Bug: https://bugs.openjdk.java.net/browse/JDK-8248563
WebRev:
Hi Vladimir and Magnus,
How about configuring with --with-libffi=... like this:
--with-libffi=/usr/local/Cellar/libffi/3.2.1/lib/libffi-3.2.1
--disable-warnings-as-errors
I can compile zero vm on our macos platforms with that configuration.
Thanks.
Best regards,
Jie
On 2020/7/1,
The logic for handling .rc files in Windows has been quite messy. The
variable RCFLAGS was incorrectly named RC_FLAGS. In it, we mixed
tool-specific values with defines needed by version.rc. The contents of
version.rc was needlessly copied in several places, with some variation.
Some of the
Hi all,
May I get reviews for this fix?
JBS:https://bugs.openjdk.java.net/browse/JDK-8248612
Webrev: http://cr.openjdk.java.net/~jiefu/8248612/webrev.00/
Thanks a lot.
Best regards,
Jie
35 matches
Mail list logo
