On 28/03/2022 4:56 pm, Alan Bateman wrote:
On 28/03/2022 07:46, David Holmes wrote:
Hi Jai,
It isn't obvious to me that the bundled sources are actually intended
to build on macOS. There's no include of unistd.h to get the lseek
definition.
I think the context here is that Jai is chasing an i
On Mon, 28 Mar 2022 06:46:30 GMT, Christian Hagedorn
wrote:
> Ping - may I get another review for this change?
I'll take a look later today or tomorrow. This is nice stuff, I'm looking
forward to having it upstream.
-
PR: https://git.openjdk.java.net/jdk/pull/7126
On Mon, 28 Mar 2022 08:44:10 GMT, Thomas Stuefe wrote:
> > Ping - may I get another review for this change?
>
> I'll take a look later today or tomorrow. This is nice stuff, I'm looking
> forward to having it upstream.
That's great, thanks Thomas!
-
PR: https://git.openjdk.java.n
On Mon, 28 Feb 2022 16:22:25 GMT, Christian Hagedorn
wrote:
>> When printing the native stack trace on Linux (mostly done for hs_err
>> files), it only prints the method with its parameters and a relative offset
>> in the method:
>>
>> Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x000
On Mon, 28 Mar 2022 09:13:39 GMT, Yasumasa Suenaga wrote:
> As I said before, I think it would be nice to share DWARF parser between SA
> and HotSpot. Can you expose these mechanisms? It may be another RFE, and may
> need to think other platforms.
That would be good to have. However, I'm not f
On 2022-03-28 09:03, David Holmes wrote:
On 28/03/2022 4:56 pm, Alan Bateman wrote:
On 28/03/2022 07:46, David Holmes wrote:
Hi Jai,
It isn't obvious to me that the bundled sources are actually
intended to build on macOS. There's no include of unistd.h to get
the lseek definition.
I think th
On Sun, 27 Mar 2022 05:08:52 GMT, Mikael Vidstedt wrote:
> Oracle is updating the version of Visual Studio for building the JDK on
> Windows to Visual Studio 2022 17.1.0.
>
> This change adds support for building devkits based on VS 2022. Instead of
> creating a new script file for that I deci
On Mon, 28 Feb 2022 16:22:25 GMT, Christian Hagedorn
wrote:
>> When printing the native stack trace on Linux (mostly done for hs_err
>> files), it only prints the method with its parameters and a relative offset
>> in the method:
>>
>> Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x000
On Tue, 8 Feb 2022 08:17:17 GMT, Christian Hagedorn
wrote:
>> When printing the native stack trace on Linux (mostly done for hs_err
>> files), it only prints the method with its parameters and a relative offset
>> in the method:
>>
>> Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x
On Thu, 24 Feb 2022 08:14:34 GMT, Thomas Stuefe wrote:
>> Christian Hagedorn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Make dwarf tag NOT_PRODUCT
>
> src/hotspot/share/utilities/decoder_elf.cpp line 67:
>
>> 65: if (!os::dll_add
On Mon, 28 Mar 2022 12:20:44 GMT, Thomas Stuefe wrote:
>> Christian Hagedorn has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 54 commits:
>>
>> - Updating some comments
>> - Cleanup loading dwarf file and add summary
>> - Review
On Mon, 28 Mar 2022 11:54:28 GMT, Magnus Ihse Bursie wrote:
>> Mikael Vidstedt has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove PROGRAMFILES workaround
>
> make/devkit/createWindowsDevkit.sh line 74:
>
>> 72: # Work around the ins
> Oracle is updating the version of Visual Studio for building the JDK on
> Windows to Visual Studio 2022 17.1.0.
>
> This change adds support for building devkits based on VS 2022. Instead of
> creating a new script file for that I decided to combine it with the logic in
> createWindowsDevkit2
> Oracle is updating the version of Visual Studio for building the JDK on
> Windows to Visual Studio 2022 17.1.0.
>
> This change adds support for building devkits based on VS 2022. Instead of
> creating a new script file for that I decided to combine it with the logic in
> createWindowsDevkit2
On Mon, 28 Mar 2022 16:05:03 GMT, Mikael Vidstedt wrote:
>> make/devkit/createWindowsDevkit.sh line 74:
>>
>>> 72: # Work around the insanely named ProgramFiles(x86) env variable
>>> 73: PROGRAMFILES_X86="$($WINDOWS_PATH_TO_UNIX_PATH "$(cmd.exe /c set | sed
>>> -n 's/^ProgramFiles(x86)=//p' | t
On Mon, 28 Mar 2022 16:40:31 GMT, Mikael Vidstedt wrote:
>> Oracle is updating the version of Visual Studio for building the JDK on
>> Windows to Visual Studio 2022 17.1.0.
>>
>> This change adds support for building devkits based on VS 2022. Instead of
>> creating a new script file for that I
On Mon, 28 Mar 2022 12:58:20 GMT, Thomas Stuefe wrote:
>> Christian Hagedorn has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 54 commits:
>>
>> - Updating some comments
>> - Cleanup loading dwarf file and add summary
>> - Review
On Mon, 28 Mar 2022 11:18:36 GMT, Christian Hagedorn
wrote:
>> As I said before, I think it would be nice to share DWARF parser between SA
>> and HotSpot. Can you expose these mechanisms? It may be another RFE, and may
>> need to think other platforms.
>
>> As I said before, I think it would b
Hello Magnus,
On 28/03/22 5:21 pm, Magnus Ihse Bursie wrote:
On 2022-03-28 09:03, David Holmes wrote:
On 28/03/2022 4:56 pm, Alan Bateman wrote:
On 28/03/2022 07:46, David Holmes wrote:
Hi Jai,
It isn't obvious to me that the bundled sources are actually
intended to build on macOS. There's
19 matches
Mail list logo
