Re: What am I doing wrong here?

2008-03-19 Thread iris clark
I'll make sure that these comments gets to the guide writing team: [EMAIL PROTECTED] Received. Thanks, iris

Re: [PATCH] Remove dependency on JScheme for generating CORBA exceptions

2008-06-19 Thread iris clark
Hi. The CORBA code isn't maintained directly in OpenJDK, but rather in a sub-project of GlassFish (https://glassfish-corba.dev.java.net/). That's why there's no CORBA Group. (The same goes for JAXWS and JAXP.) For a list of projects and their associated mailing lists (including contact

RE: RFR (XS): Enable new build on Linux/PPC64 (jdk part)

2013-06-27 Thread Iris Clark
Hi, Volker. I think that the right thing for this change [1] is for you to push into ppc-aix-port/stage once you get the necessary reviews (presumably Erik and possibly Alan). While your changeset contains some general purpose updates, it also contains PPC/AIX-specific files which can't be

RE: Notice: Build Group Lead resignation

2014-04-01 Thread Iris Clark
Hi, Kelly. You've been Build Group Lead since 2007! Thanks for all of your hard work and dedication! For those wishing to nominate a new Group Lead, please see these instructions for Group Lead nomination, approval, and ratification on the Group overview page [1]. Thanks, iris [1]:

RE: CFV: Nomination of Tim Bell as the new Build Group Lead

2014-04-02 Thread Iris Clark
Yes, you're still a member... just not the Lead. iris -Original Message- From: Kelly O'Hair [mailto:kellyoh...@gmail.com] Sent: Wednesday, April 02, 2014 8:56 AM To: Magnus Ihse Bursie Cc: build-dev Subject: Re: CFV: Nomination of Tim Bell as the new Build Group Lead Do I get to vote?

RE: RFR: JDK-8042348: Copyright link in Javadoc page for Java SE 8

2014-05-05 Thread Iris Clark
Hi, Erik. I think the change looks fine. Thanks, iris -Original Message- From: Erik Joelsson Sent: Monday, May 05, 2014 6:28 AM To: build-dev Subject: RFR: JDK-8042348: Copyright link in Javadoc page for Java SE 8 Hello, Please review this small patch to javadoc generation. The

RE: Adding hg version check to get_source.sh?

2014-06-18 Thread Iris Clark
Hi, Mike. The minimum recommended version of Hg on the client side is 2.6.3 [1, 2]. I'd recommend a warning for anything older than that. Thanks, iris [1]: http://mail.openjdk.java.net/pipermail/announce/2014-March/000164.html [2]: http://openjdk.java.net/guide/repositories.html#installConfig

RE: Official and community supported build platforms for JDK 8 and 9

2014-12-01 Thread Iris Clark
Hi, Martijn. Likewise - is it possible to get edit access? https://wiki.openjdk.java.net/display/Build/Supported+build+platforms That wikispace is owned by the Build Group, so all Members of that Group as listed in the Census [0] should be able to edit the page. Thanks, iris [0]

RE: RFR: JDK-8075056 Remove Version.java.template from jconsole

2015-03-12 Thread Iris Clark
Hi, Staffan. bug: https://bugs.openjdk.java.net/browse/JDK-8075056 webrev: http://cr.openjdk.java.net/~sla/8075056/webrev.00/ http://cr.openjdk.java.net/~sla/8075056/webrev.00/ Looks good. I'm always happy to see changes where complexity is reduced. Thanks, iris

RE: RFR: JDK-8137259 configure needs to parse Verona-style version strings for bootjdk

2015-09-28 Thread Iris Clark
Hi, Magnus. Thanks for taking care of this. The modified regular expression looks like it will handle Verona builds now. Regards, iris -Original Message- From: Magnus Ihse Bursie Sent: Monday, September 28, 2015 5:43 AM To: build-dev@openjdk.java.net Cc: jdk9-versioning_ww_grp

RE: RFR: 8135083 Product version string for DLLs and EXEs should not include trailing zeros

2015-09-09 Thread Iris Clark
Hi, Daniil. You change looks good to me. Thanks for tracking down this issue. Regards, iris (not a Reviewer) -Original Message- From: Daniil Titov Sent: Wednesday, September 09, 2015 2:12 PM To: build-dev@openjdk.java.net Cc: verona-...@openjdk.java.net Subject: RFR: 8135083 Product

RE: RFR: 8160000: Runtime.version() cause startup regressions in 9+119

2016-06-27 Thread Iris Clark
Hi, Claes. http://cr.openjdk.java.net/~redestad/816/webrev.4/ Overall, this change looks good. I just have a few concerns. Have you built this forcing alternative build numbers? I -Original Message- From: Claes Redestad Sent: Sunday, June 26, 2016 12:56 PM To: core-libs-dev

RE: RFR: 8160000: Runtime.version() cause startup regressions in 9+119

2016-06-27 Thread Iris Clark
Hi, Claes. [ Sorry for the premature send, my keyboard started interpreting my shortcuts in unexpected ways. ] > http://cr.openjdk.java.net/~redestad/816/webrev.5/ Nice bugid. Overall, this change looks good. I just have a few concerns. Have you built this forcing alternative build

RE: RFR: 8160000: Runtime.version() cause startup regressions in 9+119

2016-06-27 Thread Iris Clark
PM To: Mandy Chung Cc: Iris Clark; core-libs-dev; build-dev Subject: Re: RFR: 816: Runtime.version() cause startup regressions in 9+119 Sorry, uploaded the previous diff again by mistake, updated in-place now. On 2016-06-28 00:04, Mandy Chung wrote: > >> On Jun 27, 2016, at 2:

RE: RFR(XXS): 8149519: Investigate implementation of java.specification.version

2016-07-28 Thread Iris Clark
Hi, Volker. Thanks for your patience. I think that the solution that you've provided solves the immediate problem, the java.specification.version number is incorrectly set to be identical to java.version. The java.{vm.}?specification.version system properties should be independent of

RE: RFR(XXS): 8149519: Investigate implementation of java.specification.version

2016-07-29 Thread Iris Clark
Hi, Volker. >> I've also filed build bug (8162687) referencing 8145919 and 8162686. > I suppose you wanted to refer to "java.vm.specification.version" in "8162687: ava.specification.version is always set to $MAJOR at build time" because "java.vm.specification.version" is actually being set in

RE: RFR: JDK-8029942: Update VERSION_MAJOR for JDK 10

2017-01-26 Thread Iris Clark
Hi, Erik. Your change looks good. Thanks, iris -Original Message- From: Erik Joelsson Sent: Thursday, January 26, 2017 5:57 AM To: build-dev Subject: RFR: JDK-8029942: Update VERSION_MAJOR for JDK 10 The default major version for the jdk 10 repos needs to be updated from 9 to 10.

RE: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

2017-12-15 Thread Iris Clark
Hi. Another build target we need to update is LICENSE_URL in make/Docs.gmk. Here's the equivalent bug for 10: https://bugs.openjdk.java.net/browse/JDK-8189919 I've requested this link: http://www.oracle.com/technetwork/java/javase/terms/license/java11speclicense.html Thanks, iris

RE: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

2017-12-15 Thread Iris Clark
f12 Yes! iris -Original Message- From: Paul Sandoz Sent: Friday, December 15, 2017 10:41 AM To: Iris Clark <iris.cl...@oracle.com> Cc: Erik Joelsson <erik.joels...@oracle.com>; Joseph D. Darcy <joe.da...@oracle.com>; compiler-...@openjdk.java.net; build-dev <build-dev@openjd

RFR(XXS): 8189919: Update link to license in Docs.gmk

2017-10-26 Thread Iris Clark
Please review this small change to update the link to the Specification license referenced by the JavaDoc API. For JDK 10, we should reference the 10 redirect. Bug: 8189919: Update link to license in Docs.gmk https://bugs.openjdk.java.net/browse/JDK-8189919 webrev:

RE: RFR(XXS): 8189919: Update link to license in Docs.gmk

2017-10-26 Thread Iris Clark
Thanks for the review, Mark. >> http://cr.openjdk.java.net/~iris/8189919/webrev/ Pushed. iris

RE: RFR: JDK 11 P1: 8209806: API docs should be updated to refer to javase11

2018-08-21 Thread Iris Clark
Looks good to me. iris -Original Message- From: Jonathan Gibbons Sent: Tuesday, August 21, 2018 11:58 AM To: build-dev@openjdk.java.net Subject: RFR: JDK 11 P1: 8209806: API docs should be updated to refer to javase11 Please review a simple high priority fix for JDK 11 that updates

RE: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

2018-04-12 Thread Iris Clark
Hi. I believe that the internal page Christian references is for the test system. If you want to know whether the push arrived in the repository, you could subscribe to jdk-submit-chan...@openjdk.java.net. The archive of recent push notifications is public:

RE: RFR(XS): 8200469: Update link to license in Docs.gmk

2018-03-30 Thread Iris Clark
Thanks, Tim! Pushed. iris -Original Message- From: Tim Bell Sent: Thursday, March 29, 2018 9:11 PM To: Iris Clark <iris.cl...@oracle.com> Cc: build-dev <build-dev@openjdk.java.net> Subject: Re: RFR(XS): 8200469: Update link to license in Docs.gmk Iris: > Bug: > >

RFR(XS): 8200469: Update link to license in Docs.gmk

2018-03-29 Thread Iris Clark
Please review this small change to update the link to the Specification license referenced by the JavaDoc API. To avoid the need for future updates based on the version number, we should use $(VERSION_NUMBER) instead of a specific version number. Bug: 8200469: Update link to license in

RFR(XS): 8212994: Links to Oracle websites should use "https:"

2018-10-25 Thread Iris Clark
Hi. Please review changes to use "https" instead of "http" for links in the generated JavaDoc API pages: 8212994: Links to Oracle websites should use "https:" bug: https://bugs.openjdk.java.net/browse/JDK-8212994 webrev: https://cr.openjdk.java.net/~iris/8212994/webrev/ I did

RE: RFR(XS): 8212994: Links to Oracle websites should use "https:"

2018-10-25 Thread Iris Clark
Hi, Lance and Erik. Thanks for the super-speedy reviews. Pushed. iris From: Lance Andersen Sent: Thursday, October 25, 2018 1:48 PM To: Iris Clark Cc: build-dev@openjdk.java.net; Jonathan Gibbons Subject: Re: RFR(XS): 8212994: Links to Oracle websites should use "https:&qu

RE: RFR: S, 13 JDK-8226628 The copyright footer should be enclosed in

2019-06-22 Thread Iris Clark
Hi, Jon. > JBS: https://bugs.openjdk.java.net/browse/JDK-8226628 Looks good. Thanks for taking care of this. Iris

RE: RFR: JDK-8223319: Add copyright footer to specs and man pages

2019-05-03 Thread Iris Clark
Hi, Erik. I'm happy to see this change go in. It looks good. Just one comment. When removing the footer in jvmit.html, I suspect that you also need to make changes to jvmti.xsl, which was also modified when the copyright footer was inserted in this changeset:

RE: RFR: JDK-8223319: Add copyright footer to specs and man pages

2019-05-03 Thread Iris Clark
Hi, Erik. > New webrev: http://cr.openjdk.java.net/~erikj/8223319/webrev.02/ The revised webrev looks good. Thank you! Iris

RE: [16] RFR (XS) 8246803: Update link to license in Docs.gmk

2020-06-08 Thread Iris Clark
Hi, Mikael. Thanks for the review! iris -Original Message- From: Mikael Vidstedt Sent: Monday, June 8, 2020 10:35 PM To: Iris Clark Cc: build-dev@openjdk.java.net; Jesper Wilhelmsson Subject: Re: [16] RFR (XS) 8246803: Update link to license in Docs.gmk Looks good. Cheers, Mikael

RE: [16] RFR (XS) 8246803: Update link to license in Docs.gmk

2020-06-08 Thread Iris Clark
Hi, Joe. > Updating the link for JDK 16 looks fine; thanks, Thanks for the amazingly fast review! Iris

[16] RFR (XS) 8246803: Update link to license in Docs.gmk

2020-06-08 Thread Iris Clark
Hi. Please review this small change to update the link to the Specification license referenced by the JavaDoc API for JDK 16: bug: 8246803: Update link to spec license in Docs.gmk https://bugs.openjdk.java.net/browse/JDK-8246803 webrev:

RE: 15 RFR (XXS) 8250216: The README need not mention retrieving source code

2020-07-23 Thread Iris Clark
Hi, Mark. > Bug: https://bugs.openjdk.java.net/browse/JDK-8250216 > > [ ... ] > > Patch below. Looks good. I think it would be nice if you could reference the JDK Project page (ojn/projects/jdk), not just ojn. Thanks, Iris

RE: 15 RFR (XXS) 8250216: The README need not mention retrieving source code

2020-07-23 Thread Iris Clark
Hi, Mark. >> I think it would be nice if you could reference the JDK Project page >> (ojn/projects/jdk), not just ojn. > > Good idea ... but I just pushed the changeset. I’ll fix that later. Sorry for the late review. You change wasn't there when I visited the README source and I haven't

Re: [jdk16] RFR: JDK-8258657: Doc build is broken by use of new language features

2021-01-06 Thread Iris Clark
On Tue, 5 Jan 2021 22:51:29 GMT, Erik Joelsson wrote: > This patch changes how the docs-reference make target behaves to better > support the requirements for it. This target is used to generate javadocs in > a more stable way between releases, so that they those docs are better suited > for

Re: [jdk16] RFR: JDK-8259429: Update reference to README.md

2021-01-07 Thread Iris Clark
On Thu, 7 Jan 2021 22:01:51 GMT, Erik Joelsson wrote: > In JDK-8251551, the top level README file changed names to README.md. In > jib-profiles.js we have a reference to this file to identify if the current > source tree is likely to be complete. This reference needs to be updated. Marked as

Re: RFR: 8257450: Start of release updates for JDK 17

2020-12-04 Thread Iris Clark
On Tue, 1 Dec 2020 06:22:51 GMT, Joe Darcy wrote: > Start of JDK 17 updates. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1531

Re: RFR: 8258143: Update --release 16 symbol information for JDK 16 build 30 or later

2021-01-05 Thread Iris Clark
On Wed, 6 Jan 2021 02:19:51 GMT, Joe Darcy wrote: > Updating to the symbol files for JDK 16 b30; change generated with the script > > make/scripts/generate-symbol-data.sh > > The change to the java.desktop module looks to be for JDK-8258373. Marked as reviewed by iris (Reviewer).

Re: RFR: JDK-8260669: Missing quotes in fixpath.sh

2021-01-29 Thread Iris Clark
On Fri, 29 Jan 2021 19:54:12 GMT, Erik Joelsson wrote: > The build on Windows can fail if certain directory names are present in root > directory of the workspace. In particular I've observed that the single > letter 'p' is triggering this problem. This is caused by missing quotes > around

Re: RFR: 8267630: Start of release updates for JDK 18 [v5]

2021-06-07 Thread Iris Clark
On Mon, 7 Jun 2021 19:38:58 GMT, Joe Darcy wrote: >> 8267630: Start of release updates for JDK 18 > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull

Re: RFR: 8267634: Update --release 17 symbol information for JDK 17 build 26

2021-06-11 Thread Iris Clark
On Fri, 11 Jun 2021 22:44:03 GMT, Joe Darcy wrote: > Update symbol files in JDK 18 for changes in JDK 17 b26. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4477

Re: RFR: 8267630: Start of release updates for JDK 18 [v11]

2021-06-10 Thread Iris Clark
On Thu, 10 Jun 2021 14:42:24 GMT, Joe Darcy wrote: >> 8267630: Start of release updates for JDK 18 > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 25 commits: > > - Merge branch 'master' into 8267630 > - Update

Re: RFR: JDK-8266254: Update to use jtreg 6

2021-06-02 Thread Iris Clark
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote: > Please review the change to update to using jtreg 6. > > The primary change is to the jib-profiles.js file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `requiredVersion`

Re: RFR: 8267630: Start of release updates for JDK 18

2021-06-03 Thread Iris Clark
On Mon, 24 May 2021 22:35:04 GMT, Joe Darcy wrote: > 8267630: Start of release updates for JDK 18 Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4175

Re: RFR: 8268299: jvms tag produces incorrect URL

2021-06-06 Thread Iris Clark
On Sun, 6 Jun 2021 22:03:46 GMT, Joe Darcy wrote: > The @jls and @jvms taglet share most of their functionality. A JLS URL > looks like > > https://docs.oracle.com/javase/specs/jls/se16/html/**jls**-8.html#jls-8.1 > > and a JVMS URL looks like > > >

Re: RFR: 8268637: Update --release 17 symbol information for JDK 17 build 28

2021-06-30 Thread Iris Clark
On Wed, 30 Jun 2021 16:54:57 GMT, Joe Darcy wrote: > JDK 17 b28 had two fixes which updated the symbol information. A > CallerSensitive annotation was removed as part of JDK-8268349 and API changes > in JDK-826. > > These should be reflected in the JDK 18 symbol information for 17.

Re: RFR: 8266318: Switch to macos prefix for macOS bundles

2021-04-29 Thread Iris Clark
On Thu, 29 Apr 2021 19:15:52 GMT, Mikael Vidstedt wrote: > Apple rebranded the operating system as "macOS" back in 2016. The JDK bundles > files are still use the legacy "osx" string. They should be modernized to use > "macos" instead. Marked as reviewed by iris (Reviewer). -

Re: RFR: 8266318: Switch to macos prefix for macOS bundles [v2]

2021-04-29 Thread Iris Clark
On Fri, 30 Apr 2021 03:51:18 GMT, Mikael Vidstedt wrote: >> Apple rebranded the operating system as "macOS" back in 2016. The JDK >> bundles files are still use the legacy "osx" string. They should be >> modernized to use "macos" instead. > > Mikael Vidstedt has updated the pull request

Re: RFR: 8264678: Incomplete comment in build.tools.generatecharacter.GenerateCharacter

2021-04-28 Thread Iris Clark
On Wed, 28 Apr 2021 15:44:47 GMT, Claes Redestad wrote: > I'm not exactly sure what I intended to say in this partial comment. Removing > it. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3766

Re: RFR: 8252833: Correct "no comment" warnings from javadoc in java.smartcardio module

2021-03-10 Thread Iris Clark
On Thu, 11 Mar 2021 01:13:12 GMT, Bradford Wetmore wrote: > Disable the "missing" target for java.smartcardio from doclint. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2930

Re: RFR: JDK-8251210: Link JDK api docs to other versions

2021-03-06 Thread Iris Clark
On Sat, 6 Mar 2021 02:21:00 GMT, Jonathan Gibbons wrote: > Please review a small change to Docs.gmk, such that the short version string > in the upper right corner of the main API docs bundle is linked to a page > that links to other versions of the documentation. While it is not so useful >

Re: RFR: 8264779: Fix doclint warnings in java/nio [v2]

2021-04-07 Thread Iris Clark
On Wed, 7 Apr 2021 14:40:48 GMT, Conor Cleary wrote: >> This fix addresses the following warnings which were generated by building >> JDK API documentation with the `-Xdoclint:all` option enabled: >> >>

Re: RFR: JDK-8265483: All-caps “JAVA” in the top navigation bar

2021-04-20 Thread Iris Clark
On Tue, 20 Apr 2021 22:36:28 GMT, Jonathan Gibbons wrote: > Please review a moderately simple change to `make/Docs.gmk` to move the link > for "Other Versions" from a "hidden" link in the top nav bar to an explicit > link in the "bottom" text. The link is placed to appear after the sentence >

Re: RFR: 8257459: Bump minimum boot jdk to JDK 16

2021-04-17 Thread Iris Clark
On Sat, 17 Apr 2021 07:20:21 GMT, Mikael Vidstedt wrote: > With JDK 16 having gone GA about a month ago it's time to bump the minimum > boot JDK version for mainline/JDK 17. > > Testing: tier1-5. Marked as reviewed by iris (Reviewer). - PR:

Re: RFR: 8265782: Bump bootjdk to jdk-17+19 on macosx-aarch64 at Oracle

2021-04-22 Thread Iris Clark
On Thu, 22 Apr 2021 18:15:58 GMT, Mikael Vidstedt wrote: > The bootjdk used for macosx-aarch64 at Oracle is a custom build of JDK 16 > from early December, so does not include all the JDK 16 GA functionality. > This leads to build issues after JDK-8263621 which uses a method not included > in

Re: RFR: JDK-8272667: substandard error messages from the docs build

2021-08-18 Thread Iris Clark
On Wed, 18 Aug 2021 22:06:13 GMT, Jonathan Gibbons wrote: > Please review a small (delete one character) change to improve the error > messages reported when bad HTML is detected when post-processing the output > from pandoc to generate the docs. > > The change is just to pass the filename as

Re: RFR: 8272859: Javadoc external links should only have feature version number in URL

2021-08-25 Thread Iris Clark
On Wed, 25 Aug 2021 13:57:29 GMT, Magnus Ihse Bursie wrote: > Link to license terms from the JavaDoc API footer is broken in point releases > (for example, 16.0.2). > > Instead of using VERSION_NUMBER, VERSION_FEATURE should be used, Marked as reviewed by iris (Reviewer). - PR:

Re: [jdk17] RFR: 8271150: Remove EA from JDK 17 version string starting with Initial RC promotion on Aug 5, 2021(B34)

2021-07-30 Thread Iris Clark
On Fri, 30 Jul 2021 06:47:07 GMT, Saravana Kumar Vijayasekaran wrote: > 8271150: Remove EA from JDK 17 version string starting with Initial RC > promotion on Aug 5, 2021(B34) Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk17/pull/297

Re: RFR: 8264792: The NumberFormat for locale sq_XK formats price incorrectly.

2021-08-06 Thread Iris Clark
On Fri, 6 Aug 2021 16:39:34 GMT, Naoto Sato wrote: > Please review the fix to the subject issue. The root cause of this problem is > that the currency for the country code `XK` is undefined because the country > code is user-defined in the ISO 3166 standard. However, it is commonly used > to

Re: RFR: JDK-8274311: Make build.tools.jigsaw.GenGraphs more configurable

2021-09-25 Thread Iris Clark
On Fri, 24 Sep 2021 23:07:33 GMT, Mandy Chung wrote: > GenGraphs tool generates the module graph. It currently supports the > configuration via javadoc-graphs.properties. However, > `make/jdk/src/classes/build/tools/jigsaw/javadoc-graphs.properties` only > documents two properties. It should

Re: RFR: 8267636: Bump minimum boot jdk to JDK 17

2021-09-23 Thread Iris Clark
On Wed, 22 Sep 2021 20:03:55 GMT, Mikael Vidstedt wrote: > With the JDK 17 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 18. > > Testing: tier1-5, GHA builds Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5639

Re: RFR: 8274407: (tz) Update Timezone Data to 2021c

2021-10-06 Thread Iris Clark
On Wed, 6 Oct 2021 01:24:49 GMT, Naoto Sato wrote: > This PR is to upgrade the time zone data in the JDK to IANA's tzdata2021c > level. Note that the tz data is "as is", as released by IANA. No `merged > links` are retracted. > The PR also fixes two issues along with the 2021c upgrade. Marked

Re: RFR: 8274658: ISO 4217 Amendment 170 Update

2021-10-01 Thread Iris Clark
On Fri, 1 Oct 2021 18:57:28 GMT, Naoto Sato wrote: > This is to incorporate the ISO 4217 amendment #170, which has been released > today, effective immediately. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5790

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v5]

2021-11-29 Thread Iris Clark
On Mon, 29 Nov 2021 18:38:35 GMT, Joe Darcy wrote: >> The time to get JDK 19 underway draws nigh, please review this usual set of >> start-of-release updates, including CSRs for the javac and javax.lang.model >> updates: >> >> JDK-8277512: Add SourceVersion.RELEASE_19 >>

Re: RFR: JDK-8277515: Update --release 18 symbol information for JDK 18 build 29

2022-01-03 Thread Iris Clark
On Mon, 3 Jan 2022 18:26:24 GMT, Joe Darcy wrote: > Usual update to the JDK 19 symbol files for changes in JDK 18; this time > JDK-8276660 in JDK 18 build 28. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6948

Re: RFR: 8279223: Define version in .jcheck/conf

2021-12-23 Thread Iris Clark
On Thu, 23 Dec 2021 14:16:37 GMT, Erik Joelsson wrote: > This patch adds the version field to .jcheck/conf. By doing this we can > remove the corresponding configuration from the Skara bots, which in turn > reduces the need for timing and general complexity of starting a new JDK > release.

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v2]

2021-11-22 Thread Iris Clark
On Mon, 22 Nov 2021 04:30:38 GMT, Joe Darcy wrote: >> The time to get JDK 19 underway draws nigh, please review this usual set of >> start-of-release updates, including CSRs for the javac and javax.lang.model >> updates: >> >> JDK-8277512: Add SourceVersion.RELEASE_19 >>

Re: RFR: 8275766: (tz) Update Timezone Data to 2021e

2021-10-29 Thread Iris Clark
On Thu, 28 Oct 2021 01:02:27 GMT, Yoshiki Sato wrote: > Please review the integration of tzdata2021e (including tzdata2021d) to the > JDK. > The fix has passed all relevant JTREG regression tests and JCK tests. > > 8275754: (tz) Update Timezone Data to 2021d > 8275849: TestZoneInfo310.java

Re: RFR: JDK-8278179: Enable all doclint warnings for build of java.naming

2021-12-02 Thread Iris Clark
On Fri, 3 Dec 2021 03:28:46 GMT, Joe Darcy wrote: > An exploratory build indicates that it is not necessary to disable the > accessibility doclint check for the java.naming module.  - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6688

Re: RFR: 8278275: Initial nroff manpage generation for JDK 19

2021-12-13 Thread Iris Clark
On Mon, 13 Dec 2021 05:51:37 GMT, David Holmes wrote: > Trivial update to change the version to 19-ea, and update the single > reference to the "current release". > > Content changes for 19 will follow. > > Thanks, > David Marked as reviewed by iris (Reviewer). - PR:

Re: RFR: JDK-8278273: Remove unnecessary exclusion of doclint accessibility checks

2021-12-05 Thread Iris Clark
On Sun, 5 Dec 2021 23:45:32 GMT, Joe Darcy wrote: > Exploratory builds indicate it is not currently necessary to exclude the > doclint accessibility checks; this patch enables them. > > (Enabling the reference checks is left for future work.) Marked as reviewed by iris (Reviewer).

Re: RFR: 8268081: Upgrade Unicode Data Files to 14.0.0

2022-01-05 Thread Iris Clark
On Wed, 5 Jan 2022 22:42:38 GMT, Naoto Sato wrote: > Please review the changes for upgrading the Unicode support in the JDK, from > version 13 to version 14. Corresponding CSR has also been drafted. Marked as reviewed by iris (Reviewer). - PR:

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

2022-03-04 Thread Iris Clark
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo Nice tidy of the code. Is there anything that can be done to prevent re-introduction of this trivial problem? Perhaps a new

Re: RFR: 8283277: ISO 4217 Amendment 171 Update

2022-03-17 Thread Iris Clark
On Thu, 17 Mar 2022 18:10:17 GMT, Naoto Sato wrote: > This is to incorporate the ISO 4217 amendment 171 for Sierra Leonean LEONE > redenomination (removing 3 zeros). Its effective date is 4/1, but I went > ahead as JDK19 won't be released by 4/1. Marked as reviewed by iris (Reviewer).

Re: [jdk18] RFR: 8280415: Remove EA from JDK 18 version string starting with Initial RC promotion B35 on February 10, 2022

2022-02-10 Thread Iris Clark
On Thu, 10 Feb 2022 18:46:13 GMT, Pavel Kharskii wrote: > …C promotion B35 on February 10, 2022 > > Remove EA from JDK 18 version string starting with Initial RC promotion B35 > on February 10, 2022 Marked as reviewed by iris (Reviewer). - PR:

Re: RFR: 8280032: Update jib-profiles.js to use JMH 1.34 devkit

2022-01-14 Thread Iris Clark
On Fri, 14 Jan 2022 17:05:45 GMT, Claes Redestad wrote: > Change so that jib users pick up and use the latest JMH devkit. > > Testing: verified locally Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7090

Re: RFR: JDK-8279397: Update --release 18 symbol information for JDK 18 build 32

2022-01-20 Thread Iris Clark
On Thu, 20 Jan 2022 19:03:36 GMT, Joe Darcy wrote: > Update of JDK 18 symbol information for build 32. > > @lahodaj , can you take a look at the diff? Given the code changes for > JDK-8270416: "Enhance construction of Identity maps" >

Re: RFR: 8277517: Bump minimum boot jdk to JDK 18

2022-04-05 Thread Iris Clark
On Tue, 5 Apr 2022 03:19:06 GMT, Mikael Vidstedt wrote: > With the JDK 18 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 19. > > Testing: tier1-5, GHA builds Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8102

Re: RFR: 8265315: Support for CLDR version 41

2022-04-07 Thread Iris Clark
On Thu, 7 Apr 2022 21:20:20 GMT, Naoto Sato wrote: > This is to upgrade the CLDR data from version 39 to version 41 which was > released yesterday. The vast majority of the changes are basically replacing > the CLDR data, along with tools/testcase alignments. Here is the link to CLDR > v41's

Re: RFR: 8265315: Support for CLDR version 41 [v2]

2022-04-08 Thread Iris Clark
On Fri, 8 Apr 2022 20:17:52 GMT, Naoto Sato wrote: >> This is to upgrade the CLDR data from version 39 to version 41 which was >> released yesterday. The vast majority of the changes are basically replacing >> the CLDR data, along with tools/testcase alignments. Here is the link to >> CLDR

Re: RFR: 8284209: Replace remaining usages of 'a the' in source code

2022-05-18 Thread Iris Clark
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > It's the last issue in the series, and it still touches different areas of > the code. Marked as reviewed by iris (Reviewer).

Re: RFR: JDK-8284858: Start of release updates for JDK 20 [v3]

2022-05-31 Thread Iris Clark
On Tue, 31 May 2022 20:32:13 GMT, Joe Darcy wrote: >> Time to start getting ready for JDK 20... > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull

Re: RFR: JDK-8284858: Start of release updates for JDK 20 [v2]

2022-05-26 Thread Iris Clark
On Thu, 26 May 2022 23:05:32 GMT, Joe Darcy wrote: >> Time to start getting ready for JDK 20... > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Respond to review feedback. Marked as reviewed by iris (Reviewer).

Re: RFR: JDK-8284858: Start of release updates for JDK 20 [v5]

2022-06-02 Thread Iris Clark
On Thu, 2 Jun 2022 17:00:35 GMT, Joe Darcy wrote: >> Time to start getting ready for JDK 20... > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull

Re: RFR: 8287155: Additional make typos

2022-05-23 Thread Iris Clark
On Mon, 23 May 2022 10:04:14 GMT, Magnus Ihse Bursie wrote: > Testing ispell + shell magic to locate typos. It worked, but is not scalable > to the entire JDK. :-( Keep the fixes for the problems found in the make > directory, though. Marked as reviewed by iris (Reviewer). - PR:

Re: RFR: JDK-8284858: Start of release updates for JDK 20 [v2]

2022-05-27 Thread Iris Clark
On Thu, 26 May 2022 23:05:32 GMT, Joe Darcy wrote: >> Time to start getting ready for JDK 20... > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Respond to review feedback. Marked as reviewed by iris (Reviewer).

Re: RFR: JDK-8284858: Start of release updates for JDK 20 [v6]

2022-06-08 Thread Iris Clark
On Thu, 9 Jun 2022 01:03:47 GMT, Joe Darcy wrote: >> Time to start getting ready for JDK 20... > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull