Re: Fwd: Need reviewer, 7150324: Stop using drop bundles in jaxp

2012-03-04 Thread Joe Wang
On 3/4/2012 10:12 AM, Kelly O'Hair wrote: Did you see this email?' I didn't. I did not sign up on the build-dev alias until now :) Phil Race reviewed it, but I'd like your review too. I went through the webrev and noted that it's similar to what you did for jdk7 when we worked to remove the

Re: RFR: 8247432: Update IANA Language Subtag Registry to Version 2020-09-29

2020-11-20 Thread Joe Wang
On Fri, 20 Nov 2020 17:55:55 GMT, Naoto Sato wrote: > Hi, > > Please review the changes to the subject issue. This is to incorporate the > latest language subtag registry definition into the JDK. Marked as reviewed by joehw (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/

Re: RFR: 8253497: Core Libs Terminology Refresh

2020-12-14 Thread Joe Wang
On Mon, 14 Dec 2020 19:36:48 GMT, Brent Christian wrote: > This is part of an effort in the JDK to replace archaic/non-inclusive words > with more neutral terms (see JDK-8253315 for details). > > Here are the changes covering core libraries code and tests. Terms were > changed as follows: > 1

Re: RFR: 8253497: Core Libs Terminology Refresh [v2]

2020-12-14 Thread Joe Wang
On Tue, 15 Dec 2020 01:36:27 GMT, Brent Christian wrote: >> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectorServer.java >> line 152: >> >>> 150: * >>> 151: * Care must be taken when defining such a filter, as defining >>> 152: * an accept-list too r

Re: RFR: 8258794: Support for CLDR version 39

2021-04-14 Thread Joe Wang
On Wed, 14 Apr 2021 21:13:51 GMT, Naoto Sato wrote: > Please review the changes to support CLDR version 39. The vast majority of > the changes are purely data changes from Unicode. The only change affected in > logic was in `CLDRLocaleProviderAdapter.java`, where it needed to deal with > CLDR'

Re: RFR: 8265375: Bootcycle builds fail with StackOverflowError in cldrconverter

2021-04-16 Thread Joe Wang
On Fri, 16 Apr 2021 21:10:42 GMT, Naoto Sato wrote: > Please review the fix to the tier4 build failure. The piece of code that made > into `CLDRLocaleProviderAdapter.java` was also needed in the build tool > counterpart (`CLDRConverter`). Marked as reviewed by joehw (Reviewer). -

Re: RFR: 8258795: Update IANA Language Subtag Registry to Version 2021-05-11

2021-05-12 Thread Joe Wang
On Wed, 12 May 2021 16:28:54 GMT, Naoto Sato wrote: > Please review the changes to the subject issue. This is to incorporate the > latest language subtag registry definition into the JDK. Marked as reviewed by joehw (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3998

Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal

2021-05-18 Thread Joe Wang
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote: > Please review this implementation of [JEP > 411](https://openjdk.java.net/jeps/411). > > The code change is divided into 3 commits. Please review them one by one. > > 1. > https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28

Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal [v8]

2021-06-01 Thread Joe Wang
On Tue, 1 Jun 2021 15:21:33 GMT, Weijun Wang wrote: >> Please review this implementation of [JEP >> 411](https://openjdk.java.net/jeps/411). >> >> The code change is divided into 3 commits. Please review them one by one. >> >> 1. >> https://github.com/openjdk/jdk/commit/576161d15423f58281e384

Re: RFR: 8264792: The NumberFormat for locale sq_XK formats price incorrectly.

2021-08-06 Thread Joe Wang
On Fri, 6 Aug 2021 16:39:34 GMT, Naoto Sato wrote: > Please review the fix to the subject issue. The root cause of this problem is > that the currency for the country code `XK` is undefined because the country > code is user-defined in the ISO 3166 standard. However, it is commonly used > to r

Re: RFR: 8275512: Upgrade required version of jtreg to 6.1 [v2]

2021-10-19 Thread Joe Wang
On Tue, 19 Oct 2021 17:24:17 GMT, Weijun Wang wrote: >> As a follow up of JEP 411, we will soon disallow security manager by >> default. jtreg 6.1 does not set its own security manager if JDK version is >> >= 18. > > Weijun Wang has updated the pull request incrementally with one additional >

Re: RFR: 8268081: Upgrade Unicode Data Files to 14.0.0

2022-01-05 Thread Joe Wang
On Wed, 5 Jan 2022 22:42:38 GMT, Naoto Sato wrote: > Please review the changes for upgrading the Unicode support in the JDK, from > version 13 to version 14. Corresponding CSR has also been drafted. Marked as reviewed by joehw (Reviewer). - PR: https://git.openjdk.java.net/jdk/pul

Re: RFR: 8268081: Upgrade Unicode Data Files to 14.0.0

2022-01-05 Thread Joe Wang
On Wed, 5 Jan 2022 22:42:38 GMT, Naoto Sato wrote: > Please review the changes for upgrading the Unicode support in the JDK, from > version 13 to version 14. Corresponding CSR has also been drafted. I like how they changed dizzy face to face with crossed-out eyes. Pistol to water pistol, that'

Re: RFR: 8176706: Additional Date-Time Formats

2022-02-07 Thread Joe Wang
On Thu, 3 Feb 2022 23:29:54 GMT, Naoto Sato wrote: > Following the prior discussion [1], here is the PR for the subject > enhancement. CSR has also been updated according to the suggestion. > > [1] > https://mail.openjdk.java.net/pipermail/core-libs-dev/2022-January/085175.html src/java.base/

Re: RFR: 8176706: Additional Date-Time Formats [v3]

2022-02-08 Thread Joe Wang
On Tue, 8 Feb 2022 19:08:45 GMT, Naoto Sato wrote: >> Following the prior discussion [1], here is the PR for the subject >> enhancement. CSR has also been updated according to the suggestion. >> >> [1] >> https://mail.openjdk.java.net/pipermail/core-libs-dev/2022-January/085175.html > > Naoto

Re: RFR: 8283277: ISO 4217 Amendment 171 Update

2022-03-17 Thread Joe Wang
On Thu, 17 Mar 2022 18:10:17 GMT, Naoto Sato wrote: > This is to incorporate the ISO 4217 amendment 171 for Sierra Leonean LEONE > redenomination (removing 3 zeros). Its effective date is 4/1, but I went > ahead as JDK19 won't be released by 4/1. Marked as reviewed by joehw (Reviewer). --

Re: RFR: 8265315: Support for CLDR version 41

2022-04-07 Thread Joe Wang
On Thu, 7 Apr 2022 21:20:20 GMT, Naoto Sato wrote: > This is to upgrade the CLDR data from version 39 to version 41 which was > released yesterday. The vast majority of the changes are basically replacing > the CLDR data, along with tools/testcase alignments. Here is the link to CLDR > v41's r

Re: RFR: 8265315: Support for CLDR version 41 [v2]

2022-04-08 Thread Joe Wang
On Fri, 8 Apr 2022 20:17:52 GMT, Naoto Sato wrote: >> This is to upgrade the CLDR data from version 39 to version 41 which was >> released yesterday. The vast majority of the changes are basically replacing >> the CLDR data, along with tools/testcase alignments. Here is the link to >> CLDR v41

Re: RFR: 8286399: Address possibly lossy conversions in JDK Build Tools

2022-05-13 Thread Joe Wang
On Fri, 13 May 2022 17:05:43 GMT, Naoto Sato wrote: > Applied required casts for the upcoming warning. Verified by cherry-picking > Adam's patch. make/jdk/src/classes/build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java line 1278: > 1276: state[numCategories] |

Re: RFR: 8286399: Address possibly lossy conversions in JDK Build Tools

2022-05-13 Thread Joe Wang
On Fri, 13 May 2022 17:05:43 GMT, Naoto Sato wrote: > Applied required casts for the upcoming warning. Verified by cherry-picking > Adam's patch. Marked as reviewed by joehw (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8706

Re: RFR: 8287187: Utilize HashMap.newHashMap() in CLDRConverter [v2]

2022-05-25 Thread Joe Wang
On Wed, 25 May 2022 17:15:18 GMT, Naoto Sato wrote: >> Refactoring the leftover self-calculations of the optimized `HashMap` >> initial value with `newHashMap()` method. Also replaced some string literals >> using text blocks for better readability. Confirmed that the output resource >> bundle

Re: [14] RFR: 8212970: TZ database in "vanguard" format support

2019-07-24 Thread Joe Wang
Hi Naoto, The method findNegativeSavings method in TzdbZoneRulesProvider.java states that it "Find the minimum negative savings". While the result is correct since the rules all have the same value for SAVE, I wonder if that's ideal conceptually. Given a start LDT, shouldn't it be looking for

Re: [14] RFR: 8212970: TZ database in "vanguard" format support

2019-07-24 Thread Joe Wang
Thanks Naoto.  Looks good. -Joe On 7/24/19 3:24 PM, naoto.s...@oracle.com wrote: Hi Joe, Thank you for the review. On 7/24/19 2:57 PM, Joe Wang wrote: Hi Naoto, The method findNegativeSavings method in TzdbZoneRulesProvider.java states that it "Find the minimum negative savings&qu

Re: RFR(S) : 8238943: switch to jtreg 5.0

2020-02-13 Thread Joe Wang
+1 for the change to test/jaxp/TEST.ROOT. Best, Joe On 2/13/20 10:08 AM, Igor Ignatev wrote: Oh, I’m sorry I actually changed it to 5.0 when were (re)doing testing, and apparently forgot to replace the webrev, the right is http://cr.openjdk.java.net/~iignatyev//8238943/webrev.01 ; with versi

Re: RFR [16/java.xml] 8251561: Fix doclint warnings in the java.xml package

2020-08-25 Thread Joe Wang
he javadoc, using @code around true, false, missing periods at the end of first sentences, etc.  But that's a different task. Created a bug to keep track of this: https://bugs.openjdk.java.net/browse/JDK-8252328 Thanks, Joe On 8/24/20 5:44 PM, Joe Wang wrote: Hi all,  adding Ro

Re: RFR [16/java.xml] 8251561: Fix doclint warnings in the java.xml package

2020-08-25 Thread Joe Wang
e warning categories by default? /Erik On 2020-08-25 11:47, Joe Wang wrote: Cc-ing build-dev@openjdk.java.net (makefile change: make/Docs.gmk) Updated webrev: http://cr.openjdk.java.net/~joehw/jdk16/8251561/webrev_04/ Thanks Roger! Please see inline comments. On 8/25/20 8:09 AM, Roger Riggs wrot

Re: Need reviewers - 6856630: Restructure jaxp/jaxws repository

2009-09-10 Thread Joe Wang
Kelly, I'm taking Friday and Monday off. I'll do after I'm back. Thanks, Joe Kelly O'Hair wrote: Joes & Rama, I'll CC the jdk7 open build alias in case anyone else might be interested in this continuing saga. Ok, here is my next attempt at: 6856630: Restructure jaxp/jaxws repositories htt

Re: Need reviewers - 6856630: Restructure jaxp/jaxws repository

2009-09-15 Thread Joe Wang
Kelly, I'm downloading the JAXP bundle from the kenai test site. It was very slow initially (almost not moving). But it became normal after I killed the 1st attempt. I'm not sure if that's what you meant when you mentioned kenai download was not stable. Maybe it was my internet connection. Di

Re: Need reviewer: jaxp and jaxws urls in openjdk6 and openjdk7

2010-11-24 Thread Joe Wang
n the future. It seems to me that's the same download server as what Kelly pointed out earlier for openjdk, e.g. http://download.java.net/openjdk/jdk7/ --Joe On 11/23/2010 9:33 AM, Joe Darcy wrote: Both sets of changes approved; thanks Kelly. Joe (Wang) and Rama, please verify the ne

jaxp 1.4.5 -> Re: Need reviewer: jaxp and jaxws urls in openjdk6 and openjdk7

2010-11-24 Thread Joe Wang
Kelly, By the way, we just finalized a plan on jaxp 1.4.5. We are planning make an internal release first by FF (12/15) of JDK7, to give you so me time to prepare for the integration, we've set 12/8 as the date by which I will provide a source bundle. After that, I will continue working on so

Re: jaxp 1.4.5 -> Re: Need reviewer: jaxp and jaxws urls in openjdk6 and openjdk7

2010-11-24 Thread Joe Wang
me we need some kind of approval to add this to jdk7? Might want to get that ball rolling if it isn't already. Or any CCC request that might be needed. -kto On Nov 24, 2010, at 10:10 AM, Joe Wang wrote: Kelly, By the way, we just finalized a plan on jaxp 1.4.5. We are planning make an i

please disregard my previous email about jaxp 1.4.5 -> Re: jaxp 1.4.5 -> Re: Need reviewer: jaxp and jaxws urls in openjdk6 and openjdk7

2010-11-24 Thread Joe Wang
Thanks, Joe On 11/24/2010 10:43 AM, Mark Wielaard wrote: On Wed, 2010-11-24 at d10:20 -0800, Joe Wang wrote: On 11/24/2010 10:13 AM, Kelly O'Hair wrote: On Nov 24, 2010, at 10:10 AM, Joe Wang wrote: By the way, we just finalized a plan on jaxp 1.4.5. We are planning make

jaxp 1.4.5 and jdk7 integration

2010-11-29 Thread Joe Wang
the jdk 7 requirements. Thanks, Joe On 11/24/2010 11:21 AM, Mark Wielaard wrote: On Wed, 2010-11-24 at 10:50 -0800, Joe Wang wrote: Sorry Mark, and all on build-dev. I didn't pay attention to the build-dev, I mean didn't realize the original email was sent to an outside alias. It&

jdk7/jaxp/jaxp: Fixed 6631310 : jaxp issue 42 : dysfunctional hyperlink in package org.xml.sax

2007-11-29 Thread joe . wang
Changeset: db868c7da6dc Author:joehw Date: 2007-11-28 22:19 -0800 URL: http://hg.openjdk.java.net/jdk7/jaxp/jaxp/rev/db868c7da6dc Fixed 6631310 : jaxp issue 42 : dysfunctional hyperlink in package org.xml.sax ! src/share/classes/org/xml/sax/ext/package.html ! src/share/classes/org/