Fwd: Heads up, new jaxws source drop

2011-05-10 Thread Kelly O';Hair
FYI... -kto Begin forwarded message: > From: Kelly O'Hair > Date: May 10, 2011 18:32:59 PM PDT > To: core-libs-dev > Cc: MARTIN GREBAC , Rama Pulavarthi > > Subject: Heads up, new jaxws source drop > > Heads up. The jdk7/tl forest has a new jaxws source drop

Build Group Membership vote

2011-05-11 Thread Kelly O';Hair
ss at openjdk.java.net. Only Members of the Build Group are eligible to vote on this decision [1]. The current Members are: Kelly O'Hair Mark Reinhold Xiomara Jayasena Tim Bell [1] http://openjdk.java.net/groups/ -kto

Build Group Membership vote

2011-05-11 Thread Kelly O';Hair
ss at openjdk.java.net. Only Members of the Build Group are eligible to vote on this decision [1]. The current Members are: Kelly O'Hair Mark Reinhold Xiomara Jayasena Tim Bell [1] http://openjdk.java.net/groups/ -kto

Build Group Membership vote

2011-05-11 Thread Kelly O';Hair
nd to discuss at openjdk.java.net. Only Members of the Build Group are eligible to vote on this decision [1]. The current Members are: Kelly O'Hair Mark Reinhold Xiomara Jayasena Tim Bell [1] http://openjdk.java.net/groups/ -kto

Should the Build Group sponsor the Build Infrastructure Project?

2011-05-11 Thread Kelly O';Hair
optional and not required. Only Members of the Build Group are eligible to vote on this decision [2]. The current Members are: Kelly O'Hair Mark Reinhold Xiomara Jayasena Tim Bell [1] http://mail.openjdk.java.net/pipermail/announce/2011-April/94.html [2] http://openjdk.jav

Re: Build Group Membership vote

2011-05-11 Thread Kelly O';Hair
On May 11, 2011, at 8:16 AM, Kelly O'Hair wrote: > > Should the following person be added as a member of the OpenJDK Build Group? > Johan Walles http://db.openjdk.java.net/people/walles > > Johan is a member of the JDK Infrastructure team in Stockholm. > >

Re: Build Group Membership vote

2011-05-11 Thread Kelly O';Hair
On May 11, 2011, at 8:12 AM, Kelly O'Hair wrote: > > Should the following person be added as a member of the OpenJDK Build Group? > Erik Joelsson http://db.openjdk.java.net/people/erikj > > Erik is a member of the JDK Infrastructure team in Stockholm. > > Please

Re: Build Group Membership vote

2011-05-11 Thread Kelly O';Hair
On May 11, 2011, at 8:17 AM, Kelly O'Hair wrote: > > Should the following person be added as a member of the OpenJDK Build Group? > Magnus Ihse Bursie http://db.openjdk.java.net/people/ihse > > Magnus is a member of the JDK Infrastructure team in Stockholm. > >

Re: Build Group Membership vote

2011-05-11 Thread Kelly O';Hair
Vote: yes. -kto On May 11, 2011, at 8:16 AM, Kelly O'Hair wrote: > > Should the following person be added as a member of the OpenJDK Build Group? > Johan Walles http://db.openjdk.java.net/people/walles > > Johan is a member of the JDK Infrastructure team in Stockho

Re: Build Group Membership vote

2011-05-11 Thread Kelly O';Hair
Vote: yes. -kto On May 11, 2011, at 8:55 AM, Kelly O'Hair wrote: > > On May 11, 2011, at 8:17 AM, Kelly O'Hair wrote: > >> >> Should the following person be added as a member of the OpenJDK Build Group? >> Magnus Ihse Bursie http://db.openjdk.ja

Re: Build Group Membership vote

2011-05-11 Thread Kelly O';Hair
Vote: yes. -kto On May 11, 2011, at 8:56 AM, Kelly O'Hair wrote: > > On May 11, 2011, at 8:12 AM, Kelly O'Hair wrote: > >> >> Should the following person be added as a member of the OpenJDK Build Group? >> Erik Joelsson http://db.openjdk.java.net/pe

Re: Request for review: always generate java-rmi.cgi

2011-05-11 Thread Kelly O';Hair
4495986. So my question is? Well questions are... Q1: What the heck is java-rmi.cgi and what is it used for? Q2: Does it belong somewhere other than the bin directory? -kto On May 11, 2011, at 6:45 AM, Dr Andrew John Hughes wrote: > On 17:32 Tue 10 May , Kelly O'Hair wrote: >>

Build Group Membership vote

2011-05-11 Thread Kelly O';Hair
y the votes and post a summary to this list and to discuss at openjdk.java.net. Only Members of the Build Group are eligible to vote on this decision [1]. The current Members are: Kelly O'Hair Mark Reinhold Xiomara Jayasena Tim Bell [1] http://openjdk.java.net/groups/ -kto

Re: Request for review: always generate java-rmi.cgi

2011-05-11 Thread Kelly O';Hair
On May 11, 2011, at 10:35 AM, Omair Majid wrote: >> >> Q2: Does it belong somewhere other than the bin directory? >> > > I am not sure. It is not supposed to be executed directly by a user. But it > is an executable file. I think the extension makes it clear that only a HTTP > server is supp

Re: Request for review: always generate java-rmi.cgi

2011-05-11 Thread Kelly O';Hair
On May 11, 2011, at 10:47 AM, Alan Bateman wrote: >> >> Q2: Does it belong somewhere other than the bin directory? >> >> > The script can be used to tunnel RMI calls over HTTP. Probably legacy now and > I'm pretty sure that java-rmi.cgi is just meant to be an example script. The > RMI FAQ p

Build Group Membership vote

2011-05-11 Thread Kelly O';Hair
UTC this Wednesday, 18 May 2011, after which time I'll tally the votes and post a summary to this list and to discuss at openjdk.java.net. Only Members of the Build Group are eligible to vote on this decision [1]. The current Members are: Kelly O'Hair Mark Reinhold Xiomar

Re: Build Group Membership vote

2011-05-11 Thread Kelly O';Hair
On May 11, 2011, at 10:55 AM, Kelly O'Hair wrote: > [Sorry about all these emails, but the build-dev alias is the group alias > too.] > > Should the following person be added as a member of the OpenJDK Build Group? > Phil Race http://db.openjdk.java.net/people/prr >

Re: Build Group Membership vote

2011-05-11 Thread Kelly O';Hair
Vote: yes. -kto On May 11, 2011, at 10:55 AM, Kelly O'Hair wrote: > [Sorry about all these emails, but the build-dev alias is the group alias > too.] > > Should the following person be added as a member of the OpenJDK Build Group? > Phil Race http://db.openjdk.java.net/

Re: Build Group Membership vote

2011-05-11 Thread Kelly O';Hair
Vote: yes -kto On May 11, 2011, at 10:20 AM, Kelly O'Hair wrote: > > Should the following person be added as a member of the OpenJDK Build Group? > David Katleman http://db.openjdk.java.net/people/katleman > > David is a member of the Release Engineering team in Santa

Re: Build Group Membership vote

2011-05-11 Thread Kelly O';Hair
My apologies for all the email noise on this topic. I am withdrawing the nominations of: Magnus Ihse Bursie http://db.openjdk.java.net/people/ihse Erik Joelsson http://db.openjdk.java.net/people/erikj Johan Walles http://db.openjdk.java.net/people/walles These three three very importan

Re: Should the Build Group sponsor the Build Infrastructure Project?

2011-05-11 Thread Kelly O';Hair
Vote: yes. -kto On May 11, 2011, at 8:23 AM, Kelly O'Hair wrote: > > Should the Build Group sponsor the Build Infrastructure Project [1]? > Please cast your vote by replying to this message with either > Vote: yes > or > Vote: no > as the first line of

Re: Request for review: always generate java-rmi.cgi

2011-05-11 Thread Kelly O';Hair
On May 11, 2011, at 1:33 PM, Omair Majid wrote: > Also, given that you have written up a more correct patch, perhaps you should > be committing it instead? Let me take care of this. I'll send out a webrev shortly. -kto

Re: Request for review: always generate java-rmi.cgi

2011-05-11 Thread Kelly O';Hair
Please review this change: 7043921: generate java-rmi.cgi on 64 bit platform http://cr.openjdk.java.net/~ohair/openjdk7/java-rmi-7043921/webrev/ I think this works for you guys, and seems to be a bit more obvious, at least to me. ;^) -kto

Re: Request for review: always generate java-rmi.cgi

2011-05-11 Thread Kelly O';Hair
On May 11, 2011, at 6:59 PM, David Katleman wrote: > > > On 5/11/2011 6:50 PM, Kelly O'Hair wrote: >> Please review this change: >> >> 7043921: generate java-rmi.cgi on 64 bit platform >> http://cr.openjdk.java.net/~ohair/openjdk7/java-rmi-7043921/web

Re: Need reviewer: Added test target and makefile cleanups

2011-05-12 Thread Kelly O';Hair
On May 11, 2011, at 7:54 AM, Omair Majid wrote: >> >> This will take a little looking. I'll file a separate CR (7043700) on this, >> but no promises. >> I don't want to backout the original changeset completely, maybe ifdef it >> for windows. >> > > I didnt mean that we should backout the ch

Need reviewers: 7043700: Regression for IcedTea builds (e.g. ALT_OUTPUTDIR)

2011-05-12 Thread Kelly O';Hair
Need reviewers. (Omair, you will want to verify this works for IcedTea). Some background: this changeset: http://hg.openjdk.java.net/jdk7/jdk7/rev/47f6b7db1882 Created some issues for people setting ALT_OUTPUTDIR to a vanilla path like /tmp/foobar. The expectation was that a debug build would

Re: Need reviewers: 7043700: Regression for IcedTea builds (e.g. ALT_OUTPUTDIR)

2011-05-12 Thread Kelly O';Hair
On May 12, 2011, at 4:33 PM, Omair Majid wrote: > Hi Kelly, > > On 05/12/2011 04:39 PM, Kelly O'Hair wrote: >> >> Need reviewers. (Omair, you will want to verify this works for IcedTea). >> >> Some background: this changeset: >> http://hg

Re: Need reviewers: 7043700: Regression for IcedTea builds (e.g. ALT_OUTPUTDIR)

2011-05-13 Thread Kelly O';Hair
change on a number of our builds before passing further > judgement. I think it is something that may have to wait given where we are > with Java 7. Well, it either works or it doesn't. The biggest impact is to those that set ALT_OUTPUTDIR. Getting this fixed removes a patch from the

Re: Build portability: enable or disable warnings

2011-05-16 Thread Kelly O';Hair
On May 16, 2011, at 7:23 AM, Dr Andrew John Hughes wrote: > I think the issue is actually having -Werror enabled for all builds, not > just debug builds. Without that, these additional warnings would just be > noise. Having -Werror on also causes problems just upgrading the version > of gcc, re

Re: Need reviewers: 7043700: Regression for IcedTea builds (e.g. ALT_OUTPUTDIR)

2011-05-16 Thread Kelly O';Hair
in the eating" and while the > actual make logic changes seem a little puzzling to me the end result is > good. The use of --fastdebug had caused problems for builds that > had differentiators beyond OS and ARCH. > > So thumbs up from me. > > Thanks, > david > &g

Re: Build portability: enable or disable warnings

2011-05-16 Thread Kelly O';Hair
rn on all warnings and -Werror by default. > > Having zero-warning build is good practice and it's not too costly. > > -Dmitry > > On 2011-05-16 19:56, Andrew Haley wrote: >> On 05/16/2011 04:35 PM, Kelly O'Hair wrote: >>> >>> On May 16, 2011, at 7:23 AM

Re: Build portability: enable or disable warnings

2011-05-16 Thread Kelly O';Hair
On May 16, 2011, at 10:12 AM, Andrew Haley wrote: > On 05/16/2011 05:50 PM, Dmitry Samersoff wrote: >> Andrew, >> >> I guess we can add to build system something like >> >> ALT_COMPILER_FLAGS >> >> and turn on all warnings and -Werror by default. >> >> Having zero-warning build is good practi

Re: Build portability: enable or disable warnings

2011-05-19 Thread Kelly O';Hair
On May 19, 2011, at 11:32 AM, Alan Bateman wrote: > David Holmes wrote: >> : >> >>> In contrast, there are basically two Java compilers in general use (javac >>> and ecj) >>> and one is part of OpenJDK. Yet, the Java code does not have -Werror >>> enabled by default and there >>> are a mass o

Fwd: Heads up, new jaxp source drop

2011-05-19 Thread Kelly O';Hair
FYI... -kto Begin forwarded message: > From: "Kelly O'Hair" > Date: May 19, 2011 17:53:36 PM GMT+02:00 > To: core-libs-dev > Subject: Heads up, new jaxp source drop > > Heads up. The jdk7/tl forest has a new jaxp source drop dependency. > > 7044493: I

Build Infrastructure Project

2011-05-20 Thread Kelly O';Hair
We now have a Build Infrastructure project! Register for email at: http://mail.openjdk.java.net/mailman/listinfo/build-infra-dev The repos will be at: http://hg.openjdk.java.net/build-infra/jdk7 But I haven't been able to populate them just yet, having access issues. Once the repos are pr

Re: Build Infrastructure Project

2011-05-20 Thread Kelly O';Hair
On May 20, 2011, at 3:36 PM, Dr Andrew John Hughes wrote: > On 13:11 Fri 20 May , Kelly O'Hair wrote: >> >> We now have a Build Infrastructure project! >> >> Register for email at: >> http://mail.openjdk.java.net/mailman/listinfo/build-infra-dev

Re: Build Infrastructure Project

2011-05-20 Thread Kelly O';Hair
gt; > -- Jon > > > > > > On 05/20/2011 07:12 AM, Kelly O'Hair wrote: >> On May 20, 2011, at 3:36 PM, Dr Andrew John Hughes wrote: >> >>> On 13:11 Fri 20 May , Kelly O'Hair wrote: >>>> We now have a Build Infrastructure projec

Re: Error when building openjdk 7

2011-05-21 Thread Kelly O';Hair
has this problem. openjdk6 does not have this problem. I have > used openjdk6 to successfully build jdk7. > > On Wed, Apr 27, 2011 at 11:26 PM, Kelly O'Hair wrote: > This is a reply to a delayed email, but the answer may be helpful to someone, > assuming this email > doesn&#

Should the Build Group sponsor the JDK 8 Project?

2011-05-23 Thread Kelly O';Hair
required. Only Members of the Build Group are eligible to vote on this decision [2]. The current Members are: Kelly O'Hair Mark Reinhold Xiomara Jayasena Tim Bell Phil Race David Katleman [1] http://mail.openjdk.java.net/pipermail/announce/2011-May/98.html [2]

Re: Should the Build Group sponsor the JDK 8 Project?

2011-05-23 Thread Kelly O';Hair
Vote: yes -kto On May 23, 2011, at 9:27 PM, Kelly O'Hair wrote: > Should the Build Group sponsor the JDK 8 Project [1]? > > Please cast your vote by replying to this message with either > Vote: yes > or > Vote: no > as the first line of the message body.

Fwd: JDK 8 Project

2011-05-24 Thread Kelly O';Hair
FYI.. -kto Begin forwarded message: > From: Kelly O'Hair > Date: May 24, 2011 9:04:17 AM GMT+02:00 > To: disc...@openjdk.java.net > Subject: JDK 8 Project > > The OpenJDK Build Group has agreed to sponsor the JDK 8 Project [1] > > 5 yes votes out of 6, one perso

New jaxws source drop

2011-06-03 Thread Kelly O';Hair
Heads up. Another new jaxws source drop dependency has been integrated into b145. http://hg.openjdk.java.net/jdk7/jdk7/jaxws/rev/bcca8afc019f The new jaxws source drop bundle is called: jdk7-jaxws2_2_4-b03-2011_05_27.zip So if you have your own ALT_DROPS_DIR cache, you need to add this file:

Boot JDK used with jdk7 builds

2011-06-03 Thread Kelly O';Hair
The documented Boot JDK to be used when building JDK7 repositories is JDK6 Update 18, as listed here http://hg.openjdk.java.net/jdk7/build/raw-file/tip/README-builds.html#MBE However, as many people know, JDK releases newer than JDK6u18 should always work, and some older ones can work too. Va

Re: Boot JDK used with jdk7 builds

2011-06-03 Thread Kelly O';Hair
On Jun 3, 2011, at 9:02 AM, Dr Andrew John Hughes wrote: > On 08:57 Fri 03 Jun , Kelly O'Hair wrote: >> >> The documented Boot JDK to be used when building JDK7 repositories is JDK6 >> Update 18, as listed here >> http://hg.openjdk.java.net/jdk7/build/raw

Should the Build Group sponsor the "JDK 7 Update" project?

2011-06-15 Thread Kelly O';Hair
s optional and not required. Only Members of the Build Group are eligible to vote on this decision [2]. The current Members are: Kelly O'Hair Mark Reinhold Xiomara Jayasena Tim Bell Phil Race David Katleman [1] http://mail.openjdk.java.net/pipermail/announce/2011-June/00010

Re: Should the Build Group sponsor the "JDK 7 Update" project?

2011-06-15 Thread Kelly O';Hair
Vote: yes -kto

Re: Request for review: 7039182 NIO platform specific files

2011-06-22 Thread Kelly O';Hair
Things like this: 884 $(SFS_GEN)/SolarisConstants.java: 885 $(prep-target) 886 $(CP) $(NIO_PLATFORM_CLASSES_ROOT_DIR)/sun/nio/fs/SolarisConstants-$(PLATFORM)-$(ARCH).java $@ Should be written as: 884 $(SFS_GEN)/SolarisConstants.java: $(NIO_PLATFORM_CLASSES_ROOT_DIR)/sun/ni

Re: 7057935: com/sun/nio/sctp tests should be moved out of jdk_nio and into their own target, jdk_sctp

2011-06-22 Thread Kelly O';Hair
On Jun 22, 2011, at 8:10 AM, Alan Bateman wrote: > Chris Hegarty wrote: >> Kelly, Alan, >> >> The com/sun/nio/sctp tests are run when running the jdk regression tests >> with the makefile in the jdk/test directory. They are currently part of the >> jdk_nio3 target. >> >> SCTP is a niche area

Re: Request for review: 7039182 NIO platform specific files

2011-06-27 Thread Kelly O';Hair
Looks fine. -kto On Jun 27, 2011, at 12:28 AM, David Holmes wrote: > Thanks Kelly. Updated webrev at: > > http://cr.openjdk.java.net/~dholmes/7039182/webrev.1/ > > David > > Kelly O'Hair said the following on 06/23/11 02:35: >> Things like this: >>

OpenJDK Build Group Quarterly Report

2011-06-30 Thread Kelly O';Hair
State of the OpenJDK Build Group The current Members are: Kelly O'Hair Mark Reinhold Xiomara Jayasena Tim Bell Phil Race David Katleman The OpenJDK Build Group sponsors the following Projects: * JDK 7 Update * Build Infrastructure * JDK 8 * JDK 7 * JDK 6

Re: Request for review: Store convenience scripts as executable

2011-07-20 Thread Kelly O';Hair
Although the jcheck extension isn't publicly available (it will be someday), it is used on the servers and by developers. That extension disallows ANY file from having execute permissions. So this changeset would get blocked, or create havoc for the developers. In general, placing execute permi

Need reviewer

2011-07-22 Thread Kelly O';Hair
Can one of you review these jprt changes, there is no impact to RE or manual developer building. These changes are needed to instruct our internal developer build system JPRT on how to build jdk8. 7069993: Adjust make/jprt.properties file for jdk8 http://cr.openjdk.java.net/~ohair/openjdk8/jprt

Re: Need reviewer

2011-07-22 Thread Kelly O';Hair
On Jul 22, 2011, at 5:09 PM, David Katleman wrote: > > > On 7/22/2011 4:57 PM, Kelly O'Hair wrote: >> >> Can one of you review these jprt changes, there is no impact to RE or manual >> developer building. >> >> These changes are needed to

Need reviewers, web page changes

2011-07-25 Thread Kelly O';Hair
Includes changes to use get_source.sh and hgforest.sh rather than the Forest Extension and the fclone/fstatus/fupdate/ffetch/fpush/fpull commands. Also added NetBeans project files (so I can use the NetBeans html editor). http://cr.openjdk.java.net/~ohair/web-forest/webrev/ -kto

Re: Need reviewers, web page changes

2011-07-25 Thread Kelly O';Hair
On Jul 25, 2011, at 11:02 AM, Mario Torre wrote: > Il giorno lun, 25/07/2011 alle 09.47 -0700, Kelly O'Hair ha scritto: >> Includes changes to use get_source.sh and hgforest.sh rather than the Forest >> Extension >> and the fclone/fstatus/fupdate/ffetch/fpush/fpull c

Re: Regression in OpenJDK8 Makefiles

2011-07-27 Thread Kelly O';Hair
On Jul 27, 2011, at 11:04 AM, Dr Andrew John Hughes wrote: > Hi, > > Can someone please tell me why: > > http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf4edfcd7119 > > reverted my earlier fix: > > http://hg.openjdk.java.net/jdk8/tl/jdk/rev/80368890a2a0 > > without any discussion? My apologies,

Re: Regression in OpenJDK8 Makefiles

2011-07-27 Thread Kelly O';Hair
On Jul 27, 2011, at 4:28 PM, Dr Andrew John Hughes wrote: > On 11:58 Wed 27 Jul , Kelly O'Hair wrote: >> >> On Jul 27, 2011, at 11:04 AM, Dr Andrew John Hughes wrote: >> >>> Hi, >>> >>> Can someone please tell me why: >>>

Re: Different javac options for explicitly and automatically compiled files

2011-08-02 Thread Kelly O';Hair
Eventually, we should always be using -implicit:none That will be part of the build infrastructure changes. I'm talking to Fredrik today, and this week. Hopefully we can get this project more public and accelerated. -kto On Aug 2, 2011, at 1:02 AM, Jonathan Gibbons wrote: > On 08/01/2011 02:55

Re: Different javac options for explicitly and automatically compiled files

2011-08-03 Thread Kelly O';Hair
On Aug 3, 2011, at 7:48 AM, Dr Andrew John Hughes wrote: >> >> No. The Makefiles should be set so that the "bootstrap runtime library" >> is overridden >> with -bootclasspath, meaning that the compilation will fail if the >> classes are not >> available to javac in source or compiled form. >>

Re: Different javac options for explicitly and automatically compiled files

2011-08-03 Thread Kelly O';Hair
On Aug 2, 2011, at 8:10 PM, Alexandre Boulgakov wrote: >> Eventually, we should always be using -implicit:none >> That will be part of the build infrastructure changes. > Is there a bug tracking this? That way I could omit the -Werror flag for now > and reference the relevant bug. > > Thanks, >

Build Infrastructure changes

2011-08-03 Thread Kelly O';Hair
FYI... If you are interested in the jdk8 build infrastructure changes coming down the pipe, I invite you to join the build-infra-dev alias: http://mail.openjdk.java.net/pipermail/build-infra-dev/2011-August/29.html I expect this work to get started and moving soon with Fredrik as the primar

Re: build failure on solaris-sparc

2011-09-14 Thread Kelly O';Hair
It has recently become apparent that Solaris is moving into the C99 arena, accidentally in some places, and on purpose in others. Many of the Solaris developers are unaware of the C99 features they are using or inflicting on everyone via /usr/include files, mostly because the default 'cc' behavi

OpenJDK Build Group Quarterly Report

2011-09-30 Thread Kelly O';Hair
State of the OpenJDK Build Group The current Members are: Kelly O'Hair Mark Reinhold Xiomara Jayasena Tim Bell Phil Race David Katleman The OpenJDK Build Group sponsors the following Projects: * JDK 7 Update * Build Infrastructure * JDK 8 * JDK 7 * JDK 6

Re: Improving source drops documentation

2011-10-11 Thread Kelly O';Hair
My plan of record has been to just unzip these bundles right into the repositories and get rid of this painful situation, that I have to confess, I created. :^( But I was thinking I could come up with some kind of way to paint these sources RED or something so that people do not patch these files

Re: Improving source drops documentation

2011-10-11 Thread Kelly O';Hair
wned upon? That would make clear that the > "source" is the intact bundle, not a bunch of separate, editable files. Just > a thought... > > —Dan > > On Oct 11, 2011, at 1:52 AM, Kelly O'Hair wrote: > >> My plan of record has been to just unzip these bun

Re: Confused about Windows build

2011-10-16 Thread Kelly O';Hair
Windows 2000 and Visual Studio 2003 is for 32bit. Windows 2003 and Microsoft Platform SDK is for 64bit X64. It's possible it could build with different Visual Studio compilers, but that would probably require makefile and source changes. -kto On Oct 16, 2011, at 5:33 PM, Ulf Zibis wrote: > On

Re: Review Request: openjdk make changes for "CR 7099017: jdk7u2-dev does not build"

2011-10-17 Thread Kelly O';Hair
Looks good to me. -kto On Oct 17, 2011, at 1:54 PM, chris.grus...@oracle.com wrote: > I am still looking for a reviewer. > > Please, > -ChrisG > > On 10/13/2011 5:03 PM, chris.grus...@oracle.com wrote: >> openjdk make changes to skip demo/DEMOS_LICENSE and sample/SAMPLES_LICENSE >> when build

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

2011-10-20 Thread Kelly O';Hair
Looks good. -kto On Oct 19, 2011, at 11:30 PM, Sean Chou wrote: > Hi all, > >Would anyone like to review this patch ? The problem it trying to fix is > very simple, just > add the version information to the dll files in demo. > >The bug link is: http://bugs.sun.com/bugdatabase/view_bu

Re: Building OpenJDK8 using OpenJDK7

2011-10-21 Thread Kelly O';Hair
I will fix this https issue. However, have you signed the OCA? See http://openjdk.java.net/contribute/ Your other changes make sense, but I need to make sure the OCA issue is ok first. -kto On Oct 21, 2011, at 8:28 AM, Tim Ellison wrote: > I tried building OpenJDK8 using my build of OpenJDK7,

Re: JDK8 32-bit "docs" build fails on 64-bit Windows

2011-10-27 Thread Kelly O';Hair
As I recall, on Windows, if we change to 1024, it's possible the VM will not startup if the machine doesn't have a hole that big in it's virtual memory. So if we change to 1024, we could rule out people with a fragmented memory system, like running NetBeans and FireFox and 100's of useless Windo

Re: JDK8 32-bit "docs" build fails on 64-bit Windows

2011-10-28 Thread Kelly O';Hair
because I assume there are few Windows build >>>>>>> machines with less than >>>>>>> 512mb memory nowadays:) >>>>>>> >>>>>>> So back to our problem: I think MAX_VM_MEMORY should be set depending >>>>&g

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

2011-11-02 Thread Kelly O';Hair
This change is both a build change and a serviceability change, but I would argue that it is more of a build change since the functionality of the jvmti demos shouldn't have changed with this. Although I am listed as a member of the serviceability "group", I'm not exactly sure who leads that gr

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

2011-11-03 Thread Kelly O';Hair
Checking out the change now. -kto On Nov 3, 2011, at 10:02 AM, Neil Richards wrote: > On Wed, 2011-11-02 at 12:29 -0700, Kelly O'Hair wrote: >> It will be important that you create the changeset using the latest jdk8 >> build >> forest, e.g. using a clones from http:

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

2011-11-04 Thread Kelly O';Hair
t. Thanks for the contribution, hopefully as the bug tracking system become open and we can create a build&test system accessible to all openjdk contributors this will get easier for everyone. -kto On Nov 3, 2011, at 10:02 AM, Neil Richards wrote: > On Wed, 2011-11-02 at 12:29 -0700, K

Re: Xm/Motif for OpenJDK build?

2011-11-09 Thread Kelly O';Hair
I am using: aptitude update aptitude install mercurial aptitude install rpm ssh openjdk6-jdk expect tcsh csh ksh gawk g++ build-essential aptitude build-dep openjdk-6 if [ "`uname -m`" = "x86_64" ] ; then aptitude install ia32-libs fi aptitude ins

Re: Xm/Motif for OpenJDK build?

2011-11-10 Thread Kelly O';Hair
> On Wed, Nov 9, 2011 at 10:06 AM, Kelly O'Hair wrote: > I am using: > > aptitude update > aptitude install mercurial > aptitude install rpm ssh openjdk6-jdk expect tcsh csh ksh gawk g++ > build-essential > aptitude build-dep openjdk-6

Re: problem when building openjdk6

2011-11-14 Thread Kelly O';Hair
After you apply the fix, you need to start from scratch, delete the build/ directory and start again. -kto On Nov 13, 2011, at 7:10 PM, Li Li wrote: > hi all > I tried to build a debug version of openjdk6. I follows these articles: > http://weblogs.java.net/blog/simonis/archive/2008/01/hots

Re: Please review 7112160

2011-11-16 Thread Kelly O';Hair
Looks fine. -kto On Nov 16, 2011, at 11:47 AM, Kumar Srinivasan wrote: > Hi, > > Here is a tiny change to increase the heap space for javadoc, during the > jdk build, this allows the build to complete and speeds up the build as well. > > fyi. The heap space was on the borderline of running o

Re: Please review 7112160 (Kumar Srinivasan)

2011-11-16 Thread Kelly O';Hair
On windows, it's more of a "give me a block of memory this big", and sometimes even if the system has 4GB, it might not have a 1GB hole to give you. :^( So java just dies on startup. And if you make this number > RAM, the Linux/Solaris systems could very easily just page thrash. We could dec

Re: (XS) Request for review: 7109092 - link changes for embedded builds

2011-11-28 Thread Kelly O';Hair
Looks ok to me. -kto On Nov 22, 2011, at 10:55 PM, David Holmes wrote: > We need to make an adjustment to the link instructions used for libjava in > embedded builds, as defined in Defs-embedded.gmk > > webrev: http://cr.openjdk.java.net/~dholmes/7109092/webrev/ > > Summary: system soft-float

Re: please review fix for 7116322, enhance javac make rule with a little bit of instrumentation

2011-11-29 Thread Kelly O';Hair
Looks fine to me. -kto On Nov 28, 2011, at 8:00 PM, Stuart Marks wrote: > > > On 11/28/11 7:00 PM, David Holmes wrote: >> On 29/11/2011 10:42 AM, Stuart Marks wrote: >>> Please review this change to add to the javac make rule some messages >>> about the number of files being compiled, the curr

Re: please review fix for 7116322, enhance javac make rule with a little bit of instrumentation

2011-11-29 Thread Kelly O';Hair
No objection from me. -kto On Nov 29, 2011, at 3:09 PM, Stuart Marks wrote: > Thanks Kelly (and David). > > Any objection if I were to push this into the TL forest? A test build on all > the platforms (including Windows) was successful. > > s'marks > > On 11

Re: Building Open JDK 6 On Windows 7

2011-12-12 Thread Kelly O';Hair
openjdk6 would require source file changes and lots of makefile changes to build with VS2010. The transition of openjdk7 from VS2003 to VS2010 was a long and somewhat painful trip. Not that it isn't possible to do it for openjdk6, just no priority or need from my point of view. Of course, keep

Re: please review 7122061: enable -Werror in various jdk build steps

2011-12-15 Thread Kelly O';Hair
Looks ok. -kto On Dec 15, 2011, at 6:59 PM, Stuart Marks wrote: > The webrev is here: > > http://cr.openjdk.java.net/~smarks/reviews/7122061/webrev.0/ > > This defines the JAVAC_MAX_WARNINGS and JAVAC_WARNINGS_FATAL variables in a > variety of Makefiles within the jdk repository. This essenti

Re: Build succeeds even if JDK source file fails to compile

2011-12-16 Thread Kelly O';Hair
You are correct. This changeset was wrong. Mandy was asking me about this a while back and I was also noticing the problem with a recent problem Maurizio was having doing boot cycle builds on Linux, where javac failed, make did not stop, and merrily crashed later in javah. :^( -kto On Dec 16,

Re: Build succeeds even if JDK source file fails to compile

2011-12-16 Thread Kelly O';Hair
)" -d $(CLASSDESTDIR) > @$<.filtered; \ > - $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) > @$<.filtered; \ > + $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) > @$<.filtered && \ > $(

Re: Need help in building openjdk in ubuntu 11.10

2011-12-21 Thread Kelly O';Hair
Did you export ALT_BOOTDIR? It needs to be set in the environment. -kto On Dec 21, 2011, at 4:55 PM, m silverstri wrote: > I have run and passed 'make sanity' and I have download and set > ALT_BOOTDIR to a jdk6: > > $ echo $ALT_BOOTDIR > /home/michael/Programs/jdk1.6.0_30 > > But when I 'mak

Re: Need help in building openjdk in ubuntu 11.10

2011-12-21 Thread Kelly O';Hair
e --version say? -kto On Dec 21, 2011, at 6:11 PM, m silverstri wrote: > I did. > > $ echo $ALT_BOOTDIR > /home/michael/Programs/jdk1.6.0_30 > > On Wed, Dec 21, 2011 at 5:54 PM, Kelly O'Hair wrote: >> Did you export ALT_BOOTDIR? It needs to be set in the envi

Re: please review 7122061: enable -Werror in various jdk build steps

2011-12-22 Thread Kelly O';Hair
On Dec 22, 2011, at 12:46 PM, Joe Darcy wrote: > As an aside, I've thought it was a bit of design error that implicit > compilation was the default. Me too. > > Since JDK 6 there has been a javac option that can be used to disable > implicit compilation, -implicit:none. > > Perhaps this opt

Re: Need help in building openjdk on ubuntu 11.10

2011-12-29 Thread Kelly O';Hair
The makefiles are not prepared for building on Linux 3.0 kernels yet. Try applying this patch: diff --git a/make/linux/Makefile b/make/linux/Makefile --- a/make/linux/Makefile +++ b/make/linux/Makefile @@ -230,7 +230,7 @@ # Solaris 2.5.1, 2.6). # Disable this check by setting DISABLE_HOTSPOT_O

Re: Does OpenJDK statically link the C++ runtime?

2012-01-04 Thread Kelly O';Hair
On Jan 3, 2012, at 10:16 PM, John Von Seggern wrote: > Does OpenJDK continue to take this approach? > Depends on who does the build. The default might be to statically link, pretty sure anyway. > I'm asking because I would like to use the Java Native Interface to > call functions in a C++ lib

Re: freetype_versioncheck failed to compile

2012-01-04 Thread Kelly O';Hair
The change sounds reasonable, but it's a change to something I have always hated, so it's somewhat distasteful to me because of that. Having the makefiles build and run an application as part of a sanity check just seems so... what is the word silly? :^( I had hoped that we could just hav

Need reviewer: fixes to prtconf for solaris zones and less execs

2012-01-04 Thread Kelly O';Hair
Need reviewer: fixes to prtconf for solaris zones and less execs Basically this patch, will be made to openjdk6, 7u4, and jdk8: diff --git a/make/common/shared/Platform.gmk b/make/common/shared/Platform.gmk --- a/make/common/shared/Platform.gmk +++ b/make/common/shared/Platform.gmk @@ -147,8 +14

Re: Does OpenJDK statically link the C++ runtime?

2012-01-04 Thread Kelly O';Hair
pend on using a specific version of the C/C++ runtime. C is easier than C++ because the runtime issues are not as complicated. And each JDK release uses a different C/C++ compiler and potentially a different C++ runtime. Usually, only one C++ runtime is allowed in a process at a time, or at

Re: Does OpenJDK statically link the C++ runtime?

2012-01-04 Thread Kelly O';Hair
On Jan 4, 2012, at 6:03 PM, Dr Andrew John Hughes wrote: > The most obvious issue for me is security. If a security flaw appears in > libstdc++ > (or whatever library is linked statically), you have to rebuild to fix it. > So the JDK > has to have a security update due to one of its dependenc

Re: freetype_versioncheck failed to compile

2012-01-05 Thread Kelly O';Hair
CC_PROGRAM_OUTPUT_FLAG variable was not used consistently. Windows has multiple ways to specify the names. So I just got rid of it, everyone is explicit now. -kto On Jan 4, 2012, at 6:50 PM, Jonathan Lu wrote: > Hi Kelly, > > Thanks for reviewing, > > On 01/05/2012 06:35 AM, Kelly O

Re: freetype_versioncheck failed to compile

2012-01-06 Thread Kelly O';Hair
Jonathan, This is bit more than what you suggested but should fix your initial issue. Let me know if you are ok with this change and I will try and integrate it asap. -kto On Jan 5, 2012, at 1:02 PM, David Katleman wrote: > > > On 1/5/2012 12:46 PM, Kelly O'Hair wrote: >

Re: Customized make file inclusion

2012-01-17 Thread Kelly O';Hair
Generally, I have no objection to this change. But instead of setting it to NO_SUCH_PATH, I would not set it at all, and avoid the $(shell) to see if it exists completely. Just don't set CUSTOM_MAKE_DIR if it does not exist. Then you don't need the HAS_CUSTOM_MAKE, it can just be ifdef CUSTOM_MA

Re: Customized make file inclusion

2012-01-18 Thread Kelly O';Hair
On Jan 17, 2012, at 7:17 PM, David Holmes wrote: > On 18/01/2012 7:07 AM, Kelly O'Hair wrote: >> Generally, I have no objection to this change. >> >> But instead of setting it to NO_SUCH_PATH, I would not set it at all, and >> avoid the $(shell) to see if it &

Re: Build openjdk in Ubuntu 11.10

2012-01-18 Thread Kelly O';Hair
Patch looks fine to me. -kto On Jan 13, 2012, at 9:54 AM, mark.reinh...@oracle.com wrote: > 2012/1/13 9:33 -0800, michael.j.silvers...@gmail.com: >> I am getting the following error when building openjdk 7.0 on ubuntu 11.10 >> But I already have the package libasound2-dev installed. > > This is

  1   2   3   4   5   6   7   8   9   10   >