configure error on OSX 10.8.5: Could not find free type!

2014-01-10 Thread Lance Andersen
would be appreciated! Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com

Re: configure error on OSX 10.8.5: Could not find free type!

2014-01-10 Thread Lance Andersen
In case configure is looking for it is here on my system freetype.6.dylib ew-host-5:lib lance$ ls -l /usr/X11/lib/libfreetype.6.dylib -rwxr-xr-x 1 root wheel 25984 Nov 15 2012 /usr/X11/lib/libfreetype.6.dylib Best Lance On Jan 10, 2014, at 5:45 PM, Lance Andersen lance.ander

Re: configure error on OSX 10.8.5: Could not find free type!

2014-01-11 Thread Lance Andersen
...@gmail.com wrote: Hi Lance, just install the latest XQuartz version, e.g. 2.7.5. It helped me on OSX 10.9.1. Hope this helps. Best regards, Andrej Golovnin On 10.01.2014, at 23:45, Lance Andersen lance.ander...@oracle.com wrote: Hi all, Trying to get a build environment on OSX

regression test failures

2014-01-11 Thread Lance Andersen
: /Users/lance/Documents/hg-workspaces/jdk8/jdbc-jdk/jdk/testoutput/jdk_all/JTreport/text/summary.txt EXIT CODE: 1 EXIT CODE: 1 make[2]: *** [jtreg_tests] Error 1 make[1]: *** [jdk_all] Error 2 make: *** [jdk_all] Error 2 - Lance Andersen| Principal Member of Technical

Re: regression test failures

2014-01-12 Thread Lance Andersen
alan.bate...@oracle.com wrote: On 11/01/2014 19:15, Lance Andersen wrote: : /Users/lance/Documents/hg-workspaces/jdk8/jdbc-jdk/jdk/test/TEST.groups: group compact2_minimal: file not found: :needs_compact3 /Users/lance/Documents/hg-workspaces/jdk8/jdbc-jdk/jdk/test/TEST.groups: group

Re: regression test failures

2014-01-14 Thread Lance Andersen
Lance On Jan 13, 2014, at 9:26 PM, David Holmes david.hol...@oracle.com wrote: -l :jdk_all Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com

Re: regression test failures

2014-01-14 Thread Lance Andersen
Thank you for the follow up On Jan 14, 2014, at 8:35 AM, Alan Bateman alan.bate...@oracle.com wrote: On 14/01/2014 13:25, Lance Andersen wrote: Hi David, Thank you for the email. Running the command jtreg -l :jdk_all produces (I assume running this from jdk/test was the correct spot

Re: get_source.sh using JT_HOME?

2014-01-14 Thread Lance Andersen
On Jan 14, 2014, at 12:17 PM, Alan Bateman alan.bate...@oracle.com wrote: On 14/01/2014 16:36, Lance Andersen wrote: Not sure if this is intentional, but I had JT_HOME set when i sourced get_source.sh against jdk8u-dev noticed the following messages: jdk/src/closed: hg clone JT_HOME

Change in hotspot causing build issues on OSX 10.8.5

2015-08-21 Thread Lance Andersen
clean? Thoughts? Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com

Re: Change in hotspot causing build issues on OSX 10.8.5

2015-08-24 Thread Lance Andersen
-dev/jdk/src/java.base/unix/native/libjava/jlong_md.h:69:9: warning: 'ptr_to_jlong' macro redefined #define ptr_to_jlong(a) ((jlong)(a)) -- Best Lance On Aug 24, 2015, at 12:18 AM, David Holmes david.hol...@oracle.com wrote: Hi Lance, On 22/08/2015 1:20 AM, Lance Andersen wrote: Hi

jdk 9 build broken?

2015-11-14 Thread Lance Andersen
misc in my jdk 9 workspace Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com

Errors building on OSX 10.8.5

2016-03-19 Thread Lance Andersen
] Error 2 ljanders-mac:modular-dev ljanders$ Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com

Cloning issues anyone seeing them?

2016-07-20 Thread Lance Andersen
racle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Problem running configure on El Capitan

2016-07-20 Thread Lance Andersen
sign/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: JDK 9 RFR Enable doclint reference checking for the java.management.rmi module

2017-02-14 Thread Lance Andersen
+1 -- Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPhone > On Feb 14, 2017, at 8:27 PM, joe darcy <joe.da...@oracle.com> wrote: > > Hello, >

Re: support/gensrc/jdk.jdi/jdwp-protocol.html build error

2016-10-31 Thread Lance Andersen
cy in the recent Javadoc > refactoring, which is triggered on your build platform. > > A workaround for you right now is to do 'make jdk.jdi' first, which will make > sure the Javadoc stage later will succeed. > > Sorry for the inconvenience. :-( > > /Magnus > >>

support/gensrc/jdk.jdi/jdwp-protocol.html build error

2016-10-31 Thread Lance Andersen
this? Thank you in advance… Best Lance <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance And

Re: support/gensrc/jdk.jdi/jdwp-protocol.html build error

2016-10-31 Thread Lance Andersen
oc > refactoring, which is triggered on your build platform. > > A workaround for you right now is to do 'make jdk.jdi' first, which will make > sure the Javadoc stage later will succeed. > > Sorry for the inconvenience. :-( > > /Magnus > >> 31 okt. 2016

Re: Review Request: JDK-8179035: Include tool modules in unified docs

2017-04-20 Thread Lance Andersen
t;http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Techn

JIB build failures JDK 10 full repro of install

2017-09-24 Thread Lance Andersen
om/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington,

make reconfigure fails on idk 10

2017-10-17 Thread Lance Andersen
le.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlingt

Re: make reconfigure fails on idk 10

2017-10-17 Thread Lance Andersen
> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: make reconfigure fails on idk 10

2017-10-18 Thread Lance Andersen
and see if the > problem still exists? > > /Erik > > > On 2017-10-17 23:08, Lance Andersen wrote: >> Hi, >> >> I just tried to run ‘make reconfigure’ in a JDK 10 workspace which was >> cloned from an existing workspace it fails: >> >>

Re: RFR: JDK-8205942: Build failure on macosx after JDK-8189429

2018-06-27 Thread Lance Andersen
<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR 8190378: Java EE and CORBA modules removal

2018-02-07 Thread Lance Andersen
l just be left over stuff in it. > > Best regards, > Goetz. > > > -Original Message- > From: core-libs-dev [mailto:core-libs-dev-boun...@openjdk.java.net] On Behalf > Of Lance Andersen > Sent: Wednesday, February 7, 2018 5:57 PM > To: core-libs-dev &l

Re: RFR 8190378: Java EE and CORBA modules removal

2018-02-07 Thread Lance Andersen
wse/JDK-8194308 >> <https://bugs.openjdk.java.net/browse/JDK-8194308> >> <https://bugs.openjdk.java.net/browse/JDK-8194308> >> <https://bugs.openjdk.java.net/browse/JDK-8194308> >> >> >> >> Best, >> Lance >&

Re: RFR 8190378: Java EE and CORBA modules removal

2018-02-13 Thread Lance Andersen
ying to read > from stdin. > > At least that is what my analysis indicates. I simply set: > > JAVASE_MODULES := > > to work around it. > > David > - > > On 8/02/2018 11:37 PM, Lance Andersen wrote: >>> On Feb 8, 2018, at 3:04 AM, Alan Bateman

Re: [11] RFR JDK-8197865: @moduleGraph taglet generates incorrect link to module graph

2018-02-13 Thread Lance Andersen
mbnailHeight = -1; > String hoverImage = ""; > if (!moduleName.equals("java.base")) { <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-

Re: [11] RFR JDK-8197865: @moduleGraph taglet generates incorrect link to module graph

2018-02-13 Thread Lance Andersen
Change is pushed. Thank you Tim for the review your change looks good Mandy... Best Lance > On Feb 13, 2018, at 2:38 PM, Lance Andersen <lance.ander...@oracle.com> wrote: > > Hi Mandy > > I just submitted an RFR to build-dev so our emails crossed > >> On F

RFR: 8197866 Docs.mk still had a reference to java.se.ee

2018-02-13 Thread Lance Andersen
racle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR 8190378: Java EE and CORBA modules removal

2018-02-08 Thread Lance Andersen
> On Feb 8, 2018, at 3:04 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 07/02/2018 16:57, Lance Andersen wrote: >> Hi all, >> >> I think we are at a point where we are ready to start reviewing the changes >> to remove the Java EE and CORBA mod

RFR 8190378: Java EE and CORBA modules removal

2018-02-07 Thread Lance Andersen
us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: [12] RFR JDK-8167314: Enable the check to detect duplicate provides in in GenModuleInfoSource

2018-08-20 Thread Lance Andersen
es generated for jdk.internal.vm.compiler. Since JDK-8208463 > is now resolved [1], we can enable this check. > > Webrev: > http://cr.openjdk.java.net/~mchung/jdk12/webrevs/8167314/webrev.00/ > > Mandy > [1] http://hg.openjdk.java.net/jdk/jdk/rev/c5461fe16efb Lance Andersen| Pr

Re: RFR: JDK 11 P1: 8209806: API docs should be updated to refer to javase11

2018-08-21 Thread Lance Andersen
ign/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR: 8208157: requires.VMProps throws NPE for missing properties in "release" file

2018-07-24 Thread Lance Andersen
ementorProperty.replace("\"", ""); > } catch (IOException e) { > e.printStackTrace(); > } > > > Thank you. > > Shura <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracl

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

2018-02-28 Thread Lance Andersen
> On Feb 28, 2018, at 2:43 PM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 28/02/2018 18:25, Lance Andersen wrote: >> Hi all, >> >> This RFR request moves the javax.transaction.xa package out of the java.sql >> module and into its own module java

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

2018-02-28 Thread Lance Andersen
Best Lance > > Paul. > >> On Feb 28, 2018, at 10:25 AM, Lance Andersen <lance.ander...@oracle.com >> <mailto:lance.ander...@oracle.com>> wrote: >> >> Hi all, >> >> This RFR request moves the javax.transaction.xa package out o

RFR JDK-8197533 move javax.transaction.xa into its own module

2018-02-28 Thread Lance Andersen
sign/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

2018-02-28 Thread Lance Andersen
> On Feb 28, 2018, at 2:20 PM, Lance Andersen <lance.ander...@oracle.com> wrote: > > Hi Paul, > > Thank you for the review. >> On Feb 28, 2018, at 1:40 PM, Paul Sandoz <paul.san...@oracle.com >> <mailto:paul.san...@oracle.com>> wrote: &

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

2018-03-01 Thread Lance Andersen
cea/8197533/webrev.03/> Best Lance > On Mar 1, 2018, at 12:37 PM, Paul Sandoz <paul.san...@oracle.com> wrote: > > +1 > >> On Mar 1, 2018, at 8:59 AM, Lance Andersen <lance.ander...@oracle.com >> <mailto:lance.ander...@oracle.com>> wrote: >>> &

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

2018-03-01 Thread Lance Andersen
> On Feb 28, 2018, at 8:29 PM, Paul Sandoz <paul.san...@oracle.com> wrote: > > > >> On Feb 28, 2018, at 1:22 PM, Lance Andersen <lance.ander...@oracle.com >> <mailto:lance.ander...@oracle.com>> wrote: >> >>> >>> On F

Re: RFR: XXS: JDK-8213102: Oracle Unilinks are [301 Moved Permanently] to https://docs.oracle.com

2018-10-29 Thread Lance Andersen
TTERN = > Pattern.compile("(?s)(\\s*)(?\\w+)(\\s+)(?.*)$"); > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR: JDK-8213237 Remove test-compile-commands from jib-profiles.js

2018-11-01 Thread Lance Andersen
m variant. These are used for > verification. > > /Magnus > (Sorry for the mess :-() <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>

Re: RFR(XS): 8212994: Links to Oracle websites should use "https:"

2018-10-25 Thread Lance Andersen
| xargs grep > "https://www.oracle.com/pls/topic/lookup?ctx=javase12\\;id=homepage; | wc > -l > 20312 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR: JDK-8215304 Make target "docs-jdk-index" has unnecessary dependencies

2018-12-12 Thread Lance Andersen
docs-zip: docs-jdk > > # Tests > > /Magnus <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-emai

Re: RFR: JDK-8214910 If pandoc is present, markdown spec files should be processed

2018-12-10 Thread Lance Andersen
-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR XXS,docs JDK-8225346: Convert file to HTML5

2019-06-05 Thread Lance Andersen
+1 > On Jun 5, 2019, at 11:21 AM, Jonathan Gibbons > wrote: > > Please review a trivial fix to change the doctype for a file from HTML 4 to > HTML 5. This gets the file off the doccheck radar. > > No webrev; patch below. > > -- Jon > > JBS: https://bugs.openjdk.java.net/browse/JDK-8225346 >

Re: RFR: S, 13 JDK-8226628 The copyright footer should be enclosed in

2019-06-21 Thread Lance Andersen
gt; specs_bottom_rel_path := ../ > $(foreach n, 0 1 2, \ > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/or

hg/python issues on Sierra(OS X 10.12.6)

2019-07-14 Thread Lance Andersen
p://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: [14] Review Request: JDK-8231027 Correct typos

2019-09-16 Thread Lance Andersen
if> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR [15] 8238918 idea.sh should work with both mercurial and git repo

2020-02-12 Thread Lance Andersen
m/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR 15 8225319: Remove the RMI static stub compiler rmic

2020-04-03 Thread Lance Andersen
a.net/browse/JDK-8225319 > > [3] Deprecate rmic for removal > https://bugs.openjdk.java.net/browse/JDK-8217412 > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-s

Re: RFR: 8251549: Update docs on building for Git

2020-09-05 Thread Lance Andersen
On Sat, 5 Sep 2020 20:13:18 GMT, Joe Darcy wrote: > 8251549: Update docs on building for Git Hi Joe, This looks OK.Are similar changes being made to http://openjdk.java.net/guide/producingChangeset.html as well given it refers to mercurial? - Marked as reviewed by lancea

Re: Documenting options; was Re: RFR: JDK-8220639 Need a way to augment JTREG_LAUNCHER_OPTIONS from command-line

2020-06-16 Thread Lance Andersen
TIONS VM_OPTIONS KEYWORDS EXTRA_PROBLEM_LISTS AOT_MODULES >>>>> LAUNCHER_OPTIONS. >>>>> RunTests.gmk:292: *** Re-run without 'help' to continue. Stop. >>>>> >>>>> Finally, I fixed some broken comments regarding AOT that I noticed while >>>>> fixing this. >>>>> >>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8220639 >>>>> WebRev: >>>>> http://cr.openjdk.java.net/~ihse/JDK-8220639-add-jtreg-launcher-options/webrev.01 >>>>> >>>>> /Magnus > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal [v6]

2021-05-31 Thread Lance Andersen
On Mon, 31 May 2021 15:02:57 GMT, Weijun Wang wrote: >> Please review this implementation of [JEP >> 411](https://openjdk.java.net/jeps/411). >> >> The code change is divided into 3 commits. Please review them one by one. >> >> 1. >>

Re: RFR: JDK-8266254: Update to use jtreg 6

2021-06-02 Thread Lance Andersen
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote: > Please review the change to update to using jtreg 6. > > The primary change is to the jib-profiles.js file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `requiredVersion`

Re: RFR: 8268267: Remove -Djavatest.security.noSecurityManager=true from jtreg runs

2021-06-04 Thread Lance Andersen
On Fri, 4 Jun 2021 15:53:42 GMT, Weijun Wang wrote: > Now that the default behavior of JDK 17 is still > `-Djava.security.manager=allow`, we can remove the > `-Djavatest.security.noSecurityManager=true` option from the jtreg command > line inside `RunTests.gmk`. Three problem-listed langtools

Re: RFR: JDK-8262315: missing ';' in generated entities

2021-02-24 Thread Lance Andersen
On Wed, 24 Feb 2021 17:45:19 GMT, Jonathan Gibbons wrote: > Fix typo-by-omission. A `;` is missing after ``. > > This is in the build tools, in the code for the `@jls` taglet, used to > generate docs. No change to JDK product code. Marked as reviewed by lancea (Reviewer). -

Re: RFR: 8275512: Upgrade required version of jtreg to 6.1 [v2]

2021-10-19 Thread Lance Andersen
On Tue, 19 Oct 2021 17:24:17 GMT, Weijun Wang wrote: >> As a follow up of JEP 411, we will soon disallow security manager by >> default. jtreg 6.1 does not set its own security manager if JDK version is >> >= 18. > > Weijun Wang has updated the pull request incrementally with one additional >

Re: RFR: 8274658: ISO 4217 Amendment #170 Update

2021-10-01 Thread Lance Andersen
On Fri, 1 Oct 2021 18:57:28 GMT, Naoto Sato wrote: > This is to incorporate the ISO 4217 amendment #170, which has been released > today, effective immediately. Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5790

Re: RFR: 8274083: Update testing docs to mention tiered testing [v6]

2021-09-24 Thread Lance Andersen
On Fri, 24 Sep 2021 06:12:20 GMT, Aleksey Shipilev wrote: >> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, >> let's mention them in `testing.md`. >> >> Current patch is my braindump, I am open for suggestions :) > > Aleksey Shipilev has updated the pull request

Re: RFR: 8276400: openjdk image Jars, Zips and Jmods built from the same source are not reproducible

2021-11-05 Thread Lance Andersen
On Thu, 4 Nov 2021 20:56:45 GMT, Andrew Leonard wrote: > This PR enables reproducible Jars, Jmods and openjdk image zip files > (eg.src.zip). > It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying > ZipOutputStream's. > It fixes the following keys issues relating to

Re: RFR: 8279877: Document IDEA IDE setup in docs/ide.md

2022-01-12 Thread Lance Andersen
On Wed, 12 Jan 2022 07:29:33 GMT, Daniel Jelinski wrote: > Currently the information about using IDEA can only be found on mailing lists. > > Additionally fixed the documentation for Visual Studio; the target > `ide-project` does not exist. Thank you for taking a stab at this. As far as I am

Re: RFR: 8279877: Document IDEA IDE setup in docs/ide.md

2022-01-12 Thread Lance Andersen
On Wed, 12 Jan 2022 12:10:50 GMT, Daniel Jelinski wrote: > > (...) As far as I am aware, the ide.html should be generated from the > > ide.md so you should only need to modify ide.md > > Are you sure about this? The discussion on #5676 suggests that the HTML files > need to be modified. > >

Re: RFR: 8279877: Document IDEA IDE setup in docs/ide.md [v2]

2022-01-12 Thread Lance Andersen
On Wed, 12 Jan 2022 14:46:54 GMT, Daniel Jelinski wrote: >> Currently the information about using IDEA can only be found on mailing >> lists. >> >> Additionally fixed the documentation for Visual Studio; the target >> `ide-project` does not exist. > > Daniel Jelinski has updated the pull

Re: RFR: 8279877: Document IDEA IDE setup in docs/ide.md [v2]

2022-01-12 Thread Lance Andersen
On Wed, 12 Jan 2022 14:46:54 GMT, Daniel Jelinski wrote: >> Currently the information about using IDEA can only be found on mailing >> lists. >> >> Additionally fixed the documentation for Visual Studio; the target >> `ide-project` does not exist. > > Daniel Jelinski has updated the pull

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

2022-03-04 Thread Lance Andersen
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo The changes look OK. The copyright year probably should be updated as part of this PR - Marked as reviewed by

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

2022-03-07 Thread Lance Andersen
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo What problem are you having editing the PR header? You should be able to do so as the author of the PR - PR:

Re: RFR: 8268081: Upgrade Unicode Data Files to 14.0.0

2022-01-06 Thread Lance Andersen
On Wed, 5 Jan 2022 22:42:38 GMT, Naoto Sato wrote: > Please review the changes for upgrading the Unicode support in the JDK, from > version 13 to version 14. Corresponding CSR has also been drafted. Marked as reviewed by lancea (Reviewer). - PR:

Re: RFR: 8284209: Replace remaining usages of 'a the' in source code

2022-05-18 Thread Lance Andersen
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > It's the last issue in the series, and it still touches different areas of > the code. Marked as reviewed by lancea (Reviewer).

Re: RFR: 8286744: failure_handler: dmesg command on macos fails to collect data due to permission issues [v2]

2022-05-13 Thread Lance Andersen
On Fri, 13 May 2022 14:39:44 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to fix the failure >> handler command `dmesg` on macOS? >> >> As noted in the JBS issue, the command currently fails with permission >> error. The commit in this PR uses `sudo` as

Re: RFR: 8286623: Bundle zlib by default with JDK on macos aarch64

2022-05-12 Thread Lance Andersen
On Thu, 12 May 2022 08:43:56 GMT, Jaikiran Pai wrote: > Can I please get a review of this change to the build system which now makes > bundled zlib as the default for macos aarch64 systems? > > We have been running into various intermittent failures on macos aarch64 > systems for several

Re: RFR: 8287155: Additional make typos

2022-05-23 Thread Lance Andersen
On Mon, 23 May 2022 10:04:14 GMT, Magnus Ihse Bursie wrote: > Testing ispell + shell magic to locate typos. It worked, but is not scalable > to the entire JDK. :-( Keep the fixes for the problems found in the make > directory, though. Marked as reviewed by lancea (Reviewer). -

Re: RFR: 8284209: Replace remaining usages of 'a the' in source code [v3]

2022-05-24 Thread Lance Andersen
On Tue, 24 May 2022 09:52:29 GMT, Alexey Ivanov wrote: >> Replaces usages of articles that follow each other in all combinations: >> a/the, an?/an?, the/the… >> >> It's the last issue in the series, and it still touches different areas of >> the code. > > Alexey Ivanov has updated the pull

Re: RFR: 8286582: Build fails on macos aarch64 when using --with-zlib=bundled [v2]

2022-05-11 Thread Lance Andersen
On Wed, 11 May 2022 14:25:39 GMT, Jaikiran Pai wrote: >> I agree with Magnus and try to avoid changing the imported zlib code. > >> I did these changes locally but for some reason this format-nonliteral is >> not getting picked up while building that library. > > Turns out that was slightly

Re: RFR: 8286582: Build fails on macos aarch64 when using --with-zlib=bundled [v2]

2022-05-11 Thread Lance Andersen
On Wed, 11 May 2022 14:24:38 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which fixes build failures on macos >> when using `--with-zlib=bundled`? >> >> With this change the build now passes (tested both with bundled and system >> zlib variants). >> >> tier1, tier2

Re: RFR: 8286582: Build fails on macos aarch64 when using --with-zlib=bundled [v2]

2022-05-11 Thread Lance Andersen
On Wed, 11 May 2022 22:03:38 GMT, Magnus Ihse Bursie wrote: > It would not make sense to set the disabled warning in the configure script, > no. The current code looks perfectly fine. Disabled warnings per module are > set in the makefiles. OK, that you for your feedback regarding the

Re: RFR: 8286582: Build fails on macos aarch64 when using --with-zlib=bundled [v2]

2022-05-11 Thread Lance Andersen
On Wed, 11 May 2022 14:24:38 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which fixes build failures on macos >> when using `--with-zlib=bundled`? >> >> With this change the build now passes (tested both with bundled and system >> zlib variants). >> >> tier1, tier2

Re: RFR: 8286582: Build fails on macos aarch64 when using --with-zlib=bundled [v2]

2022-05-11 Thread Lance Andersen
On Wed, 11 May 2022 15:03:56 GMT, Lance Andersen wrote: >> Jaikiran Pai has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - copyright years >> - disable format-nonliteral warning when building LIBSPLA

Re: Build changes for 7176225: Remove JDBC-ODBC Bridge

2012-11-08 Thread Lance Andersen - Oracle
for this then it provides an opportunity to start up a new project to develop a modern JDBC-ODBC bridge. -Alan Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com

Re: Build changes for 7176225: Remove JDBC-ODBC Bridge

2012-11-08 Thread Lance Andersen - Oracle
. Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com

review request: 8011620 adding free form netbeans project for jdbc to jdk/make/netbeans

2013-04-09 Thread Lance Andersen - Oracle
://cr.openjdk.java.net/~lancea/8011620/webrev.00/ Best lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com

Re: review request: 8011620 adding free form netbeans project for jdbc to jdk/make/netbeans

2013-04-09 Thread Lance Andersen - Oracle
Thank you ulf, I made the change in my workspace so that it will be accommodated as part of the putback Best Lance On Apr 9, 2013, at 11:26 AM, Ulf Zibis wrote: Hi, there is a little indentation error in build.xml in line 42. -Ulf Am 09.04.2013 16:55, schrieb Lance Andersen - Oracle

Re: review request: 8011620 adding free form netbeans project for jdbc to jdk/make/netbeans

2013-04-19 Thread Lance Andersen - Oracle
still looking for a committer to bless this webrev so I can put it back thank you in advance best Lance On Apr 9, 2013, at 11:58 AM, Lance Andersen - Oracle wrote: Thank you ulf, I made the change in my workspace so that it will be accommodated as part of the putback Best Lance On Apr

Re: RFR: 8011814/8013271/8013272: Three improvements to J2SE Netbeans project

2013-04-30 Thread Lance Andersen - Oracle
editors and IDEs should use what the compiler uses. Thanks for reviewing, Mike Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com

Re: 8014500: bootcycle-images fails after upgrade to JAXP 1.5

2013-05-14 Thread Lance Andersen - Oracle
(); File fileMetaZones = new File(METAZONES_SOURCE_FILE); parserNumbering.parse(fileMetaZones, handlerMetaZones); Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com