or
>
> cc-ing @dcubed-ojdk
Igor Ignatyev has updated the pull request incrementally with one additional
commit since the last revision:
build only hotspot for optimized
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1244/files
- new: https://git.openjdk.java
On Tue, 17 Nov 2020 19:52:49 GMT, Erik Joelsson wrote:
>> Igor Ignatyev has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> build only hotspot for optimized
>
> Marked as reviewed by erikj (Reviewer).
On Tue, 17 Nov 2020 00:31:24 GMT, Igor Ignatyev wrote:
> Hi all,
>
>
> [8256414](https://bugs.openjdk.java.net/browse/JDK-8256414) / #1233 added
> similar profile to submit workflow, this patch defines `linux-x64-optimized`
> profile in jib-profile so it can be used by
On Tue, 2 Feb 2021 18:17:55 GMT, Jesper Wilhelmsson
wrote:
> We have our (first) RC candidate build for JDK 16 on Feb 04, 2021. We need to
> remove the EA from version string for this build (b35) and going forward.
>
> Pushing this for @pashh
Marked as reviewed by iignatyev (Reviewer).
-
On Thu, 8 Apr 2021 17:24:38 GMT, Vladimir Kozlov wrote:
>> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related
>> to Ahead-of-Time Compiler from JDK:
>>
>> - `jdk.aot` module — the `jaotc` tool
>> - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution
On Fri, 9 Apr 2021 22:30:32 GMT, Vladimir Kozlov wrote:
>> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related
>> to Java-based JIT compiler (Graal) from JDK:
>>
>> - `jdk.internal.vm.compiler` — the Graal compiler
>> - `jdk.internal.vm.compiler.management` — Graal's `MB
On Fri, 9 Apr 2021 22:26:40 GMT, Vladimir Kozlov wrote:
>> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related
>> to Java-based JIT compiler (Graal) from JDK:
>>
>> - `jdk.internal.vm.compiler` — the Graal compiler
>> - `jdk.internal.vm.compiler.management` — Graal's `MB
On Fri, 9 Apr 2021 22:26:40 GMT, Vladimir Kozlov wrote:
>> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related
>> to Java-based JIT compiler (Graal) from JDK:
>>
>> - `jdk.internal.vm.compiler` — the Graal compiler
>> - `jdk.internal.vm.compiler.management` — Graal's `MB
On Sat, 10 Apr 2021 16:36:54 GMT, Vladimir Kozlov wrote:
>> should we remove `sun.hotspot.code.Compiler::isGraalEnabled` method and
>> update a few of its users accordingly?
>> what about `vm.graal.enabled` `@requires` property?
>
> @iignatev If you think that I should clean tests anyway I will
On Thu, 22 Apr 2021 18:15:58 GMT, Mikael Vidstedt wrote:
> The bootjdk used for macosx-aarch64 at Oracle is a custom build of JDK 16
> from early December, so does not include all the JDK 16 GA functionality.
> This leads to build issues after JDK-8263621 which uses a method not included
> in
On Tue, 13 Apr 2021 09:30:23 GMT, Doug Simon wrote:
> I guess this should really be named `isJVMCICompilerEnabled` now and the
> `vm.graal.enabled` predicate renamed to `vm.jvmcicompiler.enabled` but maybe
> that's too big a change (or can be done later).
@dougxc, I don't think that we should
Hi all,
could you please review this small patch that enables
`runtime/jsig/Testjsig.java` test and compilation of its native library on all
platforms but windows?
from JBS:
> `runtime/jsig/Testjsig.java` test currently `@requires (os.family ==
> "linux")` and `test/hotspot/jtreg/runtime/jsig/l
On Sun, 20 Jun 2021 11:08:21 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this small patch that enables
> `runtime/jsig/Testjsig.java` test and compilation of its native library on
> all platforms but windows?
> from JBS:
>> `runtime/jsig/Testj
On Sun, 20 Jun 2021 11:08:21 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this small patch that enables
> `runtime/jsig/Testjsig.java` test and compilation of its native library on
> all platforms but windows?
> from JBS:
>> `runtime/jsig/Testj
Hi all,
could you please review this small patch that enables
`runtime/jsig/Testjsig.java` test and compilation of its native library on all
platforms but windows?
from JBS:
> `runtime/jsig/Testjsig.java` test currently `@requires (os.family ==
> "linux")` and `test/hotspot/jtreg/runtime/jsig/l
On Tue, 3 Aug 2021 20:18:11 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this small patch that enables
> `runtime/jsig/Testjsig.java` test and compilation of its native library on
> all platforms but windows?
> from JBS:
>> `runtime/jsig/Testj
On Tue, 3 Aug 2021 20:18:11 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this small patch that enables
> `runtime/jsig/Testjsig.java` test and compilation of its native library on
> all platforms but windows?
> from JBS:
>> `runtime/jsig/Testj
On Tue, 19 Oct 2021 13:51:45 GMT, Weijun Wang wrote:
> As a follow up of JEP 411, we will soon disallow security manager by default.
> jtreg 6.1 does not set its own security manager if JDK version is >= 18.
LGTM
-
Marked as reviewed by iignatyev (Reviewer).
PR: https://git.openj
e it
> and rerun the tests. Please let me know.
>
>
> Thank you,
> Misha
>
>
> On 2/13/18, 8:41 PM, Igor Ignatyev wrote:
>> Hi Misha,
>>
>> have you check that it works on windows w/ GENERATE_CDS_ARCHIVE=true? it
>> seems that you should cal
in Graal mode with EXTRA_PROBLEM_LISTS=ProblemList-graal.txt
>
> thanks,
> -katya
>
> p.s.
> Igor Ignatyev volunteered to sponsor this change.
destined for use by jtreg, I would
> encourage adding a platform specifier on each line, after the bug number. If
> you want to mark the test as excluded on all platforms, the convention is to
> use "generic-all".
>
> -- Jon
>
>
> On 2/26/18 11:47 AM,
If these new problem-list files are destined for use by jtreg, I would
>> encourage adding a platform specifier on each line, after the bug number. If
>> you want to mark the test as excluded on all platforms, the convention is to
>> use "generic-all".
>>
Hi Erik,
to avoid incompatibility, you could have just made ArtifactResolverException a
subclass of java.io.FileNotFoundException.
it seems you forgot to add ArtifactResolverException.java file to the repo.
a minor nit: in JibArtifactManager::newInstance, you pass "Could not resolve "
+ JIB_SE
Looks good to me.
-- Igor
> On Mar 8, 2018, at 4:06 PM, Erik Joelsson wrote:
>
> On 2018-03-08 15:24, Igor Ignatyev wrote:
>> Hi Erik,
> Thanks for looking at this!
>> to avoid incompatibility, you could have just made ArtifactResolverException
>> a subclass of
http://cr.openjdk.java.net/~iignatyev//8200180/webrev.00/index.html
> 3 lines changed: 0 ins; 0 del; 3 mod;
Hi all,
could you please review this small fix for run-test framework documentation?
VM_OTIONS was used instead of VM_OPTIONS at several places, the fix is obvious
s/VM_OTIONS/VM_OPTION
build-docs" so that the
>> html file also gets regenerated before pushing.
>
> Looks good to me too.
>
> /Magnus
>
>>
>> /Erik
>>
>>
>>> On 2018-03-23 08:13, Igor Ignatyev wrote:
>>> http://cr.openjdk.java.net/~iignatyev//8200180/web
http://cr.openjdk.java.net/~iignatyev/8200538/webrev.00/
> 1 line changed: 0 ins; 0 del; 1 mod;
Hi all,
could you please review this one-liner change which removes C2220 from disabled
warning on windows? C2220 is "warning treated as error" compiler error, which
isn't a real compiler warning/er
Jerry, Misha,
thank you for your review.
adding build-dev alias as the patch includes makefiles changes.
-- Igor
> On Apr 30, 2018, at 8:39 AM, mikhailo wrote:
>
> Changes look good to me,
>
> Thank you,
>
> Misha
>
>
> On 04/28/2018 07:34 AM, Gerald Thornbrugh wrote:
>> Hi Igor,
>>
>>
http://cr.openjdk.java.net/~iignatyev//8199375/webrev.00/index.html
> 41276 lines changed: 41274 ins; 1 del; 1 mod;
Hi all,
could you please review the patch which open sources monitoring tests from vm
testbase?
The tests were developed to test hotspot related JMX functionality. as w/
common
or,
>>>
>>> Why you need to list each test in TEST.groups and not just directory as we
>>> do in other cases?
>>>
>>> Thanks,
>>> Vladimir
>>>
>>>> On 5/1/18 7:10 PM, Igor Ignatyev wrote:
>>>> http://cr.openjdk.java.
http://cr.openjdk.java.net/~iignatyev/8199382/webrev.00/index.html
> 577169 lines changed: 577169 ins; 0 del; 0 mod;
Hi all,
could you please review the patch which open sources JDI tests from vm
testbase? These tests cover different aspects of JDI implementation.
As usually w/ VM testbase cod
http://cr.openjdk.java.net/~iignatyev/8199370/webrev.00/index.html
> 45710 lines changed: 45710 ins; 0 del; 0 mod;
Hi all,
could you please review the patch which open sources GC tests from vm testbase?
it introduces the following test groups:
- vmTestbase_vm_g1classunloading
- vmTestbase_vm_gc_
Erik, Magnus, thank you for reviewing build change.
can someone from GC people Review the rest?
-- Igor
> On May 8, 2018, at 2:06 AM, Magnus Ihse Bursie
> wrote:
>
> On 2018-05-08 00:35, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev/8199370/webrev.00/in
http://cr.openjdk.java.net/~iignatyev//8199384/webrev.00/index.html
> 61414 lines changed: 61414 ins; 0 del; 0 mod;
Hi all,
could you please review this patch which open sources MLVM tests from VM
testbase?
these tests were developed in early days of JSR292 to test different aspects of
Method
Hi Erik,
please see my answers inline.
can I consider this RFR as reviewed by you?
Thanks,
-- Igor
> On May 14, 2018, at 4:23 AM, Erik Helin wrote:
>
> On 05/08/2018 12:35 AM, Igor Ignatyev wrote:
>> Hi all,
>
> Hi Igor,
>
> On 05/08/2018 12:35 AM, Igor Ignatyev
the files are compiled with warnings as errors. We think this
> should get fixed.
>
> Best regards,
> Martin
>
>
> -Original Message-
> From: hotspot-gc-dev [mailto:hotspot-gc-dev-boun...@openjdk.java.net] On
> Behalf Of Igor Ignatyev
> Sent: Dienstag, 15. Mai
http://cr.openjdk.java.net/~iignatyev//8199383/webrev.00/index.html
> 308253 lines changed: 308253 ins; 0 del; 0 mod;
Hi all,
could you please review this patch which open sources JVMTI tests from VM
testbase?
As usually w/ VM testbase code, these tests are old, they have been run in
hotspot t
http://cr.openjdk.java.net/~iignatyev/8199380/webrev.00/
> 2370 lines changed: 2370 ins; 0 del; 0 mod;
Hi all,
could you please review this patch which open sources AOD tests from VM
testbase? these tests test hotspot's attach-on-demand.
As usually w/ VM testbase code, these tests are old, the
Hi Misha,
looks good to me.
-- Igor
> On May 23, 2018, at 4:13 PM, mikhailo wrote:
>
> Hi Calvin,
>
> Thank you for review. I will fix the issue with vmTestbase_nsk_stress
> (merge issue) and will remove the blank line at line 1273 prior to check in.
>
>
> Misha
>
>
> On 05/23/2018 03:
http://cr.openjdk.java.net/~iignatyev//8206088/webrev.00/index.html
> 1 line changed: 0 ins; 0 del; 1 mod;
Hi all,
could you please review this one liner fix?
webrev: http://cr.openjdk.java.net/~iignatyev//8206088/webrev.00/index.html
JBS: https://bugs.openjdk.java.net/browse/JDK-8206088
testi
Hi Erik,
actually, I have a redundant quotation mark at the begging, removed. thanks for
spotting this.
Thanks,
-- Igor
> On Jun 28, 2018, at 9:50 PM, Erik Helin wrote:
>
> On 06/29/2018 06:42 AM, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8206088/webre
Erik, Katya,
thank you for such fast reviews.
Cheers,
-- Igor
> On Jun 28, 2018, at 9:56 PM, Erik Helin wrote:
>
> On 06/29/2018 06:55 AM, Igor Ignatyev wrote:
>> Hi Erik,
>> actually, I have a redundant quotation mark at the begging, removed. thanks
>> for
rowse/JDK-8206135
>
> Vladimir
>
>> Thanks,
>> David
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8206113
>>> webrev: http://cr.openjdk.java.net/~epavlova//8206113/webrev.00/index.html
>>>
>>> thanks,
>>> -katya
>>>
>>> p.s.
>>> Igor Ignatyev volunteered to sponsor this change.
> On Jul 2, 2018, at 3:52 PM, Vladimir Kozlov
> wrote:
>
> On 7/2/18 3:28 PM, Igor Ignatyev wrote:
>> Vladimir,
>> there are two different configure-time problems:
>> - 1st is ability to get unbuildable configuration w/ AOT but w/o JVMCI
>> - 2nd is not
http://cr.openjdk.java.net/~iignatyev//8206429/webrev.00/index.html
> 243 lines changed: 0 ins; 124 del; 119 mod;
Hi all,
could you please review this redo of 8202561? 8202561 was backed out b/c our CI
infra didn't support multiple test group files. now such configurations are
supported, so 82
if you were able re-test it to verify that it actually
> works. Not like last time.
>
> Thanks,
> Vladimir
>
> On 7/5/18 1:02 PM, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8206429/webrev.00/index.html
>>> 243 lines changed: 0 ins; 124 del; 1
looks good to me.
-- Igor
> On Jul 24, 2018, at 3:48 PM, Alexandre (Shura) Iline
> wrote:
>
> Hi,
>
> Could you please tale a quick look on this simple fix?
>
> diff --git a/test/jtreg-ext/requires/VMProps.java
> b/test/jtreg-ext/requires/VMProps.java
> --- a/test/jtreg-ext/requires/VMProps
http://cr.openjdk.java.net/~iignatyev/8208647/webrev.00/index.html
> 5 lines changed: 0 ins; 0 del; 5 mod;
Hi all,
could you please review this small fix which switches jtreg to the latest
available build? due to changes in javatest API, failure_handler had to be
slightly updated.
webrev: http
> On Aug 1, 2018, at 10:33 PM, David Holmes wrote:
>
> Hi Igor,
>
> On 2/08/2018 5:42 AM, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev/8208647/webrev.00/index.html
>>> 5 lines changed: 0 ins; 0 del; 5 mod;
>> Hi all,
>> could you p
http://cr.openjdk.java.net/~iignatyev//8209611/webrev.01/index.html
> 11160 lines changed: 879 ins; 61 del; 10220 mod;
Hi all,
could you please review the patch which moves all hotspot native test code to
C++? this will guarantee that we always use C++ compilers for them (as an
opposite to eith
make/test/JtregNativeHotspot.gmk.
Cheers,
-- Igor
>
> Thanks,
> David
>
>> Thanks,
>> — Igor
>> On Aug 20, 2018, at 6:43 PM, David Holmes > <mailto:david.hol...@oracle.com>> wrote:
>>> Hi Igor,
>>>
>>> On 21/08/2018 8:59 AM, Ig
http://cr.openjdk.java.net/~iignatyev//8209611/webrev.02/index.html
<http://cr.openjdk.java.net/~iignatyev//8209611/webrev.02/index.html> is a new
version of patch, which moves only vmTestbase tests.
Thanks,
-- Igor
> On Aug 20, 2018, at 11:07 PM, Igor Ignatyev wrote:
>
>
Hi David,
thanks for looking at the webrev and all your comments. my answers are inlined.
enjoy your vacation!
-- Igor
> On Aug 21, 2018, at 9:28 PM, David Holmes wrote:
>
> Hi Igor,
>
> On 22/08/2018 9:04 AM, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignaty
e to
> C++ happens, so I'd be happy to see us tackle it in a second/third step.
>
> So looks good to me and thanks for doing it!
> Jc
>
> On Tue, Aug 21, 2018 at 9:58 PM Igor Ignatyev <mailto:igor.ignat...@oracle.com>> wrote:
> Hi David,
>
> thanks for
It
>> now looks like we have a new pattern of source files/directories that turns
>> into native libraries, and we could of course create a new macro that
>> automatically generates compilation setups for them as well (given that file
>> or directory names makes it possibl
ts, and this just leads to big
> reshufflings whenever a command line changes, with little gain in
> readability. Instead, just indent the line following the \ with four more
> spaces (and no tabs!). (See
> http://openjdk.java.net/groups/build/doc/code-conventions.html)
sure thing,
Hi Erik,
thanks for your review!
-- Igor
> On Aug 28, 2018, at 9:01 AM, Erik Joelsson wrote:
>
> Hello,
>
> I have nothing to add in addition to Magnus' comments. If that is fixed, this
> looks good from a build point of view.
>
> /Erik
>
>
> On
Hi,
my claim was based on the warnings which we were getting when we just
introduced code coverage builds in JDK 9, e.g. 8130790[1] (clobbered warning in
libt2k). these warnings haven't been seen w/o code coverage enabled, and
enabling coverage changes code path, so I don't think we should care
Hi Magnus,
herein I will be talking only about 1st two warnings.
although your analyze is correct, it doesn't take into account the fact that
the warnings report situations that can't happen in current codebase, and gcc
doesn't report them in our "regular" builds b/c it can proof that
- in mac
http://cr.openjdk.java.net/~iignatyev//8213058/webrev.00/index.html
> 174 lines changed: 0 ins; 170 del; 4 mod;
Hi all,
could you please review this small clean up which removes
ExecuteInternalVMTests and VerboseInternalVMTests flags and related make
targets and tests?
8177708[1-3] is to conv
ro and
> all uses should just be deleted ... unless you plan on adding some other form
> of logging for this?
>
> Thanks,
> David
>
> On 2/11/2018 7:15 AM, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8213058/webrev.00/index.html
>>> 174 lines cha
needed due to
rebasing.
Erik, could you please re-review build changes?
http://cr.openjdk.java.net/~iignatyev//8213058/webrev.01/
<http://cr.openjdk.java.net/~iignatyev//8213058/webrev.01/> is the whole webrev.
Thanks,
-- Igor
> On Nov 1, 2018, at 4:23 PM, Igor Ignatyev
_TESTS += failure-handler make
>
>
>
> On Nov 2, 2018, at 1:27 AM, Magnus Ihse Bursie
> wrote:
>
>
> On 2018-11-02 00:37, Igor Ignatyev wrote:
>> on a second though, removing these macros isn't that big, here is an
>> incrementa
Hi Vladimir,
overall your fix looks reasonable, but w/ it we can get unintentionally
disabled features (b/c grep doesn't do full word match). although this problem
wasn't really introduced by your fix, I think it's be better to fix it as a
part of your patch. I see two possible solutions:
- a
Hi Erik,
I don't like that it's based on the assumption that ld and clang/gcc are in the
same directory, but this assumption seems to be always true for now. so unless
there is an easy way to get ld path, I'm fine w/ this fix.
-- Igor
> On Jan 23, 2019, at 1:18 PM, Vladimir Kozlov
> wrote:
>
so far it has affected only my local runs, so we are in no hurry to get this
fixed ;) you can work on a better fix, I, meanwhile, will apply your patch to
my local ws as a workaround.
-- Igor
> On Jan 23, 2019, at 3:10 PM, Erik Joelsson wrote:
>
> On 2019-01-23 13:38, Igor Ignat
~erikj/8217613/webrev.02/index.html
>
> Verified with local test using TEST_OPTS=AOT_MODULES=java.base on Macosx,
> Linux and Windows, as well as mach5 run of the same.
>
> /Erik
>
> On 2019-01-23 15:55, Igor Ignatyev wrote:
>> so far it has affected only my local runs, so
http://cr.openjdk.java.net/~iignatyev//8219391/webrev.00
> 21 lines changed: 3 ins; 0 del; 18 mod;
Hi all,
could you please review this small and trivial patch which allows usage of
--enable-native-coverage configure option w/ clang devkit?
> llvm/clang supports gcov in the same way gcc does, i
thanks Erik, pushed.
y, this means exactly that.
-- Igor
> On Feb 19, 2019, at 12:35 PM, Erik Joelsson wrote:
>
> Looks good.
>
> Does this mean it works on Macos?
>
> /Erik
>
> On 2019-02-19 11:46, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~ii
http://cr.openjdk.java.net/~iignatyev//8219132/webrev.00/index.html
> 1 line changed: 0 ins; 0 del; 1 mod;
Hi all,
could you please review this one-liner which switch jtreg version to
jtreg4.2-b14?
webrev: http://cr.openjdk.java.net/~iignatyev//8219132/webrev.00/index.html
JBS: https://bugs.op
Joelsson wrote:
>
> Looks good.
>
> Do we need to also bump the required version in the TEST.ROOT files?
>
> /Erik
>
> On 2019-02-19 16:34, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8219132/webrev.00/index.html
>>> 1 line changed: 0 ins
http://cr.openjdk.java.net/~iignatyev//8219395/webrev.00/index.html
> 65 lines changed: 59 ins; 0 del; 6 mod;
Hi all,
could you please review the patch which makes it easy to run tests on the
builds w/ native-code-coverage enabled? to do so the patch
- sets GCOV_PREFIX env. variable, so .gcda f
ctionArgs=true in 8219254.
Thanks,
-- Igor
> On Feb 19, 2019, at 5:49 PM, Joseph D. Darcy wrote:
>
> Hello,
>
> On 2/19/2019 5:06 PM, Igor Ignatyev wrote:
>> Hi Erik,
>>
>> thanks for your review.
>>
>> we can't just bump the required version
vers all
hotspot tests.
[1] https://bugs.openjdk.java.net/browse/JDK-8219408
<https://bugs.openjdk.java.net/browse/JDK-8219408>
[2] https://bugs.openjdk.java.net/browse/JDK-8219140
<https://bugs.openjdk.java.net/browse/JDK-8219140>
Thanks,
-- Igor
> On Feb 19, 2019, at 5:06 P
eing
> done unnecessarily. I would recommend explicitly setting the
> default_make_targets (which would be product-bundles and test-bundles) for
> the new *-gcov profiles.
>
> On lines 795, 804 and 812 you seem to have left commented out code that
> should probably be remove
http://cr.openjdk.java.net/~iignatyev//8222414/webrev.01
> 21638 lines changed: 21628 ins; 0 del; 10 mod;
Hi all,
could you please review this patch which makes mocking framework from google
test available for hotspot tests?
JBS: https://bugs.openjdk.java.net/browse/JDK-8222414
testing: tier1
w
njdk.java.net/groups/build/doc/code-conventions.html
>
> /Erik
>
> On 2019-05-22 22:20, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8222414/webrev.01
>>> 21638 lines changed: 21628 ins; 0 del; 10 mod;
>> Hi all,
>>
>>
@Erik, Thanks!
@hotspot (looking at Robin), can I get another review?
-- Igor
> On May 24, 2019, at 8:28 AM, Erik Joelsson wrote:
>
> Thanks, looks good!
>
> /Erik
>
> On 2019-05-23 19:07, Igor Ignatyev wrote:
>> Hi Erik,
>>
>> thanks for your revie
gt; Robin
>
>> On 24 May 2019, at 23:33, Igor Ignatyev wrote:
>>
>> @Erik, Thanks!
>>
>> @hotspot (looking at Robin), can I get another review?
>>
>> -- Igor
>>
>>> On May 24, 2019, at 8:28 AM, Erik Joelsson wrote:
>>>
>
http://cr.openjdk.java.net/~iignatyev//8226910/webrev.00/index.html
> 25 lines changed: 18 ins; 3 del; 4 mod;
Hi all,
could you please review this small patch which adds JTREG_RUN_PROBLEM_LISTS
options to run-test framework? when JTREG_RUN_PROBLEM_LISTS is set to true,
jtreg will use problem li
ping?
-- Igor
> On Jun 27, 2019, at 3:25 PM, Igor Ignatyev wrote:
>
> http://cr.openjdk.java.net/~iignatyev//8226910/webrev.00/index.html
>> 25 lines changed: 18 ins; 3 del; 4 mod;
>
> Hi all,
>
> could you please review this small patch which adds JTREG_RUN_PROB
Hi David,
> On Jul 6, 2019, at 1:58 AM, David Holmes wrote:
>
> Hi Igor,
>
> On 6/07/2019 1:09 pm, Igor Ignatyev wrote:
>> ping?
>> -- Igor
>>> On Jun 27, 2019, at 3:25 PM, Igor Ignatyev wrote:
>>>
>>> http://cr.openjdk.java.net/~iignaty
can I get a review for this patch?
http://cr.openjdk.java.net/~iignatyev//8226910/webrev.01/index.html
<http://cr.openjdk.java.net/~iignatyev//8226910/webrev.01/index.html>
Thanks,
-- Igor
> On Jul 6, 2019, at 11:50 AM, Igor Ignatyev wrote:
>
> Hi David,
>
>> On
David, Misha,
thanks for your review, pushed.
-- Igor
> On Jul 18, 2019, at 10:14 AM, mikhailo.seledt...@oracle.com wrote:
>
> +1
>
> On 7/17/19 9:43 PM, David Holmes wrote:
>> Hi Igor,
>>
>> This seems fine to me.
>>
>> Thanks,
>> Davi
http://cr.openjdk.java.net/~iignatyev//8238943/webrev.00
> 10 lines changed: 1 ins; 0 del; 9 mod;
Hi all,
could you please review the patch which changes jtreg version used in jdk/jdk
to the latest and greatest -- jtreg 5.0? and as (recently became) usually, this
patch also bumps requiredVersio
Hi Erik,
looks good to me.
-- Igor
> On Apr 9, 2020, at 8:15 AM, Erik Joelsson wrote:
>
> The test
> open/test/hotspot/jtreg/testlibrary_tests/process/TestNativeProcessBuilder.java
> fails when building the JDK with VS2019. More specifically, it fails if the
> JDK under test is built with a
Hi Roger,
removal of applications/ctw/modules/jdk_rmic.java and changes in doc (assuming
.html was generated from .md) look good to me.
adding hotspot-runtime alias to bring attention of runtime team. I'm not sure
who are the right people to review bin/unshuffle_list.txt though,.. build team
(
http://cr.openjdk.java.net/~iignatyev//8240904/webrev.00
> 35 lines changed: 26 ins; 0 del; 10 mod
Hi all,
8233827[1] which added screenshots to so-called failure handler had an
unexpected side-effect on linux, where users might observer flashes each time a
screenshot is taken, which, to put i
20, at 6:17 AM, Erik Joelsson wrote:
>
> Looks ok to me. Would it be possible to break up the long lines a bit to
> improve readability? Backslash escape for newlines should work in properties
> files.
>
> /Erik
>
> On 2020-04-15 22:22, Igor Ignatyev wrote:
>> ht
Thanks for your review, Sergey.
-- Igor
> On Apr 16, 2020, at 1:43 AM, Sergey Bylokhov
> wrote:
>
> Looks fine.
>
> On 4/15/20 10:22 pm, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8240904/webrev.00
>>> 35 lines changed: 26 ins; 0 del; 10 m
> On Apr 23, 2020, at 6:12 AM, Erik Joelsson wrote:
>
> Hello Matthias,
>
> On 2020-04-23 05:51, Matthias Klose wrote:
>> jdk-15+20 fails to build with
>>
>> * For target
>> support_test_failure_handler_classes__the.BUILD_FAILURE_HANDLER_batch:
>> /packages/openjdk/15/openjdk-15-15~20/test/
e:
>
> On 4/23/20 4:05 PM, Magnus Ihse Bursie wrote:
>>
>>> 23 apr. 2020 kl. 15:50 skrev Igor Ignatyev :
>>>
>>>
>>>
>>>> On Apr 23, 2020, at 6:12 AM, Erik Joelsson
>>>> wrote:
>>>>
&
http://cr.openjdk.java.net/~iignatyev/8245610/webrev.00/
> 132 lines changed: 80 ins; 36 del; 16 mod
http://cr.openjdk.java.net/~iignatyev/8245610/webrev.00%2bremoval/
> 57482 lines changed: 80 ins; 57385 del; 17 mod;
Hi all,
could you please review this small (if you ignore removal part) patch w
.com/google/googletest
<https://github.com/google/googletest>
git checkout release-1.8.1
-- Igor
> On May 22, 2020, at 11:12 AM, Igor Ignatyev wrote:
>
> http://cr.openjdk.java.net/~iignatyev/8245610/webrev.00/
>> 132 lines changed: 80 ins; 36 del; 16 mod
> http://cr.openjdk.ja
ould give Magnus a chance to
> look at this too.
>
> /Erik
>
> On 2020-05-22 11:12, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev/8245610/webrev.00/
>>> 132 lines changed: 80 ins; 36 del; 16 mod
>> http://cr.openjdk.java.net/~iignatyev/8245610/we
I'll let both hotspot-dev and jdk-dev aliases
know which changes might be required to enable/disable hotspot gtest tests
compilation.
Thanks.
-- Igor
>
> /Magnus
>
> On 2020-05-22 20:12, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev/8245610/webrev.00/
>>
Hi all,
could you please review this trivial one-liner?
JBS: https://bugs.openjdk.java.net/browse/JDK-8245870
webrev: http://cr.openjdk.java.net/~iignatyev//8245870/webrev.00
testing: build on linux-x64,windows-x64 (in progress)
Thanks,
-- Igor
thanks Erik, pushed.
-- Igor
> On May 26, 2020, at 2:52 PM, Erik Joelsson wrote:
>
> Looks good.
>
> /Erik
>
> On 2020-05-26 14:48, Igor Ignatyev wrote:
>> Hi all,
>>
>> could you please review this trivial one-liner?
>>
>> JBS: https:/
instream platform I do not have to specify any paths to
> libraries to build OpenJDK. This is now different, I always have to manually
> download gtests and specify gtest location. This is regrettable.
>
> Thanks, Thomas
>
>
> On Tue, May 26, 2020 at 2:27 PM Magnus Ihse Bursie
http://cr.openjdk.java.net/~iignatyev/8246387/webrev.00/
> 110 lines changed: 6 ins; 89 del; 15 mod;
Hi all,
could you please review the patch which switches jtreg used in jdk/jdk to the
newly promoted jtreg5.1? as before, the patch changes 'requiredVersion'
property in all jtreg test suites to
1 - 100 of 136 matches
Mail list logo
