On Wed, 16 Nov 2022 16:17:48 GMT, Stefan Karlsson wrote:
>> The sorted blocks of includes have deteriorated to the point that I felt
>> compelled to clean up some of the issues.
>>
>> *EDIT*: The below discussion has been deferred out of this PR. Now this only
>> deals with fixing the
On Wed, 23 Nov 2022 07:12:13 GMT, Kim Barrett wrote:
> > I'm not sure why conditional includes (that don't rely on macros.hpp) need
> > to come at the end rather than in normal sort order? I don't care either
> > way but a rationale for this would be good if it is to be the preferred
> >
On Wed, 16 Nov 2022 16:17:48 GMT, Stefan Karlsson wrote:
>> The sorted blocks of includes have deteriorated to the point that I felt
>> compelled to clean up some of the issues.
>>
>> *EDIT*: The below discussion has been deferred out of this PR. Now this only
>> deals with fixing the
On Mon, 21 Nov 2022 15:36:41 GMT, Aleksey Shipilev wrote:
> JMH 1.36 was released, so we can bump the devkit too.
>
> Additional testing:
> - [x] Ad-hoc benchmarks with newly generated devkit
This pull request has now been integrated.
Changeset: f26bd4e0
Author:Aleksey Shipilev
URL:
On Wed, 23 Nov 2022 04:47:11 GMT, David Holmes wrote:
> I'm not sure why conditional includes (that don't rely on macros.hpp) need to
> come at the end rather than in normal sort order? I don't care either way but
> a rationale for this would be good if it is to be the preferred style.
On Fri, 11 Nov 2022 22:22:51 GMT, Christoph Langer wrote:
> With this PR I'd like to make it easier to use dedicated installations of
> Xcode on Mac OS for OpenJDK builds without having to switch the active Xcode
> globally via `xcode-select`.
>
> I propose adding a new configure flag
On Tue, 22 Nov 2022 14:10:44 GMT, Magnus Ihse Bursie wrote:
>> @magicus Thanks for fixing my enumeration. I recognized that you have
>> regenerated all the html files with a newer pandoc and I had to resolve with
>> master. I guess you'll need to regenerate with my current branch once more -
On Mon, 14 Nov 2022 12:20:54 GMT, Julian Waters wrote:
>> Sorry my eyes must be playing tricks on me. ??
>>
>> Why did you need to add this here?
>
> It's to avoid redefining the linkage as static in os_windows.cpp (where it's
> implemented) after an extern declaration (inside the class),
On Mon, 21 Nov 2022 02:43:12 GMT, Julian Waters wrote:
> Out of curiosity, is there a way to get the discussion on approving the use
> of alignas back up? [...]
A PR to address JDK-8252584 would be welcomed by me. Just do the process for
Style Guide changes (see the Style Guide or previous PRs
On Tue, 22 Nov 2022 19:21:51 GMT, Matias Saavedra Silva
wrote:
>> The -XX:+AutoCreateSharedArchive flag was implemented in JDK 19, however,
>> this flag doesn't work across JDK 19 and 20.
>>
>> Expected: JDK 20 should recreate the specified CDS archive
>> Actual: JDK 20 cannot recognize the
On Tue, 22 Nov 2022 23:32:51 GMT, Magnus Ihse Bursie wrote:
>> make/langtools/tools/javacserver/client/Client.java line 148:
>>
>>> 146: cmd.addAll(Arrays.asList(conf.javaCommand().split(" ")));
>>> 147: // javacserver.server.Server is the server main class
>>> 148:
On Tue, 22 Nov 2022 20:50:04 GMT, Magnus Ihse Bursie wrote:
> In JDK-8297041, the javacserver was moved out of the JDK itself, and lifted
> out as a separate buildtool. Due to this, internal classes in jdk.compiler
> were no longer available. Therefore, the closest way to calling javac as
>
On Tue, 22 Nov 2022 23:15:20 GMT, Erik Joelsson wrote:
> Things like incremental builds, some forced failure conditions etc?
I tested simple incremental builds but I should probably make a bit more
advanced versions where I modify different files to trigger more real-life like
scenarios,
> Now that the javacserver no longer has any ambitions outside being a
> buildtool customized for the JDK build process, a lot of abstractions and
> generalizations can be removed.
>
> This will allow the actual behavior to be more clearly visible, and will help
> debugging the issues we are
On Tue, 22 Nov 2022 20:50:04 GMT, Magnus Ihse Bursie wrote:
> In JDK-8297041, the javacserver was moved out of the JDK itself, and lifted
> out as a separate buildtool. Due to this, internal classes in jdk.compiler
> were no longer available. Therefore, the closest way to calling javac as
>
On Tue, 22 Nov 2022 19:54:51 GMT, Magnus Ihse Bursie wrote:
> Now that the javacserver no longer has any ambitions outside being a
> buildtool customized for the JDK build process, a lot of abstractions and
> generalizations can be removed.
>
> This will allow the actual behavior to be more
On Tue, 22 Nov 2022 21:02:58 GMT, Christoph Langer wrote:
>> With this PR I'd like to make it easier to use dedicated installations of
>> Xcode on Mac OS for OpenJDK builds without having to switch the active Xcode
>> globally via `xcode-select`.
>>
>> I propose adding a new configure flag
> With this PR I'd like to make it easier to use dedicated installations of
> Xcode on Mac OS for OpenJDK builds without having to switch the active Xcode
> globally via `xcode-select`.
>
> I propose adding a new configure flag `--with-xcode-path` that takes the path
> to an Xcode
In JDK-8297041, the javacserver was moved out of the JDK itself, and lifted out
as a separate buildtool. Due to this, internal classes in jdk.compiler were no
longer available. Therefore, the closest way to calling javac as before were to
use `com.sun.tools.javac.Main.compile()`. This method is
On Tue, 22 Nov 2022 20:50:04 GMT, Magnus Ihse Bursie wrote:
> In JDK-8297041, the javacserver was moved out of the JDK itself, and lifted
> out as a separate buildtool. Due to this, internal classes in jdk.compiler
> were no longer available. Therefore, the closest way to calling javac as
>
On Tue, 22 Nov 2022 19:54:51 GMT, Magnus Ihse Bursie wrote:
> Now that the javacserver no longer has any ambitions outside being a
> buildtool customized for the JDK build process, a lot of abstractions and
> generalizations can be removed.
>
> This will allow the actual behavior to be more
On Tue, 22 Nov 2022 19:54:51 GMT, Magnus Ihse Bursie wrote:
> Now that the javacserver no longer has any ambitions outside being a
> buildtool customized for the JDK build process, a lot of abstractions and
> generalizations can be removed.
>
> This will allow the actual behavior to be more
Now that the javacserver no longer has any ambitions outside being a buildtool
customized for the JDK build process, a lot of abstractions and generalizations
can be removed.
This will allow the actual behavior to be more clearly visible, and will help
debugging the issues we are still seeing
> The -XX:+AutoCreateSharedArchive flag was implemented in JDK 19, however,
> this flag doesn't work across JDK 19 and 20.
>
> Expected: JDK 20 should recreate the specified CDS archive
> Actual: JDK 20 cannot recognize the archive file and gives up
>
> The new field from
> The -XX:+AutoCreateSharedArchive flag was implemented in JDK 19, however,
> this flag doesn't work across JDK 19 and 20.
>
> Expected: JDK 20 should recreate the specified CDS archive
> Actual: JDK 20 cannot recognize the archive file and gives up
>
> The new field from
On Fri, 18 Nov 2022 11:27:14 GMT, Magnus Ihse Bursie wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Uh oh
>
> Aaaahhh, **that** bug. I've run into that before. I did attempt to fix it but
> after wasting too
On Thu, 17 Nov 2022 21:46:45 GMT, Matias Saavedra Silva
wrote:
>> The -XX:+AutoCreateSharedArchive flag was implemented in JDK 19, however,
>> this flag doesn't work across JDK 19 and 20.
>>
>> Expected: JDK 20 should recreate the specified CDS archive
>> Actual: JDK 20 cannot recognize the
On Tue, 22 Nov 2022 10:59:05 GMT, Christoph Langer wrote:
>> Hm, the changes you made to the markdown file does not result in any changes
>> in the generated html file. :( I fixed it by adding an additional empty line
>> in the markdown file. The commit including both these fixes are here:
>>
On Fri, 18 Nov 2022 16:32:08 GMT, Magnus Ihse Bursie wrote:
>> Christoph Langer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix enumeration for html
>
> Hm, the changes you made to the markdown file does not result in any changes
>
> With this PR I'd like to make it easier to use dedicated installations of
> Xcode on Mac OS for OpenJDK builds without having to switch the active Xcode
> globally via `xcode-select`.
>
> I propose adding a new configure flag `--with-xcode-path` that takes the path
> to an Xcode
30 matches
Mail list logo
