Integrated: 8346294: Invalid lint category specified in compiler.properties

2024-12-16 Thread Archie Cobbs
On Mon, 16 Dec 2024 16:54:46 GMT, Archie Cobbs wrote: > Please review this fix for an incorrect `lint:` tag in `compiler.properties`, > plus an adjustment to the build process to automatically detect and fail the > build in case of any similar typos in the future. This pull request has now bee

Integrated: 8346046: Enable copyright header format check

2024-12-16 Thread Zhao Song
On Thu, 12 Dec 2024 19:58:29 GMT, Zhao Song wrote: > As requested in [SKARA-1357](https://bugs.openjdk.org/browse/SKARA-1357), now > skara bot is able to check the copyright header format. > Now I am going to update the jcheck configuration to configure copyright > check as an error. This pull

Integrated: 8346278: Clean up some flag handing in flags-cflags.m4

2024-12-16 Thread Magnus Ihse Bursie
On Mon, 16 Dec 2024 12:31:04 GMT, Magnus Ihse Bursie wrote: > WARNING_CFLAGS_JVM should not be used to set arbitrary warning flags for > Hotspot. > > We do not need to check for gcc 6+ anymore. This pull request has now been integrated. Changeset: 30302309 Author:Magnus Ihse Bursie URL:

Re: RFR: 8346294: Invalid lint category specified in compiler.properties [v2]

2024-12-16 Thread Archie Cobbs
On Mon, 16 Dec 2024 19:21:54 GMT, Archie Cobbs wrote: >> Please review this fix for an incorrect `lint:` tag in >> `compiler.properties`, plus an adjustment to the build process to >> automatically detect and fail the build in case of any similar typos in the >> future. > > Archie Cobbs has up

Re: RFR: 8346294: Invalid lint category specified in compiler.properties [v2]

2024-12-16 Thread Maurizio Cimadamore
On Mon, 16 Dec 2024 19:18:25 GMT, Archie Cobbs wrote: >> test/langtools/tools/javac/lint/LintWarningCategoryTest.java line 36: >> >>> 34: import com.sun.tools.javac.resources.CompilerProperties.LintWarnings; >>> 35: >>> 36: public class LintWarningCategoryTest { >> >> Do we need this specific

Re: RFR: 8346294: Invalid lint category specified in compiler.properties [v2]

2024-12-16 Thread Maurizio Cimadamore
On Mon, 16 Dec 2024 19:21:54 GMT, Archie Cobbs wrote: >> Please review this fix for an incorrect `lint:` tag in >> `compiler.properties`, plus an adjustment to the build process to >> automatically detect and fail the build in case of any similar typos in the >> future. > > Archie Cobbs has up

Re: RFR: 8346294: Invalid lint category specified in compiler.properties [v2]

2024-12-16 Thread Archie Cobbs
> Please review this fix for an incorrect `lint:` tag in `compiler.properties`, > plus an adjustment to the build process to automatically detect and fail the > build in case of any similar typos in the future. Archie Cobbs has updated the pull request incrementally with one additional commit s

Re: RFR: 8346294: Invalid lint category specified in compiler.properties [v2]

2024-12-16 Thread Archie Cobbs
On Mon, 16 Dec 2024 18:35:44 GMT, Maurizio Cimadamore wrote: >> Archie Cobbs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Cleanups & refactoring based on review suggestions. > > src/jdk.compiler/share/classes/com/sun/tools/javac/code

Re: RFR: 8346294: Invalid lint category specified in compiler.properties

2024-12-16 Thread Maurizio Cimadamore
On Mon, 16 Dec 2024 16:54:46 GMT, Archie Cobbs wrote: > Please review this fix for an incorrect `lint:` tag in `compiler.properties`, > plus an adjustment to the build process to automatically detect and fail the > build in case of any similar typos in the future. Thanks for catching this src

Re: RFR: 8346046: Enable copyright header format check [v2]

2024-12-16 Thread Zhao Song
On Fri, 13 Dec 2024 17:18:10 GMT, Zhao Song wrote: >> As requested in [SKARA-1357](https://bugs.openjdk.org/browse/SKARA-1357), >> now skara bot is able to check the copyright header format. >> Now I am going to update the jcheck configuration to configure copyright >> check as an error. > > Zh

Re: RFR: 8346046: Enable copyright header format check [v2]

2024-12-16 Thread duke
On Fri, 13 Dec 2024 17:18:10 GMT, Zhao Song wrote: >> As requested in [SKARA-1357](https://bugs.openjdk.org/browse/SKARA-1357), >> now skara bot is able to check the copyright header format. >> Now I am going to update the jcheck configuration to configure copyright >> check as an error. > > Zh

RFR: 8346294: Invalid lint category specified in compiler.properties

2024-12-16 Thread Archie Cobbs
Please review this fix for an incorrect `lint:` tag in `compiler.properties`, plus an adjustment to the build process to automatically detect and fail the build in case of any similar typos in the future. - Commit messages: - Fix invalid "lint" tag and update build to automatically

Re: RFR: 8346278: Clean up some flag handing in flags-cflags.m4

2024-12-16 Thread Erik Joelsson
On Mon, 16 Dec 2024 12:31:04 GMT, Magnus Ihse Bursie wrote: > WARNING_CFLAGS_JVM should not be used to set arbitrary warning flags for > Hotspot. > > We do not need to check for gcc 6+ anymore. Marked as reviewed by erikj (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/

Re: RFR: 8346278: Clean up some flag handing in flags-cflags.m4

2024-12-16 Thread Magnus Ihse Bursie
On Mon, 16 Dec 2024 12:31:04 GMT, Magnus Ihse Bursie wrote: > WARNING_CFLAGS_JVM should not be used to set arbitrary warning flags for > Hotspot. > > We do not need to check for gcc 6+ anymore. Verified that this builds properly on GHA and the Oracle CI system. - PR Comment: http

RFR: 8346278: Clean up some flag handing in flags-cflags.m4

2024-12-16 Thread Magnus Ihse Bursie
WARNING_CFLAGS_JVM should not be used to set arbitrary warning flags for Hotspot. We do not need to check for gcc 6+ anymore. - Commit messages: - 8346278: Clean up some flag handing in flags-cflags.m4 Changes: https://git.openjdk.org/jdk/pull/22762/files Webrev: https://webrevs

Re: RFR: 8341097: GHA: Demote Mac x86 jobs to build only [v3]

2024-12-16 Thread Aleksey Shipilev
On Tue, 10 Dec 2024 19:24:59 GMT, Aleksey Shipilev wrote: >> See the discussion in the bug. I think we can stop testing Mac x86 in GHA, >> leaving only the build jobs. >> >> Additional testing: >> - [x] GHA passes > > Aleksey Shipilev has updated the pull request with a new target base due to

Integrated: 8346150: Jib dependency on autoconf missing for 'docs' profile

2024-12-16 Thread Erik Joelsson
On Fri, 13 Dec 2024 00:12:00 GMT, Erik Joelsson wrote: > The 'docs' jib profile is missing the dependency on autoconf. > > This only applies to builds produced by Oracle. This pull request has now been integrated. Changeset: 8133eb2c Author:Erik Joelsson URL: https://git.openjdk.o