Re: RFR: 8365312: GCC 12 cannot compile SVE on aarch64 with auto-var-init pattern [v2]

2025-08-15 Thread Kim Barrett
On Fri, 15 Aug 2025 23:40:34 GMT, Kim Barrett wrote: >> That does make sense. Updated in the new commit. Thanks! @magicus @kimbarrett > > I think using `DEBUG_LEVEL != release` isn't right for either of these > places, since it means we're adding > the option for "optimize" builds. But doing so

Re: RFR: 8365312: GCC 12 cannot compile SVE on aarch64 with auto-var-init pattern [v2]

2025-08-15 Thread Kim Barrett
On Fri, 15 Aug 2025 14:18:57 GMT, Fei Gao wrote: >> `-ftrivial-auto-var-init=pattern` [1] supported by gcc-12 was added recently >> to help detect uses of uninitialized memory. [2] Under this extension mode, >> `__builtin_clear_padding` is called to clear the padding bits in object >> represen

Re: RFR: 8365312: GCC 12 cannot compile SVE on aarch64 with auto-var-init pattern [v2]

2025-08-15 Thread Kim Barrett
On Fri, 15 Aug 2025 14:14:41 GMT, Fei Gao wrote: >> I agree. Make sure to use the same test (DEBUG_LEVEL != release) to catch >> both fast and slow debug builds. > > That does make sense. Updated in the new commit. Thanks! @magicus @kimbarrett I think using `DEBUG_LEVEL != release` isn't right

Re: RFR: 8364973: Add JVMTI stress testing mode [v5]

2025-08-15 Thread Leonid Mesnik
On Thu, 14 Aug 2025 21:15:34 GMT, Magnus Ihse Bursie wrote: >> Makefile changes look good now. >> >> I think this new option should be documented in testing.md/html. > >> I think this new option should be documented in testing.md/html. > > Yes, I agree. I tried to ask for this above. @lmesnik W

Integrated: 8364973: Add JVMTI stress testing mode

2025-08-15 Thread Leonid Mesnik
On Thu, 17 Jul 2025 02:39:15 GMT, Leonid Mesnik wrote: > The fix added JVMTI stress testing mode. > > This mode enables stress agent that could be executed with jtreg test and > help to ensure that jvmti functionality doesn't break the other JVM/JDK > functionality. > > I filed few issues and

Re: RFR: 8365312: GCC 12 cannot compile SVE on aarch64 with auto-var-init pattern [v2]

2025-08-15 Thread Magnus Ihse Bursie
On Fri, 15 Aug 2025 14:18:57 GMT, Fei Gao wrote: >> `-ftrivial-auto-var-init=pattern` [1] supported by gcc-12 was added recently >> to help detect uses of uninitialized memory. [2] Under this extension mode, >> `__builtin_clear_padding` is called to clear the padding bits in object >> represen

Re: RFR: 8364973: Add JVMTI stress testing mode [v7]

2025-08-15 Thread Magnus Ihse Bursie
On Fri, 15 Aug 2025 15:05:02 GMT, Leonid Mesnik wrote: >> The fix added JVMTI stress testing mode. >> >> This mode enables stress agent that could be executed with jtreg test and >> help to ensure that jvmti functionality doesn't break the other JVM/JDK >> functionality. >> >> I filed few iss

Re: RFR: 8364973: Add JVMTI stress testing mode [v7]

2025-08-15 Thread Leonid Mesnik
On Fri, 15 Aug 2025 15:05:02 GMT, Leonid Mesnik wrote: >> The fix added JVMTI stress testing mode. >> >> This mode enables stress agent that could be executed with jtreg test and >> help to ensure that jvmti functionality doesn't break the other JVM/JDK >> functionality. >> >> I filed few iss

Re: RFR: 8365579: ml64.exe is not the right assembler for Windows aarch64 [v2]

2025-08-15 Thread duke
On Fri, 15 Aug 2025 15:46:58 GMT, Saint Wesonga wrote: >> [ml64](https://learn.microsoft.com/en-us/cpp/assembler/masm/ml-and-ml64-command-line-reference?view=msvc-170) >> is set as the assembler for the Windows platform but is specific to the x64 >> platform. The >> [armasm64](https://learn.mi

Re: RFR: 8365579: ml64.exe is not the right assembler for Windows aarch64 [v2]

2025-08-15 Thread Erik Joelsson
On Fri, 15 Aug 2025 15:46:58 GMT, Saint Wesonga wrote: >> [ml64](https://learn.microsoft.com/en-us/cpp/assembler/masm/ml-and-ml64-command-line-reference?view=msvc-170) >> is set as the assembler for the Windows platform but is specific to the x64 >> platform. The >> [armasm64](https://learn.mi

Re: RFR: 8364973: Add JVMTI stress testing mode [v7]

2025-08-15 Thread Erik Joelsson
On Fri, 15 Aug 2025 15:05:02 GMT, Leonid Mesnik wrote: >> The fix added JVMTI stress testing mode. >> >> This mode enables stress agent that could be executed with jtreg test and >> help to ensure that jvmti functionality doesn't break the other JVM/JDK >> functionality. >> >> I filed few iss

Re: RFR: 8365579: ml64.exe is not the right assembler for Windows aarch64 [v2]

2025-08-15 Thread Julian Waters
On Fri, 15 Aug 2025 15:43:45 GMT, Saint Wesonga wrote: >> make/common/native/CompileFile.gmk line 239: >> >>> 237:$$(call ExecuteWithLog, $$@, $$(call MakeCommandRelative, \ >>> 238:$$($1_COMPILER) $$($1_FLAGS) \ >>> 239:$(CC_OUT_OPTION)$$($1_OBJ) $$($

Re: RFR: 8365579: ml64.exe is not the right assembler for Windows aarch64 [v2]

2025-08-15 Thread Julian Waters
On Fri, 15 Aug 2025 15:46:58 GMT, Saint Wesonga wrote: >> [ml64](https://learn.microsoft.com/en-us/cpp/assembler/masm/ml-and-ml64-command-line-reference?view=msvc-170) >> is set as the assembler for the Windows platform but is specific to the x64 >> platform. The >> [armasm64](https://learn.mi

Re: RFR: 8365579: ml64.exe is not the right assembler for Windows aarch64 [v2]

2025-08-15 Thread Saint Wesonga
> [ml64](https://learn.microsoft.com/en-us/cpp/assembler/masm/ml-and-ml64-command-line-reference?view=msvc-170) > is set as the assembler for the Windows platform but is specific to the x64 > platform. The > [armasm64](https://learn.microsoft.com/en-us/cpp/assembler/arm/arm-assembler-command-lin

Re: RFR: 8365579: ml64.exe is not the right assembler for Windows aarch64 [v2]

2025-08-15 Thread Saint Wesonga
On Fri, 15 Aug 2025 14:26:00 GMT, Erik Joelsson wrote: > Have you verified that removing `-Ta` works for the x86 assembler? Yes, both of these command lines work: ; "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\bin\Hostx64\x86\ml.exe" -nologo -c -Fo test

Re: RFR: 8364973: Add JVMTI stress testing mode [v7]

2025-08-15 Thread Leonid Mesnik
> The fix added JVMTI stress testing mode. > > This mode enables stress agent that could be executed with jtreg test and > help to ensure that jvmti functionality doesn't break the other JVM/JDK > functionality. > > I filed few issues and more are coming. I want to push the agent so it is > po

Re: RFR: 8365579: ml64.exe is not the right assembler for Windows aarch64

2025-08-15 Thread Erik Joelsson
On Thu, 14 Aug 2025 23:59:23 GMT, Saint Wesonga wrote: > [ml64](https://learn.microsoft.com/en-us/cpp/assembler/masm/ml-and-ml64-command-line-reference?view=msvc-170) > is set as the assembler for the Windows platform but is specific to the x64 > platform. The > [armasm64](https://learn.micros

Re: RFR: 8365312: GCC 12 cannot compile SVE on aarch64 with auto-var-init pattern [v2]

2025-08-15 Thread Fei Gao
On Thu, 14 Aug 2025 09:43:12 GMT, Magnus Ihse Bursie wrote: >> make/autoconf/flags-cflags.m4 line 960: >> >>> 958: # avoids the use of unsupported `__builtin_clear_padding` >>> for variable >>> 959: # length aggregates >>> 960: if test "x$TOOLCHAIN_TYPE" = xg

Re: RFR: 8365312: GCC 12 cannot compile SVE on aarch64 with auto-var-init pattern

2025-08-15 Thread Fei Gao
On Wed, 13 Aug 2025 09:16:15 GMT, Fei Gao wrote: > `-ftrivial-auto-var-init=pattern` [1] supported by gcc-12 was added recently > to help detect uses of uninitialized memory. [2] Under this extension mode, > `__builtin_clear_padding` is called to clear the padding bits in object > representati

Re: RFR: 8365312: GCC 12 cannot compile SVE on aarch64 with auto-var-init pattern [v2]

2025-08-15 Thread Fei Gao
> `-ftrivial-auto-var-init=pattern` [1] supported by gcc-12 was added recently > to help detect uses of uninitialized memory. [2] Under this extension mode, > `__builtin_clear_padding` is called to clear the padding bits in object > representation. But the builtin function does not support varia

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v3]

2025-08-15 Thread SendaoYan
On Fri, 15 Aug 2025 11:43:33 GMT, Leo Korinth wrote: >> This changes the timeout factor from 4 to 1. Most of the changes add >> timeouts to individual test cases so that I am able to run them with a >> timeout factor of 0.7 (some margin to the checked in factor of one) >> >> In addition to cha

Re: RFR: 8365231: Don't build gtest with /EHsc

2025-08-15 Thread Thomas Stuefe
On Fri, 15 Aug 2025 06:45:35 GMT, Julian Waters wrote: >>> But `-fno-exceptions` _is_ used for gcc (and probably for clang, though >>> I've not checked). Verified by examination of ".o.cmdline" files for both >>> libgtest and the HotSpot gtests. >> >> Oh, and once again, thank you thank you th

Re: RFR: 8365231: Don't build gtest with /EHsc

2025-08-15 Thread Thomas Stuefe
On Mon, 11 Aug 2025 09:55:20 GMT, Magnus Ihse Bursie wrote: > According to > https://github.com/openjdk/jdk/pull/26661#issuecomment-3162014034, we should > not build gtest with `/EHsc`. > > I can honestly say I don't fully understand the consequences of this change, > but at least it passes

Re: RFR: 8365053: Refresh hotspot precompiled.hpp with headers based on current frequency [v11]

2025-08-15 Thread Francesco Andreuzzi
On Thu, 14 Aug 2025 09:27:24 GMT, Magnus Ihse Bursie wrote: > If I recall correctly the original approach was even simpler: I counted the > number of #includes in the C++ source files, not in the dependency files of a > particular build. Crude but effective, and left out discussions about > di

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v3]

2025-08-15 Thread Leo Korinth
On Fri, 15 Aug 2025 11:43:33 GMT, Leo Korinth wrote: >> This changes the timeout factor from 4 to 1. Most of the changes add >> timeouts to individual test cases so that I am able to run them with a >> timeout factor of 0.7 (some margin to the checked in factor of one) >> >> In addition to cha

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v3]

2025-08-15 Thread Leo Korinth
> This changes the timeout factor from 4 to 1. Most of the changes add timeouts > to individual test cases so that I am able to run them with a timeout factor > of 0.7 (some margin to the checked in factor of one) > > In addition to changing the timeout factor, I am also using a library call to

Integrated: 8365244: Some test control variables are undocumented in doc/testing.md

2025-08-15 Thread Volkan Yazici
On Thu, 14 Aug 2025 19:26:29 GMT, Volkan Yazici wrote: > Synchronize `make/RunTests.gmk` keyword variables with > `doc/testing.{md,html}`. This pull request has now been integrated. Changeset: 059b49b9 Author:Volkan Yazici URL: https://git.openjdk.org/jdk/commit/059b49b9551ad52f211

Re: RFR: 8365244: Some test control variables are undocumented in doc/testing.md

2025-08-15 Thread Volkan Yazici
On Thu, 14 Aug 2025 19:38:39 GMT, Erik Joelsson wrote: >> Synchronize `make/RunTests.gmk` keyword variables with >> `doc/testing.{md,html}`. > > Marked as reviewed by erikj (Reviewer). @erikj79, thanks for the review. 🙇 - PR Comment: https://git.openjdk.org/jdk/pull/26789#issuecom

Integrated: 8365491: VSCode IDE: add basic configuration for the Oracle Java extension

2025-08-15 Thread Manuel Hässig
On Wed, 13 Aug 2025 13:22:21 GMT, Manuel Hässig wrote: > This PR adds a basic configuration for the [Oracle Java VSCode > extension](https://marketplace.visualstudio.com/items?itemName=Oracle.oracle-java) > to the `vscode-project-*` targets. This pull request has now been integrated. Changese

Re: RFR: 8365491: VSCode IDE: add basic configuration for the Oracle Java extension [v3]

2025-08-15 Thread Manuel Hässig
On Fri, 15 Aug 2025 06:36:46 GMT, Manuel Hässig wrote: >> This PR adds a basic configuration for the [Oracle Java VSCode >> extension](https://marketplace.visualstudio.com/items?itemName=Oracle.oracle-java) >> to the `vscode-project-*` targets. > > Manuel Hässig has updated the pull request inc

Re: RFR: 8364973: Add JVMTI stress testing mode [v6]

2025-08-15 Thread Magnus Ihse Bursie
On Fri, 15 Aug 2025 04:33:59 GMT, Leonid Mesnik wrote: >> The fix added JVMTI stress testing mode. >> >> This mode enables stress agent that could be executed with jtreg test and >> help to ensure that jvmti functionality doesn't break the other JVM/JDK >> functionality. >> >> I filed few iss

Re: RFR: 8365231: Don't build gtest with /EHsc

2025-08-15 Thread Magnus Ihse Bursie
On Fri, 15 Aug 2025 06:45:35 GMT, Julian Waters wrote: >>> But `-fno-exceptions` _is_ used for gcc (and probably for clang, though >>> I've not checked). Verified by examination of ".o.cmdline" files for both >>> libgtest and the HotSpot gtests. >> >> Oh, and once again, thank you thank you th

Re: RFR: 8365491: VSCode IDE: add basic configuration for the Oracle Java extension [v3]

2025-08-15 Thread Magnus Ihse Bursie
On Fri, 15 Aug 2025 06:36:46 GMT, Manuel Hässig wrote: >> This PR adds a basic configuration for the [Oracle Java VSCode >> extension](https://marketplace.visualstudio.com/items?itemName=Oracle.oracle-java) >> to the `vscode-project-*` targets. > > Manuel Hässig has updated the pull request inc

Re: RFR: 8365491: VSCode IDE: add basic configuration for the Oracle Java extension [v3]

2025-08-15 Thread Jan Lahoda
On Fri, 15 Aug 2025 06:36:46 GMT, Manuel Hässig wrote: >> This PR adds a basic configuration for the [Oracle Java VSCode >> extension](https://marketplace.visualstudio.com/items?itemName=Oracle.oracle-java) >> to the `vscode-project-*` targets. > > Manuel Hässig has updated the pull request inc

Re: RFR: 8364973: Add JVMTI stress testing mode [v6]

2025-08-15 Thread Magnus Ihse Bursie
On Fri, 15 Aug 2025 04:33:59 GMT, Leonid Mesnik wrote: >> The fix added JVMTI stress testing mode. >> >> This mode enables stress agent that could be executed with jtreg test and >> help to ensure that jvmti functionality doesn't break the other JVM/JDK >> functionality. >> >> I filed few iss

Re: RFR: 8364973: Add JVMTI stress testing mode [v6]

2025-08-15 Thread Serguei Spitsyn
On Fri, 15 Aug 2025 04:33:59 GMT, Leonid Mesnik wrote: >> The fix added JVMTI stress testing mode. >> >> This mode enables stress agent that could be executed with jtreg test and >> help to ensure that jvmti functionality doesn't break the other JVM/JDK >> functionality. >> >> I filed few iss