On Wed, 12 Jun 2024 22:38:37 GMT, Zhao Song wrote:
> @kevinrushforth said in
> [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our
> repositories contain source code and not binary files. There are exceptions
> to this for images and other similar resources, but otherwis
On Wed, 12 Jun 2024 22:38:37 GMT, Zhao Song wrote:
> @kevinrushforth said in
> [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our
> repositories contain source code and not binary files. There are exceptions
> to this for images and other similar resources, but otherwis
On Wed, 12 Jun 2024 22:38:37 GMT, Zhao Song wrote:
> @kevinrushforth said in
> [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our
> repositories contain source code and not binary files. There are exceptions
> to this for images and other similar resources, but otherwis
On Tue, 18 Jun 2024 22:50:15 GMT, Phil Race wrote:
> > @prrace Any objections to the current version of the warning message?
>
> Meaning this example " ⚠️ Patch contains a binary file (duke-thinking.png)"
Yeah, that one.
-
PR Comment: https://git.openjdk.org/jdk/pull/19683#issuec
On Wed, 12 Jun 2024 22:38:37 GMT, Zhao Song wrote:
> @kevinrushforth said in
> [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our
> repositories contain source code and not binary files. There are exceptions
> to this for images and other similar resources, but otherwis
On Thu, 13 Jun 2024 17:50:21 GMT, Phil Race wrote:
>> @kevinrushforth said in
>> [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our
>> repositories contain source code and not binary files. There are exceptions
>> to this for images and other similar resources, but othe
On Thu, 13 Jun 2024 17:50:21 GMT, Phil Race wrote:
>> @kevinrushforth said in
>> [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our
>> repositories contain source code and not binary files. There are exceptions
>> to this for images and other similar resources, but othe
On Wed, 12 Jun 2024 22:38:37 GMT, Zhao Song wrote:
> @kevinrushforth said in
> [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our
> repositories contain source code and not binary files. There are exceptions
> to this for images and other similar resources, but otherwis
On Wed, 12 Jun 2024 22:38:37 GMT, Zhao Song wrote:
> @kevinrushforth said in
> [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our
> repositories contain source code and not binary files. There are exceptions
> to this for images and other similar resources, but otherwis
On Thu, 13 Jun 2024 17:50:21 GMT, Phil Race wrote:
>> @kevinrushforth said in
>> [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our
>> repositories contain source code and not binary files. There are exceptions
>> to this for images and other similar resources, but othe
On Wed, 12 Jun 2024 22:38:37 GMT, Zhao Song wrote:
> @kevinrushforth said in
> [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our
> repositories contain source code and not binary files. There are exceptions
> to this for images and other similar resources, but otherwis
On Wed, 12 Jun 2024 22:38:37 GMT, Zhao Song wrote:
> @kevinrushforth said in
> [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our
> repositories contain source code and not binary files. There are exceptions
> to this for images and other similar resources, but otherwis
On Wed, 12 Jun 2024 23:30:11 GMT, Phil Race wrote:
> > > How is this check presented to the PR author and Reviewers of a PR? Is it
> > > listed as a warning similar to the issue title warning? Do you have a
> > > sample PR (Draft is fine) that would show how this looks?
> >
> >
> > [openjdk/p
On Wed, 12 Jun 2024 22:38:37 GMT, Zhao Song wrote:
> @kevinrushforth said in
> [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our
> repositories contain source code and not binary files. There are exceptions
> to this for images and other similar resources, but otherwis
On Wed, 12 Jun 2024 22:38:37 GMT, Zhao Song wrote:
> @kevinrushforth said in
> [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our
> repositories contain source code and not binary files. There are exceptions
> to this for images and other similar resources, but otherwis
On Wed, 12 Jun 2024 22:49:30 GMT, Kevin Rushforth wrote:
> How is this check presented to the PR author and Reviewers of a PR? Is it
> listed as a warning similar to the issue title warning? Do you have a sample
> PR (Draft is fine) that would show how this looks?
https://github.com/openjdk/pl
@kevinrushforth said in
[SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our
repositories contain source code and not binary files. There are exceptions to
this for images and other similar resources, but otherwise the policy for most
repos is to avoid binary files'. Skara
On Wed, 12 Jun 2024 22:38:37 GMT, Zhao Song wrote:
> @kevinrushforth said in
> [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our
> repositories contain source code and not binary files. There are exceptions
> to this for images and other similar resources, but otherwis
18 matches
Mail list logo
