Re: (10) (M) RFR: 8174231: Factor out and share PlatformEvent and Parker code for POSIX systems

> On 19 May 2017, at 11:15, Magnus Ihse Bursie > wrote: > > > On 2017-05-19 09:15, David Holmes wrote: >> Hi Magnus, >> >> On 18/05/2017 8:06 PM, Magnus Ihse Bursie wrote: >>> >>> >>> On 2017-05-18 09:35, David Holmes wrote: On 18/05/2017 5:32 PM, Magnus

RFR: JDK-8175824 Adapt javadoc generation to different requirements for JDK and JavaSE

javadoc allows a file to be specified to provide content for the top level "overview" page. As we move towards a unified docs bundle, we need to be able to vary the content of that file depending on the content of the bundle. This does not mean providing or including lists of modules, but

Re: RFR: JDK-8180651: Make target to run tests on exploded image

Sure we can pause this. Robbin has a local patch to play with for now. If you want another name, then we should also rename exploded-image. As I understand it, the name exploded is well established. It refers to the java class files/resources not being in jars/jimage format, but exploded as

Re: (10) (M) RFR: 8174231: Factor out and share PlatformEvent and Parker code for POSIX systems

Hi Robbin, Thanks for looking at this. On 19/05/2017 6:36 PM, Robbin Ehn wrote: Hi David, On 05/18/2017 08:25 AM, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8174231 webrevs: Build-related: http://cr.openjdk.java.net/~dholmes/8174231/webrev.top/ hotspot:

Re: (10) (M) RFR: 8174231: Factor out and share PlatformEvent and Parker code for POSIX systems

On 19/05/2017 7:25 PM, Robbin Ehn wrote: On 05/19/2017 11:07 AM, David Holmes wrote: They have to be as there are three cases: 1. Relative wait using CLOCK_MONOTONIC 2. Relative wait using gettimeofday() 3. Absolute wait using gettimeofday() Please consider something like: #ifdef

Re: (10) (M) RFR: 8174231: Factor out and share PlatformEvent and Parker code for POSIX systems

Hi David, On 05/18/2017 08:25 AM, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8174231 webrevs: Build-related: http://cr.openjdk.java.net/~dholmes/8174231/webrev.top/ hotspot: http://cr.openjdk.java.net/~dholmes/8174231/webrev.hotspot/ I like this, with neg

Re: (10) (M) RFR: 8174231: Factor out and share PlatformEvent and Parker code for POSIX systems

Thanks Erik! David On 19/05/2017 6:07 PM, Erik Joelsson wrote: Build changes look good to me. /Erik On 2017-05-19 09:15, David Holmes wrote: Hi Magnus, On 18/05/2017 8:06 PM, Magnus Ihse Bursie wrote: On 2017-05-18 09:35, David Holmes wrote: On 18/05/2017 5:32 PM, Magnus Ihse Bursie

Re: (10) (M) RFR: 8174231: Factor out and share PlatformEvent and Parker code for POSIX systems

On 05/19/2017 11:07 AM, David Holmes wrote: They have to be as there are three cases: 1. Relative wait using CLOCK_MONOTONIC 2. Relative wait using gettimeofday() 3. Absolute wait using gettimeofday() Please consider something like: #ifdef SUPPORTS_CLOCK_MONOTONIC if

Re: RFR: JDK-8180651: Make target to run tests on exploded image

I like the idea, the changes in itself look good, but I really *really* do not like the name "exploded". It was not good before as in "exploded-image", but this is even worse. :-( Can we pause this one for just a while and try really hard to come up with a better name? If we fail to do that

Re: (10) (M) RFR: 8174231: Factor out and share PlatformEvent and Parker code for POSIX systems

Correction ... On 19/05/2017 8:53 PM, David Holmes wrote: On 19/05/2017 7:25 PM, Robbin Ehn wrote: On 05/19/2017 11:07 AM, David Holmes wrote: They have to be as there are three cases: 1. Relative wait using CLOCK_MONOTONIC 2. Relative wait using gettimeofday() 3. Absolute wait using

Re: RFR: JDK-8180480 Use "requires transitive" relationship when determining modules for javadoc

Looks good. /Erik On 2017-05-19 10:08, Magnus Ihse Bursie wrote: On 2017-05-18 17:30, Mandy Chung wrote: On May 18, 2017, at 12:54 AM, Magnus Ihse Bursie wrote: When the build system tries to figure out which modules that should be included by the javadoc

Re: (10) (M) RFR: 8174231: Factor out and share PlatformEvent and Parker code for POSIX systems

Replying to all this time :) On 19/05/2017 7:15 PM, Magnus Ihse Bursie wrote: On 2017-05-19 09:15, David Holmes wrote: Hi Magnus, On 18/05/2017 8:06 PM, Magnus Ihse Bursie wrote: On 2017-05-18 09:35, David Holmes wrote: On 18/05/2017 5:32 PM, Magnus Ihse Bursie wrote: On 2017-05-18

Re: (10) (M) RFR: 8174231: Factor out and share PlatformEvent and Parker code for POSIX systems

On 2017-05-19 09:15, David Holmes wrote: Hi Magnus, On 18/05/2017 8:06 PM, Magnus Ihse Bursie wrote: On 2017-05-18 09:35, David Holmes wrote: On 18/05/2017 5:32 PM, Magnus Ihse Bursie wrote: On 2017-05-18 08:25, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8174231

RFR: JDK-8180651: Make target to run tests on exploded image

In most cases, when running regression tests, you want to run them on the jdk image because that's the correct image and some tests will not work on other variants. However, many tests can be run successfully on the exploded image and since building the full jdk image takes quite a bit of

Re: RFR: JDK-8175824 Adapt javadoc generation to different requirements for JDK and JavaSE

Looks good. Minor nit. There are variables named JavaSE_MODULES as well as JAVASE_MODULES which can be a bit confusing. Perhaps the latter can be inlined at this point? Or the first should perhaps be called JavaSE_GROUP_MODULES? /Erik On 2017-05-19 11:28, Magnus Ihse Bursie wrote: javadoc

Re: RFR: JDK-8180651: Make target to run tests on exploded image

Thank you Erik for doing this! /Robbin On 05/19/2017 11:26 AM, Erik Joelsson wrote: In most cases, when running regression tests, you want to run them on the jdk image because that's the correct image and some tests will not work on other variants. However, many tests can be run successfully

Re: Review Request: JDK-8180717: Upgrade the docs bundle index page

Look good to me. -- Jon On 05/19/2017 01:48 PM, Mandy Chung wrote: This patch updates the build tool to generate an improved presentation of the module groupings. A sample page: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8180717/docs/index.html Webrev:

Re: RFR: JDK-8180651: Make target to run tests on exploded image

"exploded" as an adjective applies well enough to "image" but not to the imperative "run-test". At the risk of a long name, can you move exploded to the end, with something like run-test-exploded-image -- Jon On 05/19/2017 08:36 AM, Robbin Ehn wrote: Hi, On 05/19/2017 12:55 PM, Erik

Re: RFR: JDK-8180480 Use "requires transitive" relationship when determining modules for javadoc

> On May 19, 2017, at 1:08 AM, Magnus Ihse Bursie > wrote: > > > "Indirect exports" was a good term. I dropped the "Deps" part of the name and > it all became much clearer. > > Here's an updated webrev: >

Re: RFR: JDK-8175824 Adapt javadoc generation to different requirements for JDK and JavaSE

Magnus, Iris and Kevin provides the description for each group. The overview page can look like this: This document is the Java™ Platform, Standard Edition Development Kit (JDK™) 9 API Specification. Java SE The Java Platform, Standard Edition (“Java SE”) APIs define the

Re: RFR: JDK-8180651: Make target to run tests on exploded image

Hi, On 05/19/2017 12:55 PM, Erik Joelsson wrote: Sure we can pause this. Robbin has a local patch to play with for now. Yes, no rush for me. If you want another name, then we should also rename exploded-image. As I understand it, the name exploded is well established. It refers to the java

Review Request: JDK-8180717: Upgrade the docs bundle index page

This patch updates the build tool to generate an improved presentation of the module groupings. A sample page: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8180717/docs/index.html Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8180717/webrev.00/ Thanks Mandy

Re: (10) (M) RFR: 8174231: Factor out and share PlatformEvent and Parker code for POSIX systems

Hi Magnus, On 18/05/2017 8:06 PM, Magnus Ihse Bursie wrote: On 2017-05-18 09:35, David Holmes wrote: On 18/05/2017 5:32 PM, Magnus Ihse Bursie wrote: On 2017-05-18 08:25, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8174231 webrevs: Build-related:

Re: CR: 8180540: Add pandoc build fix for windows

Hello, On 2017-05-18 19:10, Brad R. Wetmore wrote: On 5/18/2017 12:27 AM, Magnus Ihse Bursie wrote: Looks good. Formally, I believe someone else needs to review it. Hm...I would have expected your "Contributed-by" and my review would be sufficient (what we do for sponsoring an "author"

Re: (10) (M) RFR: 8174231: Factor out and share PlatformEvent and Parker code for POSIX systems

Build changes look good to me. /Erik On 2017-05-19 09:15, David Holmes wrote: Hi Magnus, On 18/05/2017 8:06 PM, Magnus Ihse Bursie wrote: On 2017-05-18 09:35, David Holmes wrote: On 18/05/2017 5:32 PM, Magnus Ihse Bursie wrote: On 2017-05-18 08:25, David Holmes wrote: Bug:

Re: RFR: JDK-8180480 Use "requires transitive" relationship when determining modules for javadoc

On 2017-05-18 17:30, Mandy Chung wrote: On May 18, 2017, at 12:54 AM, Magnus Ihse Bursie wrote: When the build system tries to figure out which modules that should be included by the javadoc build, it locates the set of modules "required" by already included

Re: (10) (M) RFR: 8174231: Factor out and share PlatformEvent and Parker code for POSIX systems

Hi David On 05/19/2017 01:36 PM, David Holmes wrote: There are three different forms of the calculation. The two relative time versions use a different time function and so a different time structure (timeval vs timespec) and a different calculation. Yes that's why I included unit in my