Re: macOS High Sierra, version 10.13.2 configure: error: Could notfind freetype! You might be able to fix this by running 'brew installfreetype'

Thank you for your kind help, I’ve jump out of the last pit. Now the new challenge is: I execute the following command: bash ../8dev/configure --with-boot-jdk=/Library/Java/JavaVirtualMachines/jdk1.8.0_131.jdk/Contents/Home --with-freetype=/usr/local/Cellar/freetype/2.9/ --enable-ccache --w

Re: [OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c

-- Summary -- I ask for a committer to go into jdk/jdk and add one word to make/lib/Awt2dLibraries.gmk We need to go to line 495 and add array-bounds into the list of disabled warnings. So this: DISABLED_WARNINGS_gcc := clobbered implicit-fallthrough shift-negative-value, \ becomes this:

Re: RFR 8190378: Java EE and CORBA modules removal

Lance, In Docs.gmk you seem to have missed this: 445 446 # Setup generation of the Java SE API documentation (javadoc + modulegraph) 447 448 # The Java SE module scope is just java.se.ee and its transitive in

Re: macOS High Sierra, version 10.13.2 configure: error: Could notfind freetype! You might be able to fix this by running 'brew installfreetype'

Hello, My guess would be that Xcode 4 isn't working on Macos 10.13. Internally we build JDK 8 on 10.8. /Erik On 2018-02-13 01:41, mbl wrote: Thank you for your kind help, I’ve jump out of the last pit. Now the new challenge is: I execute the following command:  bash ../8dev/configure  -

Re: RFR 8190378: Java EE and CORBA modules removal

Hi David, I thought I did make that change. Let me go back and double check and if not, will push. My build worked fine but maybe I missed this in a merge. Best Lance > On Feb 13, 2018, at 8:05 AM, David Holmes wrote: > > Lance, > > In Docs.gmk you seem to have missed this: > > 445 >

[11] RFR JDK-8197865: @moduleGraph taglet generates incorrect link to module graph

Jon, Kumar, This is a regression from JDK-8195795 that generates but module-summary.html is under ${MODULE} directory. The correct link should be a href="module-graph.png">... Lance - I include make/Docs.gmk fix here since the docs hangs. Are you going to push a fix for it? If not, I can crea

RFR: 8197866 Docs.mk still had a reference to java.se.ee

Hi, Please review this change to address the missed reference to java.se.ee —— hg diff make/Docs.gmk diff -r 345f41527dcc make/Docs.gmk --- a/make/Docs.gmk Thu Feb 08 15:35:49 2018 +0100 +++ b/make/Docs.gmk Tue Feb 13 14:31:36 2018 -0500 @@ -445,9 +445,9 @@ ###

Re: RFR: 8197866 Docs.mk still had a reference to java.se.ee

Lance: Please review this change to address the missed reference to java.se.ee —— hg diff make/Docs.gmk diff -r 345f41527dcc make/Docs.gmk --- a/make/Docs.gmk Thu Feb 08 15:35:49 2018 +0100 +++ b/make/Docs.gmk Tue Feb 13 14:31:36 2018 -0500 @@ -445,9 +445,9 @@ #

Re: [11] RFR JDK-8197865: @moduleGraph taglet generates incorrect link to module graph

Hi Mandy I just submitted an RFR to build-dev so our emails crossed > On Feb 13, 2018, at 2:29 PM, mandy chung wrote: > > Jon, Kumar, > > This is a regression from JDK-8195795 that generates > but module-summary.html > is under ${MODULE} directory. The correct link should be > a href="mod

Re: [11] RFR JDK-8197865: @moduleGraph taglet generates incorrect link to module graph

Change is pushed. Thank you Tim for the review your change looks good Mandy... Best Lance > On Feb 13, 2018, at 2:38 PM, Lance Andersen wrote: > > Hi Mandy > > I just submitted an RFR to build-dev so our emails crossed > >> On Feb 13, 2018, at 2:29 PM, mandy chung wrote: >> >> Jon, Kumar,

Re: [11] RFR JDK-8197865: @moduleGraph taglet generates incorrect link to module graph

Good. I see you pushed the fix to Docs.gmk. Kumar, Jon - can you please review this patch? diff --git a/make/jdk/src/classes/build/tools/taglet/ModuleGraph.java b/make/jdk/src/classes/build/tools/taglet/ModuleGraph.java --- a/make/jdk/src/classes/build/tools/taglet/ModuleGraph.java +++ b/make/j

Re: RFR: 8197866 Docs.mk still had a reference to java.se.ee

Thanks Lance. That fixes my builds. David On 14/02/2018 5:36 AM, Lance Andersen wrote: Hi, Please review this change to address the missed reference to java.se.ee —— hg diff make/Docs.gmk diff -r 345f41527dcc make/Docs.gmk --- a/make/Docs.gmk Thu Feb 08 15:35:49 2018 +0100 +++ b

Re: [11] RFR JDK-8197865: @moduleGraph taglet generates incorrect link to module graph

+1 -- Jon On 02/13/2018 11:47 AM, mandy chung wrote: Good. I see you pushed the fix to Docs.gmk. Kumar, Jon - can you please review this patch? diff --git a/make/jdk/src/classes/build/tools/taglet/ModuleGraph.java b/make/jdk/src/classes/build/tools/taglet/ModuleGraph.java --- a/make/jdk/src/c

RFR: JDK-8153294: Solaris devkit uses linker from system instead of in devkit

The current devkit I created for Solaris has a flaw in that CC will still call the system linker instead of the one in the devkit. I have finally figured out a solution for this, while working on the next devkit with upgraded compiler versions, but this fix has value on its own so I decided to

Re: RFR: JDK-8153294: Solaris devkit uses linker from system instead of in devkit

Erik: The current devkit I created for Solaris has a flaw in that CC will still call the system linker instead of the one in the devkit. I have finally figured out a solution for this, while working on the next devkit with upgraded compiler versions, but this fix has value on its own so I decide

Re: RFR(S): 8197906: Enable CDS mode execution of jtreg tests via make

cc'ing build-dev as this is a shared makefile change Thanks, David On 14/02/2018 2:17 PM, Mikhailo Seledtsov wrote: Please review this small change that enables execution of any jtreg test(s) in CDS mode via make. Please see bug description for details. Thanks to Erik and Igor for their help