Re: [8u] 8203349: 8u hotspot should recognise later Windows compilers

e still OK. Thanks Kevin On 17/05/2018 23:32, Erik Joelsson wrote: Hello Kevin, In JDK 11, vm_version.cpp we have _MSC_VER == 1900 translating to VS2015 and 1912 to VS2017. Is it really 1900 in nmake? Otherwise I think this looks ok. /Erik On 2018-05-17 15:21, Kevin Walls wrote: Hi,

Re: [8u-dev] RFR for JDK-8203790: MSVCP dependency introduced in awt.dll

Thanks Alexey - my build with this change completed OK too and the MSVCP dependency in awt.dll has gone, great! Thanks Kevin On 25/05/2018 09:27, Alexey Ivanov wrote: Hi, Could you please review the following fix for 8u-dev? jbs: https://bugs.openjdk.java.net/browse/JDK-8203790 webrev:

Re: [8u] 8203349: 8u hotspot should recognise later Windows compilers

ersion 14.12.25835.0 Copyright (C) Microsoft Corporation.  All rights reserved. So it looks like you need to add 1412 to checkLink in sanity.make. /Erik On 2018-05-18 01:51, Kevin Walls wrote: Hi Erik - Quite right, thanks.  Actually I should include recognising VS2015 while I'm doing this.

[8u] 8078437: Enable use of devkits for Windows.

Hi, I'd like to get a review of a backport from 9 to 8u: 8078437: Enable use of devkits for Windows. JBS: https://bugs.openjdk.java.net/browse/JDK-8078437 9 changeset: URL:   http://hg.openjdk.java.net/jdk9/dev/rev/bc02cff96b92 9 review thread:

[8u] 8203349: 8u hotspot should recognise later Windows compilers

Hi, I'd like to get a review for this 8u/hotspot build change for Windows, to loosen the restriction on what compilers we can use. JBS: 8203349: 8u hotspot should recognise later Windows compilers https://bugs.openjdk.java.net/browse/JDK-8203349 Webrev:

Re: [8u] 8078437: Enable use of devkits for Windows.

for configure to pick it up automatically. /Erik On 2018-05-18 13:42, Kevin Walls wrote: Hi, I'd like to get a review of a backport from 9 to 8u: 8078437: Enable use of devkits for Windows. JBS: https://bugs.openjdk.java.net/browse/JDK-8078437 9 changeset: URL:   http://hg.openjdk.java.net

Re: [8u] RFR: 8042707: Source changes needed to build JDK 9 with Visual Studio 2013 (VS2013)

Joelsson wrote: Looks good. /Erik On 2018-04-26 01:38, Kevin Walls wrote: Thanks Erik - I went ahead with the jdk's make/CopyFiles.gmk change, and added SetupCopyFiles to the base repo's make/common/MakeBase.gmk. I updated the webrev, to include base and jdk repos: http

[8u] RFR: 8196108: Add build support for VS 2015/2017

Hi, I'd like to get a review of a backport to jdk8u of: 8196108: Add build support for VS 2015/2017 https://bugs.openjdk.java.net/browse/JDK-8196108 JDK 11 changeset: http://hg.openjdk.java.net/jdk/jdk/rev/bcce1fa183e7 Original review thread:

Re: [8u] RFR: 8148351: Only display resolved symlink for compiler, do not change path

Thanks Severin, Yes, keeping the special case about ccache should keep our own builds happy.  I ran this in JPRT earlier today and the builds went OK, so if it fixes your issue also then it looks good to me. Thanks Kevin On 19/06/2018 17:57, Severin Gehwolf wrote: Hi, After discussion in

Re: [8u] RFR: 8042707: Source changes needed to build JDK 9 with Visual Studio 2013 (VS2013)

/make/CopyFiles.gmk. Those changes are definitely needed. /Erik On 2018-04-20 13:18, Kevin Walls wrote: Hi, I'd like to request a review of the backport from 9 to 8u: 8042707: Source changes needed to build JDK 9 with Visual Studio 2013 (VS2013) JBS: https://bugs.openjdk.java.net/browse

[8u] RFR(xS): 8209359: [8u] hotspot needs to recognise cl.exe 19.13 to build with VS2017.

Hi, I'd like to get a review of this small change to let the jdk8u/hotspot build system recognise another Microsoft compiler version: 8209359: [8u] hotspot needs to recognise cl.exe 19.13 to build with VS2017. https://bugs.openjdk.java.net/browse/JDK-8209359 Diff below, just another if

RFR (8u): 8209002: 8u192 installed exe and dll files have wrong file version

Hi, I'd like to get a review of: 8209002: 8u192 installed exe and dll files have wrong file version https://bugs.openjdk.java.net/browse/JDK-8209002 Previous changes have changed the versions used by RC_FLAGS which changes the versions appearing in Windows binaries. Diff below, tests well

Re: 8210423: Backport of 8034788 breaks GCC version detection

Hi Andrew, I think I did that, so must have gone macro-blind by that point. Yes, looks good to me. Thanks Kevin On 05/09/2018 17:05, Andrew Haley wrote: The JDK8u backport of 8034788 changed the variable name CXX_VERSION (in configure) to CXX_VERSION_NUMBER. Unfortunately this was not done

Re: RFR (8u): 8034788: Rewrite toolchain.m4 to support multiple toolchains per platform

That's great, thanks Magnus. On 05/04/2018 11:53, Magnus Ihse Bursie wrote: On 2018-04-05 10:46, Kevin Walls wrote: Hi, I'd like to get a technical review of a backport to jdk8u: 8034788: Rewrite toolchain.m4 to support multiple toolchains per platform JBS: https://bugs.openjdk.java.net

RFR (8u): 8034788: Rewrite toolchain.m4 to support multiple toolchains per platform

Hi, I'd like to get a technical review of a backport to jdk8u: 8034788: Rewrite toolchain.m4 to support multiple toolchains per platform JBS: https://bugs.openjdk.java.net/browse/JDK-8034788 9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/rev/b18872ff5379 8u webrev:

[8u] RFR: 8035495: Improvements in autoconf integration AND 8035825

Hi, I'd like to request review of this backport from 9 to 8u: 8035495: Improvements in autoconf integration JBS: https://bugs.openjdk.java.net/browse/JDK-8035495 9 changeset: URL: http://hg.openjdk.java.net/jdk9/dev/rev/6e29cd9ac2b4 User: ihse Date: 2014-02-24 12:31:07 + 9 review

Re: [8u] RFR: 8035495: Improvements in autoconf integration AND 8035825

Thanks Magnus.   I'll also be doing the related 8035730.  That's a clean backport so will go straight to 8u-dev group. Thanks Kevin On 12/04/2018 13:05, Magnus Ihse Bursie wrote: Looks good to me. /Magnus On 2018-04-11 17:38, Kevin Walls wrote: Hi, I'd like to request review

Re: [8u] RFR: 8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris

Thanks Tim - There's a later webrev in the review thread: http://cr.openjdk.java.net/~erikj/8038340/webrev.root.03/ in which I see the common/autoconf/configure.ac change... It's in the commit in 9 also.  I think we need it. 8-) But that webrev.03 also has the commenting out of "Building

Re: [8u] RFR: 8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris

Hi Erik - thanks for clarifying. On 13/04/2018 20:58, Erik Joelsson wrote: ccache shouldn't be commented out. That must have been a local edit mistake in the original webrev. /Erik On 2018-04-13 12:51, Kevin Walls wrote: Thanks Tim - There's a later webrev in the review thread: http

[8u] RFR: 8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris

Hi, I'd like to request review of this backport from 9 to 8u: 8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris JBS: https://bugs.openjdk.java.net/browse/JDK-8038340 9 changesets: base repo: http://hg.openjdk.java.net/jdk9/dev/rev/9786ef8ca58c JDK: repo:

[8u] RFR: 8042707: Source changes needed to build JDK 9 with Visual Studio 2013 (VS2013)

Hi, I'd like to request a review of the backport from 9 to 8u: 8042707: Source changes needed to build JDK 9 with Visual Studio 2013 (VS2013) JBS: https://bugs.openjdk.java.net/browse/JDK-8042707 9 changesets: base repo: http://hg.openjdk.java.net/jdk9/jdk9/rev/39ee0ee4f890 jdk repo:

RFR(8u): 8211933: [8u] hotspot adlc needs to link statically with libstdc++ for gcc7.3

Hi, I'd like to get a review of an 8u change: 8211933: [8u] hotspot adlc needs to link statically with libstdc++ for gcc7.3 https://bugs.openjdk.java.net/browse/JDK-8211933 webrev: http://cr.openjdk.java.net/~kevinw/8211933/webrev.00/ Essentially adds -static-libstdc++ for linking adlc

RFR(8u): 8202557: OpenJDK fails to start in Windows 7 and 8.1 after upgrading compiler to VC 2017

Hi, I'd like to get a review of an 8u backport of: 8202557: OpenJDK fails to start in Windows 7 and 8.1 after upgrading compiler to VC 2017 https://bugs.openjdk.java.net/browse/JDK-8202557 11 change: http://hg.openjdk.java.net/jdk/jdk/rev/35b22ca681d1 11 review thread:

Re: RFR: 8284853: Fix various 'expected' typo [v2]

On Thu, 14 Apr 2022 18:04:16 GMT, Andrey Turbanov wrote: > I found [yet another > typo](https://github.com/kelthuzadx/jdk/commit/acb9e15bc0bf5395d1c0875f36992f692734f948) > ... I didn't think "JVMInvokeMethodSlack" was a typo. I think it's the idea of "slack space" meaning leftover space.