Re: [PATCH] linux-sparc build fixes

Hi Erik! On Thu, Jul 06, 2017 at 02:55:53PM +0200, Erik Helin wrote: > >Yes, you now have two reviewers. But for these changes (hotspot) you > >need a sponsor, which needs to be an Oracle employee, which I am not. > > > >Maybe Eric could sponsor the change? > > Yep, I can shepherd the patches in

Re: [PATCH] linux-sparc build fixes

On 07/04/2017 11:33 AM, John Paul Adrian Glaubitz wrote: On Wed, Jun 14, 2017 at 01:50:06PM +0200, Erik Helin wrote: I think the first three patches (hotspot-add-missing-log-header.diff, hotspot-fix-checkbytebuffer.diff, rename-sparc-linux-atomic-header.diff) all look good, thanks for fixing

Re: [PATCH] linux-sparc build fixes

On 07/05/2017 09:23 PM, Thomas Stüfe wrote: On Wed 5. Jul 2017 at 19:39, John Paul Adrian Glaubitz > wrote: On 07/05/2017 07:37 PM, Thomas Stüfe wrote: > Nah, I believe you :) Changes are trivial enough. OK. So

Re: [PATCH] linux-sparc build fixes

On Wed 5. Jul 2017 at 19:39, John Paul Adrian Glaubitz < glaub...@physik.fu-berlin.de> wrote: > On 07/05/2017 07:37 PM, Thomas Stüfe wrote: > > Nah, I believe you :) Changes are trivial enough. > > OK. So we're good to merge then? > > -- > .''`. John Paul Adrian Glaubitz > : :' : Debian

Re: [PATCH] linux-sparc build fixes

On 07/05/2017 07:37 PM, Thomas Stüfe wrote: > Nah, I believe you :) Changes are trivial enough. OK. So we're good to merge then? -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF

Re: [PATCH] linux-sparc build fixes

On Wed, Jul 5, 2017 at 7:27 PM, John Paul Adrian Glaubitz < glaub...@physik.fu-berlin.de> wrote: > On 07/05/2017 07:26 PM, Thomas Stüfe wrote: > > Changes look fine to me. I cannot build and test though, do not have a > sparc linux machine. > > We have a fast SPARC T5 running Debian unstable

Re: [PATCH] linux-sparc build fixes

On 07/05/2017 07:26 PM, Thomas Stüfe wrote: > Changes look fine to me. I cannot build and test though, do not have a sparc > linux machine. We have a fast SPARC T5 running Debian unstable available and I could create an account for you if you're interested. Adrian -- .''`. John Paul Adrian

Re: [PATCH] linux-sparc build fixes

Hi Adrian, Changes look fine to me. I cannot build and test though, do not have a sparc linux machine. Kind Regards, Thomas On Tue, Jul 4, 2017 at 11:33 AM, John Paul Adrian Glaubitz < glaub...@physik.fu-berlin.de> wrote: > On Wed, Jun 14, 2017 at 01:50:06PM +0200, Erik Helin wrote: > > I

Re: [PATCH] linux-sparc build fixes

On Wed, Jun 14, 2017 at 01:50:06PM +0200, Erik Helin wrote: > I think the first three patches (hotspot-add-missing-log-header.diff, > hotspot-fix-checkbytebuffer.diff, rename-sparc-linux-atomic-header.diff) all > look good, thanks for fixing broken code. Consider them Reviewed by me. > Every patch

Re: [PATCH] linux-sparc build fixes

On 27.06.2017 15:40, John Paul Adrian Glaubitz wrote: Here's a build with the patches applied and the testsuite enabled: https://people.debian.org/~glaubitz/openjdk-9_9~b170-2_sparc64.build For comparison it can be useful to keep an eye on

Re: [PATCH] linux-sparc build fixes

On Thu, Jun 22, 2017 at 12:27:03PM +0200, John Paul Adrian Glaubitz wrote: > On Mon, Jun 19, 2017 at 02:48:39PM +0200, Erik Helin wrote: > > >So, should I just run the testsuite with all three patches applied? > > > > Yes, please run the testsuite with the three patches applied. This should > >

Re: [PATCH] linux-sparc build fixes

On Mon, Jun 19, 2017 at 02:48:39PM +0200, Erik Helin wrote: > >So, should I just run the testsuite with all three patches applied? > > Yes, please run the testsuite with the three patches applied. This should > work (famous last words ;)) for the "native" Linux/sparc64 version of > hotspot (if

Re: [PATCH] linux-sparc build fixes

On 06/19/2017 09:06 AM, John Paul Adrian Glaubitz wrote: On Mon, Jun 19, 2017 at 08:59:38AM +0200, Erik Helin wrote: I'm asking because running the testsuite on Linux sparc64 will only be possible with all four patches applied as they are build fixes. Running the testsuite on Linux x86_64

Re: [PATCH] linux-sparc build fixes

On Mon, Jun 19, 2017 at 08:59:38AM +0200, Erik Helin wrote: > > I'm asking because running the testsuite on Linux sparc64 will only be > > possible with all four patches applied as they are build fixes. Running > > the testsuite on Linux x86_64 will be possible, of course. > > Ok, this is the

Re: [PATCH] linux-sparc build fixes

On 06/18/2017 01:40 AM, John Paul Adrian Glaubitz wrote: > Hi Erik! > > On 06/14/2017 02:04 PM, John Paul Adrian Glaubitz wrote: >> On Wed, Jun 14, 2017 at 01:50:06PM +0200, Erik Helin wrote: >>> thanks for contributing and signing the OCA! >> >> Thanks for reviewing my patches ;-). > > My OCA

Re: [PATCH] linux-sparc build fixes

Hi Erik! On 06/14/2017 02:04 PM, John Paul Adrian Glaubitz wrote: > On Wed, Jun 14, 2017 at 01:50:06PM +0200, Erik Helin wrote: >> thanks for contributing and signing the OCA! > > Thanks for reviewing my patches ;-). My OCA has been completed now and I'm now showing up on the list of signees:

Re: [PATCH] linux-sparc build fixes

On 2017-06-14 16:38, Erik Helin wrote: On 06/14/2017 02:21 PM, Severin Gehwolf wrote: Hi Eric, On Wed, 2017-06-14 at 13:50 +0200, Erik Helin wrote: For the fourth patch, fix-zero-build-on-sparc.diff, I'm not so sure. For example, the following is a bit surprising to me (mostly because I'm

Re: [PATCH] linux-sparc build fixes

Hi Eric, On Wed, 2017-06-14 at 16:38 +0200, Erik Helin wrote: > On 06/14/2017 02:21 PM, Severin Gehwolf wrote: > > Hi Eric, > > > > On Wed, 2017-06-14 at 13:50 +0200, Erik Helin wrote: > > > For the fourth patch, fix-zero-build-on-sparc.diff, I'm not so sure. For  > > > example, the following is

Re: [PATCH] linux-sparc build fixes

On 06/14/2017 02:21 PM, Severin Gehwolf wrote: > Hi Eric, > > On Wed, 2017-06-14 at 13:50 +0200, Erik Helin wrote: >> For the fourth patch, fix-zero-build-on-sparc.diff, I'm not so sure. For >> example, the following is a bit surprising to me (mostly because I'm not >> familiar with zero): >>

Re: [PATCH] linux-sparc build fixes

Hi Dalibor! On Wed, Jun 14, 2017 at 03:08:57PM +0200, dalibor topic wrote: > thanks, congrats & welcome! Thank you! > Since your OCA submission has not been processed yet, you are not listed on > http://www.oracle.com/technetwork/community/oca-486395.html . Patches can be > merged once your OCA

Re: [PATCH] linux-sparc build fixes

On 14.06.2017 14:04, John Paul Adrian Glaubitz wrote: Can't wait for my first patches getting merged into OpenJDK ;-). Hi Adrian, thanks, congrats & welcome! Since your OCA submission has not been processed yet, you are not listed on

Re: [PATCH] linux-sparc build fixes

On Wed, Jun 14, 2017 at 02:30:24PM +0200, Erik Helin wrote: > >I'm not 100% whether I did that. I'm not very familar with mercurial > >as I'm more used to git. If the patch format looks wrong to you, I can > >resend a revised version of this patch. > > No worries, someone will have to commit your

Re: [PATCH] linux-sparc build fixes

On 06/14/2017 02:04 PM, John Paul Adrian Glaubitz wrote: Hi Erik! On Wed, Jun 14, 2017 at 01:50:06PM +0200, Erik Helin wrote: thanks for contributing and signing the OCA! Thanks for reviewing my patches ;-). I think the first three patches (hotspot-add-missing-log-header.diff,

Re: [PATCH] linux-sparc build fixes

Hi Eric, On Wed, 2017-06-14 at 13:50 +0200, Erik Helin wrote: > For the fourth patch, fix-zero-build-on-sparc.diff, I'm not so sure. For  > example, the following is a bit surprising to me (mostly because I'm not  > familiar with zero): > > ---

Re: [PATCH] linux-sparc build fixes

Hi Erik! On Wed, Jun 14, 2017 at 01:50:06PM +0200, Erik Helin wrote: > thanks for contributing and signing the OCA! Thanks for reviewing my patches ;-). > I think the first three patches (hotspot-add-missing-log-header.diff, > hotspot-fix-checkbytebuffer.diff,

Re: [PATCH] linux-sparc build fixes

Hey Adrian, thanks for contributing and signing the OCA! I think the first three patches (hotspot-add-missing-log-header.diff, hotspot-fix-checkbytebuffer.diff, rename-sparc-linux-atomic-header.diff) all look good, thanks for fixing broken code. Consider them Reviewed by me. Every patch

Re: [PATCH]: linux-sparc build fixes

Hi Adrian, cc'ing hotspot-dev and bcc'ing build-dev as these are not issues with the build files, but hotspot sources. First, than you for taking the time and effort to contribute to OpenJDK. However ... The status of linux-sparc as a port in OpenJDK 9 (or 8u) is unclear. As you have