Hello,
On 2017-05-18 19:10, Brad R. Wetmore wrote:
On 5/18/2017 12:27 AM, Magnus Ihse Bursie wrote:
Looks good. Formally, I believe someone else needs to review it.
Hm...I would have expected your "Contributed-by" and my review would
be sufficient (what we do for sponsoring an "author" ch
On 5/18/2017 10:10 AM, Brad R. Wetmore wrote:
As long as pandoc for windows is always a windows native thing and
not provided by cygwin this seems good. A quick googling indicates
that cygwin currently does not provide pandoc so should be fine then.
You are correct in that pandoc is not prov
On 5/18/2017 12:27 AM, Magnus Ihse Bursie wrote:
Looks good. Formally, I believe someone else needs to review it.
Hm...I would have expected your "Contributed-by" and my review would be
sufficient (what we do for sponsoring an "author" change), but looks
like Erik did review also so we shou
As long as pandoc for windows is always a windows native thing and not
provided by cygwin this seems good. A quick googling indicates that
cygwin currently does not provide pandoc so should be fine then.
/Erik
On 2017-05-18 09:27, Magnus Ihse Bursie wrote:
Looks good. Formally, I believe som
Looks good. Formally, I believe someone else needs to review it.
/Magnus
On 2017-05-18 02:07, Brad R. Wetmore wrote:
Magnus,
I've added your suggested fix to spec.gmk.in, which is the minor tweak
to add @FIXPATH@ to allow pandoc to run on windows builds.
https://bugs.openjdk.java.net/br
