Re: [PATCH] modutils: fix config options dependency (2)

On Tue, Feb 7, 2017 at 4:38 PM, Kang-Che Sung <explore...@gmail.com> wrote: > On Tue, Feb 7, 2017 at 11:21 PM, Denys Vlasenko > <vda.li...@googlemail.com> wrote: >> On Tue, Feb 7, 2017 at 4:38 AM, Kang-Che Sung <explore...@gmail.com> wrote: >>> On Tue,

Re: [PATCH] modutils: fix config options dependency (2)

On Tue, Feb 7, 2017 at 4:38 AM, Kang-Che Sung <explore...@gmail.com> wrote: > On Tue, Feb 7, 2017 at 4:56 AM, Denys Vlasenko <vda.li...@googlemail.com> > wrote: >> On Mon, Feb 6, 2017 at 4:38 AM, Kang-Che Sung <explore...@gmail.com> wrote: >>> Thank you,

Re: [PATCH] Replace int -> uint to avoid signed integer overflow

On Mon, Feb 6, 2017 at 11:59 PM, Rob Landley <r...@landley.net> wrote: > On 02/06/2017 07:20 AM, Denys Vlasenko wrote: >> I'm not using their runtime debug thing (I don't even know what it is), >> if some people would use it and find real bugs, it's good for me. > > I

Re: [PATCH] modutils: fix config options dependency (2)

On Mon, Feb 6, 2017 at 4:38 AM, Kang-Che Sung <explore...@gmail.com> wrote: > On Mon, Feb 6, 2017 at 2:04 AM, Denys Vlasenko <vda.li...@googlemail.com> > wrote: >> Applied a simpler version of it. Thanks >> >> On Wed, Feb 1, 2017 at 10:22 AM, Kang-C

Re: timeout setting for login

On Mon, Feb 6, 2017 at 6:09 PM, Patrick Pief wrote: > On Mon, 06 Feb 2017 13:59:16 +0100 walter harms wrote > > > Am 28.01.2017 02:46, schrieb Patrick Pief: > > > Hello, > > > > > > As noted in http://unix.stackexchange.com/q/340333/117599 BBox's

Re: [PATCH] Replace int -> uint to avoid signed integer overflow

On Mon, Feb 6, 2017 at 8:22 AM, Rob Landley wrote: > On 02/05/2017 09:10 PM, Kang-Che Sung wrote: >> On Mon, Feb 6, 2017 at 8:52 AM, Rob Landley wrote: >>> What's an archive input that actually fails? What's an example of a >>> processor machine language that

Re: timeout setting for login

On Sat, Jan 28, 2017 at 2:46 AM, Patrick Pief wrote: > As noted in http://unix.stackexchange.com/q/340333/117599 BBox's login has no > way for setting LOGIN_TIMEOUT, it's always there and hardcoded to 60 seconds. > > What would you think if there was support for it but not

Re: SSL/TLS client command line API?

On Fri, Jan 27, 2017 at 7:23 PM, Rob Landley wrote: >> "openssl s_client" is not a production tool, it's a debug thing. > > I lean towards 'use existing tool' vs 'invent a new thing'. It seems to > be installed by default on the systems I've looked at. Yes, I know, but being a

Re: Can we bring 'test' applet's help back?

On Sun, Feb 5, 2017 at 4:14 PM, Kang-Che Sung wrote: > This is just an idea. > > After 'test' and '[' become separate, individually selectable applets, it > could be possible to bring the help of '[' and '[[' back after they got > removed in commit

Re: [PATCH] Reorder modutils config options & fix yet more dependency

Applied, thanks On Wed, Feb 1, 2017 at 12:43 PM, Kang-Che Sung wrote: > - modprobe can indirectly benefit from FEATURE_2_4_MODULES and > FEATURE_INSMOD_TRY_MAP options. > - The position of config FEATURE_INSMOD_TRY_MMAP prevented some other > config options from

Re: [PATCH] modutils: fix config options dependency (2)

Applied a simpler version of it. Thanks On Wed, Feb 1, 2017 at 10:22 AM, Kang-Che Sung wrote: > - The modprobe-small implementation of rmmod no longer chdir's to > "/lib/modules/`uname -r`" as it was not necessary for rmmod's > operation. (And it no longer need to die

Re: [PATCH] Replace int -> uint to avoid signed integer overflow

Applied, thanks On Wed, Feb 1, 2017 at 7:35 PM, Rostislav Skudnov wrote: > An example of such an error (should be compiled with DEBUG_SANITIZE): > > runtime error: left shift of 1 by 31 places cannot be represented in > type 'int' > > Signed-off-by: Rostislav Skudnov

Re: series of ctrl-c makes ssh session hang

On Thu, Feb 2, 2017 at 3:25 PM, Ronny Meeus wrote: >>> When pressing enter in the ssh session I see for dropbear: >>> # strace -p 2066 >>> strace: Process 2066 attached >>> _newselect(8, [3 5 7], [], NULL, {3516, 826061}) = 1 (in [5], left >>> {3512, 787390}) >>>

Re: series of ctrl-c makes ssh session hang

On Thu, Feb 2, 2017 at 9:21 AM, Ronny Meeus wrote: > Hello > > I'm seeing an issue that an ssh session hangs after generating a > series of ctrl-c keystrokes. > > Environment description: > --- > - multiple board chassis, with

Re: 'case' UTF-8 bug

On Sat, Dec 24, 2016 at 2:17 PM, Martijn Dekker <mart...@inlv.org> wrote: > Op 24-11-16 om 08:22 schreef Denys Vlasenko: >> On Thu, Nov 24, 2016 at 2:57 AM, Martijn Dekker <mart...@inlv.org> wrote: >>> Op 24-11-16 om 00:14 schreef Denys Vlasenko: >>>

Re: [PATCH] cmdline module options can be disabled on "big" modutils

applied, thanks On Wed, Feb 1, 2017 at 3:34 AM, Kang-Che Sung wrote: > Allow module options on command line to be disabled on "big" modutils. > > Config FEATURE_MODPROBE_SMALL_OPTIONS_ON_CMDLINE is renamed to > FEATURE_CMDLINE_MODULE_OPTIONS and no longer depends on

Re: [PATCH] add exec -a support (preliminary)

On Fri, Jan 27, 2017 at 12:56 AM, Patrick Pief wrote: > There were several times where I thought that having "exec -a" in busybox > would > be neat, and while "exec -a" is not POSIX it is still supported in a lot of > shells (see http://unix.stackexchange.com/q/250681/117599 ).

Re: [PATCH] modutils: remove redundant "select PLATFORM_LINUX" configs

applied, thanks On Tue, Jan 31, 2017 at 6:17 PM, Kang-Che Sung wrote: > It is enough to have only applets' configs select PLATFORM_LINUX. > > Signed-off-by: Kang-Che Sung > --- > modutils/Config.src | 11 --- > modutils/lsmod.c| 1 - >

Re: modprobe (small vs big) behavior inconsistency

On Tue, Jan 31, 2017 at 2:53 PM, Kang-Che Sung wrote: > I just discovered an inconsistency between the two modprobe > implementations (modprobe-small and the "big" modprobe). > > It's about "checking whether module has already loaded" part. > Both implementations open and

Re: [PATCH] modprobe-small: move lsmod code out of modprobe_main()

applied, thanks On Tue, Jan 31, 2017 at 10:30 AM, Kang-Che Sung wrote: > Having lsmod code inside modprobe_main() makes some of the applet name > checking code awkward. Besides, this make busybox x86_64 binary a few > bytes smaller. :) > > Signed-off-by: Kang-Che Sung

Re: Changes re: MODPROBE_SMALL

On Mon, Jan 30, 2017 at 10:58 PM, Olivier Brunel wrote: > Hi, > > So something changed in 1.26.1 which at first thought was a bug, but > seems it is in fact the intended behavior. Now, selecting > MODPROBE_SMALL will not result in any applet available, as one needs to > also

Re: [PATCH] ash: improve / fix glob expansion

>> I plan to massage it into this - do you see any bugs? > Looks okay. I'm committing this version, yell if something wrong. hasmeta(const char *p) { static const char chars[] ALIGN1 = { '*', '?', '[', '\\', CTLQUOTEMARK, CTLESC, 0 }; for (;;) {

Re: [PATCH] ash: improve / fix glob expansion

On Sun, Jan 29, 2017 at 2:14 PM, Felix Fietkau wrote: > When using musl libc glob() a very long string can cause glob() to fail, > which leads to an out of memory error being raised by ash. > > This can happen easily if a very long quoted string contains *, even > though no glob

Re: [PATCH] ash: improve / fix glob expansion

On Sun, Jan 29, 2017 at 2:14 PM, Felix Fietkau wrote: > When using musl libc glob() a very long string can cause glob() to fail, > which leads to an out of memory error being raised by ash. But it works with glibc glob(), right? So other programs will also be affected. Let's fix

Re: [PATCH] Fix modutils config options dependency.

Applied, thanks! On Sun, Jan 29, 2017 at 8:05 AM, Kang-Che Sung wrote: > module.aliases and module.symbols files have no use in modprobe-small > implementation. So FEATURE_MODUTILS_ALIAS and FEATURE_MODUTILS_SYMBOLS > will depend on !MODPROBE_SMALL. > > The

Re: busybox udhcp settings/options help

On Sun, Jan 29, 2017 at 10:18 PM, wrote: > Thank you for taking the time to reply. Much appreciated. > > With respect I have no idea what you are talking about :-)That is down > to my lack of knowledge obviously. These days, getting knowledge is

Re: busybox udhcp settings/options help

On Thu, Jan 26, 2017 at 10:22 PM, wrote: > Please can anyone explain what the 'boot_file' parameter is specifically > for and what udhcp does with it ? > Also, what is the difference between that 'boot_file' parameter and then the > optional 'opt bootfile '

Re: Why preferring smallint to bool in some places?

On Thu, Jan 26, 2017 at 6:25 AM, Kang-Che Sung wrote: > May I ask some little code questions? I have been reading some of the > changes in busybox and I don't understand the use of type "smallint" in > this code > > 9a64c3337cc0a5e84e9ad457eeb1d475c311e9fc "ls: convert

Re: [PATCH] Add option for specifying username to use for anonymous logins

Applied, thanks. On Fri, Jan 6, 2017 at 11:01 PM, Andrey Mozzhuhin wrote: > Anonymous ftpd logins is usefull even when ftpd authentication feature > is enabled. Anonymous logins provide simple password-less connection > for FTP clients. > > To allow password-less connection

Re: [PATCH] implement wget --server-response

On Tue, Jan 24, 2017 at 4:14 AM, Stephane Billiart wrote: > Attached is a simple patch that adds --server-response > to wget. I am using it with HTTP only but there is > (partial) FTP support too. > > Let me know what you think. Not a proper patch apllyable by "git

Re: bugs in a couple scripts

On Sun, Jan 22, 2017 at 7:14 AM, J wrote: > yeah, i see where you mean - as you say, with the trylink script I just > modified it and then rebuilt and didn't worry about it since the build > worked, so that was pretty stupid of me. i've attached a patch correcting > the points

Re: ls with "--group-directories-first" ?

Just committed it to git, please try On Sat, Jan 21, 2017 at 3:05 PM, Philip Rhoades wrote: > People, > > ls results with mixed directories and files drives me crazy . . has anyone > done the equivalent of the GNU feature: > > "--group-directories-first" > > ? > > ATM, I am

Re: SSL/TLS client command line API?

On Fri, Jan 20, 2017 at 1:38 AM, Laurent Bercot wrote: >> In order to add a real applet, I looked for an SSL/TLS client tool >> in widespread use to emulate, and did not find one with a suitable API. >> >> "openssl s_client" is not a production tool, it's a debug thing.

SSL/TLS client command line API?

Hi folks, So far bbox is completely SSL/TLS-illiterate. wget can't talk HTTPS. sendmail groks neither smtps not STARTTLS command. nc can't do TLS either. Now that I have some code reaching a state where it does talk TLS 1.2, the question is how to integrate it. TLS i/o entails some buffering. I

Re: [PATCH] ntpd: improve postponed hostname resolution

walter, check current git, it's a bit different there On Thu, Jan 19, 2017 at 1:55 PM, walter harms wrote: > > > Am 06.01.2017 12:13, schrieb Natanael Copa: >> Run the namelookup from the main loop so a misspelled first ntp server >> name does not block everything forever. >> >>

Re: [PATCH 1/2] hush: add [[ to the builtins list

n Tue, Jan 10, 2017 at 8:15 PM, Kang-Che Sung wrote: > Otherwise the [[ EXPR ]] construct will not run. > "hush: can't execute '[[': No such file or directory" > > It seems like this thing has not been working from the beginning :( > (commit

Re: [PATCH 2/2] Split bash compatible extensions into separate options.

On Wed, Jan 11, 2017 at 12:32 PM, Kang-Che Sung <explore...@gmail.com> wrote: > On Wed, Jan 11, 2017 at 4:09 PM, Denys Vlasenko > <vda.li...@googlemail.com> wrote: >> On Tue, Jan 10, 2017 at 8:17 PM, Kang-Che Sung <explore...@gmail.com> wrote: >>> All of

Re: [PATCH 2/2] Split bash compatible extensions into separate options.

On Tue, Jan 10, 2017 at 8:17 PM, Kang-Che Sung wrote: > All of the bash compatibility options will now depend on > CONFIG_*_BASH_COMPAT, and CONFIG_*_BASH_COMPAT become an option that > alone doesn't add any code. > > Splitting these options allows more flexibility in

Re: [PATCH] ash: fix error code regression

1.26.2 is out. On Sun, Jan 8, 2017 at 6:00 PM, Denys Vlasenko <vda.li...@googlemail.com> wrote: > There is a bug in ash which requires a new bugfix release (1.26.2) soon > anyway. > > On Fri, Jan 6, 2017 at 12:52 PM, Martijn Dekker <mart...@inlv.org> wrote: >> Op

Re: Please revert "ash: make dot command search current directory first, as bash does."

done. On Tue, Jan 10, 2017 at 2:43 PM, Jody Bruchon wrote: > On 2017-01-10 3:42 AM, Kang-Che Sung wrote: >> >> Please revert commit 8ad78e1ec7b2e873953f9f476fb63b5893526c39 >> "ash: make dot command search current directory first, as bash does." >> >> This dot command

Re: FAST_FUNC not working well with GCC's LTO

Applied, thanks. On Thu, Jan 5, 2017 at 2:25 AM, Kang-Che Sung wrote: > (This mail and patch was sent to busybox mailing list on Dec 25, 2016, > and I'm re-sending again for people to notice.) > > Busybox uses FAST_FUNC macro to tweak with IA-32 calling conventions in >

Re: [PATCH 2/2] Document ash and hush config options in more detail.

On Mon, Jan 9, 2017 at 4:04 PM, Kang-Che Sung wrote: > Which of the bash-compatible extensions are supported in ash and hush > are now listed. > > Also be precise about which of the builtins will be enabled in each > option. > > (By the way, I didn't yet have an idea about

Re: [PATCH 1/2] Need not build kill.c when ash's job control is off.

Applied, thanks On Mon, Jan 9, 2017 at 4:07 PM, Kang-Che Sung wrote: > On Mon, Jan 9, 2017 at 11:03 PM, Jody Bruchon wrote: >> On 2017-01-09 9:59 AM, Kang-Che Sung wrote: >>> >>> ash's 'kill' builtin depends on the job control config option. >>> >>

Re: [RFC] modprobe-small: optimizations for single applet build

On Mon, Jan 9, 2017 at 1:18 PM, Kang-Che Sung <explore...@gmail.com> wrote: > On Mon, Jan 9, 2017 at 4:49 PM, Denys Vlasenko <vda.li...@googlemail.com> > wrote: >> CONFIG_MODPROBE_SMALL=y >> CONFIG_DEPMOD=y >> # CONFIG

Re: [RFC] modprobe-small: optimizations for single applet build

CONFIG_MODPROBE_SMALL=y CONFIG_DEPMOD=y # CONFIG_INSMOD is not set CONFIG_LSMOD=y # CONFIG_FEATURE_LSMOD_PRETTY_2_6_OUTPUT is not set CONFIG_MODINFO=y # CONFIG_MODPROBE is not set # CONFIG_FEATURE_MODPROBE_BLACKLIST is not set # CONFIG_FEATURE_MODPROBE_SMALL_OPTIONS_ON_CMDLINE is not set

Re: [PATCH] Allow 'gzip -d' and 'bzip2 -d' without gunzip or bunzip2

FEATURE_BZIP2_DECOMPRESS has no type and is rejected by config system. #if FEATURE_BZIP2_DECOMPRESS is missing "ENABLE_". On Mon, Jan 9, 2017 at 3:50 AM, Kang-Che Sung wrote: > Idea copied from the "ip" applet. > > (Patch included as mail attachment.) > >

Re: [PATCH] hush: fix config text typo (HUSH_MEMLEAK)

Doh... thanks. On Mon, Jan 9, 2017 at 3:30 AM, Kang-Che Sung wrote: > Signed-off-by: Kang-Che Sung > --- > shell/hush.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/shell/hush.c b/shell/hush.c > index 9b62d5c0d..01c334a46

Re: [PATCH] ash: fix error code regression

There is a bug in ash which requires a new bugfix release (1.26.2) soon anyway. On Fri, Jan 6, 2017 at 12:52 PM, Martijn Dekker wrote: > Op 02-01-17 om 13:50 schreef Ron Yorston: >> The commit 'ash,hush: set exit code 127 in "sh /does/not/exist" case' >> only partly implemented

Re: [PATCH] httpd: fix address family for reverse proxy client socket

Applied, thanks! On Fri, Jan 6, 2017 at 10:03 PM, Laurent Bercot wrote: > When httpd proxies a request to another server, it first creates > an AF_INET socket, then resolves the server name to a sockaddr, > then connects to it. This fails if the server name resolves to

Re: [PATCH] Fix code bloat caused by zcat's seamless magic

Applied, thanks! On Sat, Jan 7, 2017 at 6:41 PM, Kang-Che Sung wrote: > (I discovered this when personally experimenting the make_single_applets > script) > > This example single-applet configuration would trigger the bloat: > > CONFIG_FEATURE_SEAMLESS_XZ=y >

Re: [PATCH] Fix ash "kill %1" not working if CONFIG_ASH is disabled

Applied, thanks! On Sun, Jan 8, 2017 at 9:24 AM, Kang-Che Sung wrote: > Fix ash "kill %1" not working if CONFIG_ASH is disabled but > ash is launched by 'sh' or 'bash' name > > Signed-off-by: Kang-Che Sung > --- > procps/kill.c | 4 ++-- > 1 file

Re: [PATCH] dpkg & dpkg_deb: don't depend on FEATURE_SEAMLESS_GZ

On Fri, Jan 6, 2017 at 4:18 AM, Kang-Che Sung wrote: > CONFIG_DPKG and CONFIG_DPKG_DEB unnecessarily depend on > CONFIG_FEATURE_SEAMLESS_GZ. Worse, it has been using "select" clause, > which would prevent FEATURE_SEAMLESS_GZ from being unselect-able when > using "make

Re: busybox 1.26.1 is 15% larger than 1.24.1 with the same configuration

On Fri, Jan 6, 2017 at 8:26 AM, ChenQi wrote: > Hi All, > > Is there any new feature in new version of busybox that would probably > increase the binary size? > > With the same configuration, busybox 1.26.1 is about 15% larger than 1.24.1. > I compared the utilities by

Re: [PATCH] ntpd: improve postponed hostname resolution

On Fri, Jan 6, 2017 at 12:13 PM, Natanael Copa wrote: > Run the namelookup from the main loop so a misspelled first ntp server > name does not block everything forever. > > This fixes the following situation which would block forever: > $ sudo ./busybox ntpd -dn -p foobar

Re: Compiling busybox for ARM-V7

I use a .config way of doing that: CONFIG_CROSS_COMPILER_PREFIX="i486-linux-uclibc-" On Fri, Jan 6, 2017 at 2:00 PM, Kang-Che Sung wrote: > On Fri, Jan 6, 2017 at 7:54 PM, Bob Dunlop wrote: >> I'm not sure passing the parameters to make like this

Re: [PATCH] unzip: avoid warning on unused variable org

applied, thanks! On Thu, Jan 5, 2017 at 5:11 PM, Cristian Ionescu-Idbohrn wrote: > archival/unzip.c: In function 'read_next_cdf': > archival/unzip.c:271:8: warning: variable 'org' set but > not used [-Wunused-but-set-variable] >

Re: [PATCH v2] modutils: remove special handling of uClibc

Applied, thanks! On Mon, Dec 26, 2016 at 8:07 PM, Waldemar Brodkorb wrote: > Commit 3a45b87ac36f (modutils: support finit_module syscall) introduced > macro finit_module. But it is not defined for uClibc. > > The compilation for busybox fails for MIPS with: > With uClibc, we

Re: ash regression in busybox-1.26.1

On Tue, Jan 3, 2017 at 5:02 PM, Natanael Copa <nc...@alpinelinux.org> wrote: > On Tue, 3 Jan 2017 16:41:03 +0100 > Denys Vlasenko <vda.li...@googlemail.com> wrote: > >> Any chance you can narrow it down? > > Yeah, i figured it is the glob implementation in musl

Re: [PATCH 3/3] Clarify help text of CONFIG_{SH,BASH}_IS_* options.

Applied, thanks! On Wed, Jan 4, 2017 at 1:57 AM, Kang-Che Sung wrote: > (This mail and patch was sent to busybox mailing list on Dec 25, 2016, > and I'm re-sending again for people to notice.) > > Mention the behavior if user selects CONFIG_SH_IS_ASH but not > CONFIG_ASH.

Re: [PATCH 2/3] Explicltly group "ash options" and "hush options"

On Wed, Jan 4, 2017 at 1:56 AM, Kang-Che Sung wrote: > This tries to workaround a menuconfig bug that all ash options are no > longer indented under "ash" after SH_IS_ASH becomes independently > selectable. This is a problem in several other places as well. It seems to

Re: [PATCH 1/3] Fix allnoconfig that ash is built in by default.

On Wed, Jan 4, 2017 at 1:55 AM, Kang-Che Sung wrote: > Change the config order that SH_IS_* and BASH_IS_* will be prompted > after ASH and HUSH. And if CONFIG_ASH=n, SH_IS_* choice will default to > SH_IS_NONE. Try "make config" without any .config file. With this patch,

Re: ash regression in busybox-1.26.1

Any chance you can narrow it down? On Tue, Jan 3, 2017 at 3:41 PM, Natanael Copa wrote: > Hi > > There is a regression in ash in busybox-1.26.1, with > https://git.busybox.net/busybox/commit/?id=ea7d2f6ec0596789fc5b2e3fca3b7a602bfa2c26 > applied. > > To reproduce, try

Re: Compiling 1.25.1 for ARM-V7: limits.h + byteswap.h

On Sat, Dec 31, 2016 at 6:35 AM, Vered Zvi wrote: > Hello, > > I have to compile busybox (1.25.1) for ARM-V7 (NXP's LS1021A) > So I installed the standalone compiler supplied by NXP. > With this compiler I compiled the kernel (supplied by NXP). > Then I tried to compile busybox

Re: [PATCH] Fix dependency for IFUPDOWN_UDHCPC_CMD_OPTIONS

Applied, thanks! On Thu, Dec 29, 2016 at 8:43 PM, Jörg Krause wrote: > Commit a8c696bf09d8151323f6e99348c4bc8989f829c8 makes ifup and ifdown > individually selectable, but forgets to update the dependency to > IFUPDOWN_UDHCPC_CMD_OPTIONS, so it is not selectable

Re: [PATCH ] fix some typos in README_distro_proposal.txt

Applied, thanks! On Tue, Dec 27, 2016 at 10:17 PM, Tito wrote: > Hi, > attached you will find a patch that fixes some typos in > README_distro_proposal.txt. > > Ciao, > Tito > > ___ > busybox mailing list > busybox@busybox.net >

Re: [PATCH] appletlib: avoid warning on unused function ingroup

On Mon, Jan 2, 2017 at 11:17 AM, Cristian Ionescu-Idbohrn wrote: > libbb/appletlib.c:558:12: warning: 'ingroup' defined but >not used [-Wunused-function] > static int ingroup(uid_t u, gid_t g) > ^~~ > > That

Re: [PATCH] ash: fix error code regression

On Mon, Jan 2, 2017 at 1:50 PM, Ron Yorston wrote: > The commit 'ash,hush: set exit code 127 in "sh /does/not/exist" case' > only partly implemented the dash commit '[ERROR] Allow the originator > of EXERROR to set the exit status'. This resulted in incorrect error > codes for a

1.26.0 is released

): awk: fix segfault on for loop syntax error udhcpc: check read of option length byte to be within packet Denys Vlasenko: build system: fix a few warnings for allnoconfig build build system: fix include/NUM_APPLETS.h generation build system: make CONFIG_FEATURE_USE_BSS_TAIL less

Re: [PATCH v2] libiproute: handle table ids larger than 255

Rebased to current git and applied. Thanks! On Tue, Dec 13, 2016 at 1:58 PM, wrote: > From: Lukasz Nowak > > Linux kernel, starting from 2.6.19 allows ip table ids to have 32-bit values. > In order to preserve compatibility, the old 8-bit field:

Re: garbled man output

On Thu, Dec 8, 2016 at 11:55 PM, ..mg.. wrote: > Hi folks. > > On my busybox 1.25.1 setup, 'man' and 'less' are conspiring to mangle > terminal control commands, like this for 'PAGER=less man bash': > > BASH(1) General Commands Manual

Re: Detecting Compilation Errors in Busybox Configurations

Tank for reporting it. I committed a fix just now, please try it. On Thu, Dec 1, 2016 at 11:40 PM, Christian Kästner wrote: > Hi, > > Recent configuration-related compilation issues: > > ping.c will not find a link target for reference inet_cksum if CONFIG_PING6 > but none

Re: segfault bb_make_directory + dirname with musl

On Sun, Dec 4, 2016 at 3:45 AM, Daniel Sabogal <dsaboga...@gmail.com> wrote: > On Thu, Dec 1, 2016 at 3:13 PM, Daniel Sabogal <dsaboga...@gmail.com> wrote: >> On Wed, Nov 30, 2016 at 5:52 PM, Denys Vlasenko >> <vda.li...@googlemail.com> wrote: >>> On We

Re: segfault bb_make_directory + dirname with musl

On Wed, Nov 30, 2016 at 3:46 AM, Daniel Sabogal wrote: > The following commands cause busybox to segfault on musl-based systems. > > $ install -D a / > $ install -D a /b > $ install -D a /b/ > > This happens because the code in > >

Re: [PATCH] makedevs: make special node creation idempotent

On Sat, Nov 5, 2016 at 2:37 PM, Arnout Vandecappelle (Essensium/Mind) wrote: > When makedevs is called for a second time with the same device file, it > will fail because the files already exist and mknod() gives -EEXISTS. > > To avoid this, check if the file already exists and if

Re: [PATCH] fdisk: Add support for GPT partition type codes

On Sun, Nov 27, 2016 at 1:41 PM, Jody Bruchon <j...@jodybruchon.com> wrote: > On 11/27/2016 12:11 AM, Denys Vlasenko wrote: >> I looked at these "type codes of GPT partitions" and they seem to be >> a figment of imagination of "GPT fdisk" people: they ar

Re: [PATCH] fdisk: Add support for GPT partition type codes

On Thu, Nov 17, 2016 at 8:28 PM, Simon Rettberg wrote: > Now that I needed to get the type codes of GPT partitions in a script I > decided to add this functionality to busybox fdisk, which had a big > FIXME in the code and just printed 0700 for every partition

Re: [RFC 2/2] udhcpc: Allow to limit maximum lease timeout

On Tue, Nov 15, 2016 at 1:47 PM, Sven Eckelmann wrote: > From: Marek Lindner > > The lease timeout accepted by udhcpc can currently be any value between 16s > and 268435455s (~8.5 years). This maximum limit can be too much for mobile >

Re: [RFC 1/2] udhcpc: Wait for interface to become available

On Tue, Nov 15, 2016 at 1:47 PM, Sven Eckelmann wrote: > From: Marek Lindner > > udhcpc can fail to read the interface information when it was just created > dynamically. Instead of failing directly, udhcpc can wait 2 seconds and > retry

Re: find -name should ignore trailing slashes

On Mon, Nov 14, 2016 at 3:36 AM, Tavian Barnes wrote: > On 13 November 2016 at 20:53, Tavian Barnes wrote: >> With busybox 1.25.1, it seems that find -name does not ignore trailing >> slashes as it should. >> >> $ busybox find foo/ -name foo

Re: [PATCH] libbb: Handle repeating escape sequences correctly

On Tue, Nov 15, 2016 at 6:26 PM, Rostislav Skudnov wrote: > The following key combinations should repeat correctly when the keys are > pressed and held: > - Alt-b > - Alt-f > - Alt-d > - Alt-Backspace > > Escape sequences corresponding to these key combinations are moved

Re: [PATCH 2/2] patch: fix matching failure

On Mon, Nov 21, 2016 at 11:19 PM, Aaro Koskinen wrote: > Fix matching failure when plist is advanced while checking for buffered > lines - the lines in the hunk that are about to be added should be > skipped when checking for matching context. > > Also add a valid test case

Re: Weird behavior of 'ash' with "remove prefix/suffix pattern" in parameter expansion

On Thu, Nov 24, 2016 at 10:29 AM, Denys Vlasenko <vda.li...@googlemail.com> wrote: >>> busybox 1.25.0 >>> $ TEST="[ \t\r]" >>> $ echo ${TEST%]} >>> [ \t\r >>> $ echo ${TEST#[} >>> [ \t\r] >>> >>> GNU

Re: Weird behavior of 'ash' with "remove prefix/suffix pattern" in parameter expansion

On Thu, Nov 24, 2016 at 9:11 AM, walter harms <wha...@bfs.de> wrote: > > > Am 24.11.2016 00:38, schrieb Denys Vlasenko: >> On Tue, Nov 22, 2016 at 6:17 PM, walter harms <wha...@bfs.de> wrote: >>> busybox 1.25.0 >>> $ TEST="[ \t\r]" >>

Re: 'case' UTF-8 bug

On Thu, Nov 24, 2016 at 2:57 AM, Martijn Dekker <mart...@inlv.org> wrote: > Op 24-11-16 om 00:14 schreef Denys Vlasenko: >> Can't reproduce: > [...] >> Tried with CONFIG_FEATURE_SH_STANDALONE=y and it still works for me. >> >> Please send your .config > >

Re: Weird behavior of 'ash' with "remove prefix/suffix pattern" in parameter expansion

On Tue, Nov 22, 2016 at 6:17 PM, walter harms wrote: > busybox 1.25.0 > $ TEST="[ \t\r]" > $ echo ${TEST%]} > [ \t\r > $ echo ${TEST#[} > [ \t\r] > > GNU bash, version 3.2.39 > $ TEST="[ \t\r]" > echo ${TEST%]} > [ \t\r > echo "${TEST#[}" > \t\r] > > It seems that ${#} does not

Re: 'case' UTF-8 bug

On Wed, Nov 23, 2016 at 6:52 PM, Martijn Dekker wrote: > busybox ash in UTF-8 locale does not like the lowercase Greek letter > 'rho' (CF 81) in a case statement. > > case "ρ" in > ( "ρ" ) echo ok ;; > ( * ) echo WRONG ;; > esac > > outputs WRONG. > > The preceding character π

Re: [PATCH] Re: Possible Vulnerability in httpd.c

On Tue, Nov 22, 2016 at 5:07 PM, Rich Felker wrote: >> Different projects choose their paranoias differently. >> >From its inception, bbox was paranoid about code size. >> >> If you see an actual bug where buffer can overflow, >> I'm more than willing to fix it. >> >> But if

Re: [PATCH] Re: Possible Vulnerability in httpd.c

On Mon, Nov 21, 2016 at 8:18 PM, Simon Rettberg wrote: > On Mon, 21 Nov 2016 20:37:14 +0200 > Timo Teras wrote: >> >> It is still good practice to fill it with snprintf. If this is done, >> proper error checking should be done to check the

Re: sed bug ?

On Thu, Nov 17, 2016 at 10:56 AM, Timo Teras wrote: > Hi, > > The following discrepancy happens on 1.25.1 (and git master) with musl > c-library: > > ~ $ echo /usr/lib/ | sed 's,\(^/\|\)[^/][^/]*,..,g' > ../../ > > ~ $ echo /usr/lib/ | busybox sed 's,\(^/\|\)[^/][^/]*,..,g' >

Re: bug in ash set -e

On Wed, Nov 9, 2016 at 6:52 PM, Natanael Copa wrote: > On Wed, 09 Nov 2016 16:12:41 + > Ron Yorston wrote: > >> Natanael Copa wrote: >> >I have found a bug (or weird feature?) in busybox ash: >> > >> >$ dash -c "set -e ; ( false ) ; echo 'should not

Re: [PATCH 1/2] cpio: add ownership (-R) test cases

applied, thanks! On Wed, Nov 2, 2016 at 11:25 PM, Aaro Koskinen wrote: > Add ownership (-R) test cases. > > Signed-off-by: Aaro Koskinen > --- > testsuite/cpio.tests | 24 > 1 file changed, 24 insertions(+) > > diff --git

Re: [PATCH] loadfont: accept fonts up to 64 KiB in size

Fixed in git, thanks! On Tue, Oct 25, 2016 at 6:15 AM, Alex Henrie wrote: > Signed-off-by: Alex Henrie > --- > Hello, > > The ArchWiki currently implies that users with HiDPI screens should set > a mkinitcpio hook to set the console font to

Re: Potential regression with ash "pause()" commit

On Tue, Nov 1, 2016 at 6:51 AM, Kang-Che Sung wrote: > Hello. > > I want to mention that in this commit > "ash: use pause(), not sigsuspend(), in wait builtin" > 8f7b0248adca9a88351fd7f3dd208775242f3fe6 > there could be a regression. > > I recently read about Problems with

Re: [PATCH] man: let the user specify the format command

On Fri, Oct 28, 2016 at 9:16 AM, Alastair Hughes wrote: > Package: busybox > Version: v1.25.1 > Severity: wishlist > > The attached patch lets the user configure the command used to format man > pages by busybox's man. > I'm using heirloom-doctools instead of groff in

Re: [BUG] Interactive (d)ash exits on assigning to readonly from 'command eval'

On Sat, Oct 29, 2016 at 8:22 PM, Harald van Dijk <har...@gigawatt.nl> wrote: > On 28/10/16 15:55, Denys Vlasenko wrote: >> >> This will probably be mangled by gmail, but here is the proposed fix: > > > This looks about the right approach, but it causes problems

Re: [BUG] Interactive (d)ash exits on assigning to readonly from 'command eval'

This will probably be mangled by gmail, but here is the proposed fix: Date: Fri, 28 Oct 2016 15:43:50 +0200 Subject: [PATCH] ash: fix interactive "command eval STRING" exiting on errors. This bug is also present in current dash Signed-off-by: Denys Vlasenko <vda.li...@googlemail.co

Re: [PATCH] strings implement -t radix v2

Applied, thanks! On Sat, Oct 15, 2016 at 9:45 PM, Tito wrote: > On 10/15/2016 03:22 PM, Tito wrote: >> >> Hi, >> the attached patch implements -t radix option >> for strings program and fixes the help text >> for -o option. >> During the little testing I've done the output

Re: wget -no-check-certificate only for DESKTOP

On Wed, Oct 19, 2016 at 5:13 PM, KP.Kirchdoerfer wrote: > HI; > > is there any reason why the option no-check-certificate is only ignored when > choosing DESKTOP the busybox general settings? > > /* Ignored (we don't do ssl) */ > IF_DESKTOP("no-check-certificate\0"

Re: Ash wildcard usability bug

On Mon, Oct 24, 2016 at 8:20 AM, <dietmar.schind...@manroland-web.com> wrote: >> Von: Denys Vlasenko >> Gesendet: Montag, 24. Oktober 2016 01:31 >> ... >> >> On Tue, Oct 18, 2016 at 4:31 PM, Lauri Kasanen <cur...@operamail.com> wrote: >> > The

Re: [PATCH] awk: Fix segfault on for loop syntax error

Applied, thanks! On Sat, Oct 15, 2016 at 3:45 PM, Brian Foley wrote: > Parsing "for()" segfaults as awk fails to find loop iteration expressions. > > Signed-off-by: Brian Foley > --- > editors/awk.c | 2 +- > testsuite/awk.tests | 3 +++ > 2 files

<    6   7   8   9   10   11   12   13   14   15   >