On Wed, 2007-07-18 at 09:41 +0200, Tito wrote:
> On Wednesday 18 July 2007 01:10:40 Denis Vlasenko wrote:
>
> > Applied to svn with minor changes. For example, we were comparing argv[0]
> > with "view", but argv[0] can be "/bin/view"! Right thing is
> >
> > strncmp(appliet_name, "view", 4)
>
On Wednesday 18 July 2007 01:10:40 Denis Vlasenko wrote:
> Applied to svn with minor changes. For example, we were comparing argv[0]
> with "view", but argv[0] can be "/bin/view"! Right thing is
>
> strncmp(appliet_name, "view", 4)
Why not:
if (*applet_name[3])
Ju
> > The attatched patch should not make things worse. If somebody find out
> > that it introduces new bugs or have suggestions to improvements of the
> > patch, let me know and I'll try to fix.
>
> Wow. thanks!
i agree. busybox vi has needed some work.
> Applied to svn with minor changes.
On Tuesday 17 July 2007 16:42, Natanael Copa wrote:
> > Care to do version 2?
>
> More improvements attatched. Fixes also a critical bug (segfault)
>
> * the puzzling message mentioned above is replaced with strerror(errno)
> so it should be even more detailed and smaller at the same time.
>
> *
On Fri, 2007-07-13 at 16:57 +0100, Denys Vlasenko wrote:
> Hi,
>
> On Thursday 12 July 2007 15:35, Natanael Copa wrote:
> > Attatched is a patch that will fix a bug in vi, enhance functionality a
> > bit, reduce size and make the code a bit more readable. Testcase
> > follows.
[...]
> Nice. Any
On Saturday 14 July 2007 21:45, Natanael Copa wrote:
> On Fri, 2007-07-13 at 16:57 +0100, Denys Vlasenko wrote:
> > > Original vim shows "permission denied" but "Read-only" is better than
> > > nothing.
> >
> > Nice. Any chance getting "[Read failed]" (or whatever non-puzzling msg)
> > so we don't
On Fri, 2007-07-13 at 16:57 +0100, Denys Vlasenko wrote:
> Hi,
>
> On Thursday 12 July 2007 15:35, Natanael Copa wrote:
> > Attatched is a patch that will fix a bug in vi, enhance functionality a
> > bit, reduce size and make the code a bit more readable. Testcase
> > follows.
[...]
> > Original
Hi,
On Thursday 12 July 2007 15:35, Natanael Copa wrote:
> Attatched is a patch that will fix a bug in vi, enhance functionality a
> bit, reduce size and make the code a bit more readable. Testcase
> follows.
>
> echo "this file is readonly" > file1
> chmod 400 file1
> sudo chown root file
>
Hi,
Attatched is a patch that will fix a bug in vi, enhance functionality a
bit, reduce size and make the code a bit more readable. Testcase
follows.
echo "this file is readonly" > file1
chmod 400 file1
sudo chown root file
Before patch:
./busybox_old vi file1
File is empty (user has n
